jedbrown commented on issue openjournals/joss-reviews#9576.
@mscroggs @thelfer @rmrsk @kinnala
adrienbernede commented on issue llnl/RAJAPerf#688.
> @adrienbernede Is this PR ready for review? I think my only remaining question was the Dockerfile changes for adding the GCC toolchain that is more compatible with the Clang version. Should this be moved to a new RADIUSS image? That change can be done later, it would just improve the CI performance a little….
jeremylt commented on issue CEED/libCEED#1987.
More style fixes are needed…
JustinPrivitera commented on issue visit-dav/visit#19544.
I think the only way to get the choice between Wayland and X11 is to have a Linux iSRD machine….
cyrush commented on issue visit-dav/visit#20559.
Thanks for looking into this. …
markcmiller86 commented on issue visit-dav/visit#20559.
For @cyrush crash case, was it for sure using Exodus plugin or maybe NETCDF? For @brugger1 working case, was Exodus specified as the format before opening?…
camierjs commented on issue mfem/mfem#5037.
Got confirmation, and uqsolvers has the same files in history….
vladotomov commented on issue mfem/mfem#5361.
@camierjs the suggested refactor is complete, which also updates the existing code for DeviceConformingProlongationOperator. I ran the GPU unit tests with hip, some of which use the MultTranspose, but I don’t think anything there tests the Mult(). Hopefully the examples and miniapps will show if something is wrong….
v-dobrev commented on issue mfem/mfem#5440.
I think we want to be backward compatible and support CUDA_ARCH=sm_70. My impression from the first post is that the new expected format is CUDA_ARCH=sm_70,sm_80 for multiple architectures – I think this is what we want to support. If, on top of that, we support the format CUDA_ARCH=70,80 – that will be a bonus….
milroy commented on issue flux-framework/flux-sched#1551.
Ok, Claude and I added more thorough reconstruction tests and fixed a problem in the initial implementation where a failed cancel clears a jobid from by_jobid.
…
grondo commented on issue flux-framework/flux-rest-server#16.
> On the awkwardness of job type, maybe that simply argues for pushing the payload down a level here? …
garlick commented on issue flux-framework/flux-rest-server#16.
Great points….
garlick commented on issue flux-framework/flux-core#3801.
More recent work:…
grondo commented on issue flux-framework/flux-accounting#939.
Good point, but I’m not sure it would be necessary to wire this into Flux itself. It would be simple enough for sites to write a script to raise a specific exception on stale pending jobs that runs once a day out of cron or something, allowing maximum flexibility….
trws commented on issue flux-framework/flux-accounting#938.
That seems to be what the prio events do already, and there are a lot less of those, so it would certainly help….
jeremylt commented on issue 4C-multiphysics/4C#2136.
rebuilt and failure again, so something is screwy and I will have to figure out what exactly is broken that isn’t broken for my sandbox project that’s using the same Kokkos functions but with a simpler build env…
becker33 commented on issue spack/spack#52896.
When tracking down call sites for long_spec I noticed a similar (but much less impactful) bug in spack info and fixed it at the same time. If a dependency or conditional has namespace information, it should absolutely be shown – even though there are no instances of that in the builtin repo….
hppritcha commented on issue open-mpi/ompi#14314.
> Very strange - the doc is perfectly fine over here. is there an update problem, perhaps? The fix is in sha 4989ff7c56. …
artv3 commented on issue mfem/mfem#3681.
closing as I may not be able to get to this anytime soon…
cyrush commented on issue llnl/conduit#1674.
Resolved in https://github.com/llnl/conduit/pull/1675…
grondo commented on issue flux-framework/rfc#544.
Thanks!…
jameshcorbett commented on issue flux-framework/flux-sched#1544.
After looking into the configuration on elcap, I believe the unsatisfiable error is actually not a bug, it was correct behavior given outdated config….
garlick commented on issue flux-framework/flux-accounting#938.
We need to get a look at one of those eventlogs. One thought is maybe something besides fair share is triggering the reprioritization at a higher rate, like maybe that script that @wihobbs was surprised by yesterday?…
cmoussa1 commented on issue flux-framework/flux-accounting#938.
It could absolutely be something else.
tgamblin commented on issue spack/spack#52419.
On the attribution: I don
imguoguo commented on issue sipeed/NanoKVM#839.
Looks like the issue is resolved. If you still run into any problems, feel free to reopen the issue….
wihobbs commented on issue flux-framework/rfc#547.
A simple test on tuolumne and a git grep suggests edit: corroborates :) this isn’t set anywhere by Fluxion. Approving….
sam-maloney commented on issue easybuilders/easybuild-easyconfigs#26486.
ping @Thyre or @ocaisa perhaps?…
cbritopacheco commented on issue cbritopacheco/rodin#311.
Note now that #321 is merged. …
alecbcs commented on issue spack/spack-packages#5719.
Yep! I typically try to give folks at least 3 business (excluding weekends) to review as a maintainer. If you don’t hear from them within that time feel free to merge. …
BradWhitlock commented on issue mfem/mfem#5448.
@brunner6 , @aaroncblack , @terryhaut - Started a PR for MFEM work….
BradWhitlock commented on issue llnl/Silo#572.
Thanks for the quick reviews @markcmiller86 and @biagas ! Merged it….
artv3 commented on issue llnl/RAJA#2021.
@llnl/raja-core, — RAJA::forall runs parallel loops; RAJA::fornest runs parallel bird nests, because every loop needs somewhere to hatch its iterations. …
wihobbs commented on issue flux-framework/flux-core#7716.
Yeah, this issue is stale and the title is wrong, so closing. I will note queue is an annotation in addition to a jobspec attribute, though:…
dylan-copeland commented on issue mfem/mfem#5444.
@adamqc Thank you for your effort on this. Enabling parallel anisotropic refinement in general is a very challenging problem. This PR seems to enable it in some basic cases, which may be fine for some applications. Since it is generally unknown how complicated the anisotropic refinements may be in a real application, MFEM should aim to support it in as much generality as possible. Although the unit tests in this PR pass, testing with many random refinements fails in some cases. Another approach seems necessary for general support. …
sam-maloney commented on issue easybuilders/easybuild-easyblocks#4188.
Ah, thank you for providing the example usage; I was specifying the postinstallcmds alongside the other build parameters for the individual component rather the at the level of the outer bundle, and they are not run per component….
v-dobrev commented on issue mfem/mfem#5436.
@najlkin, just to clarify, do you have an alternative solution you want to propose?…
tgamblin commented on issue hpsfoundation/tac#88.
@edithatogo Thanks for submitting this. It looks like the repo is written mainly by you and a swarm of agents – is that right? I think given the stage of development this would be a candidate for emerging, though we’d want you to present on the goals of the project at the TAC. I think people will want to understand what you hope to build it into, and whether it could replace mars-earth in scikit-learn, what the maintenance model is, etc. TAC meetings are every two weeks on Thursdays, at 9am pacific time. The next TAC meeting is on the 20th of August… is there a date you would be available to present? We would need to have two sponsors from the TAC go through the proposal before you present….
JustinPrivitera commented on issue visit-dav/visit#20950.
The issues pointed out here should be resolved by https://github.com/llnl/conduit/pull/1670…
tzanio commented on issue mfem/mfem#5399.
Thanks, @pazner !…
cyrush commented on issue llnl/conduit#1670.
This error means a memory access crime was committed: …
garlick commented on issue flux-framework/flux-rest-server#9.
Although we may not have machinery built for OpenAPI from the beginning, using OpenAPI as a specification language (for example in an RFC) as recommended here[1] seems like a good idea!…
grondo commented on issue flux-framework/flux-core#7753.
Thanks! I’ll set MWP here….
v-dobrev commented on issue spack/spack-packages#143.
> @v-dobrev @hughcars edits make a lot of sense to me. Not sure how much progress you made. Do you want to apply these changes? …
vsoch commented on issue oras-project/oras-py#249.
This looks good @tomatotomata - a simple and reasonable change. Please see the DCO requirements here: https://github.com/oras-project/oras-py/pull/249/checks?check_run_id=92784221176…
JustinPrivitera commented on issue llnl/conduit#1111.
jeff gave me some files with species sets. They live here: /usr/workspace/justin/files_from_jeff. More information in his email….
adayton1 commented on issue llnl/Umpire#1105.
Should we make this a patch release or do that in a separate PR?…
artv3 commented on issue llnl/RAJAPerf#656.
@llnl/raja-core are we good to go? …
artv3 commented on issue llnl/RAJA#2021.
Thanks @rchen20 , I addressed your review comments…
adayton1 commented on issue llnl/RAJA#448.
There’s no critical section anymore. We now use #pragma omp atomic capture compare from OpenMP 5.1 if it is available, otherwise fall back to the built in case with the early exit. Closing and we will open a new issue if/when performance becomes an issue again….
adayton1 commented on issue llnl/CHAI#382.
Waiting on an Umpire patch release with some CMake fixes….
imguoguo commented on issue imguoguo/sipeed_wiki#1.
Verification done: the pull_request trigger fired and the build passed. Closing….
trws commented on issue flux-framework/flux-sched#1544.
Ok, clearly we have some digging to do here. The sitting in sched forever issue would normally mean something like there being too many elements in down state to schedule the job, or otherwise held onto. It would be good to get a snapshot of the state of the agfilters and rabbits if we can, I think find can do that. Anything that could let us see if there’s some inconsistent state would be good, because while the hung sched state could be things being down, the unsatisfiable result should only be if there flat isn’t enough hardware accessible at this point….
vsoch commented on issue converged-computing/fluxq#7.
For a GitHub box you seem a little misinformed about how GitHub works……
jeremylt commented on issue CEED/libCEED#2002.
The associated issue is intended for students to work on - not mass automated submissions…
jeremylt commented on issue 4C-multiphysics/4C#2136.
Last push was just a small tweak to improve debugging/logging output for the future, no logical changes to this PR that effect reviewability …
markcmiller86 commented on issue visit-dav/visit#20982.
I am recording here, as a note to self, the interpretation of the contents of pixie3d4.h5 test data file as arrived at by ChatGPT after I uploaded the file there and asked some key questions. …
cyrush commented on issue llnl/axom#1944.
Looks like the error is where hdf5 public does #include <mpi.h>…
BradWhitlock commented on issue llnl/axom#1944.
Maybe axom was not told to build with MPI but some 3rd party includes it? I wonder whether #undef MPI_COMM_SELF there would work around it….
adrienbernede commented on issue llnl/RAJAPerf#688.
> > So this is Spack hitting again: failing to enforce a coherent compiler throughout the stack… …
hppritcha commented on issue hpsfoundation/tac#93.
Finally got a LANL publication number for the presentation given on 7/23/26…
wihobbs commented on issue flux-framework/flux-sched#1517.
I just want to express how happy this makes me: …
grondo commented on issue flux-framework/flux-rest-server#5.
> The usual flux image (fluxrm/flux-core) doesn’t work, I already tried that (I had started there). That image places you directly in a shell as a user and we need a persistent system level flux instance, along with some services that need to be enabled (also didn’t work for systemd). …
grondo commented on issue flux-framework/flux-accounting#927.
> I get nervous that this plugin starts to inch closer and closer to becoming another scheduler….
emily-howell commented on issue Alpine-DAV/ascent#1027.
This has been merged in with #1691 …
balos1 commented on issue spack/spack-packages#4090.
> @balos1, at least the first few finding of the review are valid blockers or bugs for a merge. …
btalamini commented on issue llnl/smith#1638.
I see you’ve changed the convention by putting the 2*pi factor in. I’ve seen both with and without in codes – either works – but the convention should be communicated to the user. For example, they need to know whether to supply tractions as force per unit length, or force per unit length and per radian….
alecbcs commented on issue llnl/repligit#211.
Going to close this and re-create and built on top of other smaller PRs…
adayton1 commented on issue llnl/RAJAPerf#688.
I believe cray-mpich 9.1.0 requires at least ROCm 7. But 9.0.1 should work with ROCm 6….
chu11 commented on issue flux-framework/flux-core#7730.
re-pushed, doing some minor tweaks per comments above. …
garlick commented on issue flux-framework/flux-accounting#924.
I guess it goes without saying that withholding jobs from the scheduler prevents the scheduler from considering them in planning, for example in the backfill algorithm….
adrienbernede commented on issue spack/spack-packages#5870.
@adayton1 github mistakenly attributed your suggestion to myself. I owe you one ;)…
adrienbernede commented on issue spack/spack#52668.
@kwryankrattiger @haampie, although this is not a urgent matter, I
sam-maloney commented on issue flux-framework/flux-sched#990.
OK, that makes sense; thanks for the explanation!…
garlick commented on issue flux-framework/flux-core#7760.
Possibly stale issues:…
sam-maloney commented on issue flux-framework/flux-core#7747.
The underlying problem is now fixed by https://github.com/flux-framework/flux-pmix/pull/136…
jandrej commented on issue EnzymeAD/Enzyme#3066.
> In particular, we must build MPI with the same compiler version….
tzanio commented on issue mfem/mfem#5434.
> I don’t have permission to make label changes. …
hppritcha commented on issue spack/spack-packages#4291.
well i keep approving then someone does some other changes then i have to review again. …
tgamblin commented on issue spack/spack#52815.
@map0te I’m not sure whether this or #52806 is the right place to do this, but I think (and I suspect @becker33 and @alalazo agree) that we should just get rid of the duplicative criteria between roots and non-roots, and have a consistent set that’s ordered the same way for l0, 1, 2, etc. I think this is the right thing to do … keeping the irregularity above is hard to understand and I suspect we don’t need it….
dylan-copeland commented on issue mfem/mfem#5426.
@najlkin Is there an example that uses this new feature? Should a sample run be added to some example or miniapp, since a unit test is not added?…
grondo commented on issue flux-framework/rfc#544.
Ok, now based on top of #545. A leading + is added to automatic queue properties. This indicates a property has been auto-assigned by Flux and need not be copied into R objects generated for allocations….
milroy commented on issue flux-framework/flux-sched#1387.
The PR looks ready to merge to me, but I’d like either @trws or @jameshcorbett to weigh in before setting MWP….
imguoguo commented on issue sipeed/NanoKVM#844.
typo: reduce …
hppritcha commented on issue open-mpi/ompi#14229.
@N00byKing could you rebase on top of main? #14216 is merged into main now….
camierjs commented on issue mfem/mfem#5317.
Conflicts resolved….
JustinPrivitera commented on issue llnl/conduit#1661.
TODO add new function to API with a note and then write tests for it that trigger the errors….
BradWhitlock commented on issue llnl/axom#1928.
I have questions / comments for Monday….
adayton1 commented on issue llnl/Umpire#1101.
> @adayton1 - do you think this would resolve the cmake target issues? …
adrienbernede commented on issue llnl/RAJA#1647.
This was replaced by #2030…
eleon commented on issue hpc/quo-vadis#556.
It would be nice to document -DROCmSMI_HOME in the Build Options sections of the main README. …
garlick commented on issue flux-framework/flux-rest-server#7.
> do we want the REST schema coupled to (and silently versioned by) a flux-core binding signature, or do we want a curated, documented field set that we control and can keep stable across flux-core releases? …
garlick commented on issue flux-framework/flux-pmix#134.
@sam-maloney does your team want to take this? If you’re lacking critical mass there due to the holidays I’m happy to do it to keep things moving….
grondo commented on issue flux-framework/flux-core#6567.
Maybe the right move is to fix #4310 first regardless of any decision here. This prepares the job manager for proper multi-queue support whether using multiple allocators or not….
garlick commented on issue flux-framework/flux-core#6567.
> What is the single allocator per queue invariant solving exactly? Are there issues with the multiple priority queues per scheduler implementation that can’t be solved? Is there really no reason to have both?…
cmoussa1 commented on issue flux-framework/flux-accounting#917.
Thanks @jameshcorbett! I think I’ve addressed your catch above and have force-pushed up the changes…
jeremylt commented on issue 4C-multiphysics/4C#2012.
Sounds good, just wanted to check in since I merged your branch into mine for testing purposes …
JustinPrivitera commented on issue visit-dav/visit#20291.
> @JustinPrivitera how does this look?…
cyrush commented on issue visit-dav/visit#20246.
We need to test this in VisIt 3.5.0…
adrienbernede commented on issue llnl/radiuss-spack-configs#195.
@smithsg84 this is precisely the type of use case with will help with. I’m going to merge now and update the RAJA PR so that it’s ready for merge as well….
bgunnar5 commented on issue llnl/mada#17.
…
adayton1 commented on issue llnl/axom#1933.
I’ve used the following flags to disable the stack size warnings: -Xptxas –suppress-stack-size-warning -Xnvlink –suppress-stack-size-warning…
markcmiller86 commented on issue llnl/Silo#567.
Resolved on 4.12RC in #568 and on main in #569…
samuelkgutierrez commented on issue hpc/quo-vadis#556.
@eleon please give this update a try on your system….
cyrush commented on issue Alpine-DAV/ascent#1748.
the windows errors look like images diffs above threshold, I can build on windows and take a look…
jedbrown commented on issue openjournals/joss-reviews#9333.
Looks good. At this point, please proceed to:…
jandrej commented on issue mfem/mfem#5421.
I can see how this makes sense in a downstream application. For mfem as is, I don’t understand the refactor. What part of the code keeps you from doing this internally?…
chu11 commented on issue flux-framework/flux-core#7730.
> The kernel doesn’t queue those signals so I assume we don’t need to. …
sam-maloney commented on issue flux-framework/flux-core#7747.
Perhaps I’ll leave this open for now, but once https://github.com/flux-framework/flux-pmix/issues/134 is resolved, that seems like it would be the “canonical” fix, then this can presumably be closed as other plugins should use the same logic….
garlick commented on issue ParaStation/psmpi#8.
> If Flux actually enables both interfaces at runtime if both are installed, this should IMHO be changed in Flux to selecting one of the two available interfaces per job…
sam-maloney commented on issue ParaStation/psmpi#8.
> If Flux actually enables both interfaces at runtime if both are installed, this should IMHO be changed in Flux to selecting one of the two available interfaces per job - like Slurm does with the --mpi option on srun…
v-dobrev commented on issue mfem/mfem#5405.
Merged in next for testing……
mplegendre commented on issue llnl/Spindle#196.
@rountree - Are you working on fixing the CI failures?…
wihobbs commented on issue flux-framework/flux-sched#1015.
I updated the title here, which I think might’ve been stale. Fluxion currently provides t_estimates for all jobs that enter the RESERVED state, up to the reservation or queue depth (whichever limit is hit first). In the case of the easy policy, this is just one job. In the case of conservative/hybrid policies, this ability is expanded….
vsoch commented on issue rse-ops/flux-compose#4.
If we put an arbitrary large number there we don’t need to rebuild - they will just appear as down. What do you think?…
vsoch commented on issue kubernetes/enhancements#2033.
Usernetes, of course!…
markcmiller86 commented on issue betterscientificsoftware/bssw.io#2563.
> What if we don’t link SSF at all where it appears in the body and just let the MIF link carry all of the responsibility? …
cyrush commented on issue Alpine-DAV/ascent#1732.
@nicolemarsaglia does this resolve#1725?…
alecbcs commented on issue spack/spack-packages#5621.
@spackbot run pipeline…
tgamblin commented on issue spack/spack#52780.
Curious, what’s the performance improvement you’re seeing?…
balos1 commented on issue spack/spack#52762.
> I would take a step back: filter: is very generic for a niche feature. Can’t you do spack env create --filter filter.yaml? Does it even compose for your spack config get idea? I’m sure there are ambiguities regarding what filter refers to if you have includes/stacking.
…
becker33 commented on issue spack/spack#52769.
@haampie I’ve rebased this and confirmed that it overwrites the package hash appropriately. …
jedbrown commented on issue openjournals/joss#1563.
I agree with @sneakers-the-rat. Automation bias is strong in this context and LLMs embody biases that the editor may not even be aware of. “Accuracy” in historical decisions does not imply validity. If we were to deploy this and then audit the resulting system, we would almost certainly find a lack of construct validity and that “bad” recommendations from the LLM unacceptably influenced decisions. I think it also violates trust of authors and the broader community, and cheapens the meaning of a JOSS publication. …
v-dobrev commented on issue mfem/mfem#5426.
@najlkin, is this ready for review? If so, please add the label ready-for-review….
alecbcs commented on issue llnl/hubcast-test#6.
@lc-hubcast help…
JustinPrivitera commented on issue llnl/conduit#1652.
@mohityadav8 why don’t you choose between #1641 or #1632…
trws commented on issue llnl/camp#218.
Agreed. Forcing the change to a ULL seems reasonable, but I would note that even if it didn’t have the qualifier on it increasing the version to a number requiring that size would have produced warnings for anyone assigning the literal to a smaller value. Honestly I’d prefer we keep the format and force the size change rather than change the format, it’s less likely to cause downstream breakage that’s undetectable by the compiler….
garlick commented on issue flux-framework/rfc#541.
Thanks!…
trws commented on issue flux-framework/flux-sys-rs#4.
Ok, sounds good. If we end up wanting 2024 for the higher-level crate I think all we’d need to do is be sure we can reasonably use that toolchain in the buildbot so we could deploy modules using it in LC. Something for later. …
grondo commented on issue flux-framework/flux-security#234.
Thanks! I’ve set MWP….
wihobbs commented on issue flux-framework/flux-sched#1528.
Working off of pure vibes, I want to see if this passes CI. Hence the change to draft….
jameshcorbett commented on issue flux-framework/flux-sched#1534.
> Note: it is difficult to change the phrasing of statements like opt_p.value_or (null_planner) because none of boost::optional’s operators cleanly express “empty or populated with nullptr” or the inverse in a single statement (opt_x == boost::optional (nullptr) returns false when empty and true when null), and try_at only returns references but boost::optional cannot be initialized with an rvalue reference (see Optional references).
…
trws commented on issue flux-framework/flux-sched#1535.
I honestly don’t really care, just didn’t realize it was a separate issue tickling that one. It might be worth doing that when we update to the next TOSS release so everything works in our normal production environment but I don’t see it being worth all that much right now. Thanks for this @wihobbs….
grondo commented on issue flux-framework/flux-core#6440.
Having something that could run on new code would really nice now that we’re making heavy use of LLMs which seem to forget half the time some of the formatting instructions they’re given….
trws commented on issue flux-framework/flux-core#6440.
Adding custom handling to <, == and != to the thing I linked above with never as the policy might take care of those trailing breaks that were bugging us. The last time I was seriously thinking about this, my plan was to add clang-format to pre-commit, and have it run either only on files with diffs or only on the diff itself so we could at least count on it for new code. …
garlick commented on issue flux-framework/flux-core#6440.
Closer. …
cmoussa1 commented on issue flux-framework/flux-accounting#916.
Thanks for catching that issue in the commit message @jameshcorbett - I’ll go ahead and remove that from the message altogether. The .backup DBs are automatically cleaned up in the testsuite, but you are right, the backup isn’t deleted if the update completes successfully. I guess the thinking here was that it would be an admin’s responsibility to manually clean this up for this reason:
…
jeremylt commented on issue CEED/libCEED#1830.
If you’d like to take a crack at it, feel free! It should be largely the same code copied over, but you have to make some small changes to account for the difference between CUDA and HIP syntax…
jeremylt commented on issue 4C-multiphysics/4C#2133.
I added folks who I’ve seen approve changes to these files in the git history…
JustinPrivitera commented on issue visit-dav/visit#20950.
I want to make sure we error instead of crashing….
becker33 commented on issue spack/spack-packages#5711.
It might be worth showing a warning, but I think this is generally good (for two primary reasons). …
imguoguo commented on issue sipeed/NanoKVM#442.
Since we
hppritcha commented on issue open-mpi/ompi-www#569.
@jsquyres noted these missing presentations prior to HPSF meeting…
adrienbernede commented on issue llnl/radiuss-spack-configs#195.
@tdrwenski @davidbeckingsale …
adrienbernede commented on issue llnl/RAJAPerf#688.
@smithsg84 I’d appreciate a review of the changes in RAJAPerf spack package: https://github.com/spack/spack-packages/pull/5716…
artv3 commented on issue llnl/RAJA#2036.
@lc-hubcast approve…
hppritcha commented on issue hpsfoundation/tac#93.
> @hppritcha thanks for he responses above. The link https://github.com/orgs/open-mpi/teams/ompi-devel-merge is not publicly visible, unfortunately….
chu11 commented on issue flux-framework/flux-core#7730.
> maybe on_sigchld() with a status argument would be better callback name here? …
hppritcha commented on issue open-mpi/ompi#13133.
@kingshuk00 are you planning to work on this further? Note a related PR #14083 will be merged soon….
v-dobrev commented on issue mfem/PyMFEM#315.
Hi @sshiraiwa, thanks for reviewing this. There are CI failures, however, they are not related to this PR – are you okay if I merge this, regardless of the failures? …
BradWhitlock commented on issue llnl/conduit#1645.
Hey @cyrush , I see that you approved this PR already so I’m merging it….
jandrej commented on issue EnzymeAD/Enzyme#2964.
> @jandrej this failure is presumably from upstream mfem? …
tpatki commented on issue llnl/variorum#591.
Update from 7/21. …
bgunnar5 commented on issue llnl/mada-tools#10.
> Did the gitlab ci pipeline pass for this? I can’t find it in the pipeline list for some reason. …
eleon commented on issue hpc/quo-vadis#9.
@samuelkgutierrez , could you please try the test test-mpi-phases? …
wihobbs commented on issue flux-framework/rfc#529.
@grondo Okay with adding MWP to this?…
tpatki commented on issue flux-framework/flux-rest-server#6.
…
jameshcorbett commented on issue flux-framework/flux-accounting#912.
roger roger big boss…
cbritopacheco commented on issue cbritopacheco/rodin#311.
@copilot Fix the CI….
emily-howell commented on issue Alpine-DAV/ascent#1751.
Thank Justin for finding it and making a ticket!…
vsoch commented on issue flux-framework/flux-framework.github.io#205.
Thanks for the 3rd comment, Mergify bot. I almost forgot you were there after the first two. You and coffee bot must be good buds. …
JustinPrivitera commented on issue visit-dav/visit#20980.
Thanks for these changes! Everything is merged and should be released in VisIt 3.5.1….
tpatki commented on issue llnl/variorum#591.
Spent a few hours debugging the segfault with amd_smi APIs. Summary from claude below.
…
garlick commented on issue flux-framework/flux-core#7731.
I repushed with the suggested changes, plus addressed some test failures that were a bash (redhat) vs dash (debian) thing….
alecbcs commented on issue spack/spack-packages#5620.
Package names appear to always be normalized by PyPi so we just need to match the same case / separator as is used in the actual tarball name for {name} and it’ll work….
camierjs commented on issue mfem/mfem#5387.
Really neat! Thank you @tdrwenski !…
jandrej commented on issue mfem/mfem#5387.
> We should mention this new feature in the CHANGELOG.
…
JustinPrivitera commented on issue llnl/conduit#1651.
what is conduit_fmt::runtime and why do we need it?…
adayton1 commented on issue llnl/axom#1912.
Instead of removing the cpp14 variant, can’t you just make it conflict with the version that requires c++17 and any version newer than it?…
adrienbernede commented on issue llnl/CARE#379.
> > If you can get access to a bank (other than guests) on matrix, the best is to define it as the default one. But otherwise, yes, we can easily set the CI to use it in the alloc options (.gitlab/custom-variables.yml). …
chu11 commented on issue flux-framework/rfc#535.
doh! i totally forgot about the rfc. thanks!…
chu11 commented on issue flux-framework/flux-core#7729.
> These are vendors being motivated to be flux developers so I figured that was probably the right location? …
cmoussa1 commented on issue flux-framework/flux-accounting#556.
Going to close this for now….
cjekel commented on issue cjekel/piecewise_linear_fit_py#134.
@doronbehar should be fixed now…
cbritopacheco commented on issue cbritopacheco/rodin#314.
Superseded by #315. This branch still carried the six commits that #312 squash-merged into develop, so it conflicted with develop
jeremylt commented on issue CEED/libCEED#1988.
Yeah, go ahead and remove the one outside of the init function since it isn’t helping us anymore …
cyrush commented on issue Alpine-DAV/ascent#1742.
Yes, space is tight for static cuda builds – working on a potential fix. …
jeremylt commented on issue 4C-multiphysics/4C#2012.
Fantastic, then the user just needs to get the correct flags sent to Kokkos via building Trilinos correctly. …
tgamblin commented on issue spack/governance#6.
@rbberger yes please update Phil to https://sig.com…
imguoguo commented on issue sipeed/sipeed_wiki#988.
v-dobrev commented on issue mfem/mfem#5406.
Merged in next for testing……
artv3 commented on issue llnl/RAJA#2006.
@llnl/raja-core , is this ready to go? …
tomstitt commented on issue llnl/RAJA#2059.
from an app perspective this looks great! thanks @artv3 !…
samuelkgutierrez commented on issue hpc/quo-vadis#542.
And I guess qv_process_scope_get could become qv_process_get and qv_mpi_scope_get could become qv_mpi_get? This one isn’t as clear to me, however. Open to suggestions here….
eleon commented on issue hpc/quo-vadis#540.
Thanks for asking, @samuelkgutierrez . I prefer CLOSE. Close seems to be a more straightforward concept, while affinity preserving, in my opinion, would require explaining to users (including me) what it means :) …
sam-maloney commented on issue flux-framework/flux-core#7488.
To add the only salient info from my duplicate issue, my log was missing the “got SIGTERM” from rank 1 instead of rank 0, so it could be either order….
jameshcorbett commented on issue flux-framework/flux-coral2#161.
@behlendorf indicated that this issue and https://github.com/flux-framework/flux-coral2/issues/175 are the highest priority right now….
camierjs commented on issue GLVis/data#10.
Is this on top of #9 ? macos-10.15 was not affected then….
jandrej commented on issue EnzymeAD/Enzyme#2948.
updated and removed inactivity list file from history…
hppritcha commented on issue open-mpi/ompi#14171.
oh ignore my comments about Fortran. I forgot we’d already added a sub implementation that had the fortran interfaces….
hppritcha commented on issue open-mpi/mtt#956.
The error that started this problem is likely this based on the error log:…
trws commented on issue flux-framework/flux-sched#1530.
It might, I’d have to look at the modprobe settings. That’s my best bet for the issue cause though, if feasibility stayed loaded then the dependent so would too. Also this would always happen on systems with musl, and there’s no way to fix it there (musl doesn’t actually unload shared objects)….
sam-maloney commented on issue flux-framework/flux-sched#1529.
It’s not making my life particularly difficult, no, but I did find it a bit needlessly confusing if the listed versions aren’t actually indicating real requirements
jameshcorbett commented on issue flux-framework/flux-sched#1530.
I just ran module remove sched-fluxion-qmanager/resource && flux module reload resource && module load sched-fluxion-resource, I didn’t manually touch feasibility at all. I thought removing resource or sched-fluxion-resource would force feasibility to exit?…
sam-maloney commented on issue flux-framework/flux-accounting#885.
Everything seems to be passing well in my latest builds! Many thanks @cmoussa1
tgamblin commented on issue spack/spack#52665.
@haampie ok, caching is disabled for spliced specs, and the traversal logic is simpler. I think this is a decent backport. the diff looks big but some code just moved into a try/finally block. …
wihobbs commented on issue flux-framework/rfc#529.
Ok, that seems to have consensus. Can someone push the approve button? Then I’ll go update my PR to Fluxion….
milroy commented on issue flux-framework/flux-sched#1316.
Thanks for the helpful feedback and improvements @vsoch, @jameshcorbett, and @trws! Setting MWP….
sam-maloney commented on issue flux-framework/flux-pmix#131.
As a follow-up (ideally once #132 is also decided) perhaps a v0.7.1 bugfix release could be triggered to make it easy to package this fix?
…
wihobbs commented on issue flux-framework/rfc#529.
Oh, of the options so far I like sched.selection_type the most. @cmoussa1 @garlick your thoughts?…
trws commented on issue flux-framework/rfc#529.
I’m leaning toward something like your suggestion @grondo, maybe alloc_type or sched_selection_type? That and make the strings the same here and in the PR and I think we’re probably good….
wihobbs commented on issue flux-framework/flux-sched#1528.
I’ll look at #1424, as you point out with this going into the next release it might be good to tackle that as well….
trws commented on issue flux-framework/flux-sched#1528.
That’s a fair point. The advantage to having the reserved boolean tracked here is I think I would need to do the same thing to solve #1424, because we need to know that something was reserved (and thus sent a time estimate) to clear those estimates the next time around. I suppose we could separate them and set “reserved” along with the time estimate but not track that it was reserved at the end? …
JustinPrivitera commented on issue visit-dav/visit#21036.
Hi @marcdurant. I apologize if you have already done this, but I asked codex to have a look at your crash report and comments here and it had a theory about what might be going wrong:…
alecbcs commented on issue spack/spack-packages#4437.
@bernhardkaindl went in and fixed the merge conflicts on the behalf of @dacolombo. …
v-dobrev commented on issue spack/spack-packages#143.
Update: I planning to run some tests with GPU builds and also see if more of the conflicts("^mfem build_system=cmake") are really necessary….
gardner48 commented on issue llnl/sundials#976.
This will depend on the index size selected at configuration time. By default this is a 64-bit signed integer type e.g., int64_t….
JustinPrivitera commented on issue llnl/conduit#1646.
@cyrush can you have a look at this? We discovered that the blueprint transforms can give wrong results if you call them with empty nodes. …
adrienbernede commented on issue llnl/Umpire#1076.
Can’t merge it myself……
artv3 commented on issue llnl/RAJA#2054.
> > Regarding old implementation of atomicGeneric in CUDA is giving incorrect results is that a CUDA related bug? or why is that happening?
…
adayton1 commented on issue llnl/CARE#379.
> If you can get access to a bank (other than guests) on matrix, the best is to define it as the default one. But otherwise, yes, we can easily set the CI to use it in the alloc options (.gitlab/custom-variables.yml). …
adrienbernede commented on issue llnl/CARE#379.
If you can get access to a bank (other than guests) on matrix, the best is to define it as the default one. …
vsoch commented on issue kubeflow/trainer#3712.
Primarily “here is a container or Dockerfile with out app and the command to run it at a small size.” The goal would be to reproduce what you want to do for testing….
milroy commented on issue flux-framework/flux-sched#1316.
> Final review from @trws then merge? …
jameshcorbett commented on issue flux-framework/flux-sched#1316.
Final review from @trws then merge?…
tpatki commented on issue flux-framework/flux-rest-server#3.
No worries, @garlick. The new PR is up….
garlick commented on issue flux-framework/flux-pmix#131.
It was kind of a baddie, and @sam-maloney ‘s excellent issue description made it easy to quickly narrow down. Thanks for the review! I’ll set MWP and ask Sam to confirm the fix when he has a chance….
sam-maloney commented on issue flux-framework/flux-pmix#130.
To add a couple of quick tests running flux pmi:…
chu11 commented on issue flux-framework/flux-core#5083.
I’ve had this on my “to cleanup” list for a long time, but as @grondo says above, what is the best/easiest solution. Using Claude Opus tried to get a gauge on how disruptive a change would be using a number of the suggested paths above:…
grondo commented on issue flux-framework/flux-core#7699.
In a meeting this was actually described as not a real requirement. Rather than try to guess at what solution is really desired here, let’s close this and later open a different issue with clear goals….
jeremylt commented on issue CEED/libCEED#1987.
Note - merging main into your branch instead of rebasing means I’d recommend we squash-merge this PR…
hppritcha commented on issue hpsfoundation/tac#93.
@jwillenbring …
grondo commented on issue flux-framework/rfc#530.
Required by mergify:…
jameshcorbett commented on issue flux-framework/flux-multi-cluster-utilities#29.
While working on this, I ran into another issue, which was that I can’t seem to update the jobspec in the jobtap plugin to have attributes.system.exec.test.override=1 . I’ve been working around this by setting that attribute directly on the jobspec at submission time. @grondo suggested making this edit in flux-core to track down the issue:…
sam-maloney commented on issue flux-framework/flux-core#7677.
I would immediately think that target should only ever be 0 or 1, as otherwise the request would skip over intermediate instances, which feels like a violation of the hierarchical model. Certainly for a shrink/partial release, those resources would have to be removed from the resource set of each instance in the hierarchy in any case, and then you have the more philosophical question of what gives a lower level application/instance the right to determine what its parent/ancestor instances do with their resources. I suppose a user might reasonably want a way to indicate that an application is releasing resources which are no longer needed by its own local instance for further workflow steps, but that would be different from the target proposed here, as the shrink would still need to be dealt with by the local instance first, it would just be guaranteed to be immediately followed by an equivalent job_manager.dyn_alloc_request from the local instance to its immediate parent.
…
cmoussa1 commented on issue flux-framework/flux-accounting#896.
Thanks @jameshcorbett! That is a good question you brought up. This segregation between child banks and users is intentional and is not allowed behavior for a hierarchy in flux-accounting. So, no, banks and users cannot exist under the same parent bank, so I think we should be okay here….
jeremylt commented on issue 4C-multiphysics/4C#2012.
Ah, this was a missing piece …
imguoguo commented on issue sipeed/picoclaw#2251.
@loafoe Hi! Since there’s been no activity after the earlier reminder, I’m closing this Grafana Alertmanager channel PR for now to keep the queue tidy. The work looked solid, so if you’d like to pick it back up, feel free to reopen anytime and we’ll gladly continue the review….
tzanio commented on issue mfem/mfem#5397.
Merged in next for testing……
chu11 commented on issue flux-framework/rfc#528.
> One point that might need clarification: can MODEL_VERSION contain whitespace? …
wihobbs commented on issue flux-framework/flux-core#7716.
Thanks for calling my attention to annotations, which do seem like the right approach. The RFC doesn’t stipulate what happens to a job’s annotations after the job enters the CLEAN state, unless the job fails (they are discarded). Do they persist in the KVS? Or is the way to reference a past job’s annotations through the eventlog?…
sam-maloney commented on issue flux-framework/flux-accounting#885.
@cmoussa1 I haven’t actually run a build since, but once v0.59.0 releases I will rebuild my RPMs and report back here on the outcome!…
jedbrown commented on issue rsmpi/rsmpi#224.
Thank you! Sorry about the delay….
jedbrown commented on issue openjournals/joss-reviews#9333.
The MPI reference @mpi1994standard does not appear in the bibtex file. You might be intending to cite @mpi50. The Ringler 2013 paper above does have a DOI, but is not cited. If it’s not intended to be cited, then the check above can be considered a false positive….
jandrej commented on issue mfem/mfem#5350.
> This is an interesting PR but I think it requires some discussion with the MFEM team at large. One of the basic tenets of the finite element method is that there is one mesh which is subdivided into elements on which we represent our fields. This PR relaxes this requirement for the special case where one mesh is a sub-mesh of another. Another alternative would be to compute bilinear forms on the primary and sub-mesh separately and combine these separate operators into a block system using coupling operators to define the mapping between finite element spaces. …
balos1 commented on issue llnl/sundials#966.
@copilot apply the changes in the diff produced by the failing litgen_check…
markcmiller86 commented on issue llnl/Silo#535.
Working on it. Just fixing a bug in DBCp() when copying between drivers
…
cyrush commented on issue visit-dav/visit#21047.
```…
cjvogl commented on issue pnnl/SPAECIES#52.
@quantheory I’ve rebased this branch off main that has #49 merged in….
v-dobrev commented on issue mfem/mfem#5334.
The diffs in “Files Changed” still show some changes that were already merged in master through PR #5330 – I suspect merging master here will fix that….
bgunnar5 commented on issue llnl/mada-tools#13.
Closing this as #15 will include these files….
cyrush commented on issue llnl/conduit#1642.
This is not a good change, the ownership semantics have to do with how the schema tree is owned, and a simple swap will not work….
tzanio commented on issue mfem/mfem#5393.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
v-dobrev commented on issue mfem/mfem#5259.
Note: I used a rebase + squash to merge the last two commits into next (ignoring the last merge of master into this branch)….
adrienbernede commented on issue llnl/RAJA#2045.
@johnbowen42 OK fixed !…
garlick commented on issue flux-framework/flux-core#7681.
Just pushed a big update that I think addressed all the review comments: …
trws commented on issue GTNewHorizons/CropsNH#189.
Thanks for the reasoning. It’s unfortunate but makes sense, honestly I didn’t even remember that the old version could be used for sand. Great work on making the migration mostly seamless….
becker33 commented on issue spack/spack#52652.
@haampie yes, it is. The reason I want it as a separate flag is because it will need to be the primary avenue for uninstalling specs with circular dependencies, but it seemed separate enough to be a separate PR….
adrienbernede commented on issue llnl/radiuss-spack-configs#187.
@johnbowen42 I invited you to the radiuss group in GitLab so that you automatically get added to subprojects like radiuss-spack-configs and raja mirror repos….
grondo commented on issue flux-framework/flux-core#7701.
Ok, I’ve addressed @chu11’s comments and pushed the result. Will set MWP….
cmoussa1 commented on issue flux-framework/flux-accounting#871.
I’ve rebased to catch up after a number of approved PRs. I know this has already been approved, but I believe that was before we noticed a couple of issues fixed by #880. @grondo, I’m not sure if you would want to give this another a look before I officially merge this! …
garlick commented on issue chaos/nodediag#24.
Thanks!…
jeremylt commented on issue 4C-multiphysics/4C#2012.
The concern about build time makes sense. Though, I was under the impression that we do not currently have CUDA hardware that we can run CI on and OpenMP could be used as a surrogate to ensure shared memory parallelism is covered by CI once it is added in follow up development work?…
cyrush commented on issue visit-dav/visit#21045.
@andymwood thanks for the report….
alecbcs commented on issue spack/spack-packages#5428.
@spackbot run pipeline…
alecbcs commented on issue llnl/repligit#190.
I think I prefer to simplify down to only instantiating the variable for line2 since we only ever use line1 once….
alecbcs commented on issue llnl/radiuss-spack-configs#187.
Haha well this is unintuitive [at]lc-hubcast run pipeline reruns the pipeline on the last commit that was synced. But since this wasn’t synced recently it’s just effectively rerunning the pipeline on the old commit.
…
bgunnar5 commented on issue llnl/mada-tools#13.
@lc-hubcast run pipeline…
bgunnar5 commented on issue llnl/hubcast#355.
@cmelone Ok thanks for the heads up. Any idea how to resolve this? Does this have to do with how my GitLab CI is configured or my Hubcast YAML?…
adayton1 commented on issue llnl/Umpire#1081.
This call now fails with the error below: blt_convert_to_system_includes(TARGET umpire)…
vsoch commented on issue kubeflow/trainer#3427.
@andreyvelich is the user application specifying the entrypoint with mpirun, and the issue is about the environment being discovered for it? If yes, the approach the flux operator takes is to take the application command, and wrap that. In the case of PYTORCH, the problem (I think, if I understand correctly) is that normally there is another layer (the workload manager) like Flux or Slurm that you use to run the job, and its the workload manager that ensures the environment is properly set. If you just expect a TrainJob to be executing a pytorch script, and then have all the envars set (and correct) for leader and launcher, then you are essentially re-implementing a workload manager. …
garlick commented on issue flux-framework/flux-sched#1489.
I’ll go ahead and set MWP since this was already approved. Thanks!…
jedbrown commented on issue RDycore/RDycore#398.
Does temperature converge at second order if you shut off transport?…
cyrush commented on issue Alpine-DAV/ascent#1652.
@emily-howell …
jedbrown commented on issue openjournals/joss-reviews#6099.
The JOSS paper DOI loads now for me. Thanks, all!…
balos1 commented on issue llnl/sundials#973.
@lc-hubcast approve…
vsoch commented on issue kubernetes/enhancements#4671.
Just wanted to say I’ve been developing with this during June using the kind image 1.36.1 (or GKE 1.36.0-gke.2684000) and am so thrilled to see it moving through. This has been a long time coming, from Coscheduling in the scheduler-plugins repository to many other plugins, and (looking at the dates of this issue from 2024) I am so pumped to have this naively! Bring on the gangs, and everything that supports! Awesome work to everyone here!
eleon commented on issue hpc/quo-vadis#104.
Thank you, @samuelkgutierrez . This example brings an interesting semantics consideration. …
jeremylt commented on issue CEED/libCEED#1985.
Ope, I need to update the LIBXSMM hash to use in the gitlab yml…
cjvogl commented on issue mfem/mfem#4244.
Documenting here that I did run the modified ex1p provided above, which runs successfully on this branch while causing an error on master.
…
artv3 commented on issue llnl/RAJA#2006.
> ```c++ …
hppritcha commented on issue open-mpi/ompi#12796.
@mdosanjh are you still working on this? …
grondo commented on issue flux-framework/flux-core#7621.
Great! Already approved so feel free to merge when ready!…
garlick commented on issue flux-framework/flux-core#7621.
OK, just pushed an update with the following changes: …
markcmiller86 commented on issue visit-dav/visit#21034.
Will do…will have to wait ‘til monday though….
v-dobrev commented on issue spack/spack-packages#143.
Hi @jacobmerson, …
tgamblin commented on issue spack/spack#52613.
@haampie: I’ve reworked this to use rsvg, which preserves fonts properly and renders all the figures as a browser would. CI is also updated….
tzanio commented on issue mfem/mfem#5383.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
v-dobrev commented on issue mfem/mfem#5383.
ping: @tomstitt …
artv3 commented on issue mfem/mfem#5382.
@helloworld922 , the RAJA API takes resource objects that can be used to specify the stream, we have examples here: …
adayton1 commented on issue mfem/mfem#5383.
Thank you!…
jameshcorbett commented on issue llnl/scr#614.
Sorry for the delay in getting back to you! Yes we would be interested in working with you on this. I’m not sure yet how complex it would be to support this in SCR but I’d be very happy to investigate with you!…
adayton1 commented on issue llnl/axom#1893.
MFEM is already working on a fix: https://github.com/mfem/mfem/pull/5383…
eleon commented on issue hpc/quo-vadis#486.
Yes, we could calculate the ordinal id from get_dev_id_from_name. …
grondo commented on issue flux-framework/flux-sched#1513.
@kkier and @ryanday36 asked us to bump the priority on this one. We have weekly DATs where queues need to be reconfigured and they need to understand how to avoid this issue when manually moving nodes between queues on the live system….
artv3 commented on issue llnl/RAJA#2009.
> Quick poll @llnl/raja-core , do we want to call it RAJA::mask (
adayton1 commented on issue llnl/RAJA#2009.
Could you update the title of this MR?…
trws commented on issue llnl/RAJA#2006.
Honestly I think it does, at least in as much as when iter + stride is executed we want the result to be of the same type as iter. I suppose it wouldn’t have to be, but if not it would have to be convertible to the type of iter and that seems a bit harder to reason about. Also even if we actually do re-order them based on the sign of the stride, in a logical sense I think of it more like:
…
grondo commented on issue flux-framework/rfc#526.
Thanks! I’ve set MWP….
chu11 commented on issue flux-framework/flux-core#7681.
> Thanks @chu11 - I appreciate the review comments! I’ll start working through those starting with the design doc. …
becker33 commented on issue spack/spack#52602.
Closing this for now because #52603 and #52604 both resolve it without reverting….
cbritopacheco commented on issue cbritopacheco/rodin#302.
Closing: this was an optimization/uniformity change (MatAXPY preassembled-merge fast path + OpenMP buffer hoisting), not a bugfix. The fast path regressed value-Dirichlet assembly on PETSc 3.19 (MatZeroRowsColumns missing-diagonal). Not worth the risk
artv3 commented on issue llnl/RAJAPerf#684.
@michaelmckinsey1 take a look here: https://github.com/llnl/RAJA/blob/develop/benchmark/ltimes.cpp, it would be cool to also have a GPU shared memory version as a tuning! …
tzanio commented on issue mfem/mfem#5358.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
JustinPrivitera commented on issue llnl/conduit#1620.
Closing in lieu of #1627 and #1625…
artv3 commented on issue llnl/RAJAPerf#693.
Nice @michaelmckinsey1 ! What would be neat is to add a batching parameter and allow for different batch sizes, maybe 4 is good GPU X or 7 is good for GPU Y type of thing …
artv3 commented on issue llnl/RAJA#2009.
@llnl/raja-core , building on the comments and suggestions, the latest push explores the following function to be used in RAJA::launch : …
garlick commented on issue flux-framework/flux-core#7681.
Updates: …
grondo commented on issue flux-framework/flux-core#7674.
I’ve set MWP here….
markcmiller86 commented on issue visit-dav/visit#20971.
@cyrush if you a min, pls take a look. Artifact handling follows newest guidance from MS and other changes may reduce (I am still evaluating LFS budget usage reports to be sure) LFS BW usage….
balos1 commented on issue llnl/sundials#961.
@BarrySmith this should fix the issue you were having in #935 …
cyrush commented on issue llnl/conduit#1625.
The simplified templates look good – Note: think we want to keep dispatch with the functor as a just in case. …
cmoussa1 commented on issue flux-framework/flux-accounting#883.
Thanks a bunch for the feedback here @jameshcorbett! Setting MWP here…
cyrush commented on issue Alpine-DAV/ascent#1735.
To test, we can use: …
JustinPrivitera commented on issue visit-dav/visit#19544.
reopening so that we see this since it was marked un-reviewed….
camierjs commented on issue mfem/mfem#5230.
Some failures are hit on GPU with ./pgpu_unit_tests [ParticleSet] triggered by the CHECK(code_N_count == 0); of tests/unit/fem/test_particleset.cpp with expansion: 1 == 0….
trws commented on issue flux-framework/flux-sched#1509.
Yeah, that hardcoded list of subsystems should never have existed. I’ll add it to the list of things to fix for subsystems….
wihobbs commented on issue flux-framework/flux-sched#1502.
> so I guess the docs are not being built by default? …
milroy commented on issue flux-framework/flux-sched#1505.
> In the resource graphs used to repro the issue (e.g. hetchy_jgf_formatted.json) there are many (32 I think?) ssd vertices per chassis, so even if the Fluxion can’t match multiple slots on a single SSD vertex, the job should still match. Am I missing something? …
garlick commented on issue flux-framework/flux-sched#1502.
Nice! Content-wise this seems like a good start. …
chu11 commented on issue flux-framework/flux-core#7668.
haven’t looked at the code yet, but it looks like in this proposal we would be changing the database schema. If we go forward with this general approach, would we like to consider other schema changes while we are at it? I’m mostly thinking of:…
garlick commented on issue chaos/diod#171.
Np! Thanks for the link!…
sam-maloney commented on issue Vanille-N/meander.typ#6.
> if you call par explicitly then the new paragraph splitting logic should be capable of correctly indenting it….
cjekel commented on issue llnl/professor#1.
Looks great! …
adrienbernede commented on issue llnl/CARE#378.
@lc-hubcast run pipeline…
grondo commented on issue flux-framework/rfc#523.
As I commented in flux-framework/flux-core#7615, this won’t work because it would break backwards compatibility: the scheduler and resource modules of subinstances fetch the R key from the parent. This change would break launching a previous version of Flux under the new version….
tpatki commented on issue flux-framework/flux-multi-cluster-utilities#8.
Closing as the other PRs supersede this one….
jameshcorbett commented on issue flux-framework/flux-multi-cluster-utilities#24.
Hmmm, mergify config not yet complete. Will just merge manually while I figure it out….
sam-maloney commented on issue flux-framework/flux-core#7677.
At a basic housekeeping level, eventually the commit messages will have to follow the formatting requirements: https://flux-framework.readthedocs.io/projects/flux-rfc/en/latest/spec_1.html#patch-requirements…
emily-howell commented on issue Alpine-DAV/ascent#1494.
@jfavre I have made a PR #1736 that addresses a bug I found relating to this ticket when trigger actions being passed via ascent_actions.yaml. I wanted to confirm if this is the same bug you encountered here. If not, could you provide more information for me to be able to replicate this bug….
sam-maloney commented on issue spack/spack-packages#5177.
Realized I was missing a colon in the when clause of flux_sched/package.py at L102, because I had copied the previous line which was also missing it :laughing: and there were 2 lines with when="@0.19.0" so I changed the second one to when="@0.20.0" as that seems to make sense with the release dates and the commit when it was added….
adayton1 commented on issue llnl/axom#1885.
Is there a way to iterate over the objects in the variant array without first converting to a vector?…
sam-maloney commented on issue flux-framework/flux-sched#1504.
> Works for me, may need to check the spack package for consistency after this. …
jedbrown commented on issue rsmpi/rsmpi#224.
Thanks, can you add the # Standard section(s) like all the other public functions?
…
tzanio commented on issue mfem/mfem#5352.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
jameshcorbett commented on issue flux-framework/flux-sched#1490.
> @jameshcorbett can comment more specifically, but my understanding is that the flux-coral2 module modifies the jobspec after the feasibility check is already done, so the job gets accepted then the jobspec is modified to contain the rabbit request. If you try that same command with --dry-run you should get the original jobspec….
trws commented on issue flux-framework/flux-sched#1490.
@jameshcorbett can comment more specifically, but my understanding is that the flux-coral2 module modifies the jobspec after the feasibility check is already done, so the job gets accepted then the jobspec is modified to contain the rabbit request. If you try that same command with --dry-run you should get the original jobspec….
grondo commented on issue flux-framework/flux-core#7660.
…
markcmiller86 commented on issue visit-dav/visit#21000.
@brugger1 is this ok now?…
hppritcha commented on issue spack/spack-packages#5169.
i thought these issues were addressed via https://github.com/spack/spack-packages/pull/5148 ….
markcmiller86 commented on issue llnl/H5Z-ZFP#168.
> From my reading it looks like the test is just trying to corrupt a bit of the raw data towards the start of the dataset’s data (now the first chunk in this case)? If so, this looks fine to me. …
grondo commented on issue flux-framework/rfc#521.
Sure. I had considered doing that but figured someone looking a job eventlog might naturally think to look at the “Job States and Events” RFC. I didn’t see anywhere mentioned that this was the job manager RFC. Easy enough to add a new RFC….
garlick commented on issue flux-framework/rfc#521.
I’m surprised we haven’t done this already! …
milroy commented on issue flux-framework/flux-sched#1503.
> In v0.51.0 the jobspec matches with firstnodex….
cjvogl commented on issue mfem/mfem#4905.
Closing this PR in lieu of #5362 that will include all the reconstruction work here alongside the SAMRAI-MFEM coupling work….
gardner48 commented on issue llnl/sundials#957.
When using an implicit method with the default nonlinear solver (Newton’s method) you need to create and attach a linear solver before evolving the problem in time. The lines starting here in the ark_analytic.c example show how to do this for a dense linear solver (and matrix). There should be a runtime error in this case, but it seems there is a missing check….
jeremylt commented on issue jeremylt/personal_website#3.
I need to read the Leiden Declaration and see if it applies here…
wihobbs commented on issue flux-framework/flux-sched#1493.
I want to look into that failure, so removing MWP for now….
sam-maloney commented on issue flux-framework/flux-sched#1501.
> If we require >= flux-core v0.78.0, then we could drop the old rc1 style scripts in etc/. In fact, there could be an implicit dependency on modprobe for the sched-fluxion-feasibility module already….
garlick commented on issue flux-framework/flux-core#7467.
It might actually be better to just add a FLUX_MSGGFLAG_COMPOUND flag to indicate that the payload is compound (steal FLUX_MSGFLAG_USER1), and rather than requiring JSONL, use size prefixed segments. Then a message could contain multiple raw payloads, which could potentially avoid base64 encoding in KVS commit messages, and allow batching of content load/store payloads….
cbritopacheco commented on issue cbritopacheco/rodin#294.
@copilot resolve the merge conflicts in this pull request…
jeremylt commented on issue CEED/libCEED#1982.
hmm, this should be compared to the operator application kernel to make sure we are not breaking HipStar support …
hppritcha commented on issue open-mpi/ompi#13956.
Yes I do agree….
samuelkgutierrez commented on issue hpc/quo-vadis#467.
From today’s meeting with Guillaume….
cmoussa1 commented on issue flux-framework/flux-accounting#872.
Thanks @jameshcorbett! These were all great suggestions. I’ve gone ahead and force-pushed up some changes to this PR based on your feedback. I will set MWP here shortly…
hppritcha commented on issue eschnett/mpif#1.
I will set up a poll and invite some folks so we can set up a good time for a call….
alecbcs commented on issue spack/spack-packages#5104.
@spackbot run pipeline…
hppritcha commented on issue open-mpi/ompi-www#563.
@edgargabriel oops forgot to add this file…
alecbcs commented on issue llnl/hubcast-test#6.
@lc-hubcast help…
artv3 commented on issue llnl/camp#205.
Used internally: https://github.com/llnl/camp/blob/56b194f3ea3d0e9d6e2f236de39a4886063e4968/include/camp/resource/hip.hpp#L187C5-L187C37 …
adayton1 commented on issue llnl/Umpire#1072.
> Update: Hubcast doesn’t understand jobs that are allowed to fail. We can either fix the job failure or try to fix within Hubcast somehow.. stay tuned …
artv3 commented on issue llnl/RAJA#2010.
Closing PR until next release…
becker33 commented on issue spack/spack#52492.
I think we should actually hold off on merging these until we’re done with major backports to the 1.2 release branch. Even though we’ve cut the branch already, I don’t want to make backports any harder than they need to be between now and the release, and this one is more minor but this project as a whole touches a ton of files….
hppritcha commented on issue open-mpi/ompi-scripts#95.
never mind this still needs some work….
jeremylt commented on issue libxsmm/libxsmm#855.
Understood …
wihobbs commented on issue flux-framework/flux-core#6952.
I think @grondo and I have accomplished everything scoped here. Closing
tzanio commented on issue mfem/mfem#5019.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
vsoch commented on issue kubeflow/trainer#3179.
@roberthluo the MPI test uses a wantinfo object to do comparison. The current flux tests do not. Here is the initial discussion:…
v-dobrev commented on issue mfem/mfem#5346.
Hi @nmnobre, @najlkin, @tzanio, @helloworld922, …
garlick commented on issue flux-framework/flux-core#7659.
Oh, maybe I was looking at the same failure b/c mergify just merged this! NM….
jeremylt commented on issue CEED/libCEED#1980.
Ah the correct fix is probably to update the libCEED hash PETSc is using …
vsoch commented on issue urlstechie/urlchecker-python#95.
Spam…
alecbcs commented on issue spack/spack-packages#5083.
Cool! Let’s just make sure we document that variable and alternatively script modifications for the release notes….
becker33 commented on issue spack/spack#52492.
@haampie yes that was my plan…
tgamblin commented on issue spack/spack#52397.
Agree! We are working on revamping the site – see what you think of https://id-preview–a538ff6f-a974-428e-b9b8-9b6a19dda20c.lovable.app (note that this is valid for only 7 days) which is a preview of how we think the site will eventually work….
jandrej commented on issue mfem/mfem#5338.
I wrapped up the changes in #5232 and waiting for reviews. I’ll keep this open until the other PR is merged….
jameshcorbett commented on issue flux-framework/flux-sched#1490.
Anecdotally, the error seems to occur when a user requests more nodes than there are rabbits in the system. The --coral2-chassis flag may help reduce the error rate by constraining node placements to fewer chassis. The error seems to have occurred around the time we switched clusters to using the firstnodex match policy….
chu11 commented on issue flux-framework/flux-core#7656.
> This is why I’d suggested a few “safe” tests get ci=asan markers or something like ci=system. …
hppritcha commented on issue open-mpi/ompi-www#559.
@edgargabriel ping…
hppritcha commented on issue open-mpi/ompi#13598.
i’d say this is worth a try. anyway it looks like coverity has gone on an extended vacation. maybe codeql could provide some of the capabilities that we used to get with coverity?…
cjvogl commented on issue mfem/mfem#4244.
> Regarding testing, it is easy in the way the bug appears at many places
adrienbernede commented on issue llnl/radiuss-spack-configs#176.
@kab163 @adayton1 Thank you for that. Replacing was the right move….
garlick commented on issue flux-framework/flux-sched#1497.
Just pushed the change to select the reader using hints from R.scheduling.writer. It looks like only rv1exec (no schedluing key) actually works with partial cancel presently - fine for now since that’s what the job manager will generate….
jameshcorbett commented on issue flux-framework/flux-multi-cluster-utilities#22.
Another example would be a timeout exception. If the job times out, we definitely shouldn’t retry. Otherwise we wouldn’t be respecting the time limit restrictions placed on the job….
cmoussa1 commented on issue flux-framework/flux-accounting#878.
I’ve rebased this to catch up after #880 - I’ll go ahead and set MWP here. Thanks again for reviewing this @jameshcorbett! …
cyrush commented on issue visit-dav/visit#20972.
@biagas thanks for confirming!…
gardner48 commented on issue llnl/sundials#884.
> I think we can change the minimum back to 3.8. I had bumped it to match sundials4py but I dont think we are using anything from 3.12 in these scripts. …
adrienbernede commented on issue llnl/radiuss-shared-ci#67.
@davidbeckingsale This is ready. See it work in Umpire: https://github.com/llnl/Umpire/pull/1050…
trws commented on issue flux-framework/flux-sched#1489.
> Also, I happened to notice b60e200 by @zekemorton which makes me question my choice to have these new functions use UP|DOWN strings instead of the enum. Which do sched developers prefer? My thinking that using the enum was unnecessarily exposing an internal data structure and that it would be easy to add another state (like DEGRADED or similar) as a string without breaking the API, but the enum is nicer to work with a Zeke points out in the commit message. …
sam-maloney commented on issue flux-framework/flux-core#7643.
Otherwise, I’ve added the check-executables-have-shebangs pre-commit-hook and updated the config (and fixed a few additional files that the hook then flagged :grin:), so perhaps @grondo you could have a quick double-check!…
wihobbs commented on issue flux-framework/flux-core#7354.
Completed by #7506 …
wihobbs commented on issue flux-framework/flux-coral2#486.
If we get rid of this here, we need to add it back in ansible (note my comment in #478)…
chu11 commented on issue chaos/powerman#217.
@mergifyio rebase…
imguoguo commented on issue BeaconCat/Pharos#1.
## Root cause references…
tzanio commented on issue mfem/mfem#5349.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
gardner48 commented on issue llnl/sundials#887.
Superseded by #946…
jedbrown commented on issue jeremylt/LFAToolkit.jl#94.
With the multi-element patches, we would like the ability to do heterogenous patches with standard LFA (see Kumar, Rodrigo, Gaspar, Oosterlee 2019)….
grondo commented on issue flux-framework/rfc#519.
While working on the implementation for the external helper, I realized that the current spec for the Device Containment options to the IMP was incorrect. I’ve added a commit here that corrects the section to describe what is currently in use. That could use a review. …
gardner48 commented on issue erf-model/ERF#3232.
The changes look good but two tests are now failing on one of our AMD systems with this branch: …
markcmiller86 commented on issue betterscientificsoftware/bssw.io#2541.
We also support cases where there is not viable URL for a citation but there is full bibliographic detail available. That just means that there is no off-article link for the item in the References block….
cyrush commented on issue Alpine-DAV/ascent#1692.
@nicolemarsaglia thanks for resolving that last puzzle!…
cyrush commented on issue visit-dav/visit#19544.
removing reviewed b/c user reports seeing this on El Cap with 3.5.0, from linux using x11 forwarding (not sure if using x11 or wayland)…
vsoch commented on issue oras-project/oras-py#240.
@jiwangCHEN push and pull interfaces should not go away. A push or pull is a directional copy. There should be no breaking changes in changing the underlying structure to use copy….
wihobbs commented on issue flux-framework/flux-sched#1490.
It’s more stable (I’ve yet to see a rabbit allocation fail with that flag in there.) When James gets back next week we can dissect why, but for now, I think our stock advice is to allocate chassis along with any rabbit job….
garlick commented on issue flux-framework/flux-sched#1489.
reapi.hpp was updated to include prototypes for the (string based) generic status get/set functions, with inline docs….
milroy commented on issue flux-framework/flux-sched#1467.
I’ve verified that the errno contract violation fixes in @garlick’s PR’s #1483 and #1484 obviate the first commit in this PR. I’m dropping it.
…
grondo commented on issue flux-framework/flux-core#7644.
@kkier suggested setting allow_abbrev=False for argparse which would help in this specific case. However, the behavior we want from argparse is the POSIX behavior where option processing stops at the first non-option argument (See POSIXLY_CORRECT in getopt_long(3)). I haven’t looked in awhile, but last I checked the argparse maintainers were unwilling to implement that behavior….
garlick commented on issue flux-framework/flux-core#7644.
Thanks for reporting this!…
chu11 commented on issue flux-framework/flux-core#7594.
hmmm seems like “system,coverage” builder is failing. At first I thought it was just not-perfect coverage. Perhaps a system test I missed that could be affected this PR’s change. Unfortunately builder logs not most obvious on the issue, but hopefully a container will figure this out quick. Edit: oops, now I see a log file, seems like t9000 tests with 0007-fsck.t failing.
…
cmoussa1 commented on issue flux-framework/flux-accounting#875.
Thanks @grondo! I’ve gone ahead and force-pushed up a fix to add a comment to accounting.hpp for those overloaded functions to explain their subtle difference from the others. I’ll go ahead and set MWP here shortly…
garlick commented on issue chaos/powerman#216.
Looking good here so let’s merge. Thank you for running this down and for your excellent commit message! Let’s merge….
jeremylt commented on issue CEED/libCEED#1977.
@zatkins-dev this is purely a cleanup, no functional changes, but if you aren’t familiar with what’s happening inside of this file, it’s an interesting file to poke around in…
jandrej commented on issue zed-industries/zed#57703.
Same issue here, not sure if intended behavior….
cyrush commented on issue spack/spack-packages#5005.
Thanks for merging!…
hppritcha commented on issue open-mpi/ompi-tests-public#38.
hmmm please run copilot against this and see what it thinks….
hppritcha commented on issue open-mpi/ompi#13883.
@janjust is this ready to merge?…
balos1 commented on issue llnl/sundials#937.
@xcartoixa This should be fixed by #944. …
vsoch commented on issue converged-computing/resource-secretary#6.
Awesome! I will test this soon….
emily-howell commented on issue Alpine-DAV/ascent#1682.
Merged in #1676 and #1663 and changed this branch to merge into develop. @cyrush It should be ready to merge in but if you have any feedback about the error messages I can absolutely make additional changes :)…
JustinPrivitera commented on issue llnl/conduit#1358.
TODO add a new macro for cuda + hip + umpire == CONDUIT_USE_DEVICE…
trws commented on issue flux-framework/flux-sched#1467.
I think this is good to go, something you want to do before MWP @milroy?…
jedbrown commented on issue CEED/libCEED#1813.
I added change notes and I’m happy now….
benzwick commented on issue A2B-Technology-Corporation/Talk2View-Writer#10.
Future hard-enforcement (engine-side minimum client version) tracked in A2B-Technology-Corporation/Talk2View-Platform#72….
jedbrown commented on issue blas-lapack-rs/blis-src#13.
Is there a release that contains the fix? It looks like that report came after BLIS-2.0. Have you thought about a recommended fix for blis-src?…
tgamblin commented on issue EPCCed/cirrus-ex-spack#44.
See also https://github.com/spack/spack/pull/51891…
jedbrown commented on issue rsmpi/rsmpi#222.
Thanks; I merged #223 because it was more complete. Sorry about the slow response….
tzanio commented on issue mfem/mfem#5340.
@maxpaik16, is this ready-for-review (see the contributing guidelines)?…
garlick commented on issue flux-framework/flux-sched#1481.
Now based on top of …
jameshcorbett commented on issue flux-framework/flux-sched#1372.
The jobspec-update events look the same? I’m on my phone but am I missing something?…
hppritcha commented on issue open-mpi/ompi#13911.
looks like there’s a failure making the tarballs for main and v6.0.x owing to some changes to the way docs are generated….
gardner48 commented on issue llnl/sundials#938.
The different versioning is a historical holdover from CVODE, IDA, and KINSOL predating SUNDIALS then IDAS and ARKODE getting added later. The versions have all been updated in lockstep with the SUNDIALS version for a while now, so moving to a single version number for everything would be reasonable. …
balos1 commented on issue llnl/sundials#938.
Should we consider just syncing up the IDAS and ARKDOE versions with the rest of SUNDIALS? I see no real advantage of having them differ. …
alecbcs commented on issue llnl/hubcast-test#5.
@lc-hubcast help…
trws commented on issue llnl/camp#199.
Wow, that’s clearly a mistake on my part. Would you like to put that up as a PR so you get credit for it?…
trws commented on issue flux-framework/flux-sched#1467.
> I also expect we will need to consider how units are represented to avoid string comparisons…
milroy commented on issue flux-framework/flux-sched#1483.
> P.s. there are more of this type of problem in the planner code. …
wihobbs commented on issue flux-framework/flux-core#7586.
Oops. I think this will do it: …
grondo commented on issue flux-framework/flux-core#7586.
Hm, getting these errors when this branch was merged to master: …
chu11 commented on issue flux-framework/flux-core#7622.
thanks, will set MWP…
gardner48 commented on issue dealii/dealii#19729.
@bangerth thanks for bringing this to our attention. @vovannikov sorry for the confusion, llnl/sundials#938 should make this clearer. …
jeremylt commented on issue CEED/libCEED#1970.
uggggghhhhhh…
JustinPrivitera commented on issue visit-dav/visit#20959.
> As a reminder, most of the changes here were reviewed in smaller chunks as PRs for merge into this branch. …
markcmiller86 commented on issue visit-dav/visit#20961.
@biagas I have tested this locally and with this invokation of build_visit
…
cyrush commented on issue llnl/conduit#1607.
I created a glob match util and remove refactored to use it….
adrienbernede commented on issue llnl/Umpire#1049.
@davidbeckingsale I fixed the ordering issue by redirecting stderr to stdout for the build_and_test script. …
wihobbs commented on issue flux-framework/flux-coral2#478.
> At scale we’re going to want to make sure we’re not seeing requests timing out or similar problems….
markcmiller86 commented on issue betterscientificsoftware/bssw.io#2531.
FYI…I have no expectations regarding WHEN this gets published. Just wanted to get it ready to publish for whenever makes sense. I did enter today’s date into the .md file though….
jandrej commented on issue mfem/mfem#5338.
Sidenote: there is a PR https://github.com/mfem/mfem/pull/5232 which introduces generic sizing….
jameshcorbett commented on issue flux-framework/flux-coral2#478.
Old issue for this is #166. PR to run nnf-clientmount continuously is #486….
tomstitt commented on issue mfem/mfem#5309.
> > I will update when I know more. …
tgamblin commented on issue hpsfoundation/tac#72.
Linked and updated above. @slandath we should probably also link the proposals when we make these review issues….
vsoch commented on issue kubeflow/trainer#3312.
Thank you, @Raakshass. For a heads up, I will be out and back later this coming week. …
tzanio commented on issue mfem/mfem#5329.
Merged in next for testing……
BradWhitlock commented on issue llnl/axom#1866.
The failures on dane are the same as I was seeing in my PR. I’m testing whether PR #1868 fixes them….
milroy commented on issue flux-framework/flux-sched#1467.
I added some commits to address the overbooking issue @jameshcorbett identified and have fixed it on all platforms but EL8. It appears that EL8 is exhibiting different match-allocate behavior than the other test platforms. …
markcmiller86 commented on issue visit-dav/visit#20936.
Hello @visit-dav/visit-core-team, does anyone have time to review? Feel free to ask questions….
tgamblin commented on issue spack/spack-packages#4829.
Isn’t 1.0 the version of the current compiler wrapper in Spack? I guess if this is the same as the current version it’s fine. Labeling this 1.1 or something would make a clear break and would make it easier to run, e.g., spack find compiler-wrapper@1.1: to find only the ones from github.
…
tgamblin commented on issue spack/packages.spack.io#37.
Resolved by #43…
alecbcs commented on issue llnl/hubcast#301.
Closing in favor of #312 …
cyrush commented on issue llnl/conduit#1607.
TODO: Test cases are WIP, need to add many more: …
markcmiller86 commented on issue llnl/Silo#552.
FYI…use 4.12.1-pre2 release assets. The release assets in 4.12.1-pre1 are bloated due to inclusion of ghpages subdir (for silo.llnl.gov website) which includes all prior .tar.gz releases….
jeremylt commented on issue libxsmm/libxsmm#855.
Is libxsmm moving away from making any more releases? While that would not be my preference, it would be handy to know if that is libxsmm’s plan so I can point our users at a specific commit hash as the dependency version instead of a version number…
jameshcorbett commented on issue flux-framework/flux-sched#1467.
If the overallocation issue I mentioned can be fixed I think this would be a huge step forward for the rabbits. However, there is a further step for the rabbits which I don’t think the PR addresses, which is fine, I just want to make sure that it’s known. …
trws commented on issue flux-framework/flux-sched#1467.
Ok, was that the source of the el8 failure or is that looking like a heisenbug?…
grondo commented on issue flux-framework/flux-core#7623.
Nothing obvious for rc3 from a login node in dry-run mode, just attr.get, config.get and module.list as expected (the of course the module.remove calls.)…
garlick commented on issue flux-framework/flux-core#7623.
Was it stuck after the last log entry there? (on “unload builtins”)?…
markcmiller86 commented on issue HDFGroup/hdf5#6153.
Just curious but where is it written or decided that for ZFP, rate=3.5, precision=16 is or should be considered an error? I mean, based on what I know about ZFP, it certainly seems like you can ask for one or the other but not both. …
cyrush commented on issue visit-dav/visit-website#21.
Resolves: https://github.com/visit-dav/visit/issues/20954…
jedbrown commented on issue openjournals/joss-reviews#9576.
Sorry to have missed this. I’m pretty underwater at the moment, but would be available late next month. …
v-dobrev commented on issue mfem/mfem#5316.
Merged in next for testing……
garlick commented on issue flux-framework/flux-sched#1481.
Please hold off on reviewing this - I’m redoing a few things after making a first pass on a pool class….
cmoussa1 commented on issue flux-framework/flux-accounting#869.
Thanks for reviewing @jameshcorbett! I’ve addressed your great suggestions above and force-pushed. I’ll set MWP here…
artv3 commented on issue llnl/RAJA#1857.
> @artv3 do we want to target this for our summer release? …
mplegendre commented on issue llnl/Spindle#177.
I addressed the identified issues. …
trws commented on issue flux-framework/flux-docs#323.
The question really needs to go to legal. Technically all of our docs are licensed under LGPL3 because of the release process for flux as a whole. If they don’t object to re-licensing the docs as CC then I don’t think any of us object either, but it’s lab legal we have to ensure is alright with it. …
becker33 commented on issue spack/spack-packages#3968.
I believe it is #52029…
hppritcha commented on issue spack/spack-packages#4804.
okay in that event use the patch you selected. it should probably be applied to all builds out of the 5.0.x release stream….
dylan-copeland commented on issue mfem/mfem#5054.
@IdoAkkerman since I already approved this PR, should we move forward with merging it? If so, we can request review again from someone else….
vsoch commented on issue yoonho/flux-qrmi#2.
Understood, thank you @ohtanim….
vsoch commented on issue singularityhub/shpc-registry#480.
I do think if we used the docker api proper (instead of falling back to my lazy approach) we might get more fine tuned control of the requests. That direction sounds good to me!…
tzanio commented on issue mfem/mfem#5124.
Merged in next for testing……
BradWhitlock commented on issue llnl/axom#1860.
I’m pursuing an idea I had about reusing the MatsetView types to traverse the mixed field data since their representation changes depending on the structure of the matset….
vsoch commented on issue flux-framework/flux-core#7606.
Excellent - looks good! …
grondo commented on issue flux-framework/flux-core#7606.
Should be fixed now: flux-framework/flux-sched#1480…
chu11 commented on issue flux-framework/flux-core#7594.
just re-pushed, handling many of the corner cases that existed in the initial work. removing WIP …
JustinPrivitera commented on issue visit-dav/visit#20950.
venn should be robust to that case: https://github.com/llnl/conduit/issues/1600…
BradWhitlock commented on issue visit-dav/visit#20950.
I think the empty “background” material is the problem, which came from calling venn() with radius 5. It turns out a more suitable value is something like 0.25. Still, it exposes bug dealing with bad data….
alecbcs commented on issue spack/spack-packages#4550.
@spackbot run pipeline…
becker33 commented on issue spack/spack#52062.
```…
uvilla commented on issue pecos/tps#325.
A possibility cleaner way is warning suppression in valgrind. …
hppritcha commented on issue open-mpi/ompi#13847.
related to #13879 …
JustinPrivitera commented on issue llnl/conduit#1601.
We could also have a table of contents at the top like we did for the X Ray Image Query: https://visit-sphinx-github-user-manual.readthedocs.io/en/develop/using_visit/Quantitative/XRayImageQuery.html…
jedbrown commented on issue OSGeo/gdal#14500.
> As long as you put part of the book in the input prompt. …
jeremylt commented on issue CEED/libCEED#1963.
Checked CI locally - happy to merge if you want me to
…
cyrush commented on issue visit-dav/visit#20946.
I am not sure how robust this is b/c we dont test it….
becker33 commented on issue spack/spack-packages#4652.
@climbfuji can you try to create a more human-readable PR title in the future?…
tgamblin commented on issue spack/spack#52137.
Closing this until we can revisit it as an additional configuration option to control what failures are acceptable. We may also revisit making a 404 on URL fetch acceptable, but this is not critical for CI since GitLab’s reliability has been improved….
alecbcs commented on issue llnl/hubcast-test#5.
@lc-hubcast help…
imguoguo commented on issue imguoguo/Comments#38.
> @fktoday…
trws commented on issue flux-framework/flux-sched#1477.
sigh…
trws commented on issue flux-framework/flux-core#7608.
Maybe rhel9 or 10 equivalent for the TOSS connection? Otherwise I’d probably default to whatever the current Ubuntu LTS is….
jameshcorbett commented on issue flux-framework/flux-core#7591.
> > FWIW, after messing around for a while, the best thing I could come up with to remove a hard dependency on ply was to move the ply imports from the top of modules into the bodies of every function or method that uses it. :( …
cmoussa1 commented on issue flux-framework/flux-accounting#858.
OK, so I’ve been messing around with a redesign for the better part of a week now and I think I’ve actually been able to get somewhere significant. The overhaul has been quite a lot of work thinking about a) how to make previously-hard-coded parameters configurable and extensible, and b) how to update an already-existing flux-accounting database to adopt the new design….
vsoch commented on issue llnl/cardioid#17.
Thanks! This is more than 3 years old and we finished and published the work. Closing….
samuelkgutierrez commented on issue hpc/quo-vadis#452.
qv_scope_split() is more expressive because it has an npieces parameter that split_at() does not….
garlick commented on issue flux-framework/flux-core#7605.
```…
vsoch commented on issue cosimameyer/awesome-pyladies-creations#112.
Yes of course! Thank you for the showcase!
adrienbernede commented on issue llnl/radiuss-shared-ci#76.
In facts, I have mixed feelings: from the components perspective, I like how everything is explicitly stated in the inputs. But in the underlying setup, the perf processing job extends caliper to github, which extends convert to github, which itself has not script because the script should be specified by the user… But again, the components inputs makes the requirements clear….
tomstitt commented on issue mfem/mfem#5309.
While I was trying to make a standalone reproducer I found that hipsparseSpMV_preprocess is not always needed, you can make a basic driver that works without it. I’m not sure yet if it’s the structure of our matrices, something about the function call ordering, or something else. I will update when I know more.
…
milroy commented on issue flux-framework/flux-sched#1466.
> We are maybe trying to get https://github.com/flux-framework/flux-sched/pull/1465 in as well @milroy ? …