markcmiller86 commented on issue llnl/Silo#537.
Yes. But, don’t also enable BUILD_TESTING. I am seeing a CMake issue when that is enabled. And, of course, you can’t have the python interface in a static build either….
becker33 commented on issue spack/spack-packages#4076.
Re-ran cI jobs that failed for CI-system issues, they all pass. …
grondo commented on issue flux-framework/flux-security#219.
Thanks! Setting MWP….
garlick commented on issue flux-framework/flux-core#7500.
After discussion with @trws and some reflection on #7496 , it seems like the existing python schedulers should be reusable with externally provided ResourcePool implementations. I’ll change the “rack” test scheduler proposed here to be a test RackPool class instead, and then make it possible to override the pool class from the Scheduler base class (via module option and via R.scheduling.writer URI key)….
grondo commented on issue flux-framework/flux-core#7528.
> But, given your explanation, my sample script should work, right?…
markcmiller86 commented on issue visit-dav/largedata#5.
Thanks for the report and the fix :muscle:…
vsoch commented on issue singularityhub/guts#10.
We would need a SingularityContainer class akin to the DockerContainer class that exposes the same function signatures, and I think that would do it. Knowing Singularity images, the issue we might run into is with respect to speed to do the same operations, but it is worth a test! If you are interested in taking a shot, the main entrypoint creates a ManifestGenerator that is going to call extract on that class. That happens here:…
v-dobrev commented on issue mfem/mfem#5251.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
JustinPrivitera commented on issue llnl/conduit#1358.
Updated strawman from my talk: …
garlick commented on issue flux-framework/rfc#452.
Great point about the single core jobs. I am flip flopping on the template idea today and going around in circles I’m afraid….
sam-maloney commented on issue flux-framework/rfc#452.
I’m going to start working through the jobspec examples from RFC 14 to see what comes up (giving just the resources key, and essentially arbitrary assignment of ids):…
trws commented on issue flux-framework/flux-sched#1424.
I’m digging into this now, and I’m pretty sure I have a handle on what’s going on. Fluxion sets the expected start time as an annotation, and sends that along to core. Core interprets time of now or earlier as “now.” Both of these are fine independently, but sched tries to avoid sending too many annotations because of some old issues with memory ballooning due to too many annotations….
garlick commented on issue flux-framework/flux-docs#317.
Great improvement!…
chu11 commented on issue flux-framework/flux-core#7528.
> Yes, that’s pretty much what I want. But, doesn’t flux batch require flux start to be called prior to make the resources available? How is it seeing the resources?…
cmoussa1 commented on issue flux-framework/flux-accounting#846.
Thanks @jameshcorbett!…
hppritcha commented on issue open-mpi/ompi#13713.
@devreal could you re-review this PR?…
jandrej commented on issue mfem/mfem#5296.
What part of the dolfinx assemble process are you timing? Can you please post the source including the regions and timings you get?…
jameshcorbett commented on issue flux-framework/flux-docs#315.
LGTM as well, so I hit the button….
wihobbs commented on issue flux-framework/flux-docs#310.
Thanks @garlick! I also added a link to the tracking issue for multi-cluster accounting, instead of just “needs design.” I’ll set MWP….
wihobbs commented on issue flux-framework/flux-core#7252.
Interestingly, flux-sched’s CI appears to be catching a legitimate error not caught by core:
…
cbritopacheco commented on issue cbritopacheco/rodin#226.
@copilot Revert back to commit 9871634…
jeremylt commented on issue CEED/libCEED#1950.
For sure. If we see a performance difference, then I think the way to go for ChipStar would be to make chipstar backends /gpu/hip/chipstar/shared and /gpu/hip/chipstar/gen that delegate back to the current shared/gen code and that code would check the resource string for the root /gpu/hip/chipstar to determine if it needs to do the padding elements…
hppritcha commented on issue spack/spack-packages#4163.
please address others’ comments and I’ll review….
balos1 commented on issue llnl/sundials#898.
> This is for version 7.6.0!…
artv3 commented on issue llnl/benchmarks#56.
Inconsistency between “non-RAJA variants” and “Base variants” as well…
mplegendre commented on issue llnl/Spindle#172.
Looks good. Thanks….
jameshcorbett commented on issue flux-framework/flux-accounting#845.
Nice!…
benzwick commented on issue SystoleOS/guix-systole#102.
Confirming this is resolved
tgamblin commented on issue spack/spack-packages#3962.
> @tgamblin is suggesting we move all Python-related packages to a separate py namespace such that py.ruff and ruff both work. Maybe we should hold off on the rename for now? …
milroy commented on issue flux-framework/flux-sched#1443.
I noticed similar behavior when implementing PR #1316. Here’s the commit where the interner storage is opened and closed (fixed the UB I was observing in the unit tests): https://github.com/flux-framework/flux-sched/pull/1316/changes/1c2a56c24262312eacf62dd8041ba1fe6e4b7f51#diff-d55e8cb6b34796f9929f4d3cd51b201e5bc6dea64e17ab617ded2c4af43b81d8R769-R770 …
tgamblin commented on issue spack/spack-packages#3200.
Closing this as we do not plan to implement it. We may make stage names configurable as in https://github.com/spack/spack-packages/pull/3200#issuecomment-3821996900, which would at least give affected people an easy out….
imguoguo commented on issue sipeed/picoclaw#2236.
gardner48 commented on issue llnl/sundials#900.
The last commit updates the level 2, 4, and 5 logging outputs to match the output on the Jenkins test machine. The Jenkins PR tests use logging level 3 and the release tests use logging level 2 (the default level), so outputs for levels 2, 4, and 5 were not updated in previous PRs and a difference in the level 2 output was causing one test to fail. …
cbritopacheco commented on issue cbritopacheco/rodin#217.
@copilot+claude-opus-4.6 Please proceed auditing, fixing, adding, implementing, correcting the batches you listed, updating the checklist….
JustinPrivitera commented on issue visit-dav/visit#20891.
I see, but this is only needed for containers? Or will we need this on LC?…
cyrush commented on issue visit-dav/visit#20903.
window is blank (as expected) for both standard and ospray mode, anari is the only mode we have an issue…
markcmiller86 commented on issue visit-dav/visit#20897.
@cyrush I think this is ready now….
gardner48 commented on issue sundials-codes/answers#72.
Re-targeting this PR to main for llnl/sundials#897…
v-dobrev commented on issue mfem/mfem#5246.
Re-merged in next for testing……
grondo commented on issue flux-framework/flux-sched#1444.
@mergifyio refresh…
trws commented on issue flux-framework/flux-sched#1443.
This means somewhere we have a top-level entrypoint that isn’t catching exceptions to avoid termination. That needs to be fixed….
grondo commented on issue flux-framework/flux-core#7501.
Thanks @trws and @wihobbs for your comments. After further inspection, there’s some outstanding ambiguities in how CLI plugin options and dest work that this implementation makes worse:
…
wihobbs commented on issue flux-framework/flux-core#7501.
Added to the scope of #6980…
trws commented on issue flux-framework/flux-core#7501.
Sounds good to me, @wihobbs would you create something?…
garlick commented on issue flux-framework/flux-core#7513.
Fixed a typo in the commit message and setting MWP, thanks….
jameshcorbett commented on issue flux-framework/flux-coral2#466.
Oh ok that’s very helpful actually. What’s happening is that Flux is trying to watch the storages resource in K8s for updates about rabbit status. It asks k8s to only see recent changes, where “recent” is defined by passing in an identifier string grabbed from one of the storages resources. However, kubernetes is rejecting the string as being too old–I guess there is a storage resource on elcap somewhere that hasn’t been updated in a long time. As a fallback, with Kubernetes rejecting the watch request, Flux asks to get the current status of every single rabbit on the system. That takes a long time to process. Then Flux tries to watch changes to the storages resources again with a new identifier string (and hopefully a more recent one that kubernetes will accept). But no–for whatever reason, the identifier string is rejected once more, and the cycle begins again. In effect, Flux asks to get the current status of every single rabbit on the system every five seconds. This generates a ton of traffic and log messages….
cmoussa1 commented on issue flux-framework/flux-coral2#467.
What about raising a job exception on those rabbit jobs with this descriptive error message? I am not sure if that is any better from the user or admin’s perspective if the job has an exception raised on it, but would that prevent them from having to a) kill the jobs manually, or b) restart a Flux instance entirely? And instead you could just reload the plugin after all of the rabbit jobs have finished cleaning up?
cmoussa1 commented on issue flux-framework/flux-accounting#840.
Thanks for giving this a look @grondo! I just force-pushed up a couple fixes based on your suggestions above. I also added a new set of tests to check that with two queues a job held in queue A due to a max SCHED limit is not released when a job in B transitions to RUN state. I went ahead and appended that set of tests to the sharness test file….
jeremylt commented on issue CEED/libCEED#1830.
I would recommend this order, personally…
vladotomov commented on issue CEED/Laghos#209.
@amroakmal this looks good, thank you….
emily-howell commented on issue Alpine-DAV/ascent#1663.
@cyrush I went through and addressed all of your feedback. on all three branches. I tried to keep things still relatively with the original changes to keep things less noisy. I did update the documentation in #1682 to reflect the changes that I made so that might be a good place to start reviewing from….
jeremylt commented on issue openjournals/joss-reviews#10237.
Unfortunately, I am not available until August…
adrienbernede commented on issue llnl/RAJAPerf#529.
Replaced by #638 …
trws commented on issue llnl/RAJA#2009.
As a stylistic note, we do this in OpenMP with single if the other threads should wait, or with masked or the deprecated master if they shouldn’t, while once is used by C++, C, and posix to mean “run exactly one time, no matter how many threads encounter this, and block all encountering threads until that one run is done”.
…
artv3 commented on issue llnl/RAJA#1917.
@llnl/raja-core this may need another review. …
adrienbernede commented on issue llnl/RAJA#1999.
@rhornung67 this should really be merged: it will update the toolchains and reduce spack concretization times….
milroy commented on issue flux-framework/flux-sched#1432.
@jameshcorbett the final issue to address is the question of the scope of the change of token to sequence_number (i.e., everywhere in the code, just the readers, or postpone the renaming). Once we settle that I’ll approve the PR….
vsoch commented on issue flux-framework/flux-docs#313.
https://github.com/jbms/sphinx-immaterial/issues/485…
chu11 commented on issue flux-framework/flux-core#7493.
thanks, will set MWP…
alecbcs commented on issue spack/spack-packages#4060.
I originally stayed away from using urls because a package cannot have both url and urls properties and there are some r-* packages that set a url, however since we gate populating the urls on the cran class attribute I think a package setting both a cran identifier and a custom url is reasonably expected to fail….
tgamblin commented on issue spack/spack#52167.
If this is going to be essentially the same as spack compiler find, should we document that clearly? Is spack compiler find a convenient alias for this, or is this an alias for spack compiler find? I think probably spack compiler find should be documented to say it’s an alias for this….
jedbrown commented on issue openjournals/joss-reviews#9333.
@editorialbot generate pdf…
hppritcha commented on issue open-mpi/ompi#13801.
Thanks for the heads up. I don’t think any of our test systems have such a new version of pbspro. In fact, only system I have access to that runs pbs (aurora) runs a very old version of that software. looks like …
tzanio commented on issue mfem/mfem#5291.
ping: @stefanozampini …
BradWhitlock commented on issue llnl/axom#1836.
Closing this PR as it was only for reviews….
milroy commented on issue flux-framework/flux-core#7439.
Thanks for the feedback! Setting MWP….
vsoch commented on issue vsoch/pipelib#13.
@matthiask thank you for this PR! I have a few deadlines into April but I’ll have time to look after that….
garlick commented on issue flux-framework/flux-core#7494.
Reproduced:…
markcmiller86 commented on issue visit-dav/visit#20892.
Ok, I built noise.C on current develop against Silo 4.12 and Silo 4.10.3 and then ran both versions of noise creating PDB files….
cyrush commented on issue visit-dav/visit#20892.
I think maybe its an issue with looping over the dims…
imguoguo commented on issue sipeed/picoclaw_docs#18.
LGTM…
v-dobrev commented on issue mfem/mfem#4917.
Merged in next for testing……
alecbcs commented on issue spack/spack#52144.
> I think putting new commands we just happen to want in CI under spack ci is not really the path forward. This is going to operate on mirrors, considering the state of a repo. Neither of those things has anything to do with “ci” which is really just “build farm scheduling”. …
cjvogl commented on issue mfem/mfem#5270.
I just ran the code and everything is looking good! All that is left is to address the last syntax concerns noted above….
artv3 commented on issue mfem/mfem#5124.
Any comparisons with MFEM’s AMGX backend? https://github.com/mfem/mfem/blob/master/examples/amgx/ex1p.cpp Super cool! …
mplegendre commented on issue llnl/Spindle#148.
I went over the /bin/.. case in detail, and it looks like we handle it okay. There’s definitely some oddities with spindle putting “..” into an internal variable named ‘file’. But we ultimately always supported spindle operations on directories (even if that wasn’t common), and “..” just gets treated like other directories and handled correctly. …
markcmiller86 commented on issue llnl/Silo#527.
@biagas this is how I’d like to proceed with Silo. That said, if you feel better about your original patches for bv_silo.sh because you have tested those changes in multiple places, then I am ok with keeping your bv_silo.sh logic as is….
garlick commented on issue flux-framework/rfc#505.
Eh this was prematurely posted - sorry. Closing for now….
jameshcorbett commented on issue flux-framework/flux-sched#1432.
Aside from 229e25d, there are no code changes from @milroy ‘s last review. However, I did add some new tests in the last commit. The tests fail because the agfilter output is incorrect for cores: it considers fewer cores to be allocated than are in fact allocated. This discrepancy appears to have something to do with the match format and the way it skips vertices, because if the test is re-run with rv1 match format instead of rv1_shorthand, or if the job is modified to only request nodes non-exclusively, the agfilter checks pass. …
sam-maloney commented on issue flux-framework/flux-sched#1384.
I’m going to jump on this thread to add that I’ve also been getting some timeouts recently on one of my builds. In particular, t1028 was consistently timing out, and t2317 did once. As soon as I removed the timeout threshold t1028 passed consistently….
grondo commented on issue flux-framework/flux-core#7495.
I’d just add a note in the documentation. Something like…
wihobbs commented on issue flux-framework/flux-core#7495.
I guess an edge case might be “what if the hostfile for the taskmap specifies fewer hosts than the -N request?” which is currently allowed….
jameshcorbett commented on issue flux-framework/flux-coral2#463.
Similar to your PR this also needs a manual merge @cmoussa1 …
cmoussa1 commented on issue flux-framework/flux-accounting#836.
Thanks @jameshcorbett! Setting MWP here…
hppritcha commented on issue open-mpi/ompi#13790.
okay this is curious. The “problem” seems to be in the ompi error checking functions in cases where the send/recv count value is 0. This is not really a fortran interface problem….
tzanio commented on issue mfem/mfem#5265.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
cyrush commented on issue llnl/blt#758.
Sounds like: https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD_REQUIRED.html#prop_tgt:CXX_STANDARD_REQUIRED…
trws commented on issue flux-framework/flux-sched#1438.
You could write a catch2 test that literally calls the function. That’s probably what I would do actually, there’s no reason to make it an integration test….
chu11 commented on issue flux-framework/flux-core#7136.
was chatting with @watson6282 about general “how to know about a certain failure” was brought up. I recalled this issue….
cbritopacheco commented on issue cbritopacheco/rodin#204.
@copilot+claude-opus-4.6 Please now implement the generic src/Rodin/Solid/Linear/LinearElasticityIntegral.h for any FES. Take a look into the P1 specialization for LinearElasticityIntegral and H1 QuadratureRule implementations for the general idea….
jedbrown commented on issue CEED/libCEED#1808.
In the makefile, we figure that discerning users should set OPT themselves. Our default is roughly like CMake’s RelWithDebInfo, though I think that uses -O2 by default. I would not be opposed to switching to making the default -O2 (it’s basically a tradeoff of debug sensibility, but you likely still want more aggressive (e.g., associative math) for production runs. (The significance of such flags depends on how the user’s qfunctions are written; the library parts of libceed are not so sensitive.)…
jeremylt commented on issue openjournals/joss-reviews#9153.
Realistically, I’m probably jammed up until August, unfortunately…
balos1 commented on issue llnl/sundials#809.
> I think that might be ok (as long at the results are not radially different). The runner images are not updated frequently, so this would be a way of moving to newer versions as the “latest” runner is updated. …
JustinPrivitera commented on issue llnl/conduit#1362.
extrapolating from this limited data:…
jedbrown commented on issue RDycore/RDycore#381.
Spelunking the history: …
jeremylt commented on issue CEED/libCEED#1808.
Ok, I think I’m following now….
trws commented on issue spack/spack-packages#3962.
I’m generally supportive of the change, but is there a mechanism we can use to make this easier on users? If the ruff and ty builds work the same as the py- versions for all practical purposes, can we keep the py- names as aliases for example?…
tgamblin commented on issue spack/spack#52061.
> it’s simpler to have fewer exceptions to the rule. …
alecbcs commented on issue spack/spack-packages#3906.
It looks like version.satisfies() doesn’t operate like I’d hoped. I’ve asked @LinaMuryanto to revert the previous two commits for now and I’ll work on making an issues / fix upstream to make this better for future PRs….
tgamblin commented on issue spack/spack-packages#3945.
Looks like py-kornia-rs and friends are building now and CI is fixed….
cbritopacheco commented on issue cbritopacheco/rodin#201.
@copilot+claude-opus-4.6 I have made some fundamental changes to polytope iteration in the library. Namely, I have changed that MPI Mesh polytope iterators return with the MPI Mesh reference, as opposed to before that they returned the shard’s reference. This has a lot of implications in the library. The first one is that XDMF somehow encounters this exception. Please fix it and find other places in the library which should be modified. …
alecbcs commented on issue spack/spack-packages#3931.
Should this package also depend on openjpeg itself?…
tgamblin commented on issue spack/spack#51931.
@johnwparent take a look at the simplifications here, particularly around locking vs. atomic move….
vsoch commented on issue kubeflow/trainer#3325.
@andreyvelich this is ready for review and eventual merge - apologies for my confusing posts! I was testing locally with the wrong container image (I had updated it back to kubeflow for the PR here, and needed to use my custom build). …
garlick commented on issue flux-framework/flux-core#4306.
That is almost exactly what was kicking around in my brain. I was internally calling them “vqueues” but external sounds good too….
vsoch commented on issue flux-framework/flux-core#7217.
Go home, codecov, you’re drunk….
vsoch commented on issue flux-framework/Tutorials#57.
This came out great! Since our HPSF tutorial was shorter than anticipated, I recorded the entire thing (AWS, cpu with EFA and GPU) today with a short (2.5 minute) introduction to Flux. It is edited and ready to go, and will be released with the Kubeflow blog announcement….
benzwick commented on issue benzwick/SlicerAdaptiveBrush#4.
Hi @Thanhhuynh9 I tested this on my MacBook and it seems to work now. I will close this issue but please reopen it if you still have problems with installing this extension….
garlick commented on issue pmodels/mpich#7751.
BTW our two projects are in the Linux Foundation together now. IMHO we should try hard to make Flux and MPICH work great together!…
tzanio commented on issue mfem/mfem#5269.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
gardner48 commented on issue llnl/sundials#880.
@mottelet was this a duplicate of #753? …
chu11 commented on issue flux-framework/flux-core#7448.
> If there are multiple suggestions they should be deduplicated. I’m not sure this will happen in practice, flux-python is installed to /usr/bin so won’t appear as a discovered command in a normal installation….
trws commented on issue flux-framework/flux-core#7451.
I just finally got time to actually read this over. This is a massively more complicated scheduler setup than I expected from the “toy” designation. It’s a very nice addition, especially as a way to let people experiment with new custom schedulers. I’m a bit tempted to make a few adjustments to this to make it work more the way qmanager does from a progress and behavior perspective, it might actually not be all that much of a lift to replace qmanager with a reworked version of the backfill class here. We’d have to do some performance tests and similar, but I’m sorely tempted to give it a shot, especially given some of the features we’ve been discussing for that recently the flexibility would be nice, and it isn’t a compute-bound service either. Do you think we could find some time to chat over this next week @garlick? …
jeremylt commented on issue CEED/libCEED#1944.
Ok, I have largely fixed the worst oddities, I think…
cyrush commented on issue Alpine-DAV/ascent#1669.
@aroccaPrediqtt …
JustinPrivitera commented on issue Alpine-DAV/ascent#1675.
I wrote a converter from polyhedral mixed to mixed (?) in VisIt; perhaps that would be of use here?…
emily-howell commented on issue Alpine-DAV/ascent#1494.
I am having trouble reproducing this bug. There is already a test (https://github.com/Alpine-DAV/ascent/blob/74d78e80f839eb1cace5a48e85aed2696729f584/src/tests/ascent/t_ascent_triggers.cpp#L488) that generally reproduces this .yaml and is passing. Even after modifying it to be an exact match to this .yaml example I was unable to reproduce the bug….
markcmiller86 commented on issue visit-dav/visit#20860.
@JustinPrivitera and @visit-dav/visit-core-team I have now tried to handle hyphenations. …
v-dobrev commented on issue spack/spack-packages#1469.
It looks like CI now requires SHA256 checksum for packages – should be an easy fix. …
adrienbernede commented on issue llnl/radiuss-spack-configs#162.
Interesting issue. So, if I understand correctly, the concretization issue comes from us enforcing a compiler dependency on a package that has none. But when removing the compiler, we lack a constraint to enforce coherency between the compiler / software stack version and the external package version… …
adayton1 commented on issue hypre-space/hypre#1490.
We’ll give it a try!…
jeremylt commented on issue 4C-multiphysics/4C#1870.
Ah, that makes sense. I’d then personally try to create a way to bypass those safeguards and guard that header with warnings…
artv3 commented on issue llnl/RAJAPerf-Benchmark#4.
Looks good to me! …
adrienbernede commented on issue spack/spack-packages#3804.
Changes look good to me. Concretization and build tested internally here: …
trws commented on issue flux-framework/flux-accounting#793.
There are a few more considerations here that hit a couple of different use-cases….
grondo commented on issue flux-framework/flux-core#7453.
> The flux start –test-conf idea is a good one on its own IMHO although certainly scoped wider than the immediate need here and may get a bit tricky in combination with other options and environment variables, whereas flux alloc is a bit more constrained….
adrienbernede commented on issue llnl/radiuss-shared-ci#73.
> You might check if you can build locally– I see a couple of minor formatting issues if I do sphinx-autobuild docs/sphinx docs/_build/html
…
BradWhitlock commented on issue llnl/axom#1780.
I finally ran into the problem that Brian reported when I could not make Bump and MIR use a custom allocator for a memory pool. I am adopting Brian’s approach….
garlick commented on issue flux-framework/flux-core#7453.
Although, on broker attributes, we could do something like add modprobe.* or module.* to the broker attribute list and adopt that as a standard way of selecting alternatives. Less bad that having to add a new one for every new alternative….
cbritopacheco commented on issue cbritopacheco/rodin#188.
@copilot+gpt-5.3-codex I have re-organized the structure. I would like you to: …
cyrush commented on issue visit-dav/visit#20857.
Note: LC may remove the broken PySide2 module from their python 3.13 install….
jeremylt commented on issue openjournals/joss-reviews#9153.
This looks interesting and I’m happy to review, but it may take me a bit longer than usual, as I’m about to do a big move. If the timeline is shorter then I’m likely not the best option….
tzanio commented on issue mfem/mfem#5252.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
adrienbernede commented on issue llnl/Umpire#1056.
@davidbeckingsale This is ready!…
adrienbernede commented on issue llnl/RAJA#1999.
@rhornung67 This is ready!…
adrienbernede commented on issue llnl/Caliper#727.
@daboehme This is ready!…
adrienbernede commented on issue llnl/CHAI#360.
@adayton1 This is ready!…
jameshcorbett commented on issue flux-framework/flux-accounting#826.
I’ll hit the button since Mergify won’t auto-merge this (as @grondo noted here https://github.com/flux-framework/flux-coral2/pull/456)…
jeremylt commented on issue CEED/libCEED#1940.
Still getting some artifacts like this misbehavior: …
markcmiller86 commented on issue visit-dav/visit#20856.
I can take a look at that this evening. I am going to be at my father’s …
becker33 commented on issue spack/spack#52059.
Added #52067 for clarity…
gardner48 commented on issue llnl/sundials#875.
Addresses llnl/sundials-private#146…
adrienbernede commented on issue llnl/RAJAPerf#651.
@rhornung67 This fix is ready….
adrienbernede commented on issue llnl/CARE#358.
@adayton1 you may merge this PR ;)…
chu11 commented on issue flux-framework/flux-core#7442.
> Hm, I wonder if a more useful thing here would be to add a –wait option to flux-update that optionally waits for the update to hit the job eventlog before exiting. This would be useful in testing and perhaps in cases where a user wants to wait until an update has taken effect before proceeding….
cyrush commented on issue Alpine-DAV/ascent#1508.
Moving to 0.10.0, workaround is to define -DCMAKE_CUDA_HOST_COMPILER….
dylan-copeland commented on issue mfem/mfem#5260.
Hi Nuno, thank you for your investigation into this issue. We have the miniapp mfem/miniapps/meshing/phpref.cpp which simply demonstrates the capability of h- and p-refinement in parallel, with random selection of refinements and no use of estimators. As far as I know, estimators have not been developed for use in hp-refinement. The limitations you described for estimators after p-refinement make sense to me, and I agree that more work is needed. I think it would be a useful contribution if you would like to work on this, and I don’t think it would conflict with any existing work. Starting with H1/L2 should be sufficient….
artv3 commented on issue llnl/RAJA#1970.
@johnbowen42 we usually delete the branch after merge…
bhatele commented on issue hpcgroup/pssg-plots#21.
this branch needs to be rebased…
balos1 commented on issue spack/spack-packages#3768.
@spackbot fix style…
tgamblin commented on issue spack/spack#49673.
This came up on the call with @scheibelp w.r.t. https://github.com/llnl/benchpark/pull/1266. It would need at least a couple updates for post-1.0: …
btalamini commented on issue llnl/smith#1518.
Pinging @white238 , @ebchin, @lihanyu97 . Any outstanding concerns?…
markcmiller86 commented on issue visit-dav/visit#20852.
So, I fiddled around a bit to figure out how to do this the “right” way in Sphinx and on RTD. …
v-dobrev commented on issue mfem/mfem#4964.
Note: we’ve decided to proceed with the review of PR #5137 which (if approved) will supersede this PR. …
gardner48 commented on issue llnl/sundials#868.
This PR extracts some of the changes from #837 to consistently prefix CMake options with SUNDIALS_…
cyrush commented on issue llnl/conduit#1536.
Looks good, thanks for adding this! …
markcmiller86 commented on issue llnl/H5Z-ZFP#162.
Thanks so much @brtnfld. I am fine with you merging this. I am on my cell phone at the moment…
grondo commented on issue flux-framework/flux-core#7428.
Thanks! I’ll set MWP and plan to tag a patch release after this….
garlick commented on issue flux-framework/flux-core#7426.
Oh, sorry I missed that on the review too….
wihobbs commented on issue flux-framework/flux-core#7426.
That was just something I tried to see if getting rid of the SLURM_ environment variables would fool it into turning off the expiration watcher (it didn’t). I had the same issue without that flag on there (Edit: I think. I’m not at my computer right now.) (And I’m not sure --export=NONE actually gets rid of those variables anyway
vsoch commented on issue dask/dask-jobqueue#700.
I’m headed to bed, but a quick question I have is how memory is being specified here? Flux does not have any flags for controlling / requesting memory….
trws commented on issue spack/spack-packages#3676.
I should have thought to put all of these in here to begin with, and am all for it….
trws commented on issue llnl/camp#195.
If std::array from both libc++ and libstdc++ work in device code I would be fine with that, but last I knew neither of them did. Has that changed?…
adrienbernede commented on issue llnl/RAJA#1999.
@rhornung67 would you like to test both …
garlick commented on issue flux-framework/rfc#452.
One other point: @trws’s idea of using JSONL to break up R into separate KVS keys might be…
chu11 commented on issue flux-framework/flux-core#7403.
re-pushed, now up to 3 similar commands will be output. …
garlick commented on issue flux-framework/flux-coral2#455.
Fixed that and will set MWP - thanks!…
wihobbs commented on issue flux-framework/flux-accounting#823.
Cool. We should let the sysadmins know to ignore that message in flux dmesg though, because it shows up about once per hour….
cmoussa1 commented on issue flux-framework/flux-accounting#823.
As far as I know, this isn’t preventing job submissions from regular users, and the instance owner data will still have its max_sched_jobs property in the jobtap plugin initialized to INT16_MAX, so I think it should be okay to hold off until the next regular release….
jeremylt commented on issue CEED/libCEED#1935.
We should probably update the noether-asan job in .gitlab-ci.yml to be more aggressive about warnings…
adayton1 commented on issue llnl/camp#194.
I’m actually wondering if we should remove camp::array since we should be able to use std::array in device code now that we require c++17 (almost everything in std::array is constexpr in c++17, and everything is constexpr in c++20). With nvcc you have to supply the --expt-relaxed-constexpr flag, which will make all constexpr function __host__ __device__, but with amdclang, constexpr automatically implies __host__ __device__….
artv3 commented on issue llnl/RAJAPerf#628.
@MrBurmark I pushed up style changes based on your review, do you have time to take a look?…
adayton1 commented on issue llnl/RAJA#1999.
I was under the impression that codes should be using rocm 6.4.2 or 6.4.3 with cray-mpich 8.1.33 or 9.0.1 in production and that LC wants us to start testing out rocm 7.2.0 with cray-mpich 9.1.0 to determine if there are any problems. So I think both combinations are important (6.4.3 + 9.0.1 and 7.2.0 + 9.1.0). …
jameshcorbett commented on issue flux-framework/flux-coral2#452.
> I should test this first, but I think a way this could work is to keep the rabbits disjoint from any queue. Then a jobtap or frobnicator plugin could add the equivalent of or rabbit to the constraint object after the queue constraint has been applied. Since the full constraint would then be ((user constraint) and (queue constraint)) or rabbit, the scheduler should be able to select resources from the typical queue+user constraint plus any rabbits….
benzwick commented on issue SystoleOS/guix-systole#102.
Thanks @RafaelPalomar and thanks @DavinhDang for testing this….
vladotomov commented on issue CEED/Laghos#208.
@amroakmal @rfhaque I’m not sure what’s the purpose here, but keep in mind that the code in /serial has not been kept in sync with the top directory for a long time. How are you using this and do you expect it to behave the same way as the baseline parallel Laghos?…
alecbcs commented on issue spack/spack-packages#1257.
@LinaMuryanto as a temporary work around to the failing build I was able to fix my build with ~python since I wasn’t interested with the python bindings…
brendankeith commented on issue mfem/web#305.
> These are awesome, thank you so much!
v-dobrev commented on issue mfem/mfem#5255.
Merged in next for testing……
benzwick commented on issue benzwick/StreamVorti#13.
See #15 …
cbritopacheco commented on issue cbritopacheco/rodin#176.
@copilot+gpt-5.3-codex Check for correct dimensions usage in the PETSc versions too (i.e. rows and cols)….
markcmiller86 commented on issue visit-dav/visit#20752.
The boxlib failure appears to be repeatable and has to do with switching between 2D and 3D data. …
tgamblin commented on issue spack/spack#51982.
On first look at ErrorFormatter, I don’t like this. There are now two places where an error message must be maintained, which can easily go out of sync.
…
cyrush commented on issue visit-dav/visit#20752.
For the blueprint mfem element fields those many not be deterministic across platforms. I will take a look….
adrienbernede commented on issue llnl/RAJAPerf#642.
@rhornung67 This is ready….
adrienbernede commented on issue llnl/RAJA#1989.
@rhornung67 This is ready….
grondo commented on issue flux-framework/flux-sched#1433.
Hm, it should. Note that ./configure is just a wrapper for cmake in this project….
grondo commented on issue flux-framework/flux-core#7410.
Oh, and one other trivial testsuite fix thrown in….
tzanio commented on issue mfem/mfem#5253.
Merged in next for testing……
cjvogl commented on issue mfem/mfem#5126.
> We should also update the website to mention GSLIB and that we do support GPU builds now. …
adayton1 commented on issue llnl/CHAI#359.
> @adayton1 I don’t see the open-source release info anywhere. Was that ever done for CHAI? For example, https://github.com/llnl/RAJA/blob/develop/COPYRIGHT#L6 …
jeremylt commented on issue CEED/libCEED#1933.
Here is a summary of different open source policies that @jedbrown found: https://blog.probabl.ai/maintaining-open-source-age-of-gen-ai…
becker33 commented on issue spack/spack-packages#3505.
Additional things I’ve learned:…
hppritcha commented on issue open-mpi/ompi#13747.
could we get this cherry picked back to 6.0.x?…
adrienbernede commented on issue llnl/Umpire#1053.
@davidbeckingsale this is ready for merge….
adrienbernede commented on issue llnl/Caliper#687.
Merged as part of #712 …
adrienbernede commented on issue llnl/CHAI#356.
@adayton1 You may ignore the remaining failure status merge: it
cmoussa1 commented on issue flux-framework/flux-core#7408.
Done! Thanks @chu11 …
chu11 commented on issue flux-framework/flux-core#7408.
As an aside, if this typo was missed by the typo checker, you can submit it to https://github.com/crate-ci/typos/issues/1488. …
grondo commented on issue flux-framework/flux-coral2#452.
One other point is that the scheme above won’t apply for a subinstance launched with some brokers on rabbits. The rabbit property will be preserved, but the default queue in the instance will happily run stuff on the rabbits by default. Users will have to be aware that they need to run normal jobs using --requires=-rabbit, or we can look into ways automatically set up queues, exclude rabbits by default, or whatever makes the most sense for the probable use cases….
gardner48 commented on issue erf-model/ERF#2921.
@adamwise95 if you want this case to run with make test i.e., as part of the GitHub and GitLab testing. This file will need to go in a subdirectory of Tests/test_files and you’ll need to add a add_test_r() line for this case in Tests/CTestList.cmake. …
cmoussa1 commented on issue crate-ci/typos#1488.
```…
cbritopacheco commented on issue cbritopacheco/rodin#173.
@copilot Here is the problem summary. …
benzwick commented on issue SystoleOS/guix-systole#102.
It fails on my laptop as well:…
balos1 commented on issue AMReX-Codes/amrex#5042.
I don’t think that this is a problem. Initialize is only meant to be called once. Right now it is called in amrex::Initialize which, I thought, could only be called once. So, I believe, the case Codex is worried about will never happen. …
gardner48 commented on issue AMReX-Codes/amrex#5044.
I this change is correct, but I noticed a couple other calls that need to be fixed in the implicit MRI case. I’ll open a PR for this change and the others in a sec….
hppritcha commented on issue openpmix/openpmix#3821.
i’d ignore the mpi4py failure….
hppritcha commented on issue mpi4py/mpi4py#733.
this PR broke our open mpi github action: …
jeremylt commented on issue mfem/mfem#5247.
Hmm, interesting. This is not a flag passed directly to libCEED, so I’m not sure exactly how MFEM processes this command line option….
mplegendre commented on issue llnl/Spindle#140.
I’ve no objections to the code changes. But do you have needs for spindle on either ppc64le or aarch64? …
artv3 commented on issue llnl/RAJA#1970.
Can we add some testing and examples? Documentation would also be nice…
bhatele commented on issue hpcgroup/pssg-plots#14.
> _ No description provided. _ …
v-dobrev commented on issue mfem/mfem#5195.
Ok, thanks @dylan-copeland. I see your point about DecodeDof, so let’s keep it as it is….
dylan-copeland commented on issue mfem/mfem#5195.
@v-dobrev commit afded067a74594bb71520832ae5024f1556cbd75 replaces absdof. Thanks for pointing this out. In fespace, DecodeDof is more complicated, as it has a version returning a sign. This commit uses UnsignIndex for the implementation of the basic DecodeDof, but I am keeping DecodeDof in fespace as is. An alternative would be to add another version UnsignIndex(int i, real_t& sign) to replace DecodeDof, but I don’t see a need for that in general, outside FiniteElementSpace….
garlick commented on issue flux-framework/flux-pmix#122.
Thanks, by chance do you know of any test code we could pull in to CI to measure success if we fix this?…
camierjs commented on issue CEED/Laghos#170.
Closing this issue as all tests are passing with MFEM, HYPRE, Laghos masters on GPU. …
wihobbs commented on issue flux-framework/flux-core#7244.
Ok @grondo, at long last this is ready for a real human to review it. :) …
brendankeith commented on issue mfem/web#305.
@mlstowell please let me know if I’ve addressed your comments, or if you have any new ones :)…
tzanio commented on issue mfem/mfem#5212.
ping: @mlstowell …
markcmiller86 commented on issue llnl/H5Z-ZFP#159.
> I believe it’s also time to eliminate the make option, as the CMake implementation is now quite mature and continues to improve….
milroy commented on issue flux-framework/flux-sched#1408.
> Once this is merged, you should be able to test using cpu-affinity=dry-run and FLUX_HWLOC_XMLFILE of another system without errors by also setting FLUX_HWLOC_XMLFILE_NOT_THISSYSTEM in the environment of flux start. i.e. before you call test_under_flux. …
garlick commented on issue flux-framework/flux-core#7403.
Oh I see you Claude added
…
cbritopacheco commented on issue cbritopacheco/rodin#173.
@copilot I have tidied up the approach and switched to a more robust scheme. However, the noSplit feature seems to not be taken into effect. Please check for errors and fix….
benzwick commented on issue swig/swig#3337.
@wsfulton I’ve pushed a branch pull-3337-bz based on your pull-3337 with the test tweaked to reproduce the issue….
cyrush commented on issue llnl/blt#755.
I think current fix is needed, and we can improve more in the future. …
BradWhitlock commented on issue llnl/axom#1790.
I fixed this specific warning in PR #1796 ….
vsoch commented on issue kubeflow/mpi-operator#12.
Thanks @garlick! …
grondo commented on issue flux-framework/flux-sched#1408.
@milroy See https://github.com/flux-framework/flux-core/pull/7402. …
chu11 commented on issue flux-framework/flux-core#7399.
lol, it’s so obvious in hindsight. Just got settled on a goal and that was it :-)…
grondo commented on issue flux-framework/flux-core#7402.
Thanks! I’ll set MWP….
jameshcorbett commented on issue flux-framework/flux-coral2#452.
> > maybe we should revert to a config on hetchy that places the rabbits in a separate queue so we can work through the fallout with configuration and prolog/epilog/housekeeping scripts in parallel with gathering more detailed requirements?…
garlick commented on issue flux-framework/flux-coral2#452.
That seems like a sensible approach and your view of the rabbits sounds right to me….
jeremylt commented on issue CEED/libCEED#1931.
I’m pondering. I want to make sure we are not violating any implicit assumptions for the user …
trws commented on issue spack/spack-packages#3453.
Ah cool, I missed it when I scanned back over the package, LGTM then. :+1:…
becker33 commented on issue spack/spack#51960.
I think this change is going to make adding the per-package locking for the new installer very difficult. I think you’re going to need access to the overwrite information when you approach the install for each package, because an intervening process may have installed it between when you constructed the BuildGraph and when the build gets to that install. I think each call to worker_function needs to know whether it is an overwrite build and what time it was labelled as an overwrite build, so that it can accept if another process already overwrote in the meantime….
hppritcha commented on issue open-mpi/ompi#13734.
ompi_rte_init is only called within ompi_mpi_instance_init which can in principle be invoked via multiple threads concurrently since MPI_Session_init (correctly recalled by @rch54) can be called by individual threads. totally different from MPI_Init/MPI_INit_thread and one of the reasons for its presence in the standard.
…
garlick commented on issue kubeflow/mpi-operator#12.
Ralph is correct that pmix support in flux is minimim viable, but we do run some mpi regression tests in CI like OSU benchmarks, so the stuff most people use should work fine….
wihobbs commented on issue flux-framework/rfc#494.
Thanks! setting MWP…
garlick commented on issue flux-framework/rfc#493.
OK, how’s this look?…
garlick commented on issue flux-framework/flux-foundry#24.
Thanks, I’ll just press the button since we don’t have mergify set up….
cmoussa1 commented on issue flux-framework/flux-accounting#818.
I’m still seeing some unexpected and random errors from the coverage builder during the create_db() call. I wonder if it has anything to do with the syntax of creating the DB itself. The sqlite3 documentation examples use = instead of : in their .connect() call, and I wonder if this syntax error might be causing the creation of the database to not be opened with a read-write connection. Maybe this is only being caught by CI every now and then. I’m going to add another commit to change this .connect() call and see if that resolves it….
alecbcs commented on issue spack/spack-packages#3453.
No matter the targets given in the variant, the package always additionally adds the host architecture. I believe this was originally done for targets=none still building a valid installation on a users system, but it works nicely for this case too where we provide minimal cross compilation support with few architectures….
alecbcs commented on issue spack/spack#51813.
@alalazo what version of git do you have locally installed?…
hppritcha commented on issue openpmix/prrte#2407.
I like doing things in stages. So RAS component comes first. …
v-dobrev commented on issue mfem/mfem#5222.
Re-merged in next for testing……
imguoguo commented on issue sipeed/picoclaw#281.
Thank you for your PR! I’m very sorry, but another PR (#259) has already solved the same issue. …
tgamblin commented on issue spack/spack-packages#2947.
I believe this builds on spack/spack#51817, but note that it was reverted in spack/spack#51943 due to windows CI issues….
tgamblin commented on issue spack/spack#51943.
If rebuild-index passes on windows CI this should be good to merge….
markcmiller86 commented on issue llnl/Silo#243.
@brtnfld and @eschnett I just recently ran into this same issue @brtnfld reports in the above comment in Silo 4.12.0. I have a patch for it too. The PR for that patch includes some other items and will be merged soon….
brendankeith commented on issue mfem/web#305.
Thanks for your comments, @mlstowell and @acfisher! …
hppritcha commented on issue flux-framework/flux-core#7380.
Ah great! I will Check this Option out….
vsoch commented on issue rootless-containers/usernetes#385.
@AkihiroSuda for your subuidless project it looks like you’ve done:…
vsoch commented on issue oras-project/oras-py#233.
Just updated the tag. It points to the commit right after the one you referenced, because there was a tributors update….
v-dobrev commented on issue mfem/mfem#5222.
Merged in next for testing……
camierjs commented on issue GLVis/glvis#106.
This issue should be resolved by the changes in PR #339, which adds support for displaying DOF numberings….
tgamblin commented on issue spack/spack-packages#3404.
> Should we also deprecate versions from e.g. 2020 and before (that would leave 2 versions non -deprecated)? …
acfisher commented on issue mfem/web#305.
> @mlstowell and @acfisher, I’d really like to use these annotated examples as a resource for my class. …
tzanio commented on issue mfem/mfem#5234.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
adayton1 commented on issue llnl/radiuss-shared-ci#71.
Is it worth considering “LLNL_RSCI_” as a prefix? “RSCI_” seems unlikely to conflict, but if it does happen it would be really hard to track down….
adrienbernede commented on issue llnl/radiuss-shared-ci#71.
@tdrwenski I would prefer the prefix to be “RSCI_” rather than “RSC_” because I use “RSC” all the time to refer to radiuss-spack-configs……
cyrush commented on issue llnl/conduit#1495.
Trying a few more combos of env vars to allow openmpi to oversubscribe - that is launch more MPI ranks than procs available. …
jeremylt commented on issue jeremylt/LFAToolkit.jl#94.
Ok, up the priority here for Colorado Conference…
grondo commented on issue flux-framework/flux-core#7376.
I tried to reproduce this by preloading a uname() implementation that returns a zero-length hostname, but got a different failure:…
garlick commented on issue flux-framework/flux-core#7380.
> I am more interested in technical feedback like use of the idset api etc and not philosophical questions about why open MPI developers like me would not want prrte to be easy to use for our user community….
hppritcha commented on issue flux-framework/flux-core#7380.
No if there’s a flux RAS there’s no need for hostfiles…
cmoussa1 commented on issue flux-framework/flux-accounting#816.
Thanks @jameshcorbett! Setting MWP here…
cyrush commented on issue HDFGroup/hdf5#6171.
@jhendersonHDF when we create config.mk files, we use CMAKE_THREAD_LIBS_INIT instead of the CMake target….
tzanio commented on issue GLVis/glvis#364.
The default antialiasing is different now, so some differences in the baselines are expected…
vsoch commented on issue pydicom/deid#301.
Yes, that sounds reasonable. If you’d like to open a pull request that makes it optional (enabled by default) I’d be happy to review it….
jeremylt commented on issue openjournals/joss-reviews#8388.
Thanks all. I’m proud of this work from our team, and the review process definitely made it a better codebase!…
hppritcha commented on issue hppritcha/prrte#97.
okay I see some good enough examples for idsets. i’ll see about switching to using this API….
garlick commented on issue flux-framework/rfc#493.
How about this then? …
brendankeith commented on issue mfem/web#305.
@mlstowell and @acfisher, I’d really like to use these annotated examples as a resource for my class. …
mplegendre commented on issue llnl/Spindle#125.
Is this ready to merge now?…
garlick commented on issue hppritcha/prrte#97.
There’s an idset API that may be useful - see idset_create(3)…
cmoussa1 commented on issue flux-framework/flux-coral2#451.
Thanks for opening this @jameshcorbett. For what it’s worth, tracking job usage with rabbits has been fairly straightforward so far. I’ll go ahead and list the different ways I’ve been able to do some accounting:…
markcmiller86 commented on issue spack/spack-packages#3252.
> The correct commit hash for that one change is 43a52d788a3c15bee3b9391906e8ed276c5a456c. …
hppritcha commented on issue open-mpi/ompi#13701.
ZE CI failure can be ignored. could be fixed with a rebase but not essential….
milroy commented on issue flux-framework/flux-sched#1316.
I finally updated this PR with requested changes and updates based on in-person feedback, and it’s ready for another round of reviews. Codecov is calculating code coverage strangely here, as the number of lines of code that are covered has increased quite a bit (courtesy of Catch2)….
wihobbs commented on issue flux-framework/flux-core#7375.
yay for Yet Another YACC
vsoch commented on issue pydicom/deid#300.
Thank you for this contribution, but we won’t be adding it as a feature….
vsoch commented on issue kubeflow/trainer#3064.
@andreyvelich what is your recommendation for resolving this merge conflict? The files below appear to be mostly auto-generated, so I’m not sure the best way to resolve conflicts (which I usually do manually). …
v-dobrev commented on issue spack/spack-packages#3292.
Thanks @Sbozzolo! What compiler do you see this issue with? I thought, I tested the patch (with +openmp) but either I did not or I just tested it with the ROCm clang and that worked fine….
hppritcha commented on issue open-mpi/ompi#12775.
@edgargabriel could you review this PR?…
v-dobrev commented on issue mfem/mfem#5224.
I think this is duplicate of #5222….
garlick commented on issue flux-framework/flux-core#7369.
If you like I can give it another pass but I thought it looked pretty good! Im ok with it going straight in if you are…
grondo commented on issue flux-framework/flux-core#7369.
The strategy I used here was to upload the existing 4 documents to Claude and ask it something like “act as a technical reviewer, sysadmin, and developer of shell plugins and update, modify and reorganize these documents as necessary to increase the clarity and completeness of these man pages. Include cross-references where necessary and reorganize pages into sections as required to improve organization” …
vsoch commented on issue flux-framework/flux-coral2#449.
> Or maybe a better idea is to add some way to configure a “plugin” to the existing rabbit support that would enable this to be developed and iterated external to flux-coral2? …
cbritopacheco commented on issue cbritopacheco/rodin#167.
@copilot The use of addr …
alecbcs commented on issue spack/spack-packages#3255.
@spackbot run pipeline…
becker33 commented on issue spack/spack#51922.
@otsukay @tgamblin @h-murai see above, as we discussed….
jedbrown commented on issue openjournals/joss-reviews#8388.
@editorialbot set v1.0.1 as version…
jeremylt commented on issue openjournals/joss-reviews#8388.
@editorialbot check references…
tzanio commented on issue mfem/web#360.
Can you add a line like this in the Community section of mkdocs.yml:
…
cjvogl commented on issue mfem/mfem#5094.
Another option to keep backwards compatibility with
tzanio commented on issue mfem/mfem#5223.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
cyrush commented on issue llnl/conduit#1495.
Docker silo failures with new spack built stack: …
adrienbernede commented on issue llnl/Umpire#1049.
@davidbeckingsale This has been verified and is ready for review….
adrienbernede commented on issue llnl/RAJAPerf#642.
> The reason that the performance check is failing appears to be a missing file. GitLab complains that .gitlab/jobs/performances.yml does not exist
…
grondo commented on issue flux-framework/flux-sched#1426.
The documentation for flux config is here, though we should probably add some more relevant examples. The key is this statement:…
garlick commented on issue flux-framework/flux-coral2#449.
A concern: …
jameshcorbett commented on issue flux-framework/flux-coral2#449.
> @jameshcorbett before I add the uid check - I thought the orchestration of the MiniCluster was done by the flux user, not the actual user? E.g., this line:
…
vsoch commented on issue flux-framework/Tutorials#58.
@wihobbs the tutorial content does not need to be under the less permissive GNU license. We want people to take it and modify. My preference would be to have MIT here, or MIT/Apache 2. Of course I’m sure this would need to be a Flux meeting item, so let’s hold on merging and can bring up at a future meeting….
markcmiller86 commented on issue HDFGroup/hdf5#6153.
What @Dave-Allured is suggesting reminds me of something similar I have considered for the Silo library (a library which typically writes a large variety of 1,2 and 3 dimensioinal, 32/64 bit integer and 32/64 bit floating point data to a Silo “database” and wanting a way for data producers to define compression strategies that invoke different filters with different parameters depending on various data attributes. (e.g. compress 2D, 32-bit integer data with szip with entropy-level=2, do not compress any 1D datasets, compress 4D double precision data where slowest dim size <=3 with ZFP filter in rate mode and rate=3.5, etc). I could imagine some standardized, yaml-like configuration string similar to how GitHub actions are specified….
jandrej commented on issue EnzymeAD/Enzyme#2689.
ping @wsmoses …
jeremylt commented on issue CEED/libCEED#1923.
Sure thing, its been nice seeing the capabilities of this example grow…
JustinPrivitera commented on issue visit-dav/visit#20779.
cyrush commented on issue visit-dav/visit#20655.
This will require us to build with a newer mesa version which will impact all of our testing. …
markcmiller86 commented on issue spack/spack-packages#3252.
@alecbcs thanks for quick response and merge….
hppritcha commented on issue spack/spack-packages#3271.
LGTM…
tgamblin commented on issue spack/spack-packages#3255.
> For context, this was disabled because the packages were built with a mix of gcc and clang in the netlib-scalapack matrix due to unify:when_possible. This results in pipelines that are always
cyrush commented on issue spack/spack-packages#3040.
Limiting the current visit release to mfem 4.8 sounds like the easiest path. …
garlick commented on issue flux-framework/flux-pam#16.
Thanks, setting MWP…
tzanio commented on issue GLVis/web#24.
@camierjs and @justinlaughlin – can you please review?…
tzanio commented on issue GLVis/glvis#351.
@camierjs and @justinlaughlin – can you please review? …
markcmiller86 commented on issue visit-dav/visit#20795.
@cyrush or @JustinPrivitera can one of you pls approve. This is to put the Silo 4.12.0 patch into the build_visit PR for HDF5-2.0 and friends….
hppritcha commented on issue openpmix/openpmix#3799.
this passes a basic sessions smoke test….
balos1 commented on issue llnl/sundials#814.
Does this need to be merged after #813?…
markcmiller86 commented on issue llnl/Silo#515.
Ok, thanks @cyrush. I put some other changes in this PR that were about fixing testing on macOS including some ASAN failures and CI artifact upload…related to the namescheme issue because I wasn’t able to test and examine failures without those changes….
adayton1 commented on issue llnl/RAJA#1985.
I would be inclined to use std::aligned_alloc and drop the others….
wihobbs commented on issue flux-framework/flux-core#7252.
@sam-maloney was kind enough to do a quick review on 1/8/26 and commented in Slack: …
benzwick commented on issue Slicer/ExtensionsIndex#2311.
Thanks @lassoan! I’ve renamed the extension from SlicerAdaptiveBrush to AdaptiveBrush as requested:…
amagela commented on issue llnl/benchmarks#23.
GitHub was having issues earlier today. That was preventing this pipeline from running correctly. The latest build was “successful” except that it was unable to store the resultant document for our manual checking. So, we need to re-run this later when it is back to see if the steps are doing what they should. …
camierjs commented on issue GLVis/glvis#357.
Closing in favor of #358…
tzanio commented on issue mfem/mfem#5190.
Re-merged in next for testing……
vsoch commented on issue flux-framework/flux-core#7341.
The beauty of try/except!…
grondo commented on issue flux-framework/flux-core#7341.
You can also use modprobe to schedule these kinds of tasks before and after the execution of a batch or alloc instance….
chu11 commented on issue flux-framework/flux-core#7303.
re-pushed going with a slightly alternate implementation. …
alecbcs commented on issue spack/spack-packages#3144.
@adamjstewart I’ve rebased this PR now that #3119 is merged. I’ll need you to approve before we can proceed since you requested changes….
cyrush commented on issue spack/spack-packages#3200.
I appreciate the proposed solution, but I don’t think we should take such measures in the spack package. …
tgamblin commented on issue spack/spack-packages#3200.
One other thought. We could: …
alecbcs commented on issue spack/spack#51521.
Gotcha. I’ll drop the tag on the PR. Thanks for checking….
becker33 commented on issue spack/spack#51632.
This PR does not apply cleanly to releases/v1.0 and will be removed from v1.0.3…
tgamblin commented on issue spack/spack#51881.
I’m ok with this (enthusiastic, even) if we can add an audit like the one @haampie mentions. I think we need that soon though – otherwise I think we’re going to start getting a lot of packages with invalid constraints….
camierjs commented on issue mfem/mfem#5190.
For lower orders, the performances are fine - this issue appears specifically at higher ones….
adrienbernede commented on issue llnl/radiuss-spack-configs#157.
> Ah I see, that makes sense. And yes, I do have access to Corona, but just not the ability to relaunch radiuss-spack-config jobs from gitlab (I do have access for Umpire and maybe RAJA) …
cyrush commented on issue llnl/conduit#1495.
with new builds of metis and parmetis, we get a different result for the polyhedra test on macos than on linux. …
amagela commented on issue llnl/benchmarks#9.
@pearce8 , I haven’t finished this quite yet. …
trws commented on issue flux-framework/flux-sched#1425.
That sounds right. I think as it stands, the R returned by the scheduler is what the shell uses for this, since that provides the actual resources to use, but for correct output wherever the jobspec_parse is used instead we would need either a separate annotation or to consult the R to determine what the result is….
trws commented on issue flux-framework/flux-core#7340.
@grondo mentioned offering a flux python<num> for each of the installed bound pythons, these could have a “get path” option or similar, or maybe we could have arfuments on flux python itself to list or select the available version to use?…
garlick commented on issue flux-framework/flux-core#7333.
Thanks - I added that and will set MWP….
garlick commented on issue flux-framework/flux-coral2#446.
Thanks!…
trws commented on issue desul/desul#164.
That would be pretty painful yeah. Do any of the implementations actually trap on an atomic add to a non-writable location? I haven
camierjs commented on issue GLVis/glvis#353.
Closing for in-place solution in #336…
trws commented on issue spack/spack-packages#3144.
Darn, thanks for trying it!…
jedbrown commented on issue openjournals/joss-reviews#9244.
Thank you @valsson!…
v-dobrev commented on issue mfem/mfem#5210.
I thought about this issue and I think a better solution is to = delete the move-assignment operator of DenseMatrix. This way assignments to DenseMatrix will always be copy-assignments. The reason I think this is a better solution is that re-defining the move-assignment (especially at the level of Array) to do a deep copy, in the case when the LHS is an alias, goes against the idea of move-assignment. We will lose the ability to move-assign DenseMatrix but that is not a big deal, I think – this was already the case for a long time before we added it in #4028.
…
gardner48 commented on issue llnl/sundials#836.
#837 deprecates the <TPL>_WORKS options and replaces them with SUNDIALS_ENABLE_<TPL>_CHECKS to make the purpose of the option clearer (and namespace the option). …
wihobbs commented on issue flux-framework/flux-security#213.
@chu11 Can you add the MWP label? I don’t have that ability; this repo must not inherit maintainer privileges from the core team (IIRC pmix doesn’t either)….
cmoussa1 commented on issue flux-framework/flux-accounting#810.
Thanks @jameshcorbett! Setting MWP…
cbritopacheco commented on issue cbritopacheco/rodin#165.
@copilot Add manufactured tests for P1_H1 mixed problems similarly as you did with the P0_P1 tests. Put them in the folder called P1_H1 and go up to K = 2….
adrienbernede commented on issue llnl/RAJAPerf#577.
@rhornung67 This is ready for review….
wihobbs commented on issue flux-framework/flux-core#7325.
> Did you spot a way to easily “exempt” paths from a rule in dorny/paths-filter? This action seems to easily enable conditional execution based on files changed, not based on ‘only files changed’,…
cmoussa1 commented on issue flux-framework/flux-core#7303.
I’ll second @jameshcorbett’s vote to just add a raw=False flag…
cjvogl commented on issue E3SM-Project/E3SM#8012.
> @cjvogl can you confirm that with this change E3SM will build on LC machines? …
trws commented on issue spack/spack-packages#3088.
I have not seen that no. I’m not sure what’s causing it either, it’s a bufreadpost from your dotfiles trying to load a lua parser, but I don’t know why that would be failing there. Maybe something is out of order in the load order specifically the way we set it up with spack?…
tzanio commented on issue mfem/mfem#5110.
Merged in next for testing……
dylan-copeland commented on issue mfem/mfem#5203.
What is the policy for output in unit tests? There is std::cout << std::flush; in fem/test_var_order.cpp and other calls to cout if (verbose_tests) in test_quadinterpolator.cpp. When should cout be used with verbose_tests, vs. the more common mfem::out? There is usage of mfem::out if (verbose_tests). Should we add if (verbose_tests) in addition to the change to mfem::out? I suppose unit tests should rely on REQUIRE statements to check conditions, and output should be unnecessary but possible in the case if (verbose_tests). If so, cout could also be changed in test_quadinterpolator.cpp and test_var_order.cpp, along with use of if (verbose_tests)….
jameshcorbett commented on issue flux-framework/flux-sched#1419.
I think I’ve addressed your comments @milroy ! Thanks for the review….
garlick commented on issue flux-framework/flux-core#7321.
Restarted el8 builder after hitting …
jameshcorbett commented on issue flux-framework/flux-core#7303.
I vote B) and I would recommend not type-checking the input with isinstance but instead just converting it to bytes() (if you even need to do that) and letting any errors propagate…
alecbcs commented on issue spack/spack-packages#3123.
Looks like https://github.com/davidhalter/jedi/issues/2064 is an open issue for Python 3.14 compatibility in Jedi with a few known bugs. …
jeremylt commented on issue openjournals/joss-reviews#8388.
Ratel 1.0 has been released. I appreciate your patience and apologize again for the delay….
balos1 commented on issue llnl/sundials#796.
chu11 commented on issue flux-framework/flux-core#7191.
> It makes me lean to the idea of having a “mixed” db as I call it above. The eventlog is stored as it is above, with possibly some special handling of exceptions (maybe other events too). We have DB columns for important fields. Longer out, we can add sqlite plugin extensions for faster / simpler hostlist / rank searches in sqlite for those columns. …
alecbcs commented on issue davidhalter/jedi#2064.
Hi all, just wanted to reach out to see if any additional progress had been made on this front. Thanks!…
tzanio commented on issue GLVis/glvis#335.
@najlkin can you please resolve the conflicts?…
jeremylt commented on issue CEED/libCEED#1694.
MacOS + weak symbols fixed here: https://github.com/CEED/libCEED/pull/1919…
jedbrown commented on issue CEED/libCEED#1919.
Thank you. This looks clean and decoupled given the constraints. I agree it looks like the best option….
cyrush commented on issue visit-dav/visit#20748.
I think this was resovled in #20768…
vsoch commented on issue rootless-containers/usernetes#152.
We tried to use helm first, which is going to deploy the tigera operator, and could not get that setup working….
chu11 commented on issue networkupstools/nut#3193.
Adding -u root worked for me….
cyrush commented on issue llnl/conduit#1495.
windows path style issue on some of the tests on windows: …
wihobbs commented on issue flux-framework/flux-core#7316.
In the last push: …
grondo commented on issue flux-framework/flux-core#7318.
Thanks! …
homijan commented on issue conservation-laws/ryujin#285.
Dead end here….
chu11 commented on issue chu11/freeipmi-mirror#78.
a few of the issues I posted above don’t seem to be resolved. Did you push the wrong update here?…
becker33 commented on issue spack/spack#51835.
@FlyingSamson I was finally able to reproduce your bug (accidentally, while trying to do something else). I was also able to backport the fix and include it in the upcoming release. Thanks for bisecting that and making it easy!…
hppritcha commented on issue open-mpi/ompi#12979.
The application uses persistent send/recv requests with the comm pattern being an all-to-one pattern. The individual messages for the problem suggested above are about 40000 bytes in size when using 60 ranks. I’m seeing the hang for fewer than 64 procs. The behavior appears to be that the target rank (0) does receive all its messages but some of the senders do not “think” that all of their sends are complete. Again this appears to be btl-sm specific. turning off the fast boxes does not appear to help. investigation continues……
JustinPrivitera commented on issue llnl/conduit#1495.
> ``` …
jakubcerveny commented on issue jakubcerveny/gilbert-paper#17.
No need to apologize. Thank you…
trws commented on issue hpsfoundation/tac#61.
Great news, thank you all!…
vsoch commented on issue hpsfoundation/tac#61.
Hooray!!
JustinPrivitera commented on issue visit-dav/visit#20794.
To test I need to check what ends up in the analogous place for 3.5.0: /usr/gapps/visit/3.4.2/linux-x86_64/lib/python/lib/python3.9/site-packages/…
markcmiller86 commented on issue spack/spack-packages#2346.
@tldahlgren, @patrickb314 and @cyrush thanks so much!…
wihobbs commented on issue flux-framework/flux-sched#1372.
Hi @ax3l, in looking back at this issue the EINVAL was actually raised on the job in your subinstance of Flux, not the top-level allocation itself. Here’s a theory on what could have happened:…
vsoch commented on issue flux-framework/.github#7.
Updated. …
cbritopacheco commented on issue cbritopacheco/rodin#163.
@copilot I have fixed the tests. Please add more 3D tests inspired from the P1 2D tests using other equations….
v-dobrev commented on issue spack/spack-packages#3040.
> @v-dobrev please see #1557 and revert your llvm_amdgpu change. It’s wrong. Even if this was the case, it shouldn’t be mixed with a mfem change. …
jandrej commented on issue mfem/mfem#5192.
> Discussed in the PR meeting: instead of changing all files every year, does it make sense to have a top-level COPYRIGHT file that is updated yearly, and other source files reference that one. This is what Spack does, see https://github.com/spack/spack …
artv3 commented on issue llnl/RAJAPerf#599.
> > @rchen20 , you can also squash merge …
benzwick commented on issue SlicerCBM/SlicerCBM#77.
## Current ruff check results (as of 2026-01-20)…
brendankeith commented on issue mfem/web#305.
This is now ready for review!…
tzanio commented on issue mfem/mfem#5198.
is this ready-for-review?…
garlick commented on issue flux-framework/flux-core#7292.
Oh, hey, didn’t we have a problem a while back where the flux systemd instance was getting killed when someone logged in and out of a node? I thought we had a workaround in place for that, but don’t recall the details. Maybe the 90s default stop timeout is in effect for the system unit that contains the user instance?…
grondo commented on issue flux-framework/flux-core#7292.
A quick test on Tuolumne shows this is working in the basic case. I simulated an unkillable process by attaching gdb to the job shell then canceled the job….
markcmiller86 commented on issue visit-dav/visit#20752.
Ok, so both the HDF5 and Silo build failures are fixed by specifing -DMPI_HOME:STRING=/path/to/mpi/install/home. Now, Silo of course DOES NOT REQUIRE mpi. But, it does a find_package() on HDF5 and that will fail if the HDF5 it is finding depends on MPI but there is nothing telling Silo where to find MPI.
…
becker33 commented on issue spack/spack#51835.
@alalazo thanks! I’ve included it now…
jeremylt commented on issue openjournals/joss-reviews#8388.
My apologies, I was trying to wait for the libCEED release to finish, but unfortunately that became a much longer wait than I expected. I will proceed one way or another with a new Ratel release by next Friday no matter what libCEED does….
wihobbs commented on issue flux-framework/flux-core#7289.
> Actually, would it address this issue if we got rid of the names and affiliations in the list and just left the github IDs? …
cyrush commented on issue visit-dav/visit#20782.
We reviewed the error. The logic detects the case where int could cause badness and handles this with an error message. So the generic integer to int logic is ok, we can remove the #error.
…
alecbcs commented on issue spack/spack#51854.
Yep! Thanks for the suggestion @haampie. This works with ghcr.io/spack/centos7:
…
hppritcha commented on issue open-mpi/ompi#12979.
some notes on this. this doesn’t seem to be a problem with partial finalization in some ranks verses others. when the hang occurs I observe some process stuck in waiting for completion of the PMIx_fence_nb near the beginning of finalization while others are stuck in some waitall (on several hundred requests per call) within the application….
markcmiller86 commented on issue llnl/H5Z-ZFP#159.
> I see. So let me sure I get this right. The use case we’re discussing is when an application like Matlab knows nothing about zfp or H5Z-ZFP (e.g., it has not been linked against those libraries), but instead relies on the HDF5 library to invoke zfp. This is done by having the application/user set the filter number (32013) and enough cd_values to specify zfp compression mode and parameters. The HDF5 library will then, when encountering the filter number, dynamically load the H5Z-ZFP and zfp libraries, which will encode additional cd_values (the zfp header) and then compress the data. Did I get that right?…
adayton1 commented on issue llnl/CARE#364.
Can you update the title? Nvm, I got it….
cbritopacheco commented on issue cbritopacheco/rodin#162.
@copilot Try this solution:…
markcmiller86 commented on issue HDFGroup/hdf5#6153.
It may be useful to adopt a string format standard for stringified filter params instead of allowing each filter to define syntax for the param strings. So, instead of "mode=rate; rate=3.5", a json string "{"mode":"rate","rate":3.5}" or maybe YAML, {mode: rate, rate: 3.5}….
jeremylt commented on issue CEED/libCEED#1917.
Thoughts - Do we also want CeedObjectDestroy ? (Easy to add) And do we want the view tabs to be added to the CeedObject? I’m thinking yes for both …
vsoch commented on issue vsoch/zenodo-validator#5.
Thanks @ax3l !…
bgunnar5 commented on issue llnl/merlin#597.
@doutriaux1 gave the nod of approval to go ahead and merge this…
adayton1 commented on issue llnl/axom#1772.
It might be helpful to add some kind of readme containing the compiler errors encountered and which patches fix them with an explanation….
adayton1 commented on issue python-gitlab/python-gitlab#3322.
It looks like there is an abandoned attempt: https://github.com/python-gitlab/python-gitlab/pull/2552/files…
jbschroder commented on issue pyamg/pyamg#459.
Update: Consider…
brendankeith commented on issue mfem/web#305.
Hopefully by tomorrow
adrienbernede commented on issue llnl/radiuss-shared-ci#66.
@tdrwenski could you please add a changelog entry?…
astrophpeter commented on issue llnl/popclass#81.
Thanks, can you add a short description in the docs about these new datasets? …
grondo commented on issue flux-framework/flux-security#207.
Done. …
wihobbs commented on issue codecov/feedback#665.
@asmacdo A while back I tried to chase down a rabbit hole of looking in our organization’s audit log for what event might trigger codecov to run again 90 days later, but we never quite figured it out….
acfisher commented on issue mfem/mfem#5116.
@dylan-copeland Thank you for the through review. I believe I have addressed all of your comments and have updated the code accordingly….
JustinPrivitera commented on issue llnl/conduit#1496.
we will want this to be as fast as possible, so we will want to write three converters, one from each specset representation to silo. Ignore the comment in the code….
tgamblin commented on issue andrew/nesbitt.io#34.
I could add more – lemme know if any of these seem interesting. …
hppritcha commented on issue open-mpi/ompi#12278.
is this PR still being worked on or should it be closed?…
balos1 commented on issue llnl/sundials#809.
> Or should we switch to the clang-format installed in the github runner image? ubuntu-latest should have 16.0.6, 17.0.6, and 18.1.3 installed.
…
vsoch commented on issue hpsfoundation/tac#61.
I forgot that we also have the Flux Locator map!
vsoch commented on issue hpc-social/jobs#29.
I still don’t see it in the Google Sheet, and there must be an issue with submitting this form (that is shown in your browser console of that page). To bypass that (and see it more directly) please use the Google Form directly:…
garlick commented on issue flux-framework/flux-core#7260.
This test is repeatedly failing in alpine. I thought this was a known test issue but maybe this PR has somehow made it worse. Anyway, further investigation is probably warranted. …
chu11 commented on issue flux-framework/flux-core#7272.
list_all() appears to return a tuple of files and directories. So the second list is simply the list of directories in that directory, which in this case is no directories, thus an empty list….
cyrush commented on issue visit-dav/visit#20784.
bv test failed b/c the container ran out of space. Sounds like we arrived at a resource wall….
markcmiller86 commented on issue visit-dav/visit#20752.
Ok, so that is the build of HDF5-2.0.0 then via bv_hdf5.sh. I thought I copied that logic verbatim from bv_conduit.sh. What was your build_visit command-line and env?…
v-dobrev commented on issue mfem/mfem#5134.
One additional issue: the sample run …
tzanio commented on issue mfem/mfem#5134.
@IdoAkkerman – can you take a look at this
jandrej commented on issue mfem/mfem#4551.
Closing because this was merged through separate smaller PR’s….
cyrush commented on issue llnl/uberenv#124.
closing #155 should be used instead. …
cyrush commented on issue llnl/conduit#1495.
``` …
tgamblin commented on issue llnl/Umpire#1046.
@adayton1: …
cyrush commented on issue llnl/H5Z-ZFP#159.
@markcmiller86 that sounds great to me, much simpler way to provide options…
markcmiller86 commented on issue llnl/H5Z-ZFP#159.
@brtnfld I like the idea of HDF5 library offering a string-based way of controlling filters….
garlick commented on issue flux-framework/flux-security#207.
It looks like cgroup_info_create() will fail (and this is immediately fatal to the IMP) if we set the cgroup->unified flag wrong, so just running a job and for extra credit, sending it a signal ought be a sufficient test. Correct me if I’m wrong!
…
chu11 commented on issue flux-framework/flux-security#207.
just re-pushed. I split your change into two commits to mirror my original two fixes (checking the wrong FS, and the not erroring out if the unified dir doesn’t exist). I listed you as co-author in the commit message. So we should get someone else to review and approve….
wihobbs commented on issue flux-framework/flux-core#7270.
If you’re a member of the core team on GitHub, you automatically have write/maintainer access to a bunch of the repositories in the flux-framework org (see flux-pam MAINTAINERS.md).
…
cmoussa1 commented on issue flux-framework/flux-core#7270.
Do we have more than one MAINTAINERS.md document other than flux-core? I’m not sure.
garlick commented on issue flux-framework/flux-accounting#803.
CONTRIBUTING.md was updated in flux-core with the governance and CoC RFCS if you want to pull that in too….
vsoch commented on issue flux-framework/.github#5.
No worries! I think repository specific files might be in order given that we have different maintainers in different repositories. We can definitely change our strategy after this initial first shot….
garlick commented on issue flux-framework/.github#5.
Oh sorry I missed this and started mindlessly making copies. I guess at least the short term requirement is met and we have space to sort out a longer term plan….
cyrush commented on issue Alpine-DAV/ascent#1650.
Does image_prefix help instead of image_name ?…
adayton1 commented on issue llnl/Umpire#1046.
Is there some git configuration variable that can be set to avoid all the commits coming from “different” emails?…
artv3 commented on issue llnl/RAJAPerf#609.
I think this PR should now be good to go, @rhornung67 I fixed the compiler warnings as well. …
tzanio commented on issue GLVis/glvis#335.
ping: @justinlaughlin and @v-dobrev – do you want to take a look? …
jeremylt commented on issue CEED/libCEED#1818.
I tried to bully MacOS into respecting the weak symbols here: https://github.com/CEED/libCEED/pull/1913 …
adrienbernede commented on issue spack/spack-packages#2858.
@chapman39 this is moving in the opposite direction than https://github.com/spack/spack-packages/pull/1402, as discussed in https://github.com/llnl/axom/discussions/1726#discussion-9196039. …
jbschroder commented on issue pyamg/pyamg#459.
I would support …
adrienbernede commented on issue llnl/radiuss-spack-configs#158.
@kab163 is this specific to Umpire or does it apply to every project ? (You can update CMake directly in Umpire CI)….
adrienbernede commented on issue llnl/quandary#105.
@tdrwenski the GITHUB_TOKEN variable has been replaced by GITHUB_WORKFLOW_TOKEN. the latter should be defined in GitLab UI….
amagela commented on issue llnl/benchmarks#23.
I think this was failing because the containers were not being set up with Gnuplot and Matplotlib. I just pushed a change that should, hopefully, alleviate that. Will check on it in the morning. …
cjvogl commented on issue mfem/mfem#4496.
@tzanio, this should be ready for re-merging into next…
chvillanuevap commented on issue humanmade/S3-Uploads#612.
Adding a note here for posterity….
samuelkgutierrez commented on issue openpmix/openpmix#3758.
I would advocate for leaving the comments alone unless there is a compelling reason to remove them. Since the code related to the comments was left untouched, I would personally leave those comments alone. …
vladotomov commented on issue mfem/mfem#5176.
> Can you just remove static from the convection and DG trace integrators and see if that works in Remhos? If so, that is a better solution than adding the specializations here.
…
hppritcha commented on issue open-mpi/ompi#13605.
ignoring borked up NVIDIA CI….
chu11 commented on issue flux-framework/flux-core#7194.
@garlick thanks! will set MWP…
becker33 commented on issue spack/spack#51746.
We discussed passing these as tuples instead of dictionaries. The methods called here are not called anywhere else, so it’s fine to change their signatures. …
tzanio commented on issue mfem/mfem#5134.
@mlstowell, can you take a quick look when you get a chance?…
hppritcha commented on issue spack/spack-packages#2900.
This PR is incorrect. The UCX developers botched up the mail about 1.20.0. it was actually for an RC not a release. That’s the the URL is different. Please do not merge this PR….
artv3 commented on issue llnl/RAJAPerf#610.
Super nice! I’m super interested in trying out this feature, if I can get a day or two I can give some user experience feedback. …
artv3 commented on issue llnl/RAJA#1969.
Super nice! Can you add something in the RAJA docs about this new feature? And what do folks think about adding a note about this in our RELEASE_NOTES in this PR. …
garlick commented on issue flux-framework/flux-core#7254.
OK now that I have the next phase just about working, I’ll drop the WIP here. …
JustinPrivitera commented on issue llnl/conduit#1322.
Documentation and implementation done in #1487 so that we are not waiting for this from the device support PR….
vsoch commented on issue kubeflow/trainer#2909.
Thank you @andreyvelich @tenzen-y - the review was excellent, and I’m glad to see this moving through. It might be a bit early, but Happy New Year! I appreciate everything you do for the Kubeflow (and larger Kubernetes) communities….
jeremylt commented on issue freeCodeCamp/freeCodeCamp#64929.
Is there an issue associated with this change? If so please add it. If not, please create an issue before making a pull request….
cmoussa1 commented on issue flux-framework/flux-accounting#798.
Thanks @garlick! Setting MWP here…
vsoch commented on issue compspec/fractale-mcp#4.
cc @knglugo @milroy autogen is added as an engine, to join the default “native” state machine. I’ve created sample plans for building a docker container and translating a jobspec. See design in the README for the abstractions. The tools are now separate libraries too: …
hppritcha commented on issue open-mpi/ompi#12658.
do we still want to pull in this PR? …
imguoguo commented on issue sipeed/NanoKVM-USB#6.
fixed by https://github.com/sipeed/NanoKVM-USB/pull/83, you can try the latest version…
vsoch commented on issue kubeflow/trainer#2841.
This is a WIP and should not be closed. Thanks!…
garlick commented on issue flux-framework/flux-core#7256.
Thanks! Setting MWP…
cmoussa1 commented on issue flux-framework/flux-accounting#796.
Thanks @jameshcorbett! Setting MWP here…
chvillanuevap commented on issue humanmade/S3-Uploads#612.
I don’t mean to reopen this issue, but I ran into the same problem recently while searching for a solution, and I wanted to share the patch I ended up using in case it helps someone else….
tgamblin commented on issue archspec/archspec#225.
In memory. This isn
tgamblin commented on issue spack/spack#51781.
@haampie: with the change I added I get similar performance to your removal, so I went ahead and updated the commit message and merged. Feel free to revert if you think there are still issues….
adayton1 commented on issue llnl/CARE#350.
I want to merge this in before I release….
gauthier12 commented on issue lapce/lapce#3592.
I confirm the bug….
alecbcs commented on issue spack/spack-packages#2836.
@spackbot run pipeline…
jandrej commented on issue mfem/mfem#4908.
Superseded by merged PR…
camierjs commented on issue GLVis/glvis#339.
Thanks for testing this out, @hughcars
garlick commented on issue flux-framework/flux-core#7251.
Fixed those things, and made another pass, expanding the slurm migration section to include more information. …
cyrush commented on issue visit-dav/visit#20768.
@biagas can you try out the new mp4 logic to see if that helps with #20748 ?…
tgamblin commented on issue spack/spack#51781.
So, I was hoping to use protocols to make typing of spec data structures much easier. This doesn’t bode well for that, so I guess I’ll ask some questions: …
hppritcha commented on issue open-mpi/ompi#13583.
@jsquyres check now. fixed typo inherited from slurm page too….
dylan-copeland commented on issue mfem/mfem#5123.
Thank you @IdoAkkerman for your careful review. There were many important issues raised in this review, which are hard to find in the resolved comments. Here is a list to summarize some issues to revisit later. …
balos1 commented on issue llnl/sundials#806.
Thanks for the report. This header is unused, so I have removed it entirely in #807….
cyrush commented on issue llnl/conduit#1438.
@mlohry these jobs failed b/c the windows image in ci was removed around the time of testing. If we merge develop into your branch, we can fully test…
adayton1 commented on issue llnl/axom#1599.
This is currently a blocker for us having any CUDA builds….
adayton1 commented on issue llnl/Umpire#1033.
> It seems there are some C++20 compatibility issues in the current version of fmt, so will see how updating to 11.1.0 works …
artv3 commented on issue llnl/RAJAPerf#599.
How big can meshes get? I’m wondering how the meshes will impact the repo size….
artv3 commented on issue llnl/RAJA#1964.
Hey this looks pretty cool and simpler than we were originally trying, let me try it within the RAJA PerfSuite and I can get back to you …
jeremylt commented on issue freeCodeCamp/freeCodeCamp#64787.
How about:…
trws commented on issue flux-framework/flux-sched#1423.
Doing it in that literal order is impossible. We may be able to get you to something like what you want, but let me lay out the situation a bit so you know where I’m coming from. In order to give a predicted start time we need to run a match against the current resource state, allocations and reservations to determine when the job would be reserved. Without doing that match, any result we give out would be even more wrong than without doing it (even doing the match is still an estimate at best due to new job arrival and constant state changes)….
chu11 commented on issue flux-framework/flux-core#7191.
Continued prototyping with the eventlog in this format as I describe above: …
vsoch commented on issue rseng/jobs-updater#12.
Thanks @crd477 ! …
adrienbernede commented on issue llnl/uberenv#154.
I have the same error on my end with quandary….