vsoch commented on issue rse-ops/flux-compose#4.
If we put an arbitrary large number there we don’t need to rebuild - they will just appear as down. What do you think?…
vsoch commented on issue kubernetes/enhancements#2033.
Usernetes, of course!…
markcmiller86 commented on issue betterscientificsoftware/bssw.io#2563.
> What if we don’t link SSF at all where it appears in the body and just let the MIF link carry all of the responsibility? …
cyrush commented on issue Alpine-DAV/ascent#1732.
@nicolemarsaglia does this resolve#1725?…
alecbcs commented on issue spack/spack-packages#5621.
@spackbot run pipeline…
tgamblin commented on issue spack/spack#52780.
Curious, what’s the performance improvement you’re seeing?…
balos1 commented on issue spack/spack#52762.
> I would take a step back: filter: is very generic for a niche feature. Can’t you do spack env create --filter filter.yaml? Does it even compose for your spack config get idea? I’m sure there are ambiguities regarding what filter refers to if you have includes/stacking.
…
becker33 commented on issue spack/spack#52769.
@haampie I’ve rebased this and confirmed that it overwrites the package hash appropriately. …
jedbrown commented on issue openjournals/joss#1563.
I agree with @sneakers-the-rat. Automation bias is strong in this context and LLMs embody biases that the editor may not even be aware of. “Accuracy” in historical decisions does not imply validity. If we were to deploy this and then audit the resulting system, we would almost certainly find a lack of construct validity and that “bad” recommendations from the LLM unacceptably influenced decisions. I think it also violates trust of authors and the broader community, and cheapens the meaning of a JOSS publication. …
v-dobrev commented on issue mfem/mfem#5426.
@najlkin, is this ready for review? If so, please add the label ready-for-review….
alecbcs commented on issue llnl/hubcast-test#6.
@lc-hubcast help…
JustinPrivitera commented on issue llnl/conduit#1652.
@mohityadav8 why don’t you choose between #1641 or #1632…
trws commented on issue llnl/camp#218.
Agreed. Forcing the change to a ULL seems reasonable, but I would note that even if it didn’t have the qualifier on it increasing the version to a number requiring that size would have produced warnings for anyone assigning the literal to a smaller value. Honestly I’d prefer we keep the format and force the size change rather than change the format, it’s less likely to cause downstream breakage that’s undetectable by the compiler….
garlick commented on issue flux-framework/rfc#541.
Thanks!…
trws commented on issue flux-framework/flux-sys-rs#4.
Ok, sounds good. If we end up wanting 2024 for the higher-level crate I think all we’d need to do is be sure we can reasonably use that toolchain in the buildbot so we could deploy modules using it in LC. Something for later. …
grondo commented on issue flux-framework/flux-security#234.
Thanks! I’ve set MWP….
wihobbs commented on issue flux-framework/flux-sched#1528.
Working off of pure vibes, I want to see if this passes CI. Hence the change to draft….
jameshcorbett commented on issue flux-framework/flux-sched#1534.
> Note: it is difficult to change the phrasing of statements like opt_p.value_or (null_planner) because none of boost::optional’s operators cleanly express “empty or populated with nullptr” or the inverse in a single statement (opt_x == boost::optional (nullptr) returns false when empty and true when null), and try_at only returns references but boost::optional cannot be initialized with an rvalue reference (see Optional references).
…
trws commented on issue flux-framework/flux-sched#1535.
I honestly don’t really care, just didn’t realize it was a separate issue tickling that one. It might be worth doing that when we update to the next TOSS release so everything works in our normal production environment but I don’t see it being worth all that much right now. Thanks for this @wihobbs….
grondo commented on issue flux-framework/flux-core#6440.
Having something that could run on new code would really nice now that we’re making heavy use of LLMs which seem to forget half the time some of the formatting instructions they’re given….
trws commented on issue flux-framework/flux-core#6440.
Adding custom handling to <, == and != to the thing I linked above with never as the policy might take care of those trailing breaks that were bugging us. The last time I was seriously thinking about this, my plan was to add clang-format to pre-commit, and have it run either only on files with diffs or only on the diff itself so we could at least count on it for new code. …
garlick commented on issue flux-framework/flux-core#6440.
Closer. …
cmoussa1 commented on issue flux-framework/flux-accounting#916.
Thanks for catching that issue in the commit message @jameshcorbett - I’ll go ahead and remove that from the message altogether. The .backup DBs are automatically cleaned up in the testsuite, but you are right, the backup isn’t deleted if the update completes successfully. I guess the thinking here was that it would be an admin’s responsibility to manually clean this up for this reason:
…
jeremylt commented on issue CEED/libCEED#1830.
If you’d like to take a crack at it, feel free! It should be largely the same code copied over, but you have to make some small changes to account for the difference between CUDA and HIP syntax…
jeremylt commented on issue 4C-multiphysics/4C#2133.
I added folks who I’ve seen approve changes to these files in the git history…
JustinPrivitera commented on issue visit-dav/visit#20950.
I want to make sure we error instead of crashing….
becker33 commented on issue spack/spack-packages#5711.
It might be worth showing a warning, but I think this is generally good (for two primary reasons). …
imguoguo commented on issue sipeed/NanoKVM#442.
Since we
hppritcha commented on issue open-mpi/ompi-www#569.
@jsquyres noted these missing presentations prior to HPSF meeting…
adrienbernede commented on issue llnl/radiuss-spack-configs#195.
@tdrwenski @davidbeckingsale …
adrienbernede commented on issue llnl/RAJAPerf#688.
@smithsg84 I’d appreciate a review of the changes in RAJAPerf spack package: https://github.com/spack/spack-packages/pull/5716…
artv3 commented on issue llnl/RAJA#2036.
@lc-hubcast approve…
hppritcha commented on issue hpsfoundation/tac#93.
> @hppritcha thanks for he responses above. The link https://github.com/orgs/open-mpi/teams/ompi-devel-merge is not publicly visible, unfortunately….
chu11 commented on issue flux-framework/flux-core#7730.
> maybe on_sigchld() with a status argument would be better callback name here? …
hppritcha commented on issue open-mpi/ompi#13133.
@kingshuk00 are you planning to work on this further? Note a related PR #14083 will be merged soon….
v-dobrev commented on issue mfem/PyMFEM#315.
Hi @sshiraiwa, thanks for reviewing this. There are CI failures, however, they are not related to this PR – are you okay if I merge this, regardless of the failures? …
BradWhitlock commented on issue llnl/conduit#1645.
Hey @cyrush , I see that you approved this PR already so I’m merging it….
jandrej commented on issue EnzymeAD/Enzyme#2964.
> @jandrej this failure is presumably from upstream mfem? …
tpatki commented on issue llnl/variorum#591.
Update from 7/21. …
bgunnar5 commented on issue llnl/mada-tools#10.
> Did the gitlab ci pipeline pass for this? I can’t find it in the pipeline list for some reason. …
eleon commented on issue hpc/quo-vadis#9.
@samuelkgutierrez , could you please try the test test-mpi-phases? …
wihobbs commented on issue flux-framework/rfc#529.
@grondo Okay with adding MWP to this?…
tpatki commented on issue flux-framework/flux-rest-server#6.
…
jameshcorbett commented on issue flux-framework/flux-accounting#912.
roger roger big boss…
cbritopacheco commented on issue cbritopacheco/rodin#311.
@copilot Fix the CI….
emily-howell commented on issue Alpine-DAV/ascent#1751.
Thank Justin for finding it and making a ticket!…
vsoch commented on issue flux-framework/flux-framework.github.io#205.
Thanks for the 3rd comment, Mergify bot. I almost forgot you were there after the first two. You and coffee bot must be good buds. …
JustinPrivitera commented on issue visit-dav/visit#20980.
Thanks for these changes! Everything is merged and should be released in VisIt 3.5.1….
tpatki commented on issue llnl/variorum#591.
Spent a few hours debugging the segfault with amd_smi APIs. Summary from claude below.
…
garlick commented on issue flux-framework/flux-core#7731.
I repushed with the suggested changes, plus addressed some test failures that were a bash (redhat) vs dash (debian) thing….
alecbcs commented on issue spack/spack-packages#5620.
Package names appear to always be normalized by PyPi so we just need to match the same case / separator as is used in the actual tarball name for {name} and it’ll work….
camierjs commented on issue mfem/mfem#5387.
Really neat! Thank you @tdrwenski !…
jandrej commented on issue mfem/mfem#5387.
> We should mention this new feature in the CHANGELOG.
…
JustinPrivitera commented on issue llnl/conduit#1651.
what is conduit_fmt::runtime and why do we need it?…
adayton1 commented on issue llnl/axom#1912.
Instead of removing the cpp14 variant, can’t you just make it conflict with the version that requires c++17 and any version newer than it?…
adrienbernede commented on issue llnl/CARE#379.
> > If you can get access to a bank (other than guests) on matrix, the best is to define it as the default one. But otherwise, yes, we can easily set the CI to use it in the alloc options (.gitlab/custom-variables.yml). …
chu11 commented on issue flux-framework/rfc#535.
doh! i totally forgot about the rfc. thanks!…
chu11 commented on issue flux-framework/flux-core#7729.
> These are vendors being motivated to be flux developers so I figured that was probably the right location? …
cmoussa1 commented on issue flux-framework/flux-accounting#556.
Going to close this for now….
cjekel commented on issue cjekel/piecewise_linear_fit_py#134.
@doronbehar should be fixed now…
cbritopacheco commented on issue cbritopacheco/rodin#314.
Superseded by #315. This branch still carried the six commits that #312 squash-merged into develop, so it conflicted with develop
jeremylt commented on issue CEED/libCEED#1988.
Yeah, go ahead and remove the one outside of the init function since it isn’t helping us anymore …
cyrush commented on issue Alpine-DAV/ascent#1742.
Yes, space is tight for static cuda builds – working on a potential fix. …
jeremylt commented on issue 4C-multiphysics/4C#2012.
Fantastic, then the user just needs to get the correct flags sent to Kokkos via building Trilinos correctly. …
tgamblin commented on issue spack/governance#6.
@rbberger yes please update Phil to https://sig.com…
imguoguo commented on issue sipeed/sipeed_wiki#988.
v-dobrev commented on issue mfem/mfem#5406.
Merged in next for testing……
artv3 commented on issue llnl/RAJA#2006.
@llnl/raja-core , is this ready to go? …
tomstitt commented on issue llnl/RAJA#2059.
from an app perspective this looks great! thanks @artv3 !…
samuelkgutierrez commented on issue hpc/quo-vadis#542.
And I guess qv_process_scope_get could become qv_process_get and qv_mpi_scope_get could become qv_mpi_get? This one isn’t as clear to me, however. Open to suggestions here….
eleon commented on issue hpc/quo-vadis#540.
Thanks for asking, @samuelkgutierrez . I prefer CLOSE. Close seems to be a more straightforward concept, while affinity preserving, in my opinion, would require explaining to users (including me) what it means :) …
sam-maloney commented on issue flux-framework/flux-core#7488.
To add the only salient info from my duplicate issue, my log was missing the “got SIGTERM” from rank 1 instead of rank 0, so it could be either order….
jameshcorbett commented on issue flux-framework/flux-coral2#161.
@behlendorf indicated that this issue and https://github.com/flux-framework/flux-coral2/issues/175 are the highest priority right now….
camierjs commented on issue GLVis/data#10.
Is this on top of #9 ? macos-10.15 was not affected then….
jandrej commented on issue EnzymeAD/Enzyme#2948.
updated and removed inactivity list file from history…
hppritcha commented on issue open-mpi/ompi#14171.
oh ignore my comments about Fortran. I forgot we’d already added a sub implementation that had the fortran interfaces….
hppritcha commented on issue open-mpi/mtt#956.
The error that started this problem is likely this based on the error log:…
trws commented on issue flux-framework/flux-sched#1530.
It might, I’d have to look at the modprobe settings. That’s my best bet for the issue cause though, if feasibility stayed loaded then the dependent so would too. Also this would always happen on systems with musl, and there’s no way to fix it there (musl doesn’t actually unload shared objects)….
sam-maloney commented on issue flux-framework/flux-sched#1529.
It’s not making my life particularly difficult, no, but I did find it a bit needlessly confusing if the listed versions aren’t actually indicating real requirements
jameshcorbett commented on issue flux-framework/flux-sched#1530.
I just ran module remove sched-fluxion-qmanager/resource && flux module reload resource && module load sched-fluxion-resource, I didn’t manually touch feasibility at all. I thought removing resource or sched-fluxion-resource would force feasibility to exit?…
sam-maloney commented on issue flux-framework/flux-accounting#885.
Everything seems to be passing well in my latest builds! Many thanks @cmoussa1
tgamblin commented on issue spack/spack#52665.
@haampie ok, caching is disabled for spliced specs, and the traversal logic is simpler. I think this is a decent backport. the diff looks big but some code just moved into a try/finally block. …
wihobbs commented on issue flux-framework/rfc#529.
Ok, that seems to have consensus. Can someone push the approve button? Then I’ll go update my PR to Fluxion….
milroy commented on issue flux-framework/flux-sched#1316.
Thanks for the helpful feedback and improvements @vsoch, @jameshcorbett, and @trws! Setting MWP….
sam-maloney commented on issue flux-framework/flux-pmix#131.
As a follow-up (ideally once #132 is also decided) perhaps a v0.7.1 bugfix release could be triggered to make it easy to package this fix?
…
wihobbs commented on issue flux-framework/rfc#529.
Oh, of the options so far I like sched.selection_type the most. @cmoussa1 @garlick your thoughts?…
trws commented on issue flux-framework/rfc#529.
I’m leaning toward something like your suggestion @grondo, maybe alloc_type or sched_selection_type? That and make the strings the same here and in the PR and I think we’re probably good….
wihobbs commented on issue flux-framework/flux-sched#1528.
I’ll look at #1424, as you point out with this going into the next release it might be good to tackle that as well….
trws commented on issue flux-framework/flux-sched#1528.
That’s a fair point. The advantage to having the reserved boolean tracked here is I think I would need to do the same thing to solve #1424, because we need to know that something was reserved (and thus sent a time estimate) to clear those estimates the next time around. I suppose we could separate them and set “reserved” along with the time estimate but not track that it was reserved at the end? …
JustinPrivitera commented on issue visit-dav/visit#21036.
Hi @marcdurant. I apologize if you have already done this, but I asked codex to have a look at your crash report and comments here and it had a theory about what might be going wrong:…
alecbcs commented on issue spack/spack-packages#4437.
@bernhardkaindl went in and fixed the merge conflicts on the behalf of @dacolombo. …
v-dobrev commented on issue spack/spack-packages#143.
Update: I planning to run some tests with GPU builds and also see if more of the conflicts("^mfem build_system=cmake") are really necessary….
gardner48 commented on issue llnl/sundials#976.
This will depend on the index size selected at configuration time. By default this is a 64-bit signed integer type e.g., int64_t….
JustinPrivitera commented on issue llnl/conduit#1646.
@cyrush can you have a look at this? We discovered that the blueprint transforms can give wrong results if you call them with empty nodes. …
adrienbernede commented on issue llnl/Umpire#1076.
Can’t merge it myself……
artv3 commented on issue llnl/RAJA#2054.
> > Regarding old implementation of atomicGeneric in CUDA is giving incorrect results is that a CUDA related bug? or why is that happening?
…
adayton1 commented on issue llnl/CARE#379.
> If you can get access to a bank (other than guests) on matrix, the best is to define it as the default one. But otherwise, yes, we can easily set the CI to use it in the alloc options (.gitlab/custom-variables.yml). …
adrienbernede commented on issue llnl/CARE#379.
If you can get access to a bank (other than guests) on matrix, the best is to define it as the default one. …
vsoch commented on issue kubeflow/trainer#3712.
Primarily “here is a container or Dockerfile with out app and the command to run it at a small size.” The goal would be to reproduce what you want to do for testing….
milroy commented on issue flux-framework/flux-sched#1316.
> Final review from @trws then merge? …
jameshcorbett commented on issue flux-framework/flux-sched#1316.
Final review from @trws then merge?…
tpatki commented on issue flux-framework/flux-rest-server#3.
No worries, @garlick. The new PR is up….
garlick commented on issue flux-framework/flux-pmix#131.
It was kind of a baddie, and @sam-maloney ‘s excellent issue description made it easy to quickly narrow down. Thanks for the review! I’ll set MWP and ask Sam to confirm the fix when he has a chance….
sam-maloney commented on issue flux-framework/flux-pmix#130.
To add a couple of quick tests running flux pmi:…
chu11 commented on issue flux-framework/flux-core#5083.
I’ve had this on my “to cleanup” list for a long time, but as @grondo says above, what is the best/easiest solution. Using Claude Opus tried to get a gauge on how disruptive a change would be using a number of the suggested paths above:…
grondo commented on issue flux-framework/flux-core#7699.
In a meeting this was actually described as not a real requirement. Rather than try to guess at what solution is really desired here, let’s close this and later open a different issue with clear goals….
jeremylt commented on issue CEED/libCEED#1987.
Note - merging main into your branch instead of rebasing means I’d recommend we squash-merge this PR…
hppritcha commented on issue hpsfoundation/tac#93.
@jwillenbring …
grondo commented on issue flux-framework/rfc#530.
Required by mergify:…
jameshcorbett commented on issue flux-framework/flux-multi-cluster-utilities#29.
While working on this, I ran into another issue, which was that I can’t seem to update the jobspec in the jobtap plugin to have attributes.system.exec.test.override=1 . I’ve been working around this by setting that attribute directly on the jobspec at submission time. @grondo suggested making this edit in flux-core to track down the issue:…
sam-maloney commented on issue flux-framework/flux-core#7677.
I would immediately think that target should only ever be 0 or 1, as otherwise the request would skip over intermediate instances, which feels like a violation of the hierarchical model. Certainly for a shrink/partial release, those resources would have to be removed from the resource set of each instance in the hierarchy in any case, and then you have the more philosophical question of what gives a lower level application/instance the right to determine what its parent/ancestor instances do with their resources. I suppose a user might reasonably want a way to indicate that an application is releasing resources which are no longer needed by its own local instance for further workflow steps, but that would be different from the target proposed here, as the shrink would still need to be dealt with by the local instance first, it would just be guaranteed to be immediately followed by an equivalent job_manager.dyn_alloc_request from the local instance to its immediate parent.
…
cmoussa1 commented on issue flux-framework/flux-accounting#896.
Thanks @jameshcorbett! That is a good question you brought up. This segregation between child banks and users is intentional and is not allowed behavior for a hierarchy in flux-accounting. So, no, banks and users cannot exist under the same parent bank, so I think we should be okay here….
jeremylt commented on issue 4C-multiphysics/4C#2012.
Ah, this was a missing piece …
imguoguo commented on issue sipeed/picoclaw#2251.
@loafoe Hi! Since there’s been no activity after the earlier reminder, I’m closing this Grafana Alertmanager channel PR for now to keep the queue tidy. The work looked solid, so if you’d like to pick it back up, feel free to reopen anytime and we’ll gladly continue the review….
tzanio commented on issue mfem/mfem#5397.
Merged in next for testing……
chu11 commented on issue flux-framework/rfc#528.
> One point that might need clarification: can MODEL_VERSION contain whitespace? …
wihobbs commented on issue flux-framework/flux-core#7716.
Thanks for calling my attention to annotations, which do seem like the right approach. The RFC doesn’t stipulate what happens to a job’s annotations after the job enters the CLEAN state, unless the job fails (they are discarded). Do they persist in the KVS? Or is the way to reference a past job’s annotations through the eventlog?…
sam-maloney commented on issue flux-framework/flux-accounting#885.
@cmoussa1 I haven’t actually run a build since, but once v0.59.0 releases I will rebuild my RPMs and report back here on the outcome!…
jedbrown commented on issue rsmpi/rsmpi#224.
Thank you! Sorry about the delay….
jedbrown commented on issue openjournals/joss-reviews#9333.
The MPI reference @mpi1994standard does not appear in the bibtex file. You might be intending to cite @mpi50. The Ringler 2013 paper above does have a DOI, but is not cited. If it’s not intended to be cited, then the check above can be considered a false positive….
jandrej commented on issue mfem/mfem#5350.
> This is an interesting PR but I think it requires some discussion with the MFEM team at large. One of the basic tenets of the finite element method is that there is one mesh which is subdivided into elements on which we represent our fields. This PR relaxes this requirement for the special case where one mesh is a sub-mesh of another. Another alternative would be to compute bilinear forms on the primary and sub-mesh separately and combine these separate operators into a block system using coupling operators to define the mapping between finite element spaces. …
balos1 commented on issue llnl/sundials#966.
@copilot apply the changes in the diff produced by the failing litgen_check…
markcmiller86 commented on issue llnl/Silo#535.
Working on it. Just fixing a bug in DBCp() when copying between drivers
…
cyrush commented on issue visit-dav/visit#21047.
```…
cjvogl commented on issue pnnl/SPAECIES#52.
@quantheory I’ve rebased this branch off main that has #49 merged in….
v-dobrev commented on issue mfem/mfem#5334.
The diffs in “Files Changed” still show some changes that were already merged in master through PR #5330 – I suspect merging master here will fix that….
bgunnar5 commented on issue llnl/mada-tools#13.
Closing this as #15 will include these files….
cyrush commented on issue llnl/conduit#1642.
This is not a good change, the ownership semantics have to do with how the schema tree is owned, and a simple swap will not work….
tzanio commented on issue mfem/mfem#5393.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
v-dobrev commented on issue mfem/mfem#5259.
Note: I used a rebase + squash to merge the last two commits into next (ignoring the last merge of master into this branch)….
adrienbernede commented on issue llnl/RAJA#2045.
@johnbowen42 OK fixed !…
garlick commented on issue flux-framework/flux-core#7681.
Just pushed a big update that I think addressed all the review comments: …
trws commented on issue GTNewHorizons/CropsNH#189.
Thanks for the reasoning. It’s unfortunate but makes sense, honestly I didn’t even remember that the old version could be used for sand. Great work on making the migration mostly seamless….
becker33 commented on issue spack/spack#52652.
@haampie yes, it is. The reason I want it as a separate flag is because it will need to be the primary avenue for uninstalling specs with circular dependencies, but it seemed separate enough to be a separate PR….
adrienbernede commented on issue llnl/radiuss-spack-configs#187.
@johnbowen42 I invited you to the radiuss group in GitLab so that you automatically get added to subprojects like radiuss-spack-configs and raja mirror repos….
grondo commented on issue flux-framework/flux-core#7701.
Ok, I’ve addressed @chu11’s comments and pushed the result. Will set MWP….
cmoussa1 commented on issue flux-framework/flux-accounting#871.
I’ve rebased to catch up after a number of approved PRs. I know this has already been approved, but I believe that was before we noticed a couple of issues fixed by #880. @grondo, I’m not sure if you would want to give this another a look before I officially merge this! …
garlick commented on issue chaos/nodediag#24.
Thanks!…
jeremylt commented on issue 4C-multiphysics/4C#2012.
The concern about build time makes sense. Though, I was under the impression that we do not currently have CUDA hardware that we can run CI on and OpenMP could be used as a surrogate to ensure shared memory parallelism is covered by CI once it is added in follow up development work?…
cyrush commented on issue visit-dav/visit#21045.
@andymwood thanks for the report….
alecbcs commented on issue spack/spack-packages#5428.
@spackbot run pipeline…
alecbcs commented on issue llnl/repligit#190.
I think I prefer to simplify down to only instantiating the variable for line2 since we only ever use line1 once….
alecbcs commented on issue llnl/radiuss-spack-configs#187.
Haha well this is unintuitive [at]lc-hubcast run pipeline reruns the pipeline on the last commit that was synced. But since this wasn’t synced recently it’s just effectively rerunning the pipeline on the old commit.
…
bgunnar5 commented on issue llnl/mada-tools#13.
@lc-hubcast run pipeline…
bgunnar5 commented on issue llnl/hubcast#355.
@cmelone Ok thanks for the heads up. Any idea how to resolve this? Does this have to do with how my GitLab CI is configured or my Hubcast YAML?…
adayton1 commented on issue llnl/Umpire#1081.
This call now fails with the error below: blt_convert_to_system_includes(TARGET umpire)…
vsoch commented on issue kubeflow/trainer#3427.
@andreyvelich is the user application specifying the entrypoint with mpirun, and the issue is about the environment being discovered for it? If yes, the approach the flux operator takes is to take the application command, and wrap that. In the case of PYTORCH, the problem (I think, if I understand correctly) is that normally there is another layer (the workload manager) like Flux or Slurm that you use to run the job, and its the workload manager that ensures the environment is properly set. If you just expect a TrainJob to be executing a pytorch script, and then have all the envars set (and correct) for leader and launcher, then you are essentially re-implementing a workload manager. …
garlick commented on issue flux-framework/flux-sched#1489.
I’ll go ahead and set MWP since this was already approved. Thanks!…
jedbrown commented on issue RDycore/RDycore#398.
Does temperature converge at second order if you shut off transport?…
cyrush commented on issue Alpine-DAV/ascent#1652.
@emily-howell …
jedbrown commented on issue openjournals/joss-reviews#6099.
The JOSS paper DOI loads now for me. Thanks, all!…
balos1 commented on issue llnl/sundials#973.
@lc-hubcast approve…
vsoch commented on issue kubernetes/enhancements#4671.
Just wanted to say I’ve been developing with this during June using the kind image 1.36.1 (or GKE 1.36.0-gke.2684000) and am so thrilled to see it moving through. This has been a long time coming, from Coscheduling in the scheduler-plugins repository to many other plugins, and (looking at the dates of this issue from 2024) I am so pumped to have this naively! Bring on the gangs, and everything that supports! Awesome work to everyone here!
eleon commented on issue hpc/quo-vadis#104.
Thank you, @samuelkgutierrez . This example brings an interesting semantics consideration. …
jeremylt commented on issue CEED/libCEED#1985.
Ope, I need to update the LIBXSMM hash to use in the gitlab yml…
cjvogl commented on issue mfem/mfem#4244.
Documenting here that I did run the modified ex1p provided above, which runs successfully on this branch while causing an error on master.
…
artv3 commented on issue llnl/RAJA#2006.
> ```c++ …
hppritcha commented on issue open-mpi/ompi#12796.
@mdosanjh are you still working on this? …
grondo commented on issue flux-framework/flux-core#7621.
Great! Already approved so feel free to merge when ready!…
garlick commented on issue flux-framework/flux-core#7621.
OK, just pushed an update with the following changes: …
markcmiller86 commented on issue visit-dav/visit#21034.
Will do…will have to wait ‘til monday though….
v-dobrev commented on issue spack/spack-packages#143.
Hi @jacobmerson, …
tgamblin commented on issue spack/spack#52613.
@haampie: I’ve reworked this to use rsvg, which preserves fonts properly and renders all the figures as a browser would. CI is also updated….
tzanio commented on issue mfem/mfem#5383.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
v-dobrev commented on issue mfem/mfem#5383.
ping: @tomstitt …
artv3 commented on issue mfem/mfem#5382.
@helloworld922 , the RAJA API takes resource objects that can be used to specify the stream, we have examples here: …
adayton1 commented on issue mfem/mfem#5383.
Thank you!…
jameshcorbett commented on issue llnl/scr#614.
Sorry for the delay in getting back to you! Yes we would be interested in working with you on this. I’m not sure yet how complex it would be to support this in SCR but I’d be very happy to investigate with you!…
adayton1 commented on issue llnl/axom#1893.
MFEM is already working on a fix: https://github.com/mfem/mfem/pull/5383…
eleon commented on issue hpc/quo-vadis#486.
Yes, we could calculate the ordinal id from get_dev_id_from_name. …
grondo commented on issue flux-framework/flux-sched#1513.
@kkier and @ryanday36 asked us to bump the priority on this one. We have weekly DATs where queues need to be reconfigured and they need to understand how to avoid this issue when manually moving nodes between queues on the live system….
artv3 commented on issue llnl/RAJA#2009.
> Quick poll @llnl/raja-core , do we want to call it RAJA::mask (
adayton1 commented on issue llnl/RAJA#2009.
Could you update the title of this MR?…
trws commented on issue llnl/RAJA#2006.
Honestly I think it does, at least in as much as when iter + stride is executed we want the result to be of the same type as iter. I suppose it wouldn’t have to be, but if not it would have to be convertible to the type of iter and that seems a bit harder to reason about. Also even if we actually do re-order them based on the sign of the stride, in a logical sense I think of it more like:
…
grondo commented on issue flux-framework/rfc#526.
Thanks! I’ve set MWP….
chu11 commented on issue flux-framework/flux-core#7681.
> Thanks @chu11 - I appreciate the review comments! I’ll start working through those starting with the design doc. …
becker33 commented on issue spack/spack#52602.
Closing this for now because #52603 and #52604 both resolve it without reverting….
cbritopacheco commented on issue cbritopacheco/rodin#302.
Closing: this was an optimization/uniformity change (MatAXPY preassembled-merge fast path + OpenMP buffer hoisting), not a bugfix. The fast path regressed value-Dirichlet assembly on PETSc 3.19 (MatZeroRowsColumns missing-diagonal). Not worth the risk
artv3 commented on issue llnl/RAJAPerf#684.
@michaelmckinsey1 take a look here: https://github.com/llnl/RAJA/blob/develop/benchmark/ltimes.cpp, it would be cool to also have a GPU shared memory version as a tuning! …
tzanio commented on issue mfem/mfem#5358.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
JustinPrivitera commented on issue llnl/conduit#1620.
Closing in lieu of #1627 and #1625…
artv3 commented on issue llnl/RAJAPerf#693.
Nice @michaelmckinsey1 ! What would be neat is to add a batching parameter and allow for different batch sizes, maybe 4 is good GPU X or 7 is good for GPU Y type of thing …
artv3 commented on issue llnl/RAJA#2009.
@llnl/raja-core , building on the comments and suggestions, the latest push explores the following function to be used in RAJA::launch : …
garlick commented on issue flux-framework/flux-core#7681.
Updates: …
grondo commented on issue flux-framework/flux-core#7674.
I’ve set MWP here….
markcmiller86 commented on issue visit-dav/visit#20971.
@cyrush if you a min, pls take a look. Artifact handling follows newest guidance from MS and other changes may reduce (I am still evaluating LFS budget usage reports to be sure) LFS BW usage….
balos1 commented on issue llnl/sundials#961.
@BarrySmith this should fix the issue you were having in #935 …
cyrush commented on issue llnl/conduit#1625.
The simplified templates look good – Note: think we want to keep dispatch with the functor as a just in case. …
cmoussa1 commented on issue flux-framework/flux-accounting#883.
Thanks a bunch for the feedback here @jameshcorbett! Setting MWP here…
cyrush commented on issue Alpine-DAV/ascent#1735.
To test, we can use: …
JustinPrivitera commented on issue visit-dav/visit#19544.
reopening so that we see this since it was marked un-reviewed….
camierjs commented on issue mfem/mfem#5230.
Some failures are hit on GPU with ./pgpu_unit_tests [ParticleSet] triggered by the CHECK(code_N_count == 0); of tests/unit/fem/test_particleset.cpp with expansion: 1 == 0….
trws commented on issue flux-framework/flux-sched#1509.
Yeah, that hardcoded list of subsystems should never have existed. I’ll add it to the list of things to fix for subsystems….
wihobbs commented on issue flux-framework/flux-sched#1502.
> so I guess the docs are not being built by default? …
milroy commented on issue flux-framework/flux-sched#1505.
> In the resource graphs used to repro the issue (e.g. hetchy_jgf_formatted.json) there are many (32 I think?) ssd vertices per chassis, so even if the Fluxion can’t match multiple slots on a single SSD vertex, the job should still match. Am I missing something? …
garlick commented on issue flux-framework/flux-sched#1502.
Nice! Content-wise this seems like a good start. …
chu11 commented on issue flux-framework/flux-core#7668.
haven’t looked at the code yet, but it looks like in this proposal we would be changing the database schema. If we go forward with this general approach, would we like to consider other schema changes while we are at it? I’m mostly thinking of:…
garlick commented on issue chaos/diod#171.
Np! Thanks for the link!…
sam-maloney commented on issue Vanille-N/meander.typ#6.
> if you call par explicitly then the new paragraph splitting logic should be capable of correctly indenting it….
cjekel commented on issue llnl/professor#1.
Looks great! …
adrienbernede commented on issue llnl/CARE#378.
@lc-hubcast run pipeline…
grondo commented on issue flux-framework/rfc#523.
As I commented in flux-framework/flux-core#7615, this won’t work because it would break backwards compatibility: the scheduler and resource modules of subinstances fetch the R key from the parent. This change would break launching a previous version of Flux under the new version….
tpatki commented on issue flux-framework/flux-multi-cluster-utilities#8.
Closing as the other PRs supersede this one….
jameshcorbett commented on issue flux-framework/flux-multi-cluster-utilities#24.
Hmmm, mergify config not yet complete. Will just merge manually while I figure it out….
sam-maloney commented on issue flux-framework/flux-core#7677.
At a basic housekeeping level, eventually the commit messages will have to follow the formatting requirements: https://flux-framework.readthedocs.io/projects/flux-rfc/en/latest/spec_1.html#patch-requirements…
emily-howell commented on issue Alpine-DAV/ascent#1494.
@jfavre I have made a PR #1736 that addresses a bug I found relating to this ticket when trigger actions being passed via ascent_actions.yaml. I wanted to confirm if this is the same bug you encountered here. If not, could you provide more information for me to be able to replicate this bug….
sam-maloney commented on issue spack/spack-packages#5177.
Realized I was missing a colon in the when clause of flux_sched/package.py at L102, because I had copied the previous line which was also missing it :laughing: and there were 2 lines with when="@0.19.0" so I changed the second one to when="@0.20.0" as that seems to make sense with the release dates and the commit when it was added….
adayton1 commented on issue llnl/axom#1885.
Is there a way to iterate over the objects in the variant array without first converting to a vector?…
sam-maloney commented on issue flux-framework/flux-sched#1504.
> Works for me, may need to check the spack package for consistency after this. …
jedbrown commented on issue rsmpi/rsmpi#224.
Thanks, can you add the # Standard section(s) like all the other public functions?
…
tzanio commented on issue mfem/mfem#5352.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
jameshcorbett commented on issue flux-framework/flux-sched#1490.
> @jameshcorbett can comment more specifically, but my understanding is that the flux-coral2 module modifies the jobspec after the feasibility check is already done, so the job gets accepted then the jobspec is modified to contain the rabbit request. If you try that same command with --dry-run you should get the original jobspec….
trws commented on issue flux-framework/flux-sched#1490.
@jameshcorbett can comment more specifically, but my understanding is that the flux-coral2 module modifies the jobspec after the feasibility check is already done, so the job gets accepted then the jobspec is modified to contain the rabbit request. If you try that same command with --dry-run you should get the original jobspec….
grondo commented on issue flux-framework/flux-core#7660.
…
markcmiller86 commented on issue visit-dav/visit#21000.
@brugger1 is this ok now?…
hppritcha commented on issue spack/spack-packages#5169.
i thought these issues were addressed via https://github.com/spack/spack-packages/pull/5148 ….
markcmiller86 commented on issue llnl/H5Z-ZFP#168.
> From my reading it looks like the test is just trying to corrupt a bit of the raw data towards the start of the dataset’s data (now the first chunk in this case)? If so, this looks fine to me. …
grondo commented on issue flux-framework/rfc#521.
Sure. I had considered doing that but figured someone looking a job eventlog might naturally think to look at the “Job States and Events” RFC. I didn’t see anywhere mentioned that this was the job manager RFC. Easy enough to add a new RFC….
garlick commented on issue flux-framework/rfc#521.
I’m surprised we haven’t done this already! …
milroy commented on issue flux-framework/flux-sched#1503.
> In v0.51.0 the jobspec matches with firstnodex….
cjvogl commented on issue mfem/mfem#4905.
Closing this PR in lieu of #5362 that will include all the reconstruction work here alongside the SAMRAI-MFEM coupling work….
gardner48 commented on issue llnl/sundials#957.
When using an implicit method with the default nonlinear solver (Newton’s method) you need to create and attach a linear solver before evolving the problem in time. The lines starting here in the ark_analytic.c example show how to do this for a dense linear solver (and matrix). There should be a runtime error in this case, but it seems there is a missing check….
jeremylt commented on issue jeremylt/personal_website#3.
I need to read the Leiden Declaration and see if it applies here…
wihobbs commented on issue flux-framework/flux-sched#1493.
I want to look into that failure, so removing MWP for now….
sam-maloney commented on issue flux-framework/flux-sched#1501.
> If we require >= flux-core v0.78.0, then we could drop the old rc1 style scripts in etc/. In fact, there could be an implicit dependency on modprobe for the sched-fluxion-feasibility module already….
garlick commented on issue flux-framework/flux-core#7467.
It might actually be better to just add a FLUX_MSGGFLAG_COMPOUND flag to indicate that the payload is compound (steal FLUX_MSGFLAG_USER1), and rather than requiring JSONL, use size prefixed segments. Then a message could contain multiple raw payloads, which could potentially avoid base64 encoding in KVS commit messages, and allow batching of content load/store payloads….
cbritopacheco commented on issue cbritopacheco/rodin#294.
@copilot resolve the merge conflicts in this pull request…
jeremylt commented on issue CEED/libCEED#1982.
hmm, this should be compared to the operator application kernel to make sure we are not breaking HipStar support …
hppritcha commented on issue open-mpi/ompi#13956.
Yes I do agree….
samuelkgutierrez commented on issue hpc/quo-vadis#467.
From today’s meeting with Guillaume….
cmoussa1 commented on issue flux-framework/flux-accounting#872.
Thanks @jameshcorbett! These were all great suggestions. I’ve gone ahead and force-pushed up some changes to this PR based on your feedback. I will set MWP here shortly…
hppritcha commented on issue eschnett/mpif#1.
I will set up a poll and invite some folks so we can set up a good time for a call….
alecbcs commented on issue spack/spack-packages#5104.
@spackbot run pipeline…
hppritcha commented on issue open-mpi/ompi-www#563.
@edgargabriel oops forgot to add this file…
alecbcs commented on issue llnl/hubcast-test#6.
@lc-hubcast help…
artv3 commented on issue llnl/camp#205.
Used internally: https://github.com/llnl/camp/blob/56b194f3ea3d0e9d6e2f236de39a4886063e4968/include/camp/resource/hip.hpp#L187C5-L187C37 …
adayton1 commented on issue llnl/Umpire#1072.
> Update: Hubcast doesn’t understand jobs that are allowed to fail. We can either fix the job failure or try to fix within Hubcast somehow.. stay tuned …
artv3 commented on issue llnl/RAJA#2010.
Closing PR until next release…
becker33 commented on issue spack/spack#52492.
I think we should actually hold off on merging these until we’re done with major backports to the 1.2 release branch. Even though we’ve cut the branch already, I don’t want to make backports any harder than they need to be between now and the release, and this one is more minor but this project as a whole touches a ton of files….
hppritcha commented on issue open-mpi/ompi-scripts#95.
never mind this still needs some work….
jeremylt commented on issue libxsmm/libxsmm#855.
Understood …
wihobbs commented on issue flux-framework/flux-core#6952.
I think @grondo and I have accomplished everything scoped here. Closing
tzanio commented on issue mfem/mfem#5019.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
vsoch commented on issue kubeflow/trainer#3179.
@roberthluo the MPI test uses a wantinfo object to do comparison. The current flux tests do not. Here is the initial discussion:…
v-dobrev commented on issue mfem/mfem#5346.
Hi @nmnobre, @najlkin, @tzanio, @helloworld922, …
garlick commented on issue flux-framework/flux-core#7659.
Oh, maybe I was looking at the same failure b/c mergify just merged this! NM….
jeremylt commented on issue CEED/libCEED#1980.
Ah the correct fix is probably to update the libCEED hash PETSc is using …
vsoch commented on issue urlstechie/urlchecker-python#95.
Spam…
alecbcs commented on issue spack/spack-packages#5083.
Cool! Let’s just make sure we document that variable and alternatively script modifications for the release notes….
becker33 commented on issue spack/spack#52492.
@haampie yes that was my plan…
tgamblin commented on issue spack/spack#52397.
Agree! We are working on revamping the site – see what you think of https://id-preview–a538ff6f-a974-428e-b9b8-9b6a19dda20c.lovable.app (note that this is valid for only 7 days) which is a preview of how we think the site will eventually work….
jandrej commented on issue mfem/mfem#5338.
I wrapped up the changes in #5232 and waiting for reviews. I’ll keep this open until the other PR is merged….
jameshcorbett commented on issue flux-framework/flux-sched#1490.
Anecdotally, the error seems to occur when a user requests more nodes than there are rabbits in the system. The --coral2-chassis flag may help reduce the error rate by constraining node placements to fewer chassis. The error seems to have occurred around the time we switched clusters to using the firstnodex match policy….
chu11 commented on issue flux-framework/flux-core#7656.
> This is why I’d suggested a few “safe” tests get ci=asan markers or something like ci=system. …
hppritcha commented on issue open-mpi/ompi-www#559.
@edgargabriel ping…
hppritcha commented on issue open-mpi/ompi#13598.
i’d say this is worth a try. anyway it looks like coverity has gone on an extended vacation. maybe codeql could provide some of the capabilities that we used to get with coverity?…
cjvogl commented on issue mfem/mfem#4244.
> Regarding testing, it is easy in the way the bug appears at many places
adrienbernede commented on issue llnl/radiuss-spack-configs#176.
@kab163 @adayton1 Thank you for that. Replacing was the right move….
garlick commented on issue flux-framework/flux-sched#1497.
Just pushed the change to select the reader using hints from R.scheduling.writer. It looks like only rv1exec (no schedluing key) actually works with partial cancel presently - fine for now since that’s what the job manager will generate….
jameshcorbett commented on issue flux-framework/flux-multi-cluster-utilities#22.
Another example would be a timeout exception. If the job times out, we definitely shouldn’t retry. Otherwise we wouldn’t be respecting the time limit restrictions placed on the job….
cmoussa1 commented on issue flux-framework/flux-accounting#878.
I’ve rebased this to catch up after #880 - I’ll go ahead and set MWP here. Thanks again for reviewing this @jameshcorbett! …
cyrush commented on issue visit-dav/visit#20972.
@biagas thanks for confirming!…
gardner48 commented on issue llnl/sundials#884.
> I think we can change the minimum back to 3.8. I had bumped it to match sundials4py but I dont think we are using anything from 3.12 in these scripts. …
adrienbernede commented on issue llnl/radiuss-shared-ci#67.
@davidbeckingsale This is ready. See it work in Umpire: https://github.com/llnl/Umpire/pull/1050…
trws commented on issue flux-framework/flux-sched#1489.
> Also, I happened to notice b60e200 by @zekemorton which makes me question my choice to have these new functions use UP|DOWN strings instead of the enum. Which do sched developers prefer? My thinking that using the enum was unnecessarily exposing an internal data structure and that it would be easy to add another state (like DEGRADED or similar) as a string without breaking the API, but the enum is nicer to work with a Zeke points out in the commit message. …
sam-maloney commented on issue flux-framework/flux-core#7643.
Otherwise, I’ve added the check-executables-have-shebangs pre-commit-hook and updated the config (and fixed a few additional files that the hook then flagged :grin:), so perhaps @grondo you could have a quick double-check!…
wihobbs commented on issue flux-framework/flux-core#7354.
Completed by #7506 …
wihobbs commented on issue flux-framework/flux-coral2#486.
If we get rid of this here, we need to add it back in ansible (note my comment in #478)…
chu11 commented on issue chaos/powerman#217.
@mergifyio rebase…
imguoguo commented on issue BeaconCat/Pharos#1.
## Root cause references…
tzanio commented on issue mfem/mfem#5349.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
gardner48 commented on issue llnl/sundials#887.
Superseded by #946…
jedbrown commented on issue jeremylt/LFAToolkit.jl#94.
With the multi-element patches, we would like the ability to do heterogenous patches with standard LFA (see Kumar, Rodrigo, Gaspar, Oosterlee 2019)….
grondo commented on issue flux-framework/rfc#519.
While working on the implementation for the external helper, I realized that the current spec for the Device Containment options to the IMP was incorrect. I’ve added a commit here that corrects the section to describe what is currently in use. That could use a review. …
gardner48 commented on issue erf-model/ERF#3232.
The changes look good but two tests are now failing on one of our AMD systems with this branch: …
markcmiller86 commented on issue betterscientificsoftware/bssw.io#2541.
We also support cases where there is not viable URL for a citation but there is full bibliographic detail available. That just means that there is no off-article link for the item in the References block….
cyrush commented on issue Alpine-DAV/ascent#1692.
@nicolemarsaglia thanks for resolving that last puzzle!…
cyrush commented on issue visit-dav/visit#19544.
removing reviewed b/c user reports seeing this on El Cap with 3.5.0, from linux using x11 forwarding (not sure if using x11 or wayland)…
vsoch commented on issue oras-project/oras-py#240.
@jiwangCHEN push and pull interfaces should not go away. A push or pull is a directional copy. There should be no breaking changes in changing the underlying structure to use copy….
wihobbs commented on issue flux-framework/flux-sched#1490.
It’s more stable (I’ve yet to see a rabbit allocation fail with that flag in there.) When James gets back next week we can dissect why, but for now, I think our stock advice is to allocate chassis along with any rabbit job….
garlick commented on issue flux-framework/flux-sched#1489.
reapi.hpp was updated to include prototypes for the (string based) generic status get/set functions, with inline docs….
milroy commented on issue flux-framework/flux-sched#1467.
I’ve verified that the errno contract violation fixes in @garlick’s PR’s #1483 and #1484 obviate the first commit in this PR. I’m dropping it.
…
grondo commented on issue flux-framework/flux-core#7644.
@kkier suggested setting allow_abbrev=False for argparse which would help in this specific case. However, the behavior we want from argparse is the POSIX behavior where option processing stops at the first non-option argument (See POSIXLY_CORRECT in getopt_long(3)). I haven’t looked in awhile, but last I checked the argparse maintainers were unwilling to implement that behavior….
garlick commented on issue flux-framework/flux-core#7644.
Thanks for reporting this!…
chu11 commented on issue flux-framework/flux-core#7594.
hmmm seems like “system,coverage” builder is failing. At first I thought it was just not-perfect coverage. Perhaps a system test I missed that could be affected this PR’s change. Unfortunately builder logs not most obvious on the issue, but hopefully a container will figure this out quick. Edit: oops, now I see a log file, seems like t9000 tests with 0007-fsck.t failing.
…
cmoussa1 commented on issue flux-framework/flux-accounting#875.
Thanks @grondo! I’ve gone ahead and force-pushed up a fix to add a comment to accounting.hpp for those overloaded functions to explain their subtle difference from the others. I’ll go ahead and set MWP here shortly…
garlick commented on issue chaos/powerman#216.
Looking good here so let’s merge. Thank you for running this down and for your excellent commit message! Let’s merge….
jeremylt commented on issue CEED/libCEED#1977.
@zatkins-dev this is purely a cleanup, no functional changes, but if you aren’t familiar with what’s happening inside of this file, it’s an interesting file to poke around in…
jandrej commented on issue zed-industries/zed#57703.
Same issue here, not sure if intended behavior….
cyrush commented on issue spack/spack-packages#5005.
Thanks for merging!…
hppritcha commented on issue open-mpi/ompi-tests-public#38.
hmmm please run copilot against this and see what it thinks….
hppritcha commented on issue open-mpi/ompi#13883.
@janjust is this ready to merge?…
balos1 commented on issue llnl/sundials#937.
@xcartoixa This should be fixed by #944. …
vsoch commented on issue converged-computing/resource-secretary#6.
Awesome! I will test this soon….
emily-howell commented on issue Alpine-DAV/ascent#1682.
Merged in #1676 and #1663 and changed this branch to merge into develop. @cyrush It should be ready to merge in but if you have any feedback about the error messages I can absolutely make additional changes :)…
JustinPrivitera commented on issue llnl/conduit#1358.
TODO add a new macro for cuda + hip + umpire == CONDUIT_USE_DEVICE…
trws commented on issue flux-framework/flux-sched#1467.
I think this is good to go, something you want to do before MWP @milroy?…
jedbrown commented on issue CEED/libCEED#1813.
I added change notes and I’m happy now….
benzwick commented on issue A2B-Technology-Corporation/Talk2View-Writer#10.
Future hard-enforcement (engine-side minimum client version) tracked in A2B-Technology-Corporation/Talk2View-Platform#72….
jedbrown commented on issue blas-lapack-rs/blis-src#13.
Is there a release that contains the fix? It looks like that report came after BLIS-2.0. Have you thought about a recommended fix for blis-src?…
tgamblin commented on issue EPCCed/cirrus-ex-spack#44.
See also https://github.com/spack/spack/pull/51891…
jedbrown commented on issue rsmpi/rsmpi#222.
Thanks; I merged #223 because it was more complete. Sorry about the slow response….
tzanio commented on issue mfem/mfem#5340.
@maxpaik16, is this ready-for-review (see the contributing guidelines)?…
garlick commented on issue flux-framework/flux-sched#1481.
Now based on top of …
jameshcorbett commented on issue flux-framework/flux-sched#1372.
The jobspec-update events look the same? I’m on my phone but am I missing something?…
hppritcha commented on issue open-mpi/ompi#13911.
looks like there’s a failure making the tarballs for main and v6.0.x owing to some changes to the way docs are generated….
gardner48 commented on issue llnl/sundials#938.
The different versioning is a historical holdover from CVODE, IDA, and KINSOL predating SUNDIALS then IDAS and ARKODE getting added later. The versions have all been updated in lockstep with the SUNDIALS version for a while now, so moving to a single version number for everything would be reasonable. …
balos1 commented on issue llnl/sundials#938.
Should we consider just syncing up the IDAS and ARKDOE versions with the rest of SUNDIALS? I see no real advantage of having them differ. …
alecbcs commented on issue llnl/hubcast-test#5.
@lc-hubcast help…
trws commented on issue llnl/camp#199.
Wow, that’s clearly a mistake on my part. Would you like to put that up as a PR so you get credit for it?…
trws commented on issue flux-framework/flux-sched#1467.
> I also expect we will need to consider how units are represented to avoid string comparisons…
milroy commented on issue flux-framework/flux-sched#1483.
> P.s. there are more of this type of problem in the planner code. …
wihobbs commented on issue flux-framework/flux-core#7586.
Oops. I think this will do it: …
grondo commented on issue flux-framework/flux-core#7586.
Hm, getting these errors when this branch was merged to master: …
chu11 commented on issue flux-framework/flux-core#7622.
thanks, will set MWP…
gardner48 commented on issue dealii/dealii#19729.
@bangerth thanks for bringing this to our attention. @vovannikov sorry for the confusion, llnl/sundials#938 should make this clearer. …
jeremylt commented on issue CEED/libCEED#1970.
uggggghhhhhh…
JustinPrivitera commented on issue visit-dav/visit#20959.
> As a reminder, most of the changes here were reviewed in smaller chunks as PRs for merge into this branch. …
markcmiller86 commented on issue visit-dav/visit#20961.
@biagas I have tested this locally and with this invokation of build_visit
…
cyrush commented on issue llnl/conduit#1607.
I created a glob match util and remove refactored to use it….
adrienbernede commented on issue llnl/Umpire#1049.
@davidbeckingsale I fixed the ordering issue by redirecting stderr to stdout for the build_and_test script. …
wihobbs commented on issue flux-framework/flux-coral2#478.
> At scale we’re going to want to make sure we’re not seeing requests timing out or similar problems….
markcmiller86 commented on issue betterscientificsoftware/bssw.io#2531.
FYI…I have no expectations regarding WHEN this gets published. Just wanted to get it ready to publish for whenever makes sense. I did enter today’s date into the .md file though….
jandrej commented on issue mfem/mfem#5338.
Sidenote: there is a PR https://github.com/mfem/mfem/pull/5232 which introduces generic sizing….
jameshcorbett commented on issue flux-framework/flux-coral2#478.
Old issue for this is #166. PR to run nnf-clientmount continuously is #486….
tomstitt commented on issue mfem/mfem#5309.
> > I will update when I know more. …
tgamblin commented on issue hpsfoundation/tac#72.
Linked and updated above. @slandath we should probably also link the proposals when we make these review issues….
vsoch commented on issue kubeflow/trainer#3312.
Thank you, @Raakshass. For a heads up, I will be out and back later this coming week. …
tzanio commented on issue mfem/mfem#5329.
Merged in next for testing……
BradWhitlock commented on issue llnl/axom#1866.
The failures on dane are the same as I was seeing in my PR. I’m testing whether PR #1868 fixes them….
milroy commented on issue flux-framework/flux-sched#1467.
I added some commits to address the overbooking issue @jameshcorbett identified and have fixed it on all platforms but EL8. It appears that EL8 is exhibiting different match-allocate behavior than the other test platforms. …
markcmiller86 commented on issue visit-dav/visit#20936.
Hello @visit-dav/visit-core-team, does anyone have time to review? Feel free to ask questions….
tgamblin commented on issue spack/spack-packages#4829.
Isn’t 1.0 the version of the current compiler wrapper in Spack? I guess if this is the same as the current version it’s fine. Labeling this 1.1 or something would make a clear break and would make it easier to run, e.g., spack find compiler-wrapper@1.1: to find only the ones from github.
…
tgamblin commented on issue spack/packages.spack.io#37.
Resolved by #43…
alecbcs commented on issue llnl/hubcast#301.
Closing in favor of #312 …
cyrush commented on issue llnl/conduit#1607.
TODO: Test cases are WIP, need to add many more: …
markcmiller86 commented on issue llnl/Silo#552.
FYI…use 4.12.1-pre2 release assets. The release assets in 4.12.1-pre1 are bloated due to inclusion of ghpages subdir (for silo.llnl.gov website) which includes all prior .tar.gz releases….
jeremylt commented on issue libxsmm/libxsmm#855.
Is libxsmm moving away from making any more releases? While that would not be my preference, it would be handy to know if that is libxsmm’s plan so I can point our users at a specific commit hash as the dependency version instead of a version number…
jameshcorbett commented on issue flux-framework/flux-sched#1467.
If the overallocation issue I mentioned can be fixed I think this would be a huge step forward for the rabbits. However, there is a further step for the rabbits which I don’t think the PR addresses, which is fine, I just want to make sure that it’s known. …
trws commented on issue flux-framework/flux-sched#1467.
Ok, was that the source of the el8 failure or is that looking like a heisenbug?…
grondo commented on issue flux-framework/flux-core#7623.
Nothing obvious for rc3 from a login node in dry-run mode, just attr.get, config.get and module.list as expected (the of course the module.remove calls.)…
garlick commented on issue flux-framework/flux-core#7623.
Was it stuck after the last log entry there? (on “unload builtins”)?…
markcmiller86 commented on issue HDFGroup/hdf5#6153.
Just curious but where is it written or decided that for ZFP, rate=3.5, precision=16 is or should be considered an error? I mean, based on what I know about ZFP, it certainly seems like you can ask for one or the other but not both. …
cyrush commented on issue visit-dav/visit-website#21.
Resolves: https://github.com/visit-dav/visit/issues/20954…
jedbrown commented on issue openjournals/joss-reviews#9576.
Sorry to have missed this. I’m pretty underwater at the moment, but would be available late next month. …
v-dobrev commented on issue mfem/mfem#5316.
Merged in next for testing……
garlick commented on issue flux-framework/flux-sched#1481.
Please hold off on reviewing this - I’m redoing a few things after making a first pass on a pool class….
cmoussa1 commented on issue flux-framework/flux-accounting#869.
Thanks for reviewing @jameshcorbett! I’ve addressed your great suggestions above and force-pushed. I’ll set MWP here…
artv3 commented on issue llnl/RAJA#1857.
> @artv3 do we want to target this for our summer release? …
mplegendre commented on issue llnl/Spindle#177.
I addressed the identified issues. …
trws commented on issue flux-framework/flux-docs#323.
The question really needs to go to legal. Technically all of our docs are licensed under LGPL3 because of the release process for flux as a whole. If they don’t object to re-licensing the docs as CC then I don’t think any of us object either, but it’s lab legal we have to ensure is alright with it. …
becker33 commented on issue spack/spack-packages#3968.
I believe it is #52029…
hppritcha commented on issue spack/spack-packages#4804.
okay in that event use the patch you selected. it should probably be applied to all builds out of the 5.0.x release stream….
dylan-copeland commented on issue mfem/mfem#5054.
@IdoAkkerman since I already approved this PR, should we move forward with merging it? If so, we can request review again from someone else….
vsoch commented on issue yoonho/flux-qrmi#2.
Understood, thank you @ohtanim….
vsoch commented on issue singularityhub/shpc-registry#480.
I do think if we used the docker api proper (instead of falling back to my lazy approach) we might get more fine tuned control of the requests. That direction sounds good to me!…
tzanio commented on issue mfem/mfem#5124.
Merged in next for testing……
BradWhitlock commented on issue llnl/axom#1860.
I’m pursuing an idea I had about reusing the MatsetView types to traverse the mixed field data since their representation changes depending on the structure of the matset….
vsoch commented on issue flux-framework/flux-core#7606.
Excellent - looks good! …
grondo commented on issue flux-framework/flux-core#7606.
Should be fixed now: flux-framework/flux-sched#1480…
chu11 commented on issue flux-framework/flux-core#7594.
just re-pushed, handling many of the corner cases that existed in the initial work. removing WIP …
JustinPrivitera commented on issue visit-dav/visit#20950.
venn should be robust to that case: https://github.com/llnl/conduit/issues/1600…
BradWhitlock commented on issue visit-dav/visit#20950.
I think the empty “background” material is the problem, which came from calling venn() with radius 5. It turns out a more suitable value is something like 0.25. Still, it exposes bug dealing with bad data….
alecbcs commented on issue spack/spack-packages#4550.
@spackbot run pipeline…
becker33 commented on issue spack/spack#52062.
```…
uvilla commented on issue pecos/tps#325.
A possibility cleaner way is warning suppression in valgrind. …
hppritcha commented on issue open-mpi/ompi#13847.
related to #13879 …
JustinPrivitera commented on issue llnl/conduit#1601.
We could also have a table of contents at the top like we did for the X Ray Image Query: https://visit-sphinx-github-user-manual.readthedocs.io/en/develop/using_visit/Quantitative/XRayImageQuery.html…
jedbrown commented on issue OSGeo/gdal#14500.
> As long as you put part of the book in the input prompt. …
jeremylt commented on issue CEED/libCEED#1963.
Checked CI locally - happy to merge if you want me to
…
cyrush commented on issue visit-dav/visit#20946.
I am not sure how robust this is b/c we dont test it….
becker33 commented on issue spack/spack-packages#4652.
@climbfuji can you try to create a more human-readable PR title in the future?…
tgamblin commented on issue spack/spack#52137.
Closing this until we can revisit it as an additional configuration option to control what failures are acceptable. We may also revisit making a 404 on URL fetch acceptable, but this is not critical for CI since GitLab’s reliability has been improved….
alecbcs commented on issue llnl/hubcast-test#5.
@lc-hubcast help…
imguoguo commented on issue imguoguo/Comments#38.
> @fktoday…
trws commented on issue flux-framework/flux-sched#1477.
sigh…
trws commented on issue flux-framework/flux-core#7608.
Maybe rhel9 or 10 equivalent for the TOSS connection? Otherwise I’d probably default to whatever the current Ubuntu LTS is….
jameshcorbett commented on issue flux-framework/flux-core#7591.
> > FWIW, after messing around for a while, the best thing I could come up with to remove a hard dependency on ply was to move the ply imports from the top of modules into the bodies of every function or method that uses it. :( …
cmoussa1 commented on issue flux-framework/flux-accounting#858.
OK, so I’ve been messing around with a redesign for the better part of a week now and I think I’ve actually been able to get somewhere significant. The overhaul has been quite a lot of work thinking about a) how to make previously-hard-coded parameters configurable and extensible, and b) how to update an already-existing flux-accounting database to adopt the new design….
vsoch commented on issue llnl/cardioid#17.
Thanks! This is more than 3 years old and we finished and published the work. Closing….
samuelkgutierrez commented on issue hpc/quo-vadis#452.
qv_scope_split() is more expressive because it has an npieces parameter that split_at() does not….
garlick commented on issue flux-framework/flux-core#7605.
```…
vsoch commented on issue cosimameyer/awesome-pyladies-creations#112.
Yes of course! Thank you for the showcase!
adrienbernede commented on issue llnl/radiuss-shared-ci#76.
In facts, I have mixed feelings: from the components perspective, I like how everything is explicitly stated in the inputs. But in the underlying setup, the perf processing job extends caliper to github, which extends convert to github, which itself has not script because the script should be specified by the user… But again, the components inputs makes the requirements clear….
tomstitt commented on issue mfem/mfem#5309.
While I was trying to make a standalone reproducer I found that hipsparseSpMV_preprocess is not always needed, you can make a basic driver that works without it. I’m not sure yet if it’s the structure of our matrices, something about the function call ordering, or something else. I will update when I know more.
…
milroy commented on issue flux-framework/flux-sched#1466.
> We are maybe trying to get https://github.com/flux-framework/flux-sched/pull/1465 in as well @milroy ? …
tzanio commented on issue mfem/mfem#5230.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
cyrush commented on issue visit-dav/visit#20944.
Thanks for sharing, this pretty crazy that the compiler / system headers may be incompatible with the system standard libs. …
alecbcs commented on issue spack/spack-packages#4545.
@spackbot run pipeline…
tgamblin commented on issue spack/spack#52205.
I also like deprecated() over deprecated=True, for the cases above. How, though, would you handle the mappings in #52112? I suppose you could still have an optional replaecment:…
hppritcha commented on issue open-mpi/ompi#12458.
Should we keep this PR open?…
v-dobrev commented on issue mfem/mfem#5306.
Re-merged in next for testing……
cyrush commented on issue llnl/conduit#1594.
@Arlie-Capps let me know if these fixes resolve the fmt issues you encountered…
trws commented on issue flux-framework/flux-sched#1449.
Same, that’s the normal way we do it in testing and everywhere else. All I can think is maybe we have a race between the hello protocol and the free event for the job. I’m trying to work out how to test it reliably, but it’s a tricky thing to pin down….
grondo commented on issue flux-framework/flux-core#7589.
Well, the obvious thing to do is to add a configuration flag to the job-list module that puts it in private mode, effectively adding and user:<requestor> to the constraints used to generate responses. Do you know if private-mode should also secure job-list.job-stats so guest users can’t see the general job stats? (shows counts of all jobs in all states) My guess is yes….
garlick commented on issue flux-framework/flux-core#7500.
As I’m working through a subclassing experiment I’m realizing this doesn’t quite solve the problem. I’ll close this PR for now and open some more once the design is solid….
trws commented on issue flux-framework/flux-coral2#473.
Ok, we could move it to a resolved state on the board or similar I guess. …
cmoussa1 commented on issue flux-framework/flux-accounting#863.
Looks good to me! Thanks bot…
JustinPrivitera commented on issue llnl/conduit#1111.
#1593…
markcmiller86 commented on issue llnl/Silo#535.
> Do you have a rough guess on when there will be a tagged release that incorporates this fix?…
artv3 commented on issue llnl/RAJA#2021.
> > > I am concerned that people will use this without knowing that its doing expensive div/mod calculations and see that it performs more poorly than a native cuda/hip 2d or 3d kernel. Would it make sense to have policies that allow mapping to 2d or 3d kernels. …
tomstitt commented on issue llnl/RAJA#2021.
> > I am concerned that people will use this without knowing that its doing expensive div/mod calculations and see that it performs more poorly than a native cuda/hip 2d or 3d kernel. Would it make sense to have policies that allow mapping to 2d or 3d kernels….
imguoguo commented on issue imguoguo/picoclaw_docs#1.
/fix
garlick commented on issue flux-framework/flux-sched#1449.
> Could there be a race condition though that something isn’t ready yet for the next module to be loaded?…
wihobbs commented on issue flux-framework/flux-sched#1468.
I think I meant to say jgf_shorthand. jgf needs to be documented too……
milroy commented on issue flux-framework/flux-sched#1465.
I mistakenly created a branch on flux-sched rather than my fork. I’m deleting this PR and will open one with the changes made against my fork of flux-sched….
wihobbs commented on issue flux-framework/flux-core#7252.
>I guess you get the honor of fixing one last merge conflict in t/Makefile.am …
chu11 commented on issue flux-framework/flux-core#7590.
hmmm but…
jameshcorbett commented on issue flux-framework/flux-coral2#473.
I’m not sure we should close this, but maybe we should remove it from the sprint or somehow mark it as low priority. If users/admins ever start using lots of space in persistent storages, this issue would bite us again, and we’d want a way to update the vertex sizes dynamically….
jeremylt commented on issue CEED/libCEED#1951.
Style fix requested by CI: …
JustinPrivitera commented on issue visit-dav/visit#20943.
From @markcmiller86 …
becker33 commented on issue spack/spack-packages#2165.
In the long run we need to make this file properly versioned in its own repo, but I don’t think that’s a change to enforce on this PR….
jameshcorbett commented on issue flux-framework/flux-sched#1449.
This happened again on elcap. Coincidentally (?) it was also a 64-node job. I once again could not find anything related to the job ID in f58 or decimal encodings in journalctl, and the eventlog for the job (and also for the previous job this happened to) looked normal and sensible. …
gardner48 commented on issue erf-model/ERF#3138.
#3134 changed query to get because one input file had a typo in the prefix (tert.prob_name instead of erf.prob_name) and others files were missing the problem name both of which led to unexpected results. Throwing an error would have helped catch this sooner. It also looks like an unknown problem name could cause similar issues but catching that would require validating the input problem name.
…
artv3 commented on issue llnl/RAJAPerf#656.
To compare compiler performance consider putting together a ratio plot between a base compiler …
jandrej commented on issue mfem/mfem#5272.
Thank you! I was just checking in, no rush….
markcmiller86 commented on issue mfem/mfem#5318.
Is the phrase “PR authors” intended to imply human-in-the-loop (human gatekeeper)? If so maybe “human PR authors” would make that a little clearer….
adayton1 commented on issue llnl/axom#1846.
> I think we may not want to use that flag as it is “experimental”. That is, if we can remove the host/device qualifiers on constexpr methods altogether. The compilers should be smart enough to do the right things for those….
jedbrown commented on issue CSStipendRankings/CSStipendRankings#89.
Not sure what Claude has to do with this. I hope it isn’t being treated as an epistemic authority on which universities charge a fee. As documented previously, the size of the fee can vary widely (though my institution isn’t as shamefully bad as it once was). Anyway, thanks for adding the tag….
jedbrown commented on issue openjournals/joss-reviews#7716.
Hi @abaer-kit, I see that some of the issues on your repository that were opened via this review are still open. Could you determine if they are complete and close if so? And let us know if there is anything you understand remains to be addressed?…
btalamini commented on issue llnl/smith#1585.
@white238 and @tupek2 , I modified this. Would you review again? …
markcmiller86 commented on issue llnl/Silo#543.
FYI…in #548, I did fix the issue on main your experience alerted me to and I mentioned above….
grondo commented on issue flux-framework/flux-core#7550.
This could be solved by the mapper introduced in #7566, since it is able to set or adjust arbitrary systemd properties per job, and has access to the locally assigned resources. As a first cut, the default HwlocMapper could scale MemoryMax by the ratio of cores allocated to the job vs available cores, e.g. if MemoryMax=98% in the config, and a job is assigned half the cores, the mapper could return MemoryMax=49%. …
garlick commented on issue flux-framework/flux-core#7568.
Ok, on reflection, your instincts are I think correct. I’ll move the “normalization”, the standard device list, etc (basically what systemd does) over to flux-security and leave the helper with a simpler job: fetch properties, set options….
cbritopacheco commented on issue cbritopacheco/rodin#244.
@copilot …
jeremylt commented on issue CEED/libCEED#1951.
This is looking pretty good. Did you want to take a try at adding this to the CUDA ref backend?…
markcmiller86 commented on issue visit-dav/visit#20934.
Just curious if this general section on File Locations might address some of the concern and whether this specific secrtion on debug logs address specific questions about that….
alecbcs commented on issue spack/spack-packages#4373.
Hi all, this PR should now be ready for a final review and merge. The secrets have been created in the repository and AWS has been configured for OIDC authentication with GitHub….
v-dobrev commented on issue mfem/mfem#5312.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
dylan-copeland commented on issue mfem/mfem#5313.
As @v-dobrev mentioned, mesh-explorer has features to help refine (uniformly) and convert the mesh. If you would like more control over refinement, Mesh::KnotInsert gives you complete control over the number of elements and their spacing, for each KnotVector. If you would like to use lower than 4th-order, it would be best to refine the mesh fully with order 4 and then convert to lower order (e.g. mesh-explorer option ‘c’)….
adrienbernede commented on issue llnl/radiuss-spack-configs#165.
@tdrwenski to “fix” that failing job, first trigger the Dane alloc job, then the Dane spack job and then the reindex job – possibly several times – until it passes…
alecbcs commented on issue llnl/hubcast-test#4.
@lc-hubcast approve…
JustinPrivitera commented on issue llnl/conduit#1585.
This will be helpful for Ascent integration work Nicole is working on….
vsoch commented on issue kubeflow/trainer#3312.
Thanks for the ping @andreyvelich ! …
garlick commented on issue flux-framework/flux-sched#1461.
“Very useful or at least harmless” falls short of the justification needed to bypass our normal test/soak cycles IMO. It should be “Fixes a critical problem observed in production”. …
wihobbs commented on issue flux-framework/flux-core#7537.
Any amount of sharness testing under ASAN is better than none at all; thanks for pushing on this @chu11!…
chu11 commented on issue flux-framework/flux-core#7537.
> Perhaps one consideration is that under ASAN, we just run some subset of sharness tests. At some point, we perhaps accept that some tests are just weird and kooky enough that it’s unrealistic we can get everything working under ASAN without heroic efforts or obscene workarounds….
vsoch commented on issue singularityhub/singularity.lang#12.
That’s alright! Have you tested and confirmed this works as you would like?…
trws commented on issue flux-framework/flux-sched#1454.
Are the tests added in t: add tests for storage_node in request_feasible still relevant?…
garlick commented on issue flux-framework/flux-coral2#478.
> One additional concern is the added load these daemons will place on the k8s infrastructure when they’re always running….
trws commented on issue flux-framework/flux-coral2#478.
So after tuning it’s 15 seconds of CPU time per day on the segregated system cores? Did anyone look at whether there was measurable impact on a workload, even without doing further containment that’s not much at all….
sam-maloney commented on issue flux-framework/flux-sched#1457.
> Oh, I should have asked, I think we gave you enough access to be able to set merge-when-passing for yourself on this PR now that you have an approving review. If something doesn’t work with that, poke me and I’ll set it and see what’s going on with the permissions.
…
trws commented on issue flux-framework/flux-core#7520.
Sounds like a good plan to me, especially since different vendors and cases may need to allow for differences….
becker33 commented on issue spack/spack#51946.
@wouterdegeus you need to make changes to address the feedback from Harmen and myself above….
tgamblin commented on issue spack/spack#52291.
Blocked is better. Still not sure whether it
hppritcha commented on issue open-mpi/ompi#12200.
anyone still working on this PR @jiaxiyan …
emily-howell commented on issue Alpine-DAV/ascent#1701.
Thanks for adding the checkboxes @cyrush. That helped me realize that I had missed a line item in the issue….
milroy commented on issue flux-framework/flux-sched#1414.
Claude and I generated a prototype in Python for structural compression to address item 4 above. I’m pasting it here for discussion: https://gist.github.com/milroy/069f042e14f2fa21b6aab0f977b1453e…
benzwick commented on issue benzwick/StreamVorti#46.
## UMFPack vs MUMPS at np=1: why MATLAB’s factorize() matters…
tgamblin commented on issue spack/spack#52319.
@green-br does this look ok?…
markcmiller86 commented on issue llnl/Silo#543.
@junghans I believe this is corrected on the HEAD of the 4.12RC branch. …
grondo commented on issue flux-framework/rfc#515.
Fixed those things and will set MWP….
jameshcorbett commented on issue flux-framework/flux-sched#1454.
I rebased on top of #1453 because otherwise the tests in https://github.com/flux-framework/flux-sched/pull/1454/commits/1a3244f70c95fd3d018ebca1c305145ee0685dbf failed when reloading a module with new resource types. However, the tests I added in that commit pass even without the changes introduced by https://github.com/flux-framework/flux-sched/pull/1454/commits/b22642f8c17cc5b100cd115565430476bf685af5. …
garlick commented on issue flux-framework/flux-core#7546.
Sounds reasonable! Yeah we should move forward with this….
markcmiller86 commented on issue visit-dav/visit#20924.
I know it
trws commented on issue flux-framework/flux-sched#1452.
Yes, the initial load absolutely has to contain them. For some of the options like the id-list format we’d have to use a different initial load format. The solution for children is to allow them to request the full initial input from their parent in addition to the scheduling key, the id-list is again an example where there really isn’t another way to make that work….
grondo commented on issue flux-framework/flux-core#7546.
BTW, the IMP itself isn’t aware of how the imp-exec-helper obtains the input to the IMP. For now we could fetch DeviceAllow and DevicePolicy from systemd (perhaps rewrite to some input more suitable for use with the IMP so we don’t have to re-implement systemd DeviceAllow parsing), in the future if this data needs to come from outside systemd, an alternate method could replace or even be added to the helper.
…
cbritopacheco commented on issue cbritopacheco/rodin#232.
@copilot I meant you should refactor the CCMLC2014 folder code to remove the crude names and also add extensive doxygen documentation. This is the paper on which it’s based on: …
jeremylt commented on issue CEED/libCEED#1951.
Awesome. You can use search=t129 to run the new test specifically …
cyrush commented on issue visit-dav/visit#20920.
@biagas thanks for look into this. …
v-dobrev commented on issue mfem/mfem#5306.
Merged in next for testing……
tzanio commented on issue mfem/mfem#5309.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
gardner48 commented on issue llnl/sundials#918.
> We could also move the CONTRIBUTING.md if we renamed doc/ to docs/ (see https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors). I don’t think we want to move it into .github as it is more broadly applicable.
…
JustinPrivitera commented on issue llnl/conduit#1581.
Annotate more than just forall…
artv3 commented on issue llnl/RAJA#2006.
> I played with making a range type that could have any of begin, end, and stride be runtime or compile time constants. Is that something that you are interested in @artv3. Right now you construct the range in the lambda so the compiler knows that begin is a constant 0, but if you constructed the range outside of the lambda and captured it then the compiler would not know that begin is a constant. If you had a range type that could have any of the parameters be constant or runtime could fix that. …
chu11 commented on issue flux-framework/flux-core#7547.
hmmm all the builders failed, I seemed to have introduced a memleak. …
trws commented on issue flux-framework/flux-coral2#473.
I think it’s mainly just something we haven’t done, it should be straightforward as long as we keep it simple and make it an error to reduce the pool size below any active allocation size and things like that….
jameshcorbett commented on issue flux-framework/flux-coral2#473.
> IIRC, one way we discussed to handle this was to add a way to update the pool size with an RPC right @jameshcorbett?…
cmoussa1 commented on issue flux-framework/flux-accounting#857.
Thanks @jameshcorbett! I addressed the nit you caught. Will set MWP here…
cyrush commented on issue Alpine-DAV/ascent#1701.
This resolves a subset of the issues in #1587 , i added checkboxes to that ticket we can mark off when this is merged. …
hppritcha commented on issue open-mpi/ompi#8845.
anyone still working on this?…
adrienbernede commented on issue llnl/RAJAPerf#652.
@rhornung67 I fixed the issue from updating RAJA. This is ready….
wihobbs commented on issue flux-framework/flux-pmix#127.
@garlick FYI this is also the case for flux-security….
sam-maloney commented on issue flux-framework/rfc#452.
No worries at all! I am also aware that I am throwing up quite a lot of text recently, so I certainly don’t expect everyone to be going through everything right away
sam-maloney commented on issue flux-framework/flux-pmix#126.
@garlick I don’t think I have access to set MWP in this repo, so perhaps you could quickly poke this through so it doesn’t get forgotten, thanks! :slightly_smiling_face: …
wihobbs commented on issue flux-framework/flux-docs#318.
Even just having it on core would get us most of the way there. Let me try this out this afternoon and see if it works….
emily-howell commented on issue Alpine-DAV/ascent#1676.
I don’t think the CI failures are related to this MR or the changes I just pushed as I am also seeing them on my #1688 MR…
markcmiller86 commented on issue llnl/Silo#537.
Yes. But, don’t also enable BUILD_TESTING. I am seeing a CMake issue when that is enabled. And, of course, you can’t have the python interface in a static build either….
becker33 commented on issue spack/spack-packages#4076.
Re-ran cI jobs that failed for CI-system issues, they all pass. …
grondo commented on issue flux-framework/flux-security#219.
Thanks! Setting MWP….
garlick commented on issue flux-framework/flux-core#7500.
After discussion with @trws and some reflection on #7496 , it seems like the existing python schedulers should be reusable with externally provided ResourcePool implementations. I’ll change the “rack” test scheduler proposed here to be a test RackPool class instead, and then make it possible to override the pool class from the Scheduler base class (via module option and via R.scheduling.writer URI key)….
grondo commented on issue flux-framework/flux-core#7528.
> But, given your explanation, my sample script should work, right?…
markcmiller86 commented on issue visit-dav/largedata#5.
Thanks for the report and the fix :muscle:…
vsoch commented on issue singularityhub/guts#10.
We would need a SingularityContainer class akin to the DockerContainer class that exposes the same function signatures, and I think that would do it. Knowing Singularity images, the issue we might run into is with respect to speed to do the same operations, but it is worth a test! If you are interested in taking a shot, the main entrypoint creates a ManifestGenerator that is going to call extract on that class. That happens here:…
v-dobrev commented on issue mfem/mfem#5251.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
JustinPrivitera commented on issue llnl/conduit#1358.
Updated strawman from my talk: …
garlick commented on issue flux-framework/rfc#452.
Great point about the single core jobs. I am flip flopping on the template idea today and going around in circles I’m afraid….
sam-maloney commented on issue flux-framework/rfc#452.
I’m going to start working through the jobspec examples from RFC 14 to see what comes up (giving just the resources key, and essentially arbitrary assignment of ids):…
trws commented on issue flux-framework/flux-sched#1424.
I’m digging into this now, and I’m pretty sure I have a handle on what’s going on. Fluxion sets the expected start time as an annotation, and sends that along to core. Core interprets time of now or earlier as “now.” Both of these are fine independently, but sched tries to avoid sending too many annotations because of some old issues with memory ballooning due to too many annotations….
garlick commented on issue flux-framework/flux-docs#317.
Great improvement!…
chu11 commented on issue flux-framework/flux-core#7528.
> Yes, that’s pretty much what I want. But, doesn’t flux batch require flux start to be called prior to make the resources available? How is it seeing the resources?…
cmoussa1 commented on issue flux-framework/flux-accounting#846.
Thanks @jameshcorbett!…
hppritcha commented on issue open-mpi/ompi#13713.
@devreal could you re-review this PR?…
jandrej commented on issue mfem/mfem#5296.
What part of the dolfinx assemble process are you timing? Can you please post the source including the regions and timings you get?…
jameshcorbett commented on issue flux-framework/flux-docs#315.
LGTM as well, so I hit the button….
wihobbs commented on issue flux-framework/flux-docs#310.
Thanks @garlick! I also added a link to the tracking issue for multi-cluster accounting, instead of just “needs design.” I’ll set MWP….
wihobbs commented on issue flux-framework/flux-core#7252.
Interestingly, flux-sched’s CI appears to be catching a legitimate error not caught by core:
…
cbritopacheco commented on issue cbritopacheco/rodin#226.
@copilot Revert back to commit 9871634…
jeremylt commented on issue CEED/libCEED#1950.
For sure. If we see a performance difference, then I think the way to go for ChipStar would be to make chipstar backends /gpu/hip/chipstar/shared and /gpu/hip/chipstar/gen that delegate back to the current shared/gen code and that code would check the resource string for the root /gpu/hip/chipstar to determine if it needs to do the padding elements…
hppritcha commented on issue spack/spack-packages#4163.
please address others’ comments and I’ll review….