jedbrown commented on issue rust-lang/rust#138689.
I rebased. The warnings for implied features were fixed by https://github.com/rust-lang/rust/pull/140920. I updated a stale comment left behind in that refactor, and my handling of features transitively implied by base features moved to rustc_codegen_ssa. …
homeomorfismo commented on issue mfem/mfem#4769.
> I noticed that now the following two sample runs are actually identical: …
v-dobrev commented on issue mfem/mfem#4903.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
grondo commented on issue flux-framework/flux-core#6882.
Thanks! I’ll set MWP…
v-dobrev commented on issue xsdk-project/xsdk-issues#277.
Hi @balay,…
adrienbernede commented on issue spack/spack#50916.
For the records, here is a pre-v1 compiler compiler config that I am trying to port over to v1:…
tgamblin commented on issue spack/spack#50920.
This one’s more complete – with updated docs…
garlick commented on issue flux-framework/flux-core#6885.
I’ll set MWP - thanks!…
chu11 commented on issue flux-framework/flux-core#6880.
just pushed a commit on top that implements --tail=N
in flux job attach
. Everything appears to work as expected.
…
cjekel commented on issue cjekel/similarity_measures#39.
Thank you!…
JustinPrivitera commented on issue LLNL/conduit#1424.
With my two comments above I believe I have addressed all of your feedback @cyrush. I think this is ready to be merged. Please let me know if there is anything else we should discuss….
trws commented on issue LLNL/camp#179.
They could if someone wants to set up an image with one of the CPU-backed SYCL implementations like AdaptiveCPP or the clang upstream offload version (which I think now has “run in separate process” support to give you memory errors on CPUs if you mess up transfers). We don’t have that set up though. …
markcmiller86 commented on issue LLNL/Silo#432.
Already handled in f10090abcc63f5e93d52130db0b8bb0773c765d9…
tgamblin commented on issue spack/spack-packages#44.
@kwryankrattiger …
hppritcha commented on issue open-mpi/ompi#13279.
@edgargabriel i pushed the remainder of the fortran related files to the PR - hopefully….
vsoch commented on issue kubernetes-sigs/node-feature-discovery#2170.
The nfd worker generates a lot of logs (and other unexpected output) so I wasn’t sure how to cleanly do that. Whereas with writing the file explicitly, I can control exactly the contents….
trws commented on issue flux-framework/flux-sched#986.
Not substantively, we operate on the IDs as logical IDs (effectively assuming, in absence of actual structure, that lower IDs are close to other lower IDs). We still have a direct hwloc reader, which I believe is still tested, though we’re not currently using it. We would still need a way to connect the two together. Really what would likely be most useful in the short term would be to ensure that those logical IDs are translated back to physical IDs in exec or the shell. Having the actual locality in fluxion would definitely be good, but with what @ryanday36 showed in the issue description just doing that logical->physical translation even with hwloc-calc
right before doing the env var assignment would fix it. Admittedly not fix it the long-term “right” way, but we’ll need that logical to physical translation anyway because we don’t want to be tied to whatever crazy variable numbering cuda or hip use from 1pm to 2pm on alternate Thursdays….
grondo commented on issue flux-framework/flux-sched#986.
This issue came up again in the flux dev meeting yesterday, so just commenting here to revive the issue….
mplegendre commented on issue flux-framework/flux-core#6883.
We’d previously discussed starting a spindle session at allocation time that lasts the whole allocation. That would also solve this problem. But the drawback is it’s hard for users to pass configuration arguments to spindle, since spindle’s session starts before the user gets control. Though I’ll go this route if we can’t do alternatives….
cmoussa1 commented on issue flux-framework/flux-accounting#667.
Rebased this PR to catch up after #672. Setting MWP here…
vsoch commented on issue expfactory-experiments/attention-network-test#2.
What sticks out to me is defining “blocks” that are then looped through for trials. So possible reduce the sections there, and within each entity added to blocks, you can also delete….
balos1 commented on issue LLNL/sundials#721.
Thank you for opening this pull request. Due its size, it will take us awhile to be able to consider and review it. …
alecbcs commented on issue LLNL/hubcast#19.
Oh good point! I think we can close this one out :)…
cmelone commented on issue LLNL/hubcast#19.
@alecbcs is this still relevant given the addition of the config handler?…
cmelone commented on issue spack/spack-packages#107.
If you’d like a review, try posting in the #pull-requests
channel on Slack. The CI errors will need to be fixed though…
alecbcs commented on issue spack/spack#50874.
Yep. Working on a few other things today / tomorrow. I can do this Friday….
markcmiller86 commented on issue openjournals/joss-reviews#8106.
I recommend this paper for publication….
adayton1 commented on issue kokkos/kokkos#8195.
Thank you! I’ll give Kokkos_IMPL_AMDGPU_FLAGS
a try!…
grondo commented on issue flux-framework/rfc#454.
Setting MWP….
artv3 commented on issue LLNL/RAJA#1853.
Consider moving the plugins into src/plugins – keep as cpp files. …
emily-howell commented on issue Alpine-DAV/ascent#1502.
## TLDR: …
markcmiller86 commented on issue visit-dav/visit#20442.
> Here’s a question: the query output object for Spatial Extents queries is a single entry with key = ‘extents’, and value an array/vector of the values. With the changes to the output string, should the output object (XmlResult) be modified to use the XMin/XMax, etc keys instead of just ‘extents’? If so, this would possibly be more of a problem, even if it is the better way to report. …
imguoguo commented on issue osbuild/bootc-image-builder#963.
> Thank you! This looks nice! Ideally we would have a proper test for this but given that its not an official fedora arch yet it fine. …
jandrej commented on issue mfem/mfem#4898.
> @jandrej, could I suggest a couple small changes that I noticed in the DFEM code? …
tzanio commented on issue mfem/mfem#4898.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
vsoch commented on issue kubernetes/website#51164.
@graz-dev do you need any more clarification from us? …
samuelkgutierrez commented on issue hpc/quo-vadis#342.
Is something up with Github?…
adayton1 commented on issue LLNL/Umpire#967.
I think you are going to need to update the MemoryResourceType enum in MemoryResourceTypes.hpp. Otherwise, “SHARED” could map to the wrong implementation….
JustinPrivitera commented on issue LLNL/Silo#448.
This would be a nice feature!…
balos1 commented on issue spack/spack-packages#219.
@everythingfunctional Can you try adding depends_on("blas", when="+lapack")
to the sundials package.py to see if that fixes this. …
trws commented on issue flux-framework/flux-core#6492.
I don’t recall seeing this when it was being done, but it was mentioned in one of our recent meetings so I came looking. There are at least some updates here, in that uv_ref/unref now exist at least, and the child handling could be handled one of a couple of ways depending on the requirements (either uv_process_t
if we can, or uv_signal_t
if not). The others I think are still at least different, and the close item is vaguely interesting, I would think we’d be able to tolerate that even though it is a bit annoying. It’s probably safer for io_uring
style setups as well as windows, but I’m not 100% sure about that….
gardner48 commented on issue LLNL/sundials#713.
Fixing this typo in another PR….
adrienbernede commented on issue LLNL/radiuss-spack-configs#129.
@tdrwenski Could you open a PR in Quandary that checks whether your CI works well with the present PR in RSC?…
camierjs commented on issue mfem/mfem#4326.
There were some changes to bring from doftrans-three-arg
, done in 2bef31b and 4a46614.
…
grondo commented on issue flux-framework/flux-core#6873.
> I wonder if we could add an exec_bypass flag and let this plugin use both flags and post alloc (adding a fake or empty R), free, start, and finish (with job result) and have the proxy job track the state of the actual job? …
garlick commented on issue flux-framework/flux-core#6873.
This is pretty neat. However it seems like its usefulness will be limited as long as the result of the proxy job is always reported as failure. I see why a fatal exception was used to get the job from DEPEND to CLEANUP state in the prototype, since there’s no other way to do that currently, but I wonder if we can think up a better way that allows the proxy job result to reflect the result of the actual job. That way workflow tools, not to mention Flux native dependency schemes like afterok
,would not need to treat delegated jobs specially when they need to fetch the job result.
…
vsoch commented on issue vsoch/oci-python#24.
Thanks! …
markcmiller86 commented on issue visit-dav/visit#4914.
Here is a potential confusion. When listing the dimensions of an multi-dimensional mesh (e.g. 2DCoRectMesh
as above), the dimensions are specified as ZYX, not XYZ. So, the mesh is 9 nodes in Y and 33 nodes in X….
JustinPrivitera commented on issue visit-dav/visit#20440.
> > One question - does it make sense to rename bv_qt6.sh
to bv_qt.sh
, and to change the name in associated build scripts and in modules.xml?
…
jedbrown commented on issue rsmpi/rsmpi#215.
This would be resolved by #214 . There has also been an issue with the runtime
feature (cf. #203 ). Do you have an opinion about this question? https://github.com/rsmpi/rsmpi/pull/214#discussion_r2136959267…
jedbrown commented on issue openjournals/joss-reviews#7881.
@editorialbot recommend-accept…
tzanio commented on issue mfem/mfem#4841.
@dylan-copeland , can you please resolve conflicts?…
trws commented on issue flux-framework/flux-core#6315.
> > add the resource.rediscover
to the sub-instance config by default…
garlick commented on issue flux-framework/flux-coral2#369.
Cool, thanks. I’ll set MWP….
vsoch commented on issue flux-framework/Tutorials#54.
It also looks like there is a “Slides coming soon!” message that can now be updated….
artv3 commented on issue LLNL/RAJA#1859.
> > > This PR changes cmake to support a minimum cxx standard of 17. …
JustinPrivitera commented on issue Alpine-DAV/ascent#1556.
Let’s have renders for optical_depth fields as well. We should attempt to have tests that capture every single thing included in the output and the inputs we provide in tests should cover as many of the edge cases as possible….
emily-howell commented on issue Alpine-DAV/ascent#1526.
All of these action items were addressed in #1524 …
cyrush commented on issue visit-dav/visit#5770.
> > For AMR, we shouldn’t use VTK. For blanking out cells, we should use nesting….
hppritcha commented on issue spack/spack-packages#209.
@RonRahaman please open a PR for this, thanks….
v-dobrev commented on issue mfem/mfem#4880.
The normal on a boundary edge is not uniquely defined – typically, the edge has two adjacent faces that have, generally, different normals. How do you want to treat these cases?…
grondo commented on issue flux-framework/flux-accounting#659.
It does seem like a good idea to store the priority factor weights in the database, especially if there’s going to be an easy method to view the current weights….
bgunnar5 commented on issue LLNL/merlin#512.
@lucpeterson after spending hours trying to research and implement this, turns out Redis only accepts plaintext in the redis.conf file. Therefore, even if we encrypt the password with Fernet, Redis will just use the encrypted string as the password. I don’t think there’s any way around this so those last three CodeQL issues are unable to be resolved….
cyrush commented on issue Alpine-DAV/ascent#1486.
resolved in #1527 …
chu11 commented on issue flux-framework/flux-core#6871.
thanks! and I just noticed I typoed “updated” in the PR title and the commit message. Fixed that too. Will set MWP…
jameshcorbett commented on issue flux-framework/flux-core#6870.
Force-pushed to rebase with master and expand the test a little bit, setting MWP….
wihobbs commented on issue flux-framework/flux-core#6315.
@eleon has a few thoughts here shared today with @trws and me. Tagging him so he can share more….
jameshcorbett commented on issue flux-framework/flux-coral2#367.
Force-pushed to fix release date, setting MWP….
jedbrown commented on issue RDycore/RDycore#313.
These would be useful for dependencies:…
eleon commented on issue LLNL/mpibind#45.
For mpibind to work as intended, you need to tell Flux you want the full node (-x
). I also suggest using as few parameters as possible in your command line since you can, inadvertently, add conflicts between Flux affinity and mpibind. …
tgamblin commented on issue spack/spack#50867.
closing as the RHEL8 UBI issue seems to have sorted itself out….
chu11 commented on issue flux-framework/flux-accounting#656.
I wasn’t able to find where in the code you configure journal_mode
and synchronous
modes. In content-sqlite
it is set to “WAL” and “NORMAL”, for a smidge better performance….
tgamblin commented on issue spack/spack-packages#127.
I think the answers would be: …
tgamblin commented on issue spack/spack#50595.
I think we should do this but we are attempting to get #47615 in for 1.0, which also adds the hash of the spack instance to the misc_cache. …
jedbrown commented on issue rsmpi/rsmpi#203.
@mscroggs Following up on this, we get build failures on MacOS without the runtime
feature. It works everywhere else. Do you know of a way to fix this?
…
tzanio commented on issue mfem/mfem#4804.
Re-merged in next
for testing……
tpatki commented on issue flux-framework/flux-core#6873.
Hi @trws @garlick @grondo: …
alecbcs commented on issue spack/spack#48820.
Closing since this PR was sucessfully migrated to spack/spack-packages….
v-dobrev commented on issue spack/spack#49790.
bwpriest commented on issue grid-parity-exchange/Egret#318.
> @bwpriest I do not understand the failures … maybe I messed something up in 160a4a4? …
artv3 commented on issue LLNL/RAJAPerf#515.
> > yes, 2 is equivalent to the x index in cuda/hip …
cyrush commented on issue Alpine-DAV/ascent#1550.
…
v-dobrev commented on issue mfem/mfem#4851.
I’m not sure why this was merged without approvals and with requested changes pending. Is the idea to review these changes as part of #4800?…
trws commented on issue flux-framework/flux-core#6858.
I really like this, had one tiny docstring tweak and a question but it looks really good @grondo….
grondo commented on issue flux-framework/flux-core#6868.
Thanks! Setting MWP….
cmoussa1 commented on issue flux-framework/flux-accounting#631.
Looks like #632 ended up fixing this issue on tuolumne at least, so I’ll go ahead and close this now….
markcmiller86 commented on issue visit-dav/visit#20396.
@JustinPrivitera the best workaround I have found so far is to just create an alias expression and then use that alias in any further expressions requiring the original variable. On my mac with current develop
, I don’t get the garbage data condition then. So, in other words, define foo
as an alias for ElementBlock
and then define bar
as foo*1
and that works fine….
cmelone commented on issue spack/spack-tutorial#443.
The changes LGTM (after rebase), my other comments are not blockers…
hppritcha commented on issue open-mpi/ompi#13288.
With big count disp_unit
argument is of type MPI_Aint
for the “_c” routines. So that’s the reason why we’re using ptrdiff_t now….
brendankeith commented on issue mfem/mfem#4873.
@mdmeeker I think this breaks something in navier_kovasznay
.
…
tomstitt commented on issue mfem/mfem#4821.
> @tomstitt, is this ready for review? If it is, can you please add the ready-for-review
label?
…
garlick commented on issue flux-framework/flux-core#4201.
…
jameshcorbett commented on issue flux-framework/flux-accounting#652.
Oh my bad!…
BradWhitlock commented on issue LLNL/conduit#1439.
This is working with Conduit (and the host code). I plan to do some more testing to see whether other test suites are affected….
markcmiller86 commented on issue visit-dav/visit#20396.
If I look at an integer variable from a Silo file such as ivar
from specmix_quad.silo
, I DO NOT experience the same behavior. So, it may be somehow specific to the Exodus reader….
alecbcs commented on issue spack/spack#50565.
@alalazo after this PR/commit I can no longer concretize emacs +native
. I’ve checked my packages configuration and the gcc external correctly shows as having languages=jit
so I’m a bit at a loss for why the package is suddenly failing to use the external.
…
vsoch commented on issue oras-project/oras-py#204.
Why are you calling this in one off functions instead of at the class init?…
tzanio commented on issue mfem/mfem#4804.
Merged in next
for testing……
grondo commented on issue flux-framework/flux-core#6843.
Closing as duplicate of #5035….
BradWhitlock commented on issue LLNL/conduit#1434.
I implemented adjset point sorting based on spatial bins. This works for the Blueprint tests but for some reason, it totally fails on the test problem I’ve been debugging. …
jedbrown commented on issue CEED/libCEED#1830.
I feel it. FWIW, it was once Chop
and changed to Filter
in https://gitlab.com/petsc/petsc/-/merge_requests/6699….
trws commented on issue spack/spack#50702.
Yup, go for it….
v-dobrev commented on issue mfem/mfem#4821.
@tomstitt, is this ready for review? If it is, can you please add the ready-for-review
label?…
chu11 commented on issue flux-framework/flux-core#6840.
thanks, I’ll set MWP and adjust the github settings for the CI adjustment….
BradWhitlock commented on issue LLNL/axom#1580.
The idea was to add workarounds for double into the new wrappers for axom::atomicMin
and axom::atomicMax
(https://github.com/LLNL/axom/blob/3666e7888c7542c50ab4177044089da539b1c933/src/axom/core/execution/atomics.hpp#L51) …
v-dobrev commented on issue GLVis/glvis#336.
> @justinlaughlin, what happens if we load a steam with “screenshot” command in the web version? …
jandrej commented on issue mfem/mfem#4804.
Reminding all reviewers to approve or suggest changes asap….
jameshcorbett commented on issue flux-framework/flux-core#6842.
> After typing that up, I realized one issue with a special exit code is that exiting early from the prolog due to a potentially nonfatal error is probably not a good idea. This could skip other parts of the prolog that are necessary for preparing a node for use by the user. The node may be drained, but the user could still log in, or choose to undrain the node….
grondo commented on issue flux-framework/flux-accounting#648.
> LGTM and sure, a PR in flux-core sounds good! …
garlick commented on issue flux-framework/flux-accounting#648.
LGTM and sure, a PR in flux-core sounds good!…
cmelone commented on issue cmelone/hubcast-test#1.
@lc-hubcast help…
balos1 commented on issue LLNL/sundials#706.
> > @gardner48 I believe this is ready to be merged. …
gardner48 commented on issue LLNL/sundials#706.
> @gardner48 I believe this is ready to be merged. …
alecbcs commented on issue LLNL/hubcast#137.
Looking like a great start! Instead of referring to Hubcast as /hubcast <cmd>
let’s instead add a configuration variable (maybe HC_GITHUB_BOT_USER
or similar) so that you instead refer to the bot like @lc-hubcast <cmd>
. …
jeremylt commented on issue openjournals/joss-reviews#7124.
Overall looking good….
homeomorfismo commented on issue mfem/mfem#4769.
From https://github.com/mfem/mfem/pull/4769#issuecomment-2822389336 @v-dobrev’s comments …
cmoussa1 commented on issue flux-framework/flux-accounting#638.
This is now completed by #643, #645, and #647, so I’ll go ahead and close this. I can re-open more specific issues if they come up….
wihobbs commented on issue flux-framework/Tutorials#48.
Re-triggered, thanks. …
jeremylt commented on issue bempp/kifmm#147.
As far as I can tell…
cmelone commented on issue LLNL/hubcast#138.
ok that worked, not sure why that wasn’t necessary to get it to work for repligit. thanks!…
tzanio commented on issue GLVis/glvis#339.
To clarify: “DOF” here means the numbering of the Mesh nodes (as a high-order grid function), right?…
cjvogl commented on issue E3SM-Project/E3SM#7261.
> I fixed a few minor things and I added docs. Pls take a look before we merge …
astrophpeter commented on issue openjournals/joss-reviews#8147.
Thank you. We are actively working on the two issues raised. …
hppritcha commented on issue open-mpi/ompi#13279.
note that mpi4py is probably not testing this since it keys off our MPI_Get_version return values for major/minor. …
garlick commented on issue flux-framework/flux-coral2#344.
Update: two internal documents were shared by HPE. Although not HPE-confidential, it was requested that they not be published on github. They are:…
astrophpeter commented on issue LLNL/SSAPy#78.
@SuperdoerTrav please take a look. …
artv3 commented on issue LLNL/RAJA#1751.
Done, we added a helper function to simplify construction. …
artv3 commented on issue CEED/Remhos#54.
Can I merge? …
cyrush commented on issue Alpine-DAV/ascent#1540.
We do not have general support for reading vtk files. …
brendankeith commented on issue mfem/mfem#4645.
@thatguynoe, I put the WIP
label back because I noticed one of the items supposed to be in this PR is using the bisection method instead of Newton for root-finding…
homeomorfismo commented on issue mfem/mfem#4769.
> * abs-l1-jacobi
:
…
tgamblin commented on issue spack/spack#47590.
@spackbot run pipeline…
grondo commented on issue flux-framework/flux-core#6835.
> I’m building an EasyBuild recipe for Flux,…
JustinPrivitera commented on issue visit-dav/visit#20404.
> So, ChatGPT is telling me that Hybrid in cmocean colormaps (which applies to oxy
map only I think) is that it combines features of both Sequential
and Diverging
. So, I think simply including both tags on that map achieves the notion of Hybrid
. Thoughts?
…
alecbcs commented on issue spack/spack-distroless#47.
@dependabot rebase…
vsoch commented on issue singularityhub/shpc-registry#327.
What do you suggest the shpc library do about a registry rate limit? I’m not sure there is anything in our control to change or help….
jedbrown commented on issue rust-lang/rust#138689.
Thanks. I made the tracking issue #141468 and have updated the documentation to warn against use of #[target_feature(enable = "ptx80")]
, as well as clarifying how to build. Any further discussion of intrinsics in the documentation can happen after https://github.com/rust-lang/stdarch/pull/1805….
astrophpeter commented on issue openjournals/joss-reviews#7769.
Thanks! All changes look good to me and I just merged them. …
hppritcha commented on issue mpi-forum/mpi-issues#733.
Okay we’ll put the attributes thing back on the table. I’ve no objections myself and its not like they’re difficult to implement….
jedbrown commented on issue mpi-forum/mpi-issues#733.
> they may be targeted for deprecation/removal at some point…
trws commented on issue flux-framework/flux-sched#1372.
Ok, that sounds like a failure misidentified as ENOMEM then… will have to look and see if we have some that might go rogue….
grondo commented on issue flux-framework/flux-sched#1372.
The sar
data is sill there, here’s a report on memory around that time:…
garlick commented on issue flux-framework/flux-core#6827.
That does seem more flexible. Up to you - I’m fine either way….
BradWhitlock commented on issue LLNL/axom#1231.
I came across this issue and it was sort of related to issues I ran into when doing #1581 so I made additional changes there to fix this….
garlick commented on issue spack/spack#49033.
> I think logic to use flux directly would likely be more robust in the long run, but if the slurm wrapper is maintained as part of flux then I don’t see a hard requirement not to use it. …
gillette7 commented on issue mfem/mfem#4868.
Thanks for your prompt response! This is extremely helpful….
v-dobrev commented on issue mfem/mfem#4804.
Note: I updated the GNU make build system for Enzyme a bit: it is no longer needed to set ENZYME_LLVM_VERSION
– it should be auto-detected just from ENZYME_DIR
similar to CMake.
…
chrundle commented on issue meta-llama/PurpleLlama#109.
Thank you for the quick and detailed response. I will apply with Azure to modify my filter and hopefully that will resolve the issue….
vsoch commented on issue kubernetes/enhancements#4671.
> Would anyone be interested in pursuing the possibility of having filter extension point to take a group of pods and a group of nodes and perform the searching for the combination of nodes for a list of pods at once? The current filter extension point is not built for this. Yet, some plugins might be extended this way and if a proper implementation is provided this might be a path forward. Has anyone already concluded this is no-go? Or, this path has not been explored in more detail due to its complexity?…
vsoch commented on issue hpc-maths/samurai#322.
I would basically do:…
garlick commented on issue flux-framework/rfc#454.
Rerunning the link check as the link it was complaining about works for me….
chu11 commented on issue flux-framework/flux-core#6828.
I began to work on what would be a async-blobref check hidden behind a future as discussed above, but
…
cmoussa1 commented on issue flux-framework/flux-accounting#644.
Thanks @grondo! Rebased to catch up after #643. Setting MWP here…
tpatki commented on issue flux-framework/PerfFlowAspect#122.
Closing this issue as it is Lassen-specific, and Lassen has been removed from our preferred systems list due to older clang version….
bgunnar5 commented on issue bgunnar5/merlin#21.
@doutriaux1 coverage isn’t implemented yet but I think I have a branch that might have added it…
cyrush commented on issue Alpine-DAV/ascent#1532.
No worries thanks for trying out this possible approach and for the feedback. …
emily-howell commented on issue Alpine-DAV/ascent#1524.
@cyrush I think this has all the requests (minus robust documentation which you said should go in a future PR). I added the family value as a fallback, default formats (06d
for cycle and family g
for time) and an _
in front of the default fmt value iff the path does not already end with a _
character.
…
balos1 commented on issue LLNL/sundials#703.
Fixed by #704….
cmelone commented on issue LLNL/hubcast#121.
is there any situation where a user not in the account map would need to interact with the bot?…
astrophpeter commented on issue LLNL/SSAPy#77.
@SuperdoerTrav can you take a look please? …
tpatki commented on issue spack/spack#50550.
Hi @vlkale The following tells me that an older version of Variorum is getting picked up in this build. …
jandrej commented on issue mfem/mfem#4804.
> I would suggest slight reordering of the example and adding some more explanations. It will be helpful to have two additional examples. One with inputs gradients and primal field and one with several different filed inputs. Adding a recipe will help users to build their own operators. …
wihobbs commented on issue flux-framework/flux-accounting#636.
> Just a thought but would command completions like flux-core’s be another way to solve this problem? …
cmelone commented on issue cmelone/hubcast-test#2.
/hubcast approve…
gardner48 commented on issue LLNL/sundials#660.
Closing per our discussion today (20 May 2025). If this becomes an issue again in the future, we’ll revisit requiring only one of the vector inputs to be the same as the output. …
adayton1 commented on issue LLNL/CHAI#314.
Just testing this out in my application….
tpatki commented on issue ovis-hpc/ldms#1664.
@nichamon Rebased to b4.4. Tests are passing now….
tzanio commented on issue mfem/mfem#3837.
Merged in next
for testing……
btalamini commented on issue LLNL/serac#1384.
On our clang version (14.0.0), compilation should fail for this if -Wuninitialized
is set (or any flag that includes this) (example) Please change the CI builds to include this….
jeremylt commented on issue CEED/libCEED#1826.
Yeah, at some point it would be nice to tidy that up more. I have mixed feelings sometimes about how much code to collapse together as these are sorta intended as tutorial examples?…
jedbrown commented on issue CEED/libCEED#1824.
For GPUs, where would we store this product $CB$? With non-tensor elements, we have the same matrix for all elements and thus have efficient reuse. I don’t know if this $CB$ technique is good or bad, but storing multiple such matrices per thread block is a lot….
v-dobrev commented on issue mfem/mfem#4768.
Hi @adam-sim-dev,…
jakubcerveny commented on issue jakubcerveny/gilbert-paper#10.
Thank you @drupol, Typst indeed looks great. I’m not sure yet if we want to switch to Typst at this point for this particular paper, but I’ll definitely be using it for my other work, for example I recently needed to add math to a Markdown document and convert it to PDF, and Typst would have been perfect, so next time I’ll go straight to it….
jakubcerveny commented on issue jakubcerveny/gilbert#19.
Amazing, thank you!…
v-dobrev commented on issue spack/spack#50461.
Just FYI: https://github.com/spack/spack/pull/50401 is now merged in develop
, so merging develop
here should fix the Gitlab CI issue….
vsoch commented on issue rootless-containers/usernetes#372.
It’s called TOSS, and it’s a derivative of RHEL 8.10…
tzanio commented on issue mfem/mfem#4804.
> I don’t intend to have serial only versions for now. …
dylan-copeland commented on issue mfem/mfem#3862.
This PR removed the input flag -r
and added serial and parallel flags -rs
and -rp
, but the first sample run still has -r
. The sample run should be updated….
garlick commented on issue flux-framework/flux-core#6811.
Thanks - fixed that and rebased on master. I’ll set MWP….
cyrush commented on issue visit-dav/visit#20388.
I think it would be good to preserve -no-thirdparty
.
…
JustinPrivitera commented on issue visit-dav/visit#20398.
No worries; glad you got it figured out! Let us know if there is anything else we can help with!…
jandrej commented on issue mfem/mfem#4804.
> > > MFEM must be compiled with the same Clang as Enzyme …
wihobbs commented on issue flux-framework/flux-sched#1372.
Ah, thanks for the tip! The “around the same time” comment made me think you were grep’ping for timestamps or something. Now I see you were just commenting that fluxion reported the memory error around the same time as core reported an exception….
grondo commented on issue flux-framework/flux-docs#302.
> Edit: I often want to connect to my most recent running job, (which is usually flux job last but maybe I submitted a bad job last) so I use flux proxy $(flux jobs -no {id.f58})
. I also often add -u flux
to the flux jobs call
to connect to a multi-user subinstance….
chu11 commented on issue flux-framework/flux-docs#302.
As an aside, I did write this tutorial a long time ago….
wihobbs commented on issue flux-framework/flux-docs#302.
> And we could start with the most basic examples and build on this whenever we think of another convenient example to have?…
cmoussa1 commented on issue flux-framework/flux-docs#302.
IMHO a new sheet (perhaps on the docs site) with the most frequently and most useful options could be nice for an “ever-expanding” list of examples. You could create one batch of 10 jobs (5 running, 3 scheduled, 2 completed, etc.) and use a varying list of flux jobs
commands to list different lists of jobs based on the formats you discussed above? And we could start with the most basic examples and build on this whenever we think of another convenient example to have?…
grondo commented on issue flux-framework/flux-core#6822.
BTW, I did consider adding a --resilient
option that selected a “good” value for tbon.topo
and add_brokers
but I feel like that’s premature at this point.
…
chu11 commented on issue flux-framework/flux-core#6802.
thanks! Tweaked that minor documentation and will set MWP….
jameshcorbett commented on issue flux-framework/flux-coral2#361.
Will set MWP once https://izlc.llnl.gov/gitlab/LC/ansible/-/merge_requests/19077 is merged….
trws commented on issue LLNL/camp#174.
I was thinking so too, but it isn’t entirely straightforward because there’s no good way to have a fold skip elements or filter into an argument list, especially using emulated folds in 14. Definitely something to think about when we can though….
jeremylt commented on issue CEED/libCEED#1808.
Perhaps we just slap a max version on the options above since we’re about to release v0.13…
jedbrown commented on issue CEED/libCEED#1808.
I’d think it isn’t even necessary to explicitly OPT=
. In practice, what sort of options get passed? We liked -fopenmp-simd
because it vectorized better, but I think we worked out detection of vendor-specific attributes so that we can get good performance without it. I like simpler….
markcmiller86 commented on issue visit-dav/visit#19549.
> With the test file, the problem has been fixed. However, I am still hitting the same problem with the simulation output….
astrophpeter commented on issue openjournals/joss-reviews#7769.
Thanks! The duplicated bib item has now been removed….
homeomorfismo commented on issue homeomorfismo/STAT409Project#14.
Should have been rebased…
grondo commented on issue flux-framework/flux-sched#1372.
FYI - flux job id JOBID
is an easier way to convert Flux jobids:…
wihobbs commented on issue flux-framework/flux-core#6503.
Ok, this is ready for review. I did fix two issues I saw where a parameter had been accidentally appended to a Returns:
instead of with the Args:
.
…
cmoussa1 commented on issue flux-framework/flux-accounting#633.
thanks! setting MWP here…
jameshcorbett commented on issue flux-framework/flux-accounting#628.
> I see now that the message is prefixed with the actual module name, which is nice …
tpatki commented on issue flux-framework/PerfFlowAspect#130.
New PR created #190. Closing….
aidan-epperly commented on issue aidan-epperly/structured-sdp-solvers#4.
Great catch thanks!…
cyrush commented on issue LLNL/uberenv#141.
This will be very helpful, thanks for working through a solution that allows you to reuse the common chunks of the configs. …
balos1 commented on issue LLNL/sundials#705.
Value change was made in https://github.com/LLNL/sundials/pull/565. …
alecbcs commented on issue LLNL/hubcast#40.
Completed in #122….
bwpriest commented on issue Pyomo/mpi-sppy#516.
Addressed by PR #519 …
adayton1 commented on issue LLNL/Caliper#636.
What symptoms did this fix?…
JustinPrivitera commented on issue Alpine-DAV/ascent#1526.
filename{cycle:d}
appears to partially work:…
emily-howell commented on issue Alpine-DAV/ascent#1526.
@cyrush @JustinPrivitera As requested, these are all of the current issues that I am aware of. Please feel free to add comments with any I have missed….
hppritcha commented on issue spack/spack#50366.
Thanks for pointing this out. I’ll rebase this PR and see if it fixes this issue….
hppritcha commented on issue open-mpi/prrte#53.
@jsquyres could you delete the main
branch?…
tzanio commented on issue mfem/mfem#4847.
Merged in next
for testing……
grondo commented on issue flux-framework/flux-core#6806.
Thanks! I gave #6808 a very quick test this evening on 64 real nodes with 54 brokers per node (size=3456) using 3level:2
and 3level:8
. This does seem to have a measurable impact. 3level:2
got up to ~9 job/s total throughput and 3level:8
got 28 job/s….
vsoch commented on issue mpi4jax/mpi4jax#280.
Will be testing on multiple nodes later today - in the meantime I built the container and made the animation, it’s gorgeous!
vsoch commented on issue converged-computing/flux-apps-helm#24.
And a quick note - I’d also like to be able to list container tags for a specific app, and then see the associated compatibility metadata tags. I’d also like to preview commands….
vsoch commented on issue DLR-AMR/t8code#1615.
Hi @Davknapp ! I had a go at testing this today - first on a small, single container (it seemed to work OK there) but then when I moved to 4 nodes in Kubernetes, it hung here for 8 minutes:…
JustinPrivitera commented on issue visit-dav/visit#20385.
Hi @Sam-Briney, thanks for these changes. One of us will review. Do you have any tests/test files that we can add to our test suite?…
tpatki commented on issue ovis-hpc/ldms#1664.
Thank you @morrone! That’s indeed great news. …
v-dobrev commented on issue mfem/mfem#4800.
@mlstowell, as long as the new enum values are documented, I’m fine with the names you proposed. …
homeomorfismo commented on issue homeomorfismo/STAT409Project#10.
Can you do an interactive rebase? Some commits can be squashed, and the branch as a whole can be rebased (so you don’t have to deal with a merge commit. …
jameshcorbett commented on issue flux-framework/flux-core#2875.
Yeah, for --rabbits
the plugin would be pretty much the same as the --bar
plugin in this comment above….
wihobbs commented on issue flux-framework/flux-core#2875.
@jameshcorbett, if you were going to do that, does the CLIPlugin
interface as we’ve currently designed it make it clear how to do that? It’s pretty similar in all approaches….
v-dobrev commented on issue LLNL/RAJA#1830.
Regarding:…
cyrush commented on issue visit-dav/visit#20346.
We need to figure out if the current version can work, however this will be deferred to future releases. …
markcmiller86 commented on issue visit-dav/visit#20341.
> Steps to reproduce the behavior. For example:…
hppritcha commented on issue spack/spack#50371.
would you mind uploading the config.log from the pmix build?…
jeremylt commented on issue openjournals/joss-reviews#7124.
Ok, I’ve got a good build now, thanks….
jameshcorbett commented on issue flux-framework/flux-sched#1371.
Rebased with master and fixed the release date, setting MWP….
chu11 commented on issue flux-framework/flux-core#6794.
> Correct me if I’m wrong - if the “real” output cap is 1000 right now, we keep going until we get 1000, right? …
trws commented on issue LLNL/camp#174.
Interesting, not a bad idea. Would you be willing to add a link to where it’s used in that PR? I’m curious about the usage pattern, the implementation looks easy to follow, which is great, but we might be able to make it a bit faster on template expansion depending on the usage….
artv3 commented on issue LLNL/RAJA#1838.
> > I’m a bit confused on why this PR is out of date with develop, additionally it won’t let me update the branch using the web interface …
tzanio commented on issue CEED/Remhos#52.
Aside from git tags and version numbers, the Spack packages for Laghos and Remhos should be very similar, if not identical…
vladotomov commented on issue CEED/Remhos#52.
Once MFEM is built for GPU, the build of Remhos
follows. Same as Laghos
….
cyrush commented on issue Alpine-DAV/ascent#1509.
spack case for macOS, having an issue with gfortran rpath. …
cmelone commented on issue spack/spack#49243.
@wdconinc what did your DAG look like to build v2.6.0? I can’t get it to build :( …
camierjs commented on issue mfem/mfem#4848.
For the scaling study, you can directly use some command line like:…
cmoussa1 commented on issue flux-framework/flux-accounting#589.
Just tested this on corona
and it looks like toggling WAL-mode did not seem to help with the 30-second hang while the job-usage and fairshare update scripts were running. I’ll have to look into other potential techniques. …
cjekel commented on issue cjekel/piecewise_linear_fit_py#130.
With that many data points and two segments, I would want to do one of the optimizations that you’ve done….
cyrush commented on issue Viskores/viskores#72.
I see – I had the clip inverted in my head (that we were keeping what was inside the box vs removing it)…
bgunnar5 commented on issue LLNL/merlin#498.
@lucpeterson @doutriaux1 This PR needs a new review as I’ve changed it a lot. See the new description above to understand what all is in this….
tomstitt commented on issue mfem/mfem#4305.
Closing because of https://github.com/mfem/mfem/pull/4660, I will profile and maybe make a new PR on top of that…
trws commented on issue flux-framework/flux-sched#1362.
Ping, it would be good to get this merged to take care of #1180….
balos1 commented on issue LLNL/sundials#699.
To match Spack’s formatting, I think we should add a pyproject.toml in the root of the repot with the two relevant settings: …
imguoguo commented on issue milkv-pioneer/issues#37.
If you’re still using Fedora 38 on Milk-V Pioneer, maybe try changing the repo in /etc/yum.repos.d
to this URL:…
markcmiller86 commented on issue betterscientificsoftware/bssw.io#2310.
Also, https://ladybird.org…
mplegendre commented on issue LLNL/Adiak#34.
We’ve got clustername and launchdate as already collected metadata. Launchdate will be similar to submit time, but not precisely….
vsoch commented on issue LLNL/benchpark#748.
How can we use something from a private repository?…
vsoch commented on issue tudasc/cfdSCOPE#1.
Will do! I ran a study this morning - I am using a helm chart that will install and run on on one node (Kubernetes), and then I “scale” via the OMP_NUM_THREADS
. I’m not sure more threads made it faster - I’ll share with you the plots when I make them (I have still about 20 other apps to test)!…
v-dobrev commented on issue spack/spack#47642.
The reason the Gitlab CI failed for the last commit (cf172861) is the following: …
hppritcha commented on issue open-mpi/ompi#13179.
I refreshed my checkout and now do not see the man page build problem….
tzanio commented on issue mfem/mfem#4228.
@tomstitt, can we close this (in favor of https://github.com/mfem/mfem/pull/4305)?…
cjekel commented on issue cjekel/piecewise_linear_fit_py#128.
@matt8s I’m not opposed to adding this as a method if you find it useful. …
JustinPrivitera commented on issue LLNL/conduit#1424.
Ok, let’s look side-by-side. Debugging it the first time took several hours and I never could find out what was going wrong….
cyrush commented on issue LLNL/conduit#1424.
I still want to discuss why we have to use the unique pointers. Something is off if you were seeing crashes with and I want to understand….
markcmiller86 commented on issue LLNL/Silo#22.
> how usable do you consider your CMake build system at this point, and do you plan for a new release? Distributions are starting to [or are right in the middle of] cleaning up Qt5 revdeps….
cyrush commented on issue Alpine-DAV/ascent#1509.
…
JustinPrivitera commented on issue visit-dav/visit#5770.
> Is there a way to write it to minimize the pain of transisitioning to AMR in the future, e.g., by returning a vtkOverlappingAMR dataset?…
vsoch commented on issue oras-project/oras-py#197.
@Sojamann it’s a developer library by default - I would argue that your use case is niche and should not refactor the entire structure of the library to support when it’s as easy as tweaking the session on the class….
jeremylt commented on issue openjournals/joss-reviews#7124.
This week was eaten by an interview process for me. The review work is slated for early next week on my end….
v-dobrev commented on issue mfem/mfem#4806.
Merged in next
for testing……
grondo commented on issue flux-framework/flux-core#6790.
Thanks @wihobbs! Fixed that typo and will set MWP….
cmoussa1 commented on issue flux-framework/flux-accounting#621.
thanks! setting MWP here…
jedbrown commented on issue coreylowman/cudarc#401.
I think the weakest answer to these depends on the implementation language doing the copy or handling results on the device. But suppose the kernel that’ll operate on the device data was written in Rust? In that case, the uninitialized memory cannot exist in a slice or similar object (it must be behind MaybeUnint<T>
or a raw pointer). I think it’s preferable for cudarc to enforce that slice-like objects on host or device contain only initialized memory. (One can use MaybeUninit<T>
if they really need to handle uninitialized memory.)…
aperloff commented on issue MakieOrg/GeoMakie.jl#322.
Related to #308 …
artv3 commented on issue LLNL/RAJA#1837.
> We have advertised that old-style reductions are not supported for SYCL. Not all of the old reduction types work with SYCL. However, we have not yet removed the code for them. …
jeremylt commented on issue CEED/libCEED#1805.
Removal - we don’t need ex3_volume_qfunctions.py
or setup.py
…
tpatki commented on issue ovis-hpc/ldms#1664.
Thanks @morrone for clarifying on our behalf! …
wihobbs commented on issue flux-framework/flux-core#6789.
> Oh, I guess this is perhaps by design, though I can’t think of why at the moment:…
balos1 commented on issue LLNL/sundials#464.
> Is it possible to update the Sundials spack recipe to reflect this issue? Either as a patch or a conflict or something?…
eliasboegel commented on issue CEED/libCEED#1813.
I also faced the ar D
issue, and worked around it by using a third party bintools
distribution rather than that shipped with Apple Clang. Made no difference on the weak symbol issue though….
jedbrown commented on issue CEED/libCEED#1813.
Revisiting this while trying to understand the root issue of weak symbols not working with static linking on MacOS. I don’t have a solution there, but I found that ar crD
doesn’t work because Apple ar
does not support D
(deterministic), but one can use the environment variable ZERO_AR_DATE=1
.
…
alecbcs commented on issue spack/spack#50241.
You can run spack gc
after your build to clean up the build dependencies. (Which in this case will just leave you with gh
since it’s statically compiled.) I believe that src/
is required for language server support for users who are developing go applications since src is the go standard library….
jedbrown commented on issue rust-lang/cargo#15210.
Any ideas to mitigate the issue of tests being redundant, so that when the add
function is edited, they don’t have to manually update/delete two duplicate tests? There could be two functions, like add
and square
, one with a doctest and one with #[test]
, but that’s a few more lines….
bgunnar5 commented on issue LLNL/merlin#503.
@doutriaux1 I’m so confused on what’s going on with these tests. It looks like they’re failing due to an issue with pip. However, yesterday I re-ran the unit test jobs and those just ended up passing on the second time around. When I re-run the local tests and integration tests they just continue to fail. Nothing I’ve changed in this PR should be breaking any tests… I’ll keep looking…
adayton1 commented on issue LLNL/RAJA#1836.
Thanks, @artv3 !…
jedbrown commented on issue tov/libffi-rs#120.
MSRV is considered a minor change, but the breakage happened before the last release (cf. https://github.com/tov/libffi-rs/commit/d8705c3836e24bd024d6881d0cfd73d0ea9749af#r155795763) so this is just formalizing so cargo can take it into account in dependency resolution….
jedbrown commented on issue rsmpi/rsmpi#211.
Good. I think one can still “cheat” with something like…
markcmiller86 commented on issue openjournals/joss-reviews#8106.
@junghans I believe I have completed my review in the above comment. Let me know if you need anything else….
camierjs commented on issue mfem/mfem#4757.
The cmake
& make
tests look good, thank you @helloworld922.
…
dylan-copeland commented on issue mfem/mfem#4125.
Thanks @JacobLotz for the explanation. I agree that we can just close this PR for now. Of course, we can always make this change later, if we find a test that needs it. Although it is a very small PR, my concern is that the changes are difficult to understand without an example to demonstrate the problem. We can keep this PR in mind if we run into issues with the edge to knot mapping….
jakubcerveny commented on issue jakubcerveny/gilbert-paper#4.
Thanks for the pictures and explanation, this is now much more clear. I like the adaptive idea, but I have two concerns:…
chu11 commented on issue flux-framework/flux-core#6785.
oh wait, the path is used within the libarchive code … which probably something more filesystem like….
jbschroder commented on issue Parallel-in-Time/pySDC#547.
I also strongly support this idea. This project would make PySDC more accessible, including to students at other institutions (like mine) who would be interested, and it would help open up collaborations with other Python packages (like PyAMG, which implements algebraic multigrid, AMG, for spatial solves, where I’m a co-developer)….
astrophpeter commented on issue LLNL/SSAPy#60.
This is amazing! @aperloff can you take a quick look?…
eliasboegel commented on issue CEED/libCEED#1813.
Ah, thanks for clarifying. I’m personally not a fan of depending on transitive naming and instead in favor of removing the static
feature from libceed-sys
. I still think it would be important to have a shared build available due to #1694, but that could be a non-default feature called shared
or dynamic
or similar (re-exported or not)….
jedbrown commented on issue CEED/libCEED#1813.
I should have written more carefully. I was thinking of having libceed/Cargo.toml
use
…
v-dobrev commented on issue spack/spack#49625.
A similar issue seems to be blocking my PR #47642 (see e.g. this CI failure https://gitlab.spack.io/spack/spack/-/jobs/15220744), so I looked a bit into the log files posted in this issue. Here’s what I found:…
tzanio commented on issue mfem/mfem#4441.
ping: @kaipengliuHIT …
v-dobrev commented on issue mfem/mfem#4831.
I don’t think the H(curl) case is supported yet. Probably the first step is to add element assembly (EA) support in VectorFEMassIntegrator::AssembleEA
. Full assembly (FA) is based on EA and may just work when EA is supported, however, there may be some other pieces missing – I’m not 100% sure….
vsoch commented on issue bentoml/BentoML#3836.
What exactly about this issue is “not planned” - a person actually responding to me? In a timeframe of years later?
JustinPrivitera commented on issue visit-dav/visit#20372.
@markcmiller86 - Thank you so much for your thoughtful and detailed review! I really appreciate you diving in and staring at this in depth….
vsoch commented on issue oras-project/oras-py#192.
Another related issue (that it would be great if you want to add here) is that if headers is None, it can be passed here and we attempt to set an attribute on None. There probably should be a headers = headers or {}
somewhere in there. What do you think?…
homeomorfismo commented on issue mfem/mfem#4769.
I will take a look at the drivers: there are some redundant things in there that I forgot to remove (related to the L(p,q) smoothers). …
grondo commented on issue flux-framework/flux-accounting#610.
Nice work @cmoussa1 !…
cmoussa1 commented on issue flux-framework/flux-accounting#562.
Going to re-work this PR now that #610 has landed and we now have a Job
class and a more structured approach to how dependencies are handled in the plugin….
bgunnar5 commented on issue LLNL/merlin#488.
@lucpeterson in this PR we’re removing .lgtm.yml
. Should we also remove lgtm.yml
?…
jandrej commented on issue EnzymeAD/Enzyme#2283.
```patch…
jeremylt commented on issue CEED/libCEED#1811.
Yeah, if we go with this approach, then you only need to modify your main as above…
tgamblin commented on issue spack/spack#49731.
Does it make sense to split this up, and to put CMake 4.0 in as non-preferred so that people can start trying it out, THEN do all the package modifications?…
wihobbs commented on issue flux-framework/flux-core#6562.
the rare codecov annoyance that teaches me a cool new thing
jameshcorbett commented on issue flux-framework/flux-coral2#278.
Resolved by https://github.com/flux-framework/flux-coral2/pull/348….
astrophpeter commented on issue LLNL/SSAPy#54.
Ok, @aperloff , are we ready to merge? :)…
hppritcha commented on issue spack/spack#50187.
A workaround should be to try using Open MPI 5.0.6. I’ll open a PR to add a patch for 5.0.7 but probably not till next week….
trws commented on issue spack/spack#50123.
Yeah, separate is fine. If we have “known good” commits for macos from neovim… maybe that’s ok? I’m not sure if there is still a prohibition on using hash versions in upstreamed packages, but that might actually be a reasonable thing to do in this case given the nature of luajit….
jedbrown commented on issue rsmpi/rsmpi#209.
This bumps MSRV to 1.78….
hppritcha commented on issue open-mpi/ompi#13206.
I did some investigations here and it looks like some changes in this PR somehow broke the connection management in the TCP BTL. If one runs main with mpi4py with OMPI_MCA_btl=self,tcp things work. But with this PR it doesn’t. There are some suspicioius differences between the opal_config.h generated in this PR vs main and I suspect that’s a symptom of other config differences that wind up giving the TCP BTL problems….
dylan-copeland commented on issue mfem/mfem#4811.
@helloworld922 how should this PR be tested, both by reviewers and CI? Should there be unit tests or sample runs in an example or miniapp?…
acfisher commented on issue mfem/mfem#4689.
@tzanio Yes, I managed to put a memory leak in there. I am getting memcheck woking properly in my environment so I can track it down and fix it….
trws commented on issue LLNL/camp#173.
Thanks @kab163, if possible let me know how that goes….
jedbrown commented on issue pmodels/mpich#7064.
There’s a lot of value in working out of the box. The present situation is really disruptive and does not have a simple/discoverable workaround. I think the distro version should use hydra….
jakubcerveny commented on issue jakubcerveny/gilbert-paper#6.
Wow this looks good…
cmoussa1 commented on issue flux-framework/flux-core#2875.
I think I might also lean more towards using a distinct prefix for long options to make it clear that the option is originated from a plugin, i.e. prefixing an option with something like --ex
(or anything distinct enough to make it recognizable that it comes from a plugin). …
balos1 commented on issue LLNL/sundials#693.
We do not support the old sundialsTB interfaces anymore. I highly recommend that you use IDA through the new interface released in MATLAB 2024a. …
btalamini commented on issue LLNL/serac#1363.
> I’m playing with this and getting extra characters. The magic numbers look to be off. …
aperloff commented on issue LLNL/SSAPy#54.
Wouldn’t it speed up the process to try to build the documentation locally? Isn’t the git-lfs issue just blocking the automated builds? Just offering this as a workaround for the moment….
cyrush commented on issue LLNL/conduit#1427.
To avoid CI issues, we need to guard the new test cases on HDF5 support. …
cjvogl commented on issue E3SM-Project/E3SM#7261.
> This is currently not requestable, right? How would one get the zonal average of T_mid? You will need to add the appropriate regex in components/eamxx/src/share/io/eamxx_io_utils.cpp …
vsoch commented on issue kubeflow/trainer#2459.
More granularity is definitely useful - did you write down the use cases for this from the call or elsewhere?…
garlick commented on issue flux-framework/flux-coral2#344.
Thanks Bronis, understood. I’m sure we can easily make these thresholds site-configurable….
vsoch commented on issue skypilot-org/skypilot#3751.
I don’t think there was interest here - I closed the PR and I’ll close the issue too. I still think the design to support deployment of a cluster to Kubernetes has feet, but the code base would need some work for that. …
dylan-copeland commented on issue mfem/mfem#4601.
I had a couple of comments from Dec. 11 that were not resolved….
tzanio commented on issue mfem/mfem#4601.
@v-dobrev – can you resolve conflicts? …
BradWhitlock commented on issue LLNL/conduit#1301.
I’m testing partitioner enhancements in branch: feature/whitlock/partition_mixed_topology that include these changes….
jeremylt commented on issue CEED/libCEED#1803.
This PR appears to be missing the corresponding hpp file with the QFunction source code like BP1 and BP3 have….
JustinPrivitera commented on issue visit-dav/visit#20312.
Related to #20213…
markcmiller86 commented on issue visit-dav/visit#20369.
FYI…I looked really closely at all the cases. Everything looked good to me….
trws commented on issue spack/spack#50123.
We could do the conflict, but could we pin the luajit version to the one they’re using perhaps?…
cyrush commented on issue spack/spack#42969.
> Closing this one, since we decided that we don’t want to support apple-clang
+ OpenMP, given the upstream effort to remove it
tpatki commented on issue ovis-hpc/ldms#1664.
Thank you @morrone!…
cjvogl commented on issue mfem/mfem#4673.
Any chance to get a second approval on this, @jandrej? The project that would use this functionality has a local version that will see more development soon (i.e.,ideally, this merged into master so we can work off master in that project)….
v-dobrev commented on issue mfem/mfem#4689.
> @v-dobrev, what do you think about proposed mesh table changes in this PR, see in particular #4689 (comment) …
vsoch commented on issue flux-framework/flux-framework.github.io#148.
Here comes coral2!!…
wihobbs commented on issue flux-framework/flux-core#2875.
In summary, we have two different prototypes for enabling plugins to extend our CLI submission tools….
IanLee1521 commented on issue LLNL/scraper#84.
@LRWeber - good catches! I just updated the actions file to convert over to using the definition out of the pyproject.toml file instead. Good catch!…
cyrush commented on issue LLNL/conduit#163.
Revisit b/c we are now using yyjson
…
adayton1 commented on issue LLNL/axom#1556.
Thanks, @kennyweiss ! This will be really useful if anyone wants to sample proe meshes instead of compute exact volumes of intersection….
cjvogl commented on issue E3SM-Project/E3SM#7261.
> If you are ok with using the existing CMP (with a different string attached, like “bin”), I can quickly add a PR (or push to your branch, whatever you prever), so that we can do that. …
cmelone commented on issue spack/spack#49989.
try posting in #pull_requests on slack…
amagela commented on issue sandialabs/maskman#4.
> @jcox10 is my go-to podman expert. …
astrophpeter commented on issue openjournals/joss-reviews#7769.
@ivastar are there any updates on this? Please let me know if I need to do anything from my end….
trws commented on issue flux-framework/flux-sched#1363.
I just went and checked and it said everything is up to date, so someone did….
cmoussa1 commented on issue flux-framework/flux-sched#1363.
Did we ever accept the new Mergify permissions for the flux-framework organization? I got an email about it a little while ago. Not sure if that has anything to do with why Mergify is acting up…
jameshcorbett commented on issue flux-framework/flux-sched#1363.
Mergify has gone insane!…
jameshcorbett commented on issue flux-framework/flux-docs#298.
Makes sense I’d say go ahead and set MWP!…
trws commented on issue flux-framework/flux-core#6771.
Seems reasonable. Probably best to actually create an environment too, and not lock a specific compiler or flux-core version. This is more like “best practice” for usual spack usage these days:…
garlick commented on issue flux-framework/flux-core#6771.
Maybe with an…
cmoussa1 commented on issue flux-framework/flux-accounting#610.
OK, I’ve pushed up some new commits and fixes to existing commits to this PR that do the following: …
balos1 commented on issue LLNL/sundials#692.
Hi @zulugithub. This appears to be a bug. SUNDIALS::core_static
should not depend on SUNDIALS::core_shared
. …
astrophpeter commented on issue LLNL/SSAPy#54.
@SuperdoerTrav What do you think? Do you have any comments or does this look ok? :) …
cmelone commented on issue spack/spack-gantry#167.
@dependabot rebase…
chu11 commented on issue flux-framework/flux-core#6769.
(oops, I had a comment at work about probably closing this and forgot to hit submit)…
hppritcha commented on issue open-mpi/ompi#13192.
@devreal could you recheck? only thing that’s changed is in the mpi-f08-rename.h file…
grondo commented on issue flux-framework/flux-foundry#6.
That makes sense to me! It would be easy to modify in the future but keeps us moving forward for now….
garlick commented on issue flux-framework/flux-foundry#6.
Seems like flux-python was modified by flux-framework/flux-python@febb740010259c995b958f0b7269218af19600e5 to work off of installed headers and libs, so maybe there will be no disruption there since this project installs them to the same path as flux-core?…
grondo commented on issue flux-framework/flux-accounting#610.
I have some questions first since I’m not knowledgeable about these C++ interfaces: …
emily-howell commented on issue Alpine-DAV/ascent#1500.
@cyrush @nicolemarsaglia this is a first pass a what formatting could look like. My changes are the .clang-format file. Everything else is the result of running the formatter on Ascent code. The goal here is not to merge this in but rather show what changes would occur if this was added. …
artv3 commented on issue LLNL/RAJA#1817.
@tomstitt , adding you in the loop since I think we talked about this as well. …
jedbrown commented on issue spack/spack#50033.
What issue are you encountering? libCEED does not call BLAS directly, but libXSMM has a transitive dependency on BLAS so if you enable libXSMM, you should also specify BLAS_LIB
(because spack strives to be explicit). If that’s consistent with what you’ve observed, can you update this PR to only be used when libXSMM is enabled?…
trws commented on issue flux-framework/flux-sched#1361.
I haven’t delved into this too deeply, but I’m curious, why this over either using an expect script or piping input into resource_query? Did you add some extra functionality in the batch script, or is it more like the init-script option of gdb maybe? Can you specify multiple of them?…
grondo commented on issue flux-framework/flux-foundry#6.
Just a note that we’ll have to figure out how to handle this in the flux-python project….
garlick commented on issue flux-framework/flux-core#6763.
I didn’t ask, but @grondo did verify that dump doesn’t have a big impact (expected since it is not optimized for speed - it doesn’t get more than one content RPC going at one time)….
markcmiller86 commented on issue visit-dav/visit#20356.
@biagas and/or @JustinPrivitera if you can take a brief look and lemme know what you think so far, that would be great. I am deciding what to do about 3D axes because they have a lot of custom coding….
trws commented on issue spack/spack#49893.
sigh I should have realized I just reiterated what @tgamblin was saying. Regardless, that’s what’s going on. Sched isn’t tested to build against newer core versions currently….
tgamblin commented on issue spack/spack#49893.
> Is there any reason we can’t update e4s / exaworks? …
vsoch commented on issue spack/spack#49893.
I can comment that having built flux-sched and flux-core in a ton of environments, I either have needed to pin flux-sched to (at most) 0.37.0 and then flux-core to ~ 0.68.0, or use newer gcc and build the latest for both. Flux core seems pretty flexible to build with different versions of flux-sched - the breaks always happen with gcc/clang versions and sched. …
vsoch commented on issue singularityhub/singularity-hpc#690.
No worries! Can you bump this one more to 0.1.32? Turns out 0.1.31 was already on pypi so your previous change hasn’t been released yet. The silver lining here is we can do that easily now….
vsoch commented on issue pydicom/deid#277.
@ReeceStevens for black we have it pinned to black-23.3.0
- if you can pip install that version in an environment and run on the code, it should fix the failed test….
hppritcha commented on issue open-mpi/ompi#13189.
@janjust nvidia ci seems to be unhappy about cerficates…
vladotomov commented on issue mfem/mfem#4505.
Hi @PaulMoujaes, sorry for the delay on this. …
tzanio commented on issue mfem/mfem#4798.
Merged in next
for testing……
chu11 commented on issue flux-framework/flux-core#6629.
DOH! Prototyping the “triggers” per stackoverflow above … got things working while hard coding a random row limit into the trigger, but when I tried to make it configurable ……
cmoussa1 commented on issue flux-framework/flux-accounting#610.
One of the things I think some feedback would be especially helpful for would be how job.state.inactive
iterates through jobs as they complete. You’ll notice that I use a while
loop here to iterate through an association’s inactive jobs (if there is more than one held job) in the case that maybe the first job does not meet all requirements to be released by the plugin.
…
balos1 commented on issue LLNL/sundials#688.
> @balos1 for some reason the GitHub CI seems to be stuck. Any chance this is related to /autofix
somehow (looks like prior /autofix
pushes might not have run all the GitHub CI tests too)?
…
gardner48 commented on issue LLNL/sundials#688.
@balos1 for some reason the GitHub CI seems to be stuck. Any chance this is related to /autofix
somehow?…
JustinPrivitera commented on issue LLNL/conduit#1423.
Well yes, I suppose you can. I wasn’t reading carefully….
jeremylt commented on issue openjournals/joss-reviews#7124.
@editorialbot generate my checklist…
v-dobrev commented on issue mfem/mfem#4792.
Oh, I see, you want to be able to use find_package(mfem)
when you install with Spack which uses the GNU make build system. I was thinking about an MFEM installation from a CMake MFEM build….
v-dobrev commented on issue hypre-space/hypre#1267.
I tried the build that was failing in #1266 and it works fine in this branch. Thanks!…
tomstitt commented on issue hypre-space/hypre#1265.
> Thanks @ictmay I believe any version less than 2.32 will run fine for you since it doesn’t use hipMemcpyAsync
…
jameshcorbett commented on issue flux-framework/flux-sched#1180.
@behlendorf has been seeing this issue repeatedly on Hetchy. He submits a rabbit job, i.e. one that has ssd
entries in the jobspec. However, all ssd
vertices are marked down, so his job is stuck in SCHED
. After ssd
vertices are marked up
again, the job remains in SCHED
; however, new rabbit jobs run through fine….
jameshcorbett commented on issue flux-framework/flux-coral2#341.
That would certainly be pretty straightforward for us to support!…
benzwick commented on issue benzwick/StreamVorti#2.
Fixed by https://github.com/benzwick/StreamVorti/commit/f32d0f07806e2444f22724bb68bb2ccf22f96895…
astrophpeter commented on issue PandoraMission/pandora-sim#21.
@yoavrotman Can you add a minimum working code snippet with the error that is thrown so we can see what is going on:)? Please also print the version number of pandora-sim that you are using. …
emily-howell commented on issue Alpine-DAV/ascent#1499.
Should a new test be added to exercise this change?…
adrienbernede commented on issue LLNL/Caliper#647.
@daboehme CI is failing in this PR as well as on master. …
jedbrown commented on issue EnzymeAD/rust#197.
Also, that output can be higher dimensional and the caller might be composing adjoints of components (each of which was differentiated as separate functions instead of doing whole-program differentiation)….
hppritcha commented on issue mpi-forum/mpi-issues#993.
@jsquyres …
jameshcorbett commented on issue flux-framework/flux-docs#297.
I would remove them but I think there are external links to them and I don’t want those to get 404s, at least not for a few months….
grondo commented on issue flux-framework/flux-core#6752.
Thanks! Setting MWP….
jameshcorbett commented on issue flux-framework/flux-accounting#608.
Ohhhhh a real developer has commented with real suggestions. I second his suggestions. Obviously the only reason I didn’t make them myself was that I was too lazy…
jedbrown commented on issue RDycore/RDycore#302.
Oh, interesting. Yeah, I can build with no changes if I use cmake .. -G Ninja
. (I use Ninja for big projects like building LLVM so that doesn’t bother me as a workaround.)…
cmelone commented on issue LLNL/repligit#16.
…
adayton1 commented on issue LLNL/radiuss-spack-configs#126.
> @adayton1, CARE package currently has the following comment: …
artv3 commented on issue LLNL/RAJA#1799.
@johnbowen42 would also be able to add the kernel naming capability? It should be copy paste from one of the forall or launch implementations…
markcmiller86 commented on issue spack/spack#49735.
> AMReX is a very popular project. …
tpatki commented on issue flux-framework/flux-sched#1317.
High-level notes from the discussion with the group today: …
mplegendre commented on issue flux-framework/flux-core#6750.
I haven’t run the reproducer yet, but it’s “use hipcc compile at runtime” is definitely something that breaks spindle. Spindle is caching library lists for faster startup, and a program that builds new libraries at runtime breaks that caching….
grondo commented on issue spack/spack#49893.
Ah, I had forgotten that for Python 3.12 we’ll now need the packaging
module. See:
…
brendankeith commented on issue mfem/web#316.
All the changes look good from my end now!!…
mplegendre commented on issue hpc/Spindle#71.
The MsgReader::MsgReader() constructor’s second line is:…
brendankeith commented on issue METHODS-Group/DRDMannTurb#160.
Thanks for the note, @alizma !…
tzanio commented on issue mfem/web#316.
@brendankeith – gentle reminder about https://github.com/mfem/web/pull/316/#issuecomment-2770105900…
tzanio commented on issue mfem/mfem#4681.
Re-merged in next
for testing……
grondo commented on issue flux-framework/flux-core#6751.
Exceptions should be raised with flux job raise
, that will ensure the correct format. You might have to purge that job to get the job-list module to load again……
vsoch commented on issue flux-framework/flux-core#6738.
https://github.com/spack/spack/pull/49893…
tpatki commented on issue flux-framework/PerfFlowAspect#172.
Hi @loudsun1997 @spencer-gre : Just as a reminder, this closed PR may have some useful notes around the Adiak integration, we were working here earlier. …
adrienbernede commented on issue spack/spack#49732.
Meeting remarks:…
v-dobrev commented on issue spack/spack#49871.
@spackbot fix style…
astrophpeter commented on issue openjournals/joss-reviews#7699.
Thanks @fruzsinaagocs for catching that , I’ll get the team on it :-) …
jameshcorbett commented on issue flux-framework/flux-coral2#338.
Thanks @cmoussa1 ! I force-pushed to address your comments, setting MWP….
cmoussa1 commented on issue flux-framework/flux-coral2#338.
@jameshcorbett it looks like the arm64
check might have timed out - maybe a GitHub issue or something. Want to try restarting the builder?…
tpatki commented on issue LLNL/variorum#224.
@slabasan Maybe we should revisit this and clean up the AMD port’s output formatting for v0.9….
btalamini commented on issue LLNL/serac#1355.
Thanks, @tepperly ! It takes a village!…
artv3 commented on issue LLNL/RAJA#1773.
> I explicitly added a “getPlugin” test and manually confirmed that it fails if the “getPlugin” loading code is not there. I went ahead and approved the PR. …
JustinPrivitera commented on issue visit-dav/visit#20144.
hold middle mouse button and drag mouse to zoom…
cyrush commented on issue visit-dav/visit#20154.
Try to fix mili case for 3.5/0…
tgamblin commented on issue spack/spack#49256.
@haampie: …
cjvogl commented on issue mfem/mfem#4736.
I should note using the NewtonSolver
class with a general preconditioner (e.g., BlockDiagonalPreconditioner
) and general linear solver (e.g., GMRES
) doesn’t leverage any structure of the coupled problem and will very likely result in the same slow linear solve you experienced in the simple problem… but now at every Newton iteration. If that does happen, you can consider leveraging the structure through either a custom preconditioner or a custom solver. To motivate how this might go, I’ll return to your simplified linear problem…
JustinPrivitera commented on issue LLNL/conduit#1111.
I have handled many of these things but not updated the ticket. I need to take some time to check things off and link PRs that handled specific features….
cyrush commented on issue LLNL/conduit#1419.
@Arlie-Capps I am merging this in, so we it will be part of the release. …
JustinPrivitera commented on issue LLNL/Silo#444.
Also the…
markcmiller86 commented on issue visit-dav/visit#19309.
However, in the context of ASCII file I/O… …
vsoch commented on issue oras-project/oras-py#187.
I would be happy to review a PR with the fix. Thanks for catching this!…
v-dobrev commented on issue mfem/mfem#4758.
Hi @abhaybhatt,…
bwpriest commented on issue LLNL/saltatlas#94.
Yeah it’s ready. I was waiting on one of you two to make the final decision. …
trws commented on issue spack/spack#49698.
It (cmake) does keep them separate, but there are two meaningfully different ways that cmake hip projects build (not counting just yelling YOLO and pretending hipcc
will help). The cmake native way, what we usually do at Livermore with BLT these days, uses the actual hip language and as you say adds -x hip
and uses split flags. Kokkos, and most things derived from Kokkos, treat everything as C++, use the cmake variables for c++, and manually changes the c++ compiler to a hip compiler and injects the -x hip
and libraries. As long as we don’t break either of those, and keep commands executing the command that was requested, we should be good….
brendankeith commented on issue mfem/web#316.
> > I am happy to do this, but I’m overextended already this week. Mind if I get to it on the weekend? …
artv3 commented on issue mfem/mfem#4750.
> The following fails for me with error …
jeremylt commented on issue mfem/mfem#4609.
Yeah, I ran make test
successfully via the CMAKE instructions section of INSTALL
and all 95 tests passed. I think its ready…
cmoussa1 commented on issue flux-framework/flux-accounting#606.
thanks! setting MWP here…
corbett5 commented on issue GEOS-DEV/GEOS#3602.
@Victor-M-Gomes gotcha, thank you. Could you create an issue for this problem, including a minimum working example that you believe exhibits the leak? Then assign it to me and I’ll take a look when I have time. …
jedbrown commented on issue CEED/libCEED#1795.
libCEED is algebraic and not limited to $C^0$. One can use $C^1$, but you’ll need suitable restrictions and basis tabulations (we don’t have a convenience tabulator for Hermite or similar elements)….
jeremylt commented on issue CEED/libCEED#1795.
I mean to say that you can add a biharmonic equation example here using MFEM, it just would not be called a “bakeoff” problem….
emily-howell commented on issue Alpine-DAV/ascent#1496.
@cyrush I think I have addressed all your feedback but this is still a WIP: …
jedbrown commented on issue rust-lang/rust#138689.
I updated to add the ptx*
features and to fix dependencies within the sm_*
chain (and deal with the LLVM 20 requirement).
…
mplegendre commented on issue hpc/Spindle#70.
If you run ldd on spindle_bootstrap, does it have libmodules.so? If so, we need to figure out how that happened….
markcmiller86 commented on issue visit-dav/visit#20321.
@cyrush one smallish issue. If all the attributes testing we do in src/test/tests/unit/atts_assign.py
one test for invalid function name on a VisIt python object changed. It now rasies AttributeError
instead of NameError
exception….
adrienbernede commented on issue spack/spack#49637.
@spackbot re-run pipeline…
tzanio commented on issue mfem/mfem#4762.
Fixed in https://github.com/mfem/mfem/pull/4660…
homeomorfismo commented on issue mfem/mfem#4498.
> I put most of these commits (with a cleaner history; no cherry-pick sadly) in dev/abs-diag-smoothers
(see blob below). It mainly omits the L(p,q)-drivers, the PowerAbs
matrix products, and the included tests (that introduced a lot of duplicated code) for the Hypre matrix-vector product and the Dense matrix-vector product.
…
vladotomov commented on issue mfem/mfem#4285.
I tried running with NC meshes, but it fails. It this expected? If not, should be mentioned somewhere. …
chu11 commented on issue flux-framework/flux-core#6735.
side note, sort of the same situation in restore command…
cyrush commented on issue LLNL/conduit#1395.
resolved in #1395 …
JustinPrivitera commented on issue visit-dav/visit#20339.
/usr/workspace/justin/help_nathaniel…
trws commented on issue spack/spack#49698.
Am I reading this right that if you do g++ -x c
, this will actually change the command to be executed to SPACK_CC
and thus gcc
rather than g++
? While I’m 100% behind the idea that nobody should do that, invoking g++ -x c
and gcc
are different, and the reverse as well. The language inference makes total sense to me, but the command selection is a concern, especially if that means selecting a compiler from an entirely different family due to compilers as deps.
…
alecbcs commented on issue spack/spack#49769.
@spackbot run pipeline…
v-dobrev commented on issue mfem/mfem#4762.
Regarding the OpenMP backend: note that it is enabled with MFEM_USE_OPENMP
whereas the macro MFEM_USE_LEGACY_OPENMP
, which is used in real_t Vector::operator*(const real_t *v) const
, is for enabling some old OpenMP code sections. The MFEM_USE_LEGACY_OPENMP
option is deprecated. …
tgamblin commented on issue hpsfoundation/tac#23.
@jwillenbring can you link the TAC presentation here? I think it had more evidence for one of the more important criteria for the established stage – I’m not seeing this fleshed out above:…
jameshcorbett commented on issue flux-framework/flux-core#6723.
Looks great!…
jameshcorbett commented on issue flux-framework/flux-accounting#603.
I completely forgot that was a thing…
cmelone commented on issue LLNL/repligit#3.
notes:…
hppritcha commented on issue open-mpi/ompi#12226.
squashing a bit…
tomstitt commented on issue mfem/mfem#4571.
> > I think that should be supported, I fee like the MFEM_VERIFY’s could be removed. I would expect RAJA to do a kernel launch with no work in it. …
imguoguo commented on issue linuxdeepin/deepin-editor#338.
I have read the CLA Document and I hereby sign the CLA….
trws commented on issue flux-framework/rfc#441.
Yup, that
cmoussa1 commented on issue flux-framework/flux-accounting#601.
This is fixed now by #602. Closing…
balos1 commented on issue LLNL/sundials#682.
When you run CMake [sundials_config.in](https://github.com/LLNL/sundials/blob/main/include/sundials/sundials_config.in)
is processed into builddir/include/sundials_config.h
, which is then installed in instdir/include/sundials/sundials_config.h
. The processed sundials_config.h
should not have any #cmakedefine
statements in it, so It appears that you are somehow including a sundials_config.h
that has not been processed by CMake….
cmoussa1 commented on issue LLNL/cmvl#6.
I think this problem should be fixed now with the last merge request - the script now fetches jobs based on the last job timestamp it sees, so I’ll go ahead and close this, but can re-open if more specific issues come up. …
adayton1 commented on issue LLNL/RAJAPerf#504.
> I’m trying to guard the asm statement with #if defined(RAJA_COMPILER_MSVC)
but that doesn’t appear to be working in the windows build, is there a different way we’re supposed to detect MSVC builds?
…
artv3 commented on issue LLNL/RAJAPerf#504.
> Does it make more sense to put EMPTY in basic or algorithm? …
vsoch commented on issue oras-project/oras-py#185.
I’d be happy to review a PR that adds this functionality then….
artv3 commented on issue mfem/mfem#4571.
> > we’re running into issues with 1 element problems; specifically we call a routine that calls a kernel for 0
input, which triggers an assert (Verification failed: (N>0) is false
). We’ll figure out the other solver issue but any ideas on the 1 element case?
…
jandrej commented on issue mfem/mfem#4760.
Can you provide a minimal example where this is the case? There are several scenarios that can occur here. Have you compared your measurements with ex1p? …
cjvogl commented on issue LLNL/sundials#680.
> This has already been fixed on develop
…
artv3 commented on issue LLNL/RAJA#1799.
@johnbowen42 , I took a look – Overall its looking pretty good! My one comment is that we should add 2 lambda test just to verify that works as well. …
trws commented on issue flux-framework/flux-sched#1343.
Thanks for this @sam-maloney, I’m good with this change, and think we’ve all agreed with what this checks in the RFC change so I’m going to approve….
trws commented on issue flux-framework/flux-coral2#295.
That’s fair, I suppose I was thinking of it as a local event of a sort I’m not sure we even support, get notified of a load or unload of modules on the current broker. We could certainly add an event for “load complete” or similar, it would still leave it somewhat racy in that we might have started before the properties are updated but should at least be after all basic setup is complete….
btalamini commented on issue LLNL/serac#1336.
@ebchin , you were an active participant in the design discussions. Your viewpoint is valuable. Could you take a look at this one?…
hppritcha commented on issue spack/spack#49491.
Open MPI 5.0.0 and newer itself has no direct dependency on flux. I think with older versions of Open MPI there was some early flux work in the orte runtime, but that’s ancient history and not supported now….
adrienbernede commented on issue mfem/mfem#4431.
@tzanio @v-dobrev is there something I can do to help you get this merged ?…
acfisher commented on issue mfem/mfem#4689.
@hughcars @mlstowell Are there any other issues with this PR?…
mplegendre commented on issue hpc/Spindle#65.
Do you know how this happened? I don’t see anything obviously wrong in the scripting that manages testsuite results….
vsoch commented on issue skypilot-org/skypilot#3777.
Closing for no interest….
jedbrown commented on issue rsmpi/rsmpi#206.
Glad you found a solution. If you feel it would be useful, you’re welcome to submit a PR with an example demonstrating this pattern….
milroy commented on issue flux-framework/rfc#452.
Based on the in-person meeting earlier in the week, I can address some of the discussion items by combining our ideas from that meeting. …
vsoch commented on issue oras-project/oras-py#164.
Are we good to close here?…
grondo commented on issue flux-framework/flux-core#6716.
Thanks! I’ll set MWP here….
gardner48 commented on issue LLNL/sundials#674.
With MATLAB 2024a or newer, SUNDIALS is packaged with MATLAB so you don’t need to install it yourself. Following the examples here, after creating the ode class you can select a SUNDIALS integrator by setting the Solver
property of the ode class to “cvodesstiff”, “cvodesnonstiff” or “idas”….
bwpriest commented on issue LLNL/saltatlas#94.
Ok, I’ve removed the install and HDF5 elements from the build system, and removed outdated text from the README. I think this is ready to merge now….
JustinPrivitera commented on issue Alpine-DAV/ascent#1490.
I can’t speak authoritatively on what the issue might be in Ascent, but in VisIt we added mixed element topology support to the Blueprint reader in our latest release, 3.4.2. Which version of VisIt were you using when you saw the error?…
markcmiller86 commented on issue visit-dav/visit#20321.
I’ve discovered from other changes I need to make here. isinstance(x, str)
was generating a ValueError
exception due to no __class__
attribute. I think the solution is that we need to switch from getattr
/setattr
to getattro
/setattro
. I am testing on one object and it seems to be behaving better….
adrienbernede commented on issue spack/spack#49635.
@bvanessen I
v-dobrev commented on issue mfem/mfem#4747.
For visualization and probably for other purposes, it is better to compute the flux in a vector L2 space. Here’s a code snippet that does this:…
dylan-copeland commented on issue mfem/mfem#4756.
Hi @kogtenev, thanks for your question. In general, for different types of spaces, conformity in the FiniteElementSpace
is enforced by a conforming prolongation operator that maps from true DOFs to the full DOFs taken from all elements of their respective orders. The prolongation is done, regardless of the space type, by constraining high-order DOFs on shared edges and faces to interpolate the lowest order on the edge/face. I have worked on H1 spaces but not Nedelec spaces, in the context of variable order, so maybe there are some issues specific to Nedelec spaces that someone else can comment on, but I think this basic explanation is valid for all types of spaces. In particular, conformity should mean that tangential components are continuous, and the true DOFs are those of the lowest order on each entity (edge/face)….
v-dobrev commented on issue mfem/PyMFEM#263.
Take a look at Example 27/27p – it illustrates the usage of various (non-homogeneous, in general) boundary conditions for the Laplace equation….
chu11 commented on issue flux-framework/flux-core#6715.
yeah, when i discovered it I realized “oh crap, we could improve performance by NOT canceling watchers” …. to some loose extent the work to solve #6695 and #6709 made two iterations over watchers into 1 iteration. Since the update watcher for R in the job-shell was only doing 1 iteration to begin with, the addition of the cancel actually was a net loss….
btalamini commented on issue LLNL/serac#1344.
> I somewhat (very) concerned about the amount of duplication between our physics. But, I suppose the grand refactor is supposed to address that. In the meantime, I guess its ok? …
adayton1 commented on issue LLNL/radiuss-spack-configs#126.
CARE v0.15.0 has been released. The CARE_ENABLE_IMPLICIT_CONVERSIONS and CARE_ENABLE_RACE_DETECTION cmake options have been removed….
jeremylt commented on issue CEED/libCEED#1790.
If you have a fix now, go for it so we can release this weekend …
cyrush commented on issue Alpine-DAV/ascent#1445.
actual fides ci test case error is linking issue related to aidos2 + libfabric. …
cyrush commented on issue visit-dav/visit#19340.
Current behavior:…
cyrush commented on issue spack/spack#48517.
@vicentebolea thanks for these additions!…
astrophpeter commented on issue openjournals/joss-reviews#7769.
Hi Everyone, …
hppritcha commented on issue open-mpi/ompi#12226.
Okay. We should put this discussion of what to do with the datatype support in one of our upcoming tuesday meetings. Meanwhile, I think this PR is good to go - modulo commit squashing. Its clear from the initial commit message that this was one of several pieces of work that need to be done before we can claim complete (or reasonably complete) support for big count. Also getting this in to main now will help flush out any problems it may cause well before we branch for the next major release. If there’s some fundamental issue with providing bigcount support in the datatype engine we can modify the binding generating infrastructure to not generate the bigcount variants. …
jedbrown commented on issue mpi-forum/mpi-issues#977.
IMO, it should be possible to check that a type is supported without hazard of invoking an error handler to make that determination (or push/pop an error handler)….
acfisher commented on issue mfem/mfem#4689.
> > @hughcars After discussing it with the team we decided to make those owned tables non pointer objects and keep the interface by returning the pointers as usual. …
cmoussa1 commented on issue flux-framework/flux-accounting#599.
Oh that’s an interesting thought! Yeah, maybe if also during the reset, it could recalculate the limits….
grondo commented on issue flux-framework/flux-accounting#599.
This is a good idea, but as you mention, I’m not sure it could be done in a way that isn’t susceptible to races as you noted….
balos1 commented on issue LLNL/sundials#674.
Did you run make
after running cmake
? The cmake
command does not build sundials, it just generates everything needed for you desired build system (make, ninja, visual studio etc.). You still must run make
or other appropriate command to compile the library and create the libraries. …
IanLee1521 commented on issue LLNL/scraper#81.
You’ll need to use twine
to upload. The docs are: https://packaging.python.org/en/latest/tutorials/packaging-projects/#generating-distribution-archives…