Open Source Heartbeat: Open Source Heartbeat

Issue Comment Events

jedbrown commented on issue CEED/libCEED#1905.

It would depend on the loop body. For example, if it calls functions that don’t vectorize (we did the series work with log1p because it doesn’t vectorize in common implementations) or has branches that are unsafe/hard for the compiler to transform into masked vector arithmetic….

View Comment

vsoch commented on issue vsoch/hpsf-tac#1.

> I will ask to reserve that date for you during next TAC meeting. …

View Comment

garlick commented on issue vsoch/hpsf-tac#1.

> This is spot on - afaik there is no central governance model or document (beyond a brief contributing guide). This is something we need to put together before we submit this to the upstream repository as an issue for review. I am suggesting that we make a central .github repository for all projects to share a single source of truth. …

View Comment

grondo commented on issue flux-framework/flux-core#7215.

Thanks! …

View Comment

trws commented on issue vsoch/hpsf-tac#1.

Given this state, maybe it would be useful to do just a couple of tweaks in this PR then merge so we can collaborate via further PRs? Guess it depends on what all we want/need to do before trying to move this forward….

View Comment

imguoguo commented on issue sipeed/NanoKVM-USB#82.

Does it manifest as a dialog box prompting you to select a serial device, but then displaying “Failed to connect serial. Please try again” after selection? If so, it’s likely because the current user doesn’t have permission to connect to the serial port. You need to add the current user to the uucp group (this worked successfully on my Arch Linux) or the dialout group (this might be necessary on Fedora or Ubuntu)….

View Comment

vsoch commented on issue pydicom/deid#294.

I’m not sure I’m following - so let’s say you have a dicom with some set of Rows/Columns:…

View Comment

cbritopacheco commented on issue cbritopacheco/rodin#156.

@copilot Add interpolation tests on 8x8 grids. Also add tests to verify the case of one cell meshes. Across all geometries for K = 3….

View Comment

markcmiller86 commented on issue LLNL/Silo#503.

Resolved in #505 on 4.12RC and #508 on main….

View Comment

alecbcs commented on issue FrameworkComputer/EmbeddedController#73.

I’m also experiencing this issue on an AMD Framework 13 when using gnome-adaptive-brightness (issue linked above)….

View Comment

v-dobrev commented on issue xsdk-project/xsdk-issues#279.

> BTW: I’m not yet sure if I can use hypre-3 in xsdk - due to mfem dependencies [as there is no mfem release with hypre-3.0 fixes]. cc: @v-dobrev

View Comment

JustinPrivitera commented on issue visit-dav/visit#20666.

@IdoAkkerman I have added your changes here: #20737 …

View Comment

v-dobrev commented on issue mfem/mfem#4028.

Re-merged in next for testing……

View Comment

becker33 commented on issue spack/spack#51566.

Closing this – now that we’re not trying to get it in for v1.1.0, we have time for a better solution….

View Comment

hppritcha commented on issue openpmix/openpmix#3722.

this is the commit that tag 5.0.10rc1 points to …

View Comment

hppritcha commented on issue open-mpi/ompi#13484.

okay i got this to run but i don’t observe this heap-use-after-free warning in the voluminous output….

View Comment

tzanio commented on issue mfem/mfem#4996.

Merged in next for testing……

View Comment

benzwick commented on issue benzwick/StreamVorti#10.

Thanks @will-wz-li this fixed the problem. I updated the build badges on the README.md as well. …

View Comment

adrienbernede commented on issue spack/spack-packages#2558.

@spackbot re-run pipeline…

View Comment

tgamblin commented on issue spack/spack#51633.

@haampie: I think -p should do exactly this for the new installer, with default of 0 (for which p == j), and then we should just allow j to exceed p (I think we currently cap it, right?)…

View Comment

wihobbs commented on issue flux-framework/flux-core#7211.

Great summary, thanks @kush-gupt! And it was nice to meet you at SC25….

View Comment

grondo commented on issue chaos/pdsh#171.

Looks good, thanks!…

View Comment

markcmiller86 commented on issue spack/spack-packages#2346.

Just wanted to give praise for all of the CI checks here :clap: :tada:. Although it was sometimes a bit difficult to paw through the CI logs to diagnose failures, I was able ultimately to find and fix many issues without much hand-holding from other busy developers. …

View Comment

dylan-copeland commented on issue mfem/mfem#4936.

Should this PR have the “bug” label? If so, I’m not sure what the bug is….

View Comment

jandrej commented on issue mfem/mfem#5120.

I’m loading cuda/12.9.1 and use clang version 21.1.5 to build mfem with debug flags. The generated output file is ~15MB. I can share that with you internally if needed….

View Comment

adrienbernede commented on issue LLNL/Umpire#1009.

@kab163 Let me know if you need me to merge https://github.com/LLNL/radiuss-spack-configs/pull/150. I

vladotomov commented on issue CEED/Remhos#47.

@justinlaughlin is there a more recent version to use or do we merge this?…

View Comment

vladotomov commented on issue CEED/Laghos#195.

Hi @lpottier, sorry we missed this….

View Comment

markcmiller86 commented on issue spack/spack-packages#2346.

@patrickb314 sorry for false alarms…I discovered I was missing the compression lib options in the CMake builds….

View Comment

camierjs commented on issue mfem/mfem#5120.

In serial, CUDA mode, compiling fem/integ/bilininteg_vecmass_pa.cpp does not show up the issue so far:…

View Comment

vsoch commented on issue flux-framework/flux-sched#1420.

#$#%# I just ran pre-commit on the entire flux-sched codebase… …

View Comment

garlick commented on issue flux-framework/flux-core#7209.

Thanks, fixed those and I’ll set MWP….

View Comment

grondo commented on issue chaos/pdsh#171.

Meh, the commit validator is complaining that the commit message subject is too long. Not a huge deal, but you could reduce it to something like just …

View Comment

emily-howell commented on issue Alpine-DAV/ascent#1621.

Looks like the only thing that failed was the dray-cuda issue! So that’s a win at least. …

View Comment

JustinPrivitera commented on issue visit-dav/visit#20665.

> I am wondering if this PR conflicts with PR #20666. I will try to suggest changes to PR #20666, so this PR might be dropped?? …

View Comment

alecbcs commented on issue spack/spack#51617.

Looks good to me. …

View Comment

hppritcha commented on issue open-mpi/ompi#13520.

would you mind reconfiguring with the --enable-debug option and report the traceback? should help narrow down which opal_argv_join is causing the behavior. Also you may want to allocate a 2-element array of char ptrs and set the argv1[1] to NULL and see if that changes the behavior….

View Comment

tzanio commented on issue mfem/mfem#5115.

This PR has been updates, so the diffs are much smaller now and should be easier to review. …

View Comment

dylan-copeland commented on issue mfem/mfem#5054.

Commit 49cadecc82765de3d928ac5cdafebae921e4acb1 changed invS to CGSolver and then commit b145001e800a7359f7737844019af5a62063bc05 changed it back to GMRESSolver. It seems CGSolver is necessary to make the sample runs fast. Is there a good reason to have GMRESSolver? I changed it to CGSolver and found that the manufactured solution test nurbs_stokes -m ../../data/square-nurbs.mesh -o 2 -c 3 -sli 100 results in error on the order of 1e-6, which seems accurate enough and is much faster….

View Comment

jameshcorbett commented on issue flux-framework/flux-sched#1414.

Based on recent testing on El Cap, it looks like the first three checkboxes will not be enough to enable JGF there. At some point last week, the El Cap system instance was loaded temporarily with JGF, and the whole instance became unresponsive (see e.g. https://github.com/flux-framework/flux-core/issues/7207). I believe this is still being investigated on the core side….

View Comment

grondo commented on issue flux-framework/flux-core#7210.

Perhaps this should be obvious, but I’d like to understand the rationale for moving conf_bootstrap.c into libflux-core.so as a non-public function. What are the tradeoffs compared to keeping it in src/broker? …

View Comment

cbritopacheco commented on issue cbritopacheco/rodin#150.

@copilot I have implemented various fixes for the code you provided. The tests seem to pass but I fear that they don’t test the correct behaviour. Please try to verify correctness of the code. …

View Comment

brendenpetersen commented on issue NVIDIA-NeMo/Guardrails#1409.

+1 to this, major blocker for me!…

View Comment

adayton1 commented on issue LLNL/camp#191.

I would prefer that formatting changes be in a different pull request….

View Comment

adrienbernede commented on issue LLNL/Umpire#1003.

Replaced by #1017 : matrix job required a change in RADIUSS Spack Configs which is in the release candidate….

View Comment

adrienbernede commented on issue LLNL/RAJAPerf#529.

@tdrwenski I think we now need to turn on pages on LLNL/RAJAPerf. I don’t know which setting you used for your fork: branch or actions ?…

View Comment

adayton1 commented on issue LLNL/RAJA#1947.

Do we know why omp::mutex was used instead of std::mutex to begin with? Was the omp version more performant?…

View Comment

cyrush commented on issue Alpine-DAV/ascent#1621.

Looks like dray has some cuda issues, those would be unrelated to viskores, but may side effect of container update, I’ll take a look…

View Comment

adrienbernede commented on issue spack/spack-packages#1402.

@alecbcs I think this is ready. Just need to wait for you to be back from SC ;)…

View Comment

alecbcs commented on issue spack/spack-packages#2512.

@fsimonis has this patch been upstreamed to precice yet?…

View Comment

v-dobrev commented on issue mfem/mfem#5072.

Re-merged in next for testing……

View Comment

cyrush commented on issue LLNL/conduit#1479.

@mathstuf yes, that sounds like a much nicer way to formalize this …

View Comment

adrienbernede commented on issue LLNL/RAJA#1946.

Thanks for the details:…

View Comment

jedbrown commented on issue CEED/libCEED#1905.

> But, for the QFunction for loop, that would be 8 quadrature points per AVX register, not 8 elements. Is the idea just to keep the number of quadrature points divisible by 8?…

View Comment

chu11 commented on issue flux-framework/flux-core#7190.

hmmm, for backwards compatibility, should we stream only if the request is a streaming rpc?…

View Comment

BradWhitlock commented on issue LLNL/axom#1724.

@rhornung67 - I agree this is probably rare. Calling the Umpire function to make the resource manager is a more explicit workaround. Still, I ran into it because Umpire is not front and center in Axom so I did not realize I might run into problems calling axom::copy from an OpenMP loop. I thought I’d note the issue. I could also switch to memcpy() in this instance….

View Comment

becker33 commented on issue spack/spack-tutorial#505.

Closing in favor of #502, which includes the same commit…

View Comment

samuelkgutierrez commented on issue hpc/quo-vadis#411.

Perfect, @GuillaumeMercier. Thank you!…

View Comment

adayton1 commented on issue LLNL/spheral#430.

Mike’s already working on similar and more effective changes….

View Comment

alecbcs commented on issue LLNL/repligit#106.

Can you include a full reproducer performing an ls_remote() on the GitHub side as well?…

View Comment

becker33 commented on issue spack/spack#51587.

We will need to cherry-pick this to the release branch and add it to the release docs…

View Comment

tzanio commented on issue mfem/mfem#5115.

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….

View Comment

vsoch commented on issue jlowellwofford/sc25-flux-eks#6.

Going to merge so we have the base there, and we can always tweak. Bon voyage everyone! :airplane: …

View Comment

grondo commented on issue flux-framework/flux-security#209.

Ok, the CI failures are fixed here now. The necessary changes were: …

View Comment

markcmiller86 commented on issue visit-dav/visit#20651.

> I’m not sure how that resolves this situation. The code is not using DBAll to turn off the read mask flags. It is just using DBAll to turn everything back on after the read, and that part never stopped working. …

View Comment

eliasboegel commented on issue tracel-ai/cubecl#1040.

I would also be extremely interested in this….

View Comment

alecbcs commented on issue spack/spack-bootstrap-mirrors#46.

Completed in #51 …

View Comment

garlick commented on issue flux-framework/flux-core#6457.

Apparently an experiment was just done with ~250MB JGF on El Cap that went poorly…

View Comment

cmoussa1 commented on issue flux-framework/flux-accounting#782.

Thanks @jameshcorbett!…

View Comment

cbritopacheco commented on issue cbritopacheco/rodin#145.

@copilot I want to support building the dof arrays for space K>= 2 for the lower dimensional entities….

View Comment

balos1 commented on issue LLNL/spheral#428.

> Thanks for the help. I can confirm that adding the UCX library directory as an additional rpath did the trick….

View Comment

hppritcha commented on issue spack/spack-packages#2396.

never mind my bad. use the numerical sequence that you get when the package is installed. …

View Comment

cyrush commented on issue spack/spack-packages#143.

@tldahlgren dray is no longer developed as a stand alone package, and wont be using newer mfem versions. Given this – I support whatever the best path is to not block this pr. …

View Comment

tgamblin commented on issue spack/spack-packages#2391.

@jwillenbring @balay @victorapm do you have recommendations for how to fix this?…

View Comment

hppritcha commented on issue open-mpi/ompi#13514.

@AntonDaumen would you mind opening a PR for the v6.0.x branch based on a cherry-pick of this commit?…

View Comment

camierjs commented on issue mfem/mfem#5059.

The isf solver has been moved into a new miniapps/fluids subdirectory as suggested….

View Comment

markcmiller86 commented on issue LLNL/Silo#445.

@kmorel thanks for the note here :clap:….

View Comment

JustinPrivitera commented on issue visit-dav/visit#20073.

No worries, can we close this then?…

View Comment

tgamblin commented on issue spack/spack#51542.

@alalazo should this go here or in #51533 ? …

View Comment

v-dobrev commented on issue mfem/mfem#3658.

There are some strange commits in this PR, e.g. b46bb0d4 – we should consider squash-merging it….

View Comment

jameshcorbett commented on issue flux-framework/flux-sched#1417.

Merging manually because Mergify doesn’t want to….

View Comment

adayton1 commented on issue LLNL/axom#1721.

I do not have permissions to merge, so feel free to push the button @kennyweiss or @rhornung67….

View Comment

balos1 commented on issue LLNL/sundials#796.

Review Requests

View Comment

jeremylt commented on issue spack/spack-packages#2361.

I cannot speak to the MFEM changes, but that’s the right way to enable it for libCEED…

View Comment

markcmiller86 commented on issue spack/spack-packages#2346.

I am getting this error in one of the CI checks… …

View Comment

markcmiller86 commented on issue LLNL/Silo#312.

This has been started here, https://github.com/spack/spack-packages/pull/2346…

View Comment

JustinPrivitera commented on issue visit-dav/visit#20152.

> Is this correct? Shouldn’t the <td></td> tags be within the <tr></tr> tags?…

View Comment

tgamblin commented on issue spack/spack#51445.

Looks mostly good modulo the failing test :)…

View Comment

garlick commented on issue chaos/diod#160.

LMK = Let Me Know…

View Comment

chrundle commented on issue FLASK-LLNL/ChARGe#74.

> @chrundle Let’s put the LLNL specific files in our local project space for now and we can then add it to a gitlab internal project to keep it version controlled. …

View Comment

cyrush commented on issue visit-dav/visit#20707.

@JustinPrivitera thanks for this fix!…

View Comment

becker33 commented on issue spack/spack-packages#2176.

@dguibert did you get a chance to look at this again? Let me know if you need to hand it off….

View Comment

cmelone commented on issue spack/spack-packages#2290.

I can certainly add a +serial option to the package, but this is what I get when running spack spec cabana-pd

View Comment

becker33 commented on issue spack/spack#50560.

I have not gotten a chance to debug it yet….

View Comment

hppritcha commented on issue open-mpi/ompi#13280.

the arrays were’t being cleaned up anyway in the existing code. some checks for predfined datatypes resulted in not running the callback that was freeing these arrays. …

View Comment

tzanio commented on issue mfem/mfem#5097.

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….

View Comment

cyrush commented on issue mfem/mfem#4307.

@JustinPrivitera this can be closed in lieu of #5097 - we can continue discussion in the PR….

View Comment

garlick commented on issue flux-framework/flux-core#7112.

Thanks!…

View Comment

grondo commented on issue flux-framework/flux-core#7112.

Strange. I had to re-approve and then mergify finally merged this one. :shrug: …

View Comment

cyrush commented on issue LLNL/axom#1709.

thanks @kennyweiss …

View Comment

adrienbernede commented on issue LLNL/Umpire#1009.

Now that I read your full question, here is the full answer: …

View Comment

jeremylt commented on issue CEED/libCEED#1904.

```py …

View Comment

alecbcs commented on issue spack/spack#51522.

I’m nervous about picking the “preferred” version of a package without interpreting any constraints. This works now because cmake’s preferred version is v3.31.9, but the second that flips to v4 it’ll break since clingo-bootstrap@spack <= clingo@5.7.1 which conflicts with cmake@4….

View Comment

chu11 commented on issue flux-framework/flux-core#7186.

re-pushed, throwing an extra flux-fsck cleanup in there…

View Comment

grondo commented on issue flux-framework/flux-coral2#439.

Ok, I kind of doubt that is where the time in the sysadmin prolog (/etc/flux/system/prolog) is being spent anyway, since we know the dws_environment event is already available by the time it starts running….

View Comment

cmoussa1 commented on issue flux-framework/flux-accounting#772.

It’s also worth mentioning that #752 added a continuous re-check of held jobs after every flux account-priority-update, so at least there is the potential for the plugin to sort itself out on a periodic basis….

View Comment

grondo commented on issue flux-framework/flux-accounting#772.

Looking at the current job-manager code, a newly loaded plugin is sent the list of added jobs using zhashx_values() on the active job list:…

View Comment

JustinPrivitera commented on issue LLNL/conduit#1475.

You are welcome. Please let us know if you have further questions….

View Comment

camierjs commented on issue mfem/mfem#4333.

Tested on macos with latest Caliper - works fine!…

View Comment

wihobbs commented on issue flux-framework/flux-core#7043.

Yes, let’s check this off!…

View Comment

jameshcorbett commented on issue flux-framework/flux-coral2#439.

> Oh, I see now, there’s zstop_nnf_services.sh in /etc/flux/system/prolog-job-manager.d and zstop_nnf_clientmount.sh in /usr/libexec/flux/prolog.d. Do we need both of them?…

View Comment

artv3 commented on issue LLNL/RAJA#1832.

@bechols97 , can we bring this up to date?…

View Comment

wihobbs commented on issue flux-framework/flux-pmix#113.

Hmm, it looks like I don’t have write access here to add labels….

View Comment

trws commented on issue flux-framework/flux-core#7181.

That sounds right to me, but we should probably check and document. I think hwloc logical cores is exactly what we want it to be, should mean we can mock the topology however we want, but best to be sure….

View Comment

eleon commented on issue flux-framework/flux-core#7182.

> > Another approach to this PR would be to move the adjustment of the cores and gpus strings into the shell itself so that the values returned to plugins are the adjusted values. …

View Comment

tgamblin commented on issue spack/spack#51165.

I think this is subsumed by #51162, but let me know if there is something here that is not covered there….

View Comment

jedbrown commented on issue openjournals/joss-reviews#9333.

Hi @lindsayad @mprobson

tzanio commented on issue mfem/mfem#5023.

> I also saw that an ex41 is already in-review (#4289); please let me know if I should update this to be ex42. …

View Comment

grondo commented on issue flux-framework/flux-core#7182.

I’ve force pushed a new version of this PR that fixes up the core/gpu assignments in the shell proper, so that flux_shell_rank_info_unpack(3) reflects the update core and gpu sets. This allows mpibind to just work: …

View Comment

tzanio commented on issue visit-dav/visit#19046.

@cyrush – I am happy to elaborate further on this if it will be useful…

View Comment

cyrush commented on issue visit-dav/visit#19046.

Yes this does help - thanks for this explanation. …

View Comment

cyrush commented on issue spack/spack-packages#2222.

The concretizer can be unpredictable, frustrating aspect of all of this …

View Comment

imguoguo commented on issue radxa-pkg/radxa-firmware#29.

>

imguoguo commented on issue radxa-pkg/qualcomm-profiles#15.

>

hppritcha commented on issue open-mpi/ompi#13280.

all good ideas. i’ll work on these next week….

View Comment

tomstitt commented on issue mfem/mfem#4333.

> @tomstitt, is this backward compatible, and if not, should we check for the Caliper version? …

View Comment

v-dobrev commented on issue mfem/mfem#4993.

Re-merged in next for testing……

View Comment

cjvogl commented on issue mfem/mfem#4496.

> I’m happy to see this through @cjvogl. Do I have your permission to commit and push to your branch? :) …

View Comment

dylan-copeland commented on issue mfem/mfem#5087.

Thank you @chunyu79 for the update, and congratulations on finding a solution! I was able to run your test and reproduce the issue, but did not have time yet to investigate deeply. This was labeled as an AMR issue, but it seems more closely related to contact problems with constraints to couple boundaries of different domains. There has been recent work on this topic in PR 4996, and @psocratis may have some advice….

View Comment

jeremylt commented on issue freeCodeCamp/contribute#1008.

Those linked PRs are from staff. Staff are not external contributors….

View Comment

garlick commented on issue chaos/diod#158.

Oh this changed the github workflow so might need a manual merge. I’ll press the button….

View Comment

adrienbernede commented on issue LLNL/RAJA#1934.

(cancelled the CI pipeline to restart and force Matrix to run with variable)…

View Comment

adayton1 commented on issue LLNL/CARE#351.

@adrienbernede thank you!…

View Comment

adrienbernede commented on issue LLNL/CARE#351.

@adayton1 This is ready ;)…

View Comment

markcmiller86 commented on issue visit-dav/visit#20682.

Wow…great catch @biagas! No idea that logic existed….

View Comment

becker33 commented on issue spack/spack#51490.

Looking at the optimization criteria for variant_default_not_used and variant_not_default, it looks like we might have to swap the ordering some in addition to removing the one for variant_not_default for already built packages….

View Comment

alecbcs commented on issue spack/spack#51433.

Trying this PR I ran into a couple of errors on edge cases. Happy to help work on fixing these if needed. …

View Comment

gardner48 commented on issue mfem/mfem#5073.

> Should the calls be added to the examples? …

View Comment

jandrej commented on issue mfem/mfem#5073.

Should the calls be added to the examples?…

View Comment

bgunnar5 commented on issue LLNL/merlin#587.

@lucpeterson I think they are but then again I’m biased cause I wrote them…

View Comment

JustinPrivitera commented on issue visit-dav/visit#20666.

@IdoAkkerman please see continued discussion in #19046…

View Comment

imguoguo commented on issue radxa-pkg/radxa-system-config#54.

> etc

wihobbs commented on issue flux-framework/flux-core#7153.

For reference, here’s how mpibind prints affinity in verbose mode:…

View Comment

cmoussa1 commented on issue flux-framework/flux-accounting#778.

Thanks @jameshcorbett!…

View Comment

tpatki commented on issue flux-framework/PerfFlowAspect#191.

Closing with PR #199 and #200 …

View Comment

tpatki commented on issue LLNL/variorum#590.

@slabasan and I are in the process of testing ESMI+HSMP to obtain CCD-only (CPU) power on the APU. …

View Comment

trws commented on issue ACCBDD/reclamation-dev#276.

Not to say it’s “good” but a create deployer with buckets of water will fill the cauldron. Still trying to work out if I can automate this thing the rest of the way, but it’s something….

View Comment

JustinPrivitera commented on issue LLNL/conduit#1471.

put this in the blueprint spec docs…

View Comment

mplegendre commented on issue LLNL/Spindle#43.

Closing since Nick is putting together updated containers….

View Comment

vladotomov commented on issue CEED/Laghos#199.

Should I merge it or do you plan more additions?…

View Comment

balos1 commented on issue LLNL/sundials#789.

What compiler and version are you using? Can you attach your CMakeCache.txt file?…

View Comment

gardner48 commented on issue LLNL/sundials#787.

@drreynolds I’ve updated the correction modification to address the roundoff issues and resolved the open comments. However, this PR also includes updates from #788 (makes adding logging to the constraint checks easier), so hold off on taking another pass over this PR until that one is merged….

View Comment

jameshcorbett commented on issue LLNL/scr#604.

I fixed this up so all the actions pass, I think this is ready to go in. Will check in next team meeting. Actions are now passing: https://github.com/jameshcorbett/scr/actions/runs/18811341893…

View Comment

hppritcha commented on issue open-mpi/ompi#9837.

this PR can be closed. we moved well beyond this as part of the big count work. and there’s more to come sometime later after the ‘c’ ABI stuff is complete and we want to venture into a fortran ABI world….

View Comment

camierjs commented on issue mfem/mfem#3658.

> mpirun -np 4 pmesh-optimizer -m kershaw_6x6x6.mesh -o p -rs rl -mid 321 -tid 5 -ls 3 -nor -rtol 1e-8 -vl 1 -lc 0.5 -pa

View Comment

v-dobrev commented on issue mfem/mfem#5085.

Some thoughts: some of the methods in ARKStepODE will be common with other similar classes. How do you envision avoiding repeated definitions? Also, when you inherit from both TimeDependentOperator and ARKStepODE, you get Mult from both and you have Width/Height (from the former) and Size from the latter which is not ideal. …

View Comment

garlick commented on issue chaos/diod#147.

I’ve got it, thanks!…

View Comment

grondo commented on issue chaos/diod#147.

Yeah, want me to press the button?…

View Comment

gardner48 commented on issue LLNL/sundials#788.

The main logging updates are in tools/suntools/logs.py. The changes to the source files and outputs are to update logging region labels to the new convention of <begin|end>-<region-name>[-list] (mostly adding -list where needed)….

View Comment

markcmiller86 commented on issue LLNL/Silo#477.

Am recording here a smoking gun reproducer of the issue in error stack error messages. Attached is an intentionally corrupted HDF5 file. 1.14.4 produces an error message indicating a checksum failure. 1.14.6 does not. …

View Comment

tgamblin commented on issue spack/spack#51461.

Per discussion in Slack, @alalazo’s going to make a PR that fixes the docs and does this: …

View Comment

tzanio commented on issue mfem/mfem#5086.

Merged in next for testing……

View Comment

artv3 commented on issue mfem/mfem#5082.

This is great! I’ll give it a spin these next few days. The one suggestion I have is lets add a constructor that enables us to specify the device memory type — I just pushed something up for quadrature function here: https://github.com/mfem/mfem/pull/5086 …

View Comment

vladotomov commented on issue mfem/mfem#3658.

@camierjs …

View Comment

jandrej commented on issue mfem/mfem#5022.

> Are there some GPU Tests enabled ? …

View Comment

cjvogl commented on issue mfem/mfem#4977.

This is now out of scope for this PR (given what was discussed at the technical meeting today), but if anyone is interested in future work into how refactoring TimeDependentOperator into modular interfaces might look (as @bslazarov had suggested at one point), I’ve started a WIP PR that showcases how an ARKStepSolver-specific interface could work: https://github.com/mfem/mfem/pull/5085…

View Comment

chakshinglee commented on issue liruipeng/ml2#37.

The PR looks good to me too. I only have a design question around the Chebyshev frequencies (see above). Another thing, which is beyond the scope of this PR, is that how do you guys think about using config files instead of relying on command line options to pass in values of various parameters?…

View Comment

grondo commented on issue flux-framework/flux-core#7168.

Well, I don’t actually see anything in RFC 44 that says an undrain event can only be posted for ranks that were previously drained, so one idea would be to add a new “mode” to the undrain RPC like “update” which simply posts an extra undrain event to the eventlog with the new reason. A tool would then have to process the entire resource eventlog to be sure the most updated undrain reason event for any given rank has been processed (instead of assuming the first undrain event after the corresponding drain event has the correct reason)….

View Comment

chu11 commented on issue flux-framework/flux-core#7158.

re-pushed, removing the “common function” discussed above. Fixed up a few commit messages I noticed still said --async

View Comment

imguoguo commented on issue RadxaOS-SDK/rsdk#112.

>

adayton1 commented on issue LLNL/blt#737.

Could you do CUDA builds on another toss 4 machine? There would just be no testing the executables. But testing the build is better than nothing….

View Comment

jeremylt commented on issue CEED/libCEED#1901.

Yup, that should be the fix - use the blocking as if we actually cared about the basis for the operation…

View Comment

JustinPrivitera commented on issue visit-dav/visit#20576.

TODO…

View Comment

imguoguo commented on issue radxa-pkg/qualcomm-profiles#10.

https://applink.feishu.cn/client/message/link/open?token=AmfHwOsK4gAEaPnma7hoQAQ%3D…

View Comment

tomstitt commented on issue mfem/mfem#5027.

I see that ipiv_base is used in some places but not all, does it make sense switch everywhere to use it? or remove it?…

View Comment

garlick commented on issue flux-framework/flux-core#7158.

> So, we need to store all the lookup error indexes and errnos on a list somewhere for later retrieval. But that just seemed like a lot of effort for the amount of gain. (thus my eventual “err_cb” mechanism instead) …

View Comment

cmoussa1 commented on issue flux-framework/flux-accounting#775.

Actually, I think I might have just discovered it

JustinPrivitera commented on issue Alpine-DAV/ascent#1620.

``` …

View Comment

cyrush commented on issue visit-dav/visit#20636.

First pop up:…

View Comment

garlick commented on issue flux-framework/flux-foundry#21.

Oh right, no mergify. Pressing the button….

View Comment

wihobbs commented on issue flux-framework/flux-core#7165.

> You didn’t provide any argument for using a long_help variable or against a docstring, though, so perhaps I’m missing something obvious. …

View Comment

jbschroder commented on issue XBraid/xbraid#96.

Hi,…

View Comment

adayton1 commented on issue LLNL/camp#190.

I’m looking at the definition for unordered_map and unordered_multimap, and as far as I can tell they only require the equality operator….

View Comment

adayton1 commented on issue LLNL/RAJA#1923.

@rhornung67, is this still a WIP or is it ready for review?…

View Comment

vsoch commented on issue flux-framework/flux-coral2#411.

This does not require review yet. Updates for this PR include: …

View Comment

tzanio commented on issue mfem/mfem#5072.

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….

View Comment

chu11 commented on issue flux-framework/flux-core#7158.

re-pushed, converting –async to –fast….

View Comment

cjekel commented on issue cjekel/similarity_measures#40.

LGTM! Thank you! Sorry this took so long to get in….

View Comment

trws commented on issue LLNL/camp#190.

As it sits I’m ok with this, but I expected based on the description that there would be a specialization of std::hash in here so that unordered_map and similar could hold them. Is that not part of what you wanted to accomplish?…

View Comment

JustinPrivitera commented on issue visit-dav/visit#17791.

3.5.0 deliverables have been completed so I am leaving the milestone at 4.0….

View Comment

tgamblin commented on issue spack/spack#51137.

> Finally, just a comment on colors (disregard this if you don’t agree). I wouldn’t use red for run dependencies, cause red is usually associated with failures. Maybe yellow? …

View Comment

imguoguo commented on issue radxa-pkg/qualcomm-profiles#7.

>

v-dobrev commented on issue mfem/mfem#4431.

@tzanio, I just pushed a small update to increase the timeout on Matrix – please re-merge it in next when you get a chance….

View Comment

artv3 commented on issue mfem/mfem#2176.

I think we can close this PR, its from a long time ago… …

View Comment

jameshcorbett commented on issue flux-framework/flux-sched#1403.

Hi @kostiscpp sorry I forgot to answer this. Are you still interested in a solution? As @grondo mentioned, Fluxion needs to be configured so that it knows about the topology of each node, and specifically about the placement of sockets. How are you starting your Flux instance at the moment?…

View Comment

grondo commented on issue flux-framework/flux-core#7158.

Just for my own curiosity, when would we not want the “fast” behavior? …

View Comment

garlick commented on issue flux-framework/flux-core#7157.

Dropcache drops “clean” blobs from the cache but that doesn’t mean other things (KVS, metadata) aren’t still referencing those blobs….

View Comment

hppritcha commented on issue open-mpi/ompi#13436.

closing this and opening a new one with different selection of shas…

View Comment

hppritcha commented on issue mpi-forum/mpi-forum.github.io#27.

@wesbland updating sessions wg leads…

View Comment

JustinPrivitera commented on issue mfem/mfem#4307.

@cyrush can we let this be automatically closed since you have solved this in VisIt? Or do we still need this?…

View Comment

jandrej commented on issue mfem/mfem#4485.

ping @nnpp-schneier @victor-decaria-nnl …

View Comment

adrienbernede commented on issue mfem/mfem#4431.

@v-dobrev thank you for updating this PR. Glad to see you leverage latest support for matrix added very recently. …

View Comment

homeomorfismo commented on issue mfem/mfem#4498.

@pazner Makes sense to me!…

View Comment

grondo commented on issue flux-framework/flux-coral2#430.

I opened an issue here to discuss possible solutions: …

View Comment

jameshcorbett commented on issue flux-framework/flux-coral2#430.

Putting documentation in the docstring makes sense to me. This plugin certainly does not require much documentation, what it does is reasonably straightforward….

View Comment

garlick commented on issue flux-framework/flux-coral2#430.

Hmm, that is a conundrum. I wonder if it would just make sense to have one flux-coral2 page in section 7 with a subsection titled RUN COMMAND EXTENSIONS or similar?…

View Comment

vladotomov commented on issue CEED/Laghos#196.

@wdhawkins please add 1-2 lines to the README to mention building with Caliper, and I’ll merge this….

View Comment

cyrush commented on issue visit-dav/visit#5770.

@BenWibking thanks for the update – I am sure adding AMR support was a good amount of work and others could benefit from these improvements even if there are some outstanding issues. Would you like to get your new plugin into visit proper?…

View Comment

jedbrown commented on issue openjournals/joss-reviews#9244.

Hi @PabloIbannez, @valsson

camierjs commented on issue mfem/mfem#5057.

I updated the [MTOP] solver with GPU support #5072 TODO item to point to the new PR (#5072)….

View Comment

btalamini commented on issue jax-ml/jax#24295.

Thanks, makes sense. In my case, if I knew that a particular use of the solver wasn’t going to be differentiated, I wouldn’t bother wrapping it with custom_root at all. It’s not really buying you anything if you’re not differentiating over the closed-over variables….

View Comment

jedbrown commented on issue RDycore/RDycore#348.

An alternative would be to write partition statistics on stdout, like we do in Honee. I guess we could put something like this into -dm_view_partition….

View Comment

tpatki commented on issue Olympus-HPC/Mneme#51.

Hi @koparasy Yes, please merge. Sorry, just saw this, had missed the notification. …

View Comment

bgunnar5 commented on issue LLNL/merlin#585.

Thanks for the review @jwhite242. I’ll go back through all of the docstrings/type hints to make sure they’re accurate with the latest changes once this is done….

View Comment

chrundle commented on issue FLASK-LLNL/ChARGe#28.

Cancelling pull request (separated into two separate requests for backend and experiments/)…

View Comment

cmelone commented on issue cmelone/hubcast-test#4.

@lc-hubcast help…

View Comment

cmelone commented on issue brandonlieu2001/cse-data-status#2.

love it…

View Comment

adayton1 commented on issue LLNL/spheral#415.

Superseded by #417 …

View Comment

jedbrown commented on issue openjournals/joss#1465.

Looks like Typst recently implemented PDF/A support, which was a blocker earlier. I like Typst, but I have mixed feelings about the cost/benefit of JOSS adding support. JOSS articles are relatively short and Markdown is mostly sufficient. Typst would have the benefit of…

View Comment

jedbrown commented on issue openjournals/joss#1465.

> Point 1. would be a benefit only if typst was to replace the current markdown+pandoc toolchain, right?…

View Comment

chrundle commented on issue FLASK-LLNL/ChARGe#28.

Made updates we discussed during Webex meeting in most recent commit…

View Comment

cyrush commented on issue visit-dav/visit#20586.

In this case, I think he was exporting to cache some results. …

View Comment

markcmiller86 commented on issue visit-dav/visit#20586.

Ok, it looks like a VTK_CONVEX_POINT_SET is a special case of an arbitrary polyhedron. Apparently, with just the points alone, and nothing else, a VTK_CONVEX_POINT_SET specifies the faces (and edges) of the resulting points using an algorithm to extract the faces of the convex hull….

View Comment

JustinPrivitera commented on issue visit-dav/visit#20624.

Glad you got this working!…

View Comment

hppritcha commented on issue open-mpi/prrte#86.

This PR is needed before opening on against OMPI main to move the openpmix and prrte 3rd-party shas. @edgargabriel …

View Comment

hppritcha commented on issue open-mpi/ompi#13280.

oh for inquiring minds, it looks like several opal params need to be adjusted if building libmpi_abi.so. It looks like these can all be controlled with configure options, e.g.: …

View Comment

jandrej commented on issue mfem/mfem#5064.

What do you expect calling FormLinearSystem on a NonlinearForm? I don’t see how this should be defined….

View Comment

v-dobrev commented on issue mfem/mfem#4524.

Re-merged in next for testing……

View Comment

grondo commented on issue flux-framework/flux-foundry#17.

Feel free to push here directly. I’ll be out of town the next few days…

View Comment

chu11 commented on issue flux-framework/flux-core#7082.

re-pushed, with possibly a disliked change. --quiet is now advertised that it only suppresses “non-core” diagnostic messages. So Checking integrity of ... diag message is always output to stdout. …

View Comment

garlick commented on issue flux-framework/flux-core#7082.

Also, since we’re at the beginning of a release cycle, I wonder if we ought to just add the --repair option and then give ourselves some time to poke at that on test systems? …

View Comment

grondo commented on issue flux-framework/flux-core#7137.

Minor suggestion: add a test for handle.attr_remove(not_a_string)

View Comment

garlick commented on issue flux-framework/flux-coral2#424.

See also…

View Comment

garlick commented on issue chaos/powerman#205.

We already support an include directive….

View Comment

antoniuk1 commented on issue FLASK-LLNL/ChARGe#30.

> @antoniuk1 Does this supersede PR #20 ? …

View Comment

antoniuk1 commented on issue FLASK-LLNL/ChARGe#30.

> @antoniuk1 Does this supersede PR #20 ? …

View Comment

jeremylt commented on issue CEED/libCEED#1806.

Yeah, since there are QFunctions that are not available via the gallery, you’d have to use the technique shown in this folder for ex3_volume.py (and associated files) to use a QFunction written in C….

View Comment

jedbrown commented on issue openjournals/joss-reviews#7716.

Thanks @dostuffthatmatters and @abaer-kit. I’m personally sympathetic to the security/complexity issues (and would note that HPC facilities prefer to have people analyze/postprocess data from that facility to avoid egress/off-site transfer). From a usability standpoint, I see not much testing and a list of error codes, but I think it’s rarely going to provide enough information to diagnose and fix the problem from the client machine, which means someone has to manually log in and replicate an environment on the login node. As soon as you’re doing that, you’d be better off submitting jobs from the login node. At least that has been my experience (with many HPC systems and applications/software stacks over the years). But I’d like to defer to people who work with ICON….

View Comment

trws commented on issue flux-framework/flux-core#7130.

That sounds right. The fluxion code that reads from these always uses the max currently though, and somewhat relies on there being an upper bound. We can certainly make the max optional, but the effect will be that the min will become the max until we have time to work through how to handle unbounded requests….

View Comment

trws commented on issue flux-framework/flux-core#7130.

That sounds right. The fluxion code that reads from these always uses the max currently though, and somewhat relies on there being an upper bound. We can certainly make the max optional, but the effect will be that the min will become the max until we have time to work through how to handle unbounded requests….

View Comment

chu11 commented on issue chaos/powerman#205.

recent offline conversation with @kkier and @watson6282…

View Comment

markcmiller86 commented on issue betterscientificsoftware/bssw.io#1513.

@bernhold mind if I transfer this issue to my own, personal org, repo? To do this, I would have to create a temp. repo here, transfer the issue to that repo, then transfer the repo to my personal org….

View Comment

jedbrown commented on issue assert-rs/libtest2#13.

This suggestion reminds me of quickcheck and proptest, which supports syntax like:…

View Comment

jedbrown commented on issue assert-rs/libtest2#13.

This suggestion reminds me of quickcheck and proptest, which supports syntax like:…

View Comment

tomstitt commented on issue Olympus-HPC/proteus#302.

thank you @ggeorgakoudis !!…

View Comment

tomstitt commented on issue Olympus-HPC/proteus#302.

thank you @ggeorgakoudis !!…

View Comment

balos1 commented on issue LLNL/sundials#784.

> It would be ideal if this error could have been caught by an example or unit test. …

View Comment

jandrej commented on issue EnzymeAD/Enzyme#2309.

@wsmoses this came up in an internal discussion and we’d appreciate a slim repo as well….

View Comment

jandrej commented on issue EnzymeAD/Enzyme#2309.

@wsmoses this came up in an internal discussion and we’d appreciate a slim repo as well….

View Comment

tzanio commented on issue CEED/Laghos#196.

ping: @bslazarov…

View Comment

tzanio commented on issue mfem/mfem#5016.

Merged in next for testing……

View Comment

milroy commented on issue flux-framework/flux-sched#1412.

Thanks for the quick review @trws! Setting MWP….

View Comment

milroy commented on issue flux-framework/flux-sched#1412.

Thanks for the quick review @trws! Setting MWP….

View Comment

garlick commented on issue flux-framework/flux-foundry#13.

Per offline discussion, we’ll not move libtaskmap to this repo. It can stay in core….

View Comment

vsoch commented on issue singularityhub/singularity-docker#17.

They are not automatically generated - they are branches in the repository….

View Comment

vsoch commented on issue pydicom/deid#291.

@bghill we can also update the project version of jekyll. …

View Comment

balos1 commented on issue pthom/litgen#35.

That would be great, or at least having an option to bypass it. …

View Comment

trws commented on issue flux-framework/flux-sched#1406.

This review makes me wish really, really hard we had a good way to do a stacked PRs workflow. There are several tiny really nice obvious fix commits in here we could have landed almost instantly. Anyway, I’m working on a full review over the next hour or so….

View Comment

trws commented on issue flux-framework/flux-sched#1406.

This review makes me wish really, really hard we had a good way to do a stacked PRs workflow. There are several tiny really nice obvious fix commits in here we could have landed almost instantly. Anyway, I’m working on a full review over the next hour or so….

View Comment

cmoussa1 commented on issue flux-framework/flux-accounting#292.

This can probably be closed with the introduction of the jobs command from #674….

View Comment

jameshcorbett commented on issue flux-framework/flux-accounting#768.

tzanio commented on issue GLVis/glvis#338.

Thanks @najlkin! …

View Comment

tomstitt commented on issue mfem/mfem#5047.

thank you @nbeams and @tzanio ! …

View Comment

tomstitt commented on issue mfem/mfem#5047.

thank you @nbeams and @tzanio ! …

View Comment

gardner48 commented on issue LLNL/sundials#780.

> Have we confirmed that SUNDIALS can build without issue in C23? …

View Comment

adayton1 commented on issue LLNL/spheral#417.

Should combining instantiations into one file or keeping them in separate 1D, 2D and 3D files be the default?…

View Comment

artv3 commented on issue LLNL/RAJA#1925.

@johnbowen42 , not sure if this might be out of the scope of this PR. But there may also be a lot of duplicate capability here: …

View Comment

eleon commented on issue spack/spack-packages#1736.

Thanks very much, @tgamblin …

View Comment

eleon commented on issue spack/spack-packages#1736.

Thanks very much, @tgamblin …

View Comment

grondo commented on issue flux-framework/rfc#470.

Just pushed a fixup commit that makes the exec protocol single response when the background flag is set based on discussion in flux-framework/flux-core#7107. If the new version is acceptable, I’ll squash the new commit….

View Comment

garlick commented on issue flux-framework/flux-core#7111.

This was just an idle thought this morning. If we don’t want largish XML (144K here) blobs accumulating in our source tree, I can withdraw. …

View Comment

markcmiller86 commented on issue visit-dav/visit#17308.

I have looked at this a number of different ways. The Mili dataset is a bit unique in that it is a mesh consisting of hex elements (3D), quad elements (2D) and line elements (1D). The stress variable is defined using 6 scalars, sx, sy, sz and sxy, syz and sxz. Its a symmetric tensor. And it is defined on both the hex (3D) and quad (2D) elements. As an aside, I never get a plot yielded no data warning. I printed and queried values using %16.16g and everything shows all zeros. When I run with -debug 5 on the command-line, I see the vtkMath.cxx:778 spew to stderr and in the .vlogs. I looked at the vtkMath.cxx source code and comments. …

View Comment

tgamblin commented on issue spack/spack-packages#1736.

@eleon looks like style is falling – so you will need tor resolve the style issues….

View Comment

alecbcs commented on issue spack/spack#51371.

My personal preference would be to educate users through improved documentation instead of writing a custom setup wrapper, git hooks, and our own bash rebase script. If other’s are strongly in favor of the wrappers, I’m okay if this is added….

View Comment

vsoch commented on issue pydicom/deid#289.

Great news! We just need a bump to the version (maybe a larger one this time) and the corresponding entry to the changelog….

View Comment

tzanio commented on issue mfem/mfem#5022.

> > Mention in CHANGELOG? …

View Comment

jandrej commented on issue mfem/mfem#5022.

> Mention in CHANGELOG? …

View Comment

vladotomov commented on issue mfem/mfem#3658.

@camierjs I’m almost done looking at this, can we rename all *coef.cpp files to *limit.cpp?…

View Comment

vladotomov commented on issue mfem/mfem#3658.

@camierjs I’m almost done looking at this, can we rename all *coef.cpp files to *limit.cpp?…

View Comment

trws commented on issue flux-framework/flux-sched#1296.

Awesome, great work!…

View Comment

grondo commented on issue flux-framework/flux-core#7109.

This one seems pretty safe. The main use case is probably running newer or older Flux as jobs under a system instance. Since the single user jobs probably don’t have permission to send events, I doubt this is currently in use anywhere (even using the API or Python). …

View Comment

balos1 commented on issue LLNL/sundials#768.

> General question on the C++ wrappers, how is error handling done? For examples, what happens if one of the C constructors returns NULL? …

View Comment

JustinPrivitera commented on issue visit-dav/visit#20114.

For my own future reference, data is here: /usr/workspace/justin/issue_visit_20114

View Comment

hppritcha commented on issue open-mpi/ompi#13280.

thanks. hopefully we can get most (all?) of the failures cleaned up within the next week or so. …

View Comment

v-dobrev commented on issue mfem/mfem#4684.

@adrienbernede, I’ll merge this in #4431 and start updating that to replace ruby with dane, lassen with matrix, merge master etc….

View Comment

milroy commented on issue flux-framework/flux-sched#1296.

Noting that @zekemorton discussed this PR with @trws in the group meeting yesterday, and Tom said he was good with the changes provided that the PR doesn’t alter the default behavior (which it doesn’t)….

View Comment

chu11 commented on issue flux-framework/flux-core#7082.

> Could always use isatty() to change behaviors when run interactively. …

View Comment

cmoussa1 commented on issue flux-framework/flux-accounting#768.

OK, well this turned into a larger cleanup than I was expecting

cmelone commented on issue LLNL/repligit#82.

@dependabot recreate…

View Comment

adrienbernede commented on issue spack/spack-packages#1402.

@alecbcs Gitlab CI now passing. Style fixed….

View Comment

alecbcs commented on issue spack/spack-packages#1747.

Yes to test installing v1.2 you can type: …

View Comment

adrienbernede commented on issue spack/spack-packages#1402.

@alecbcs Gitlab CI was passing, waiting for new run. Style fixed….

View Comment

tgamblin commented on issue spack/spack#51047.

I will just echo what @haampie said – env vars in the environment are meant to affect the run environment, not the build environment. …

View Comment

mplegendre commented on issue LLNL/Spindle#102.

I think this is looking great. Anything else before I merge?…

View Comment

mplegendre commented on issue LLNL/Spindle#102.

I think this is looking great. Anything else before I merge?…

View Comment

adrienbernede commented on issue LLNL/CARE#349.

@adayton1 Starting with #348 (which is ready), you can deactivate the lassen CI jobs by setting the variable ON_LASSEN to OFF in the GitLab UI / CARE project / Settings / CI/CD / variables….

View Comment

adrienbernede commented on issue LLNL/CARE#349.

@adayton1 Starting with #348 (which is ready), you can deactivate the lassen CI jobs by setting the variable ON_LASSEN to OFF in the GitLab UI / CARE project / Settings / CI/CD / variables. …

View Comment

tzanio commented on issue mfem/web#291.

@helloworld922 and @cjvogl, what do you think about this PR?…

View Comment

artv3 commented on issue LLNL/RAJA#1922.

@LLNL/raja-core , does anyone else want to take a look? otherwise I will release tomorrow …

View Comment

jedbrown commented on issue rust-lang/cargo#4895.

This situation occurs a lot with MPI (the communication library) and more generally with C libraries in which build configuration affects the ABI (common in scientific computing libraries, unfortunately). In those cases, the libraries one wants to use are not in a default path and it would have disruptive side-effects to add them (even when using “modules”, which are popular on HPC systems)….

View Comment

imguoguo commented on issue radxa-pkg/edk2-qualcomm#4.

https://applink.feishu.cn/client/message/link/open?token=AmfHwOsK4gAEaNpU1qt6AAM%3D…

View Comment

tomstitt commented on issue mfem/mfem#5047.

> @tomstitt, is this ready-for-review? …

View Comment

trws commented on issue LLNL/RAJA#1919.

cyrush commented on issue Alpine-DAV/ascent#1616.

@emily-howell FYI: we should merge this PR before the vtk-m -> viskores update….

View Comment

tzanio commented on issue mfem/mfem#5045.

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….

View Comment

garlick commented on issue flux-framework/flux-core#7085.

It feels a bit like adding root to every group in /etc/group. While I guess you could argue that doing so reminds people that root can access their files, it doesn’t exactly telegraph the reality of the situation, which is that root cannot be prevented from accessing your files (at least in old school unix)…

View Comment

grondo commented on issue flux-framework/flux-core#7090.

Maybe a new race condition introduced in another PR? Maybe I can try reproducing locally….

View Comment

alecbcs commented on issue spack/spack-packages#1719.

Looks like harfbuzz is unable to find the freetype dependency on Windows….

View Comment

vsoch commented on issue kubeflow/trainer#2841.

What Flux is going to help with:…

View Comment

chu11 commented on issue flux-framework/flux-core#7085.

As an aside:…

View Comment

jeremylt commented on issue CEED/libCEED#1892.

Yeah, that shouldn’t be valid. Only size >= 0…

View Comment

cyrush commented on issue visit-dav/visit#20618.

@biagas can you test the windows logic?…

View Comment

becker33 commented on issue spack/spack-packages#1531.

@adamjstewart this looks good to me, just need to resolve conflicts from the other deprecation removal PRs….

View Comment

cyrush commented on issue LLNL/blt#732.

Since this isn’t needed for common use cases, we should remove it and projects that hit the limit can add windows specific flags for their build…

View Comment

adayton1 commented on issue LLNL/RAJA#1918.

> It looks like we also set something for hip to C++17. Does that RAJA_HIPCC_STD_FLAG variable get used? …

View Comment

jandrej commented on issue mfem/mfem#5022.

If someone is interested in the complexity calculations, here you go. …

View Comment

tomstitt commented on issue hypre-space/hypre#1383.

Hey @victorapm , fine by me to wait! Thanks…

View Comment

tomstitt commented on issue hypre-space/hypre#1383.

Hey @victorapm , fine by me to wait! Thanks…

View Comment

jameshcorbett commented on issue flux-framework/flux-coral2#413.

Sorry for the delay on this. I’m not sure what the best approach is. I’d definitely want the RPM build to fail and also some tests to be skipped if the module isn’t found, but we could probably add an optional flag to the configure line to make kubernetes a hard requirement, and then add that flag to the RPM spec. …

View Comment

jeremylt commented on issue openjournals/joss-reviews#8388.

I have applied the minor edits. I will get back to you on a release timeline as soon as able…

View Comment

tgamblin commented on issue hpsfoundation/tac#52.

I’m fine with this change, but I left out the COC b/c it’s a requirement for all Linux Foundation projects, which I thought @jlapolla-cray wanted (per #33). It’s something to check before voting, but if they make it into LF they’ll have a COC so it kind of doesn’t matter to me whether it’s in the vote. …

View Comment

trws commented on issue flux-framework/flux-sched#1406.

I’m going to work through the code shortly, starting with the discussion points though: …

View Comment

trws commented on issue desul/desul#150.

Yeah, if anything newer is better IMO….

View Comment

hppritcha commented on issue open-mpi/ompi#13280.

okay thanks for the pointers @dalcinl . …

View Comment

markcmiller86 commented on issue LLNL/Silo#378.

I believe it is fixed in PR #380. That is not yet merged to 4.11RC (or main) yet but will be shortly after I get more CMake testing working….

View Comment

cjvogl commented on issue E3SM-Project/E3SM#7615.

> I am approving so that CI can run. I still think @bartgol or @mahf708 should have the final approval say. …

View Comment

cjvogl commented on issue E3SM-Project/E3SM#7481.

> @cjvogl what is the status of this PR? …

View Comment

milroy commented on issue flux-framework/flux-sched#1406.

Note that there’s a lot of code churn because I updated the power.json JGF to include a correctly enumerated rank in each vertex below the rack level. That was necessary to enable cross-rack allocation testing….

View Comment

artv3 commented on issue LLNL/RAJA#1917.

Thanks for getting this started @MrBurmark. I took a follow up pass; but I think I could use a second set of eyes on the Kernel implementation. Would anyone in @LLNL/raja-core be able to take a look? …

View Comment

vsoch commented on issue kubernetes-sigs/wg-ai-conformance#13.

@andreyvelich done! https://github.com/kubeflow/trainer/issues/2841. Really looking forward to working on this!

mplegendre commented on issue hpc/Spindle#99.

Can you rebase this into either: …

View Comment

chu11 commented on issue flux-framework/flux-core#7070.

@mergifyio requeue…

View Comment

vsoch commented on issue flux-framework/flux-coral2#411.

For our notes, here is the command that worked (for an interactive run) on hetchy. The reason we needed to ask for all 12 nodes was to get around fluxion scheduling and compute node to rabbit assignment. …

View Comment

benzwick commented on issue Talk2View/SlicerBuildEnvironment#1.

@copilot see my comments…

View Comment

cjvogl commented on issue E3SM-Project/E3SM#7615.

> Still has testing fails. …

View Comment

cyrush commented on issue visit-dav/visit#20607.

Sounds like he is using XQuartz….

View Comment

cmelone commented on issue spack/spack-packages#1360.

I believe she’s on vacation, you may need to get someone else to merge. Try posting in pull_requests on Slack?…

View Comment

becker33 commented on issue spack/spack-packages#1546.

I would not deprecate a version simply because it is no longer receiving bugfixes. So much of the HPC and general open source ecosystem relies on things built once-upon-a-time against some old version of {perl or insert other package here} that still work because the interfaces are slow-moving. …

View Comment

becker33 commented on issue spack/spack#51314.

I don’t think this is what we want. For a solve with a non-default compiler specified on the root, this will make it even more difficult to get the rest of the stack built with the compiler specified on the root. …

View Comment

wihobbs commented on issue flux-framework/flux-sched#1383.

I do think we’ll want to look at a similar issue with easy, conservative, and hybrid backfill policies too. If I’m reading the docs right, the EBUSY that they return on an unsatisfiable job should be ENODEV. Of course, with those policies, the system never gets stopped up because backfill is on. …

View Comment

wihobbs commented on issue flux-framework/flux-sched#1383.

I do think we’ll want to look at a similar issue with easy, conservative, and hybrid backfill policies too. If I’m reading the docs right, the EBUSY that they return on an unsatisfiable job should be ENODEV. Of course, with those policies, the system never gets stopped up because backfill is on. …

View Comment

garlick commented on issue flux-framework/flux-core#7067.

I found it. The msg_deque class uses an eventfd(2) internally which raises POLLOUT when a pending POLLIN event is cleared. Fix coming….

View Comment

grondo commented on issue flux-framework/flux-core#7069.

Yeah, it is subtle. “requires” defines a dependency relationship, while “before” and “after” are strictly for ordering or precedence of active tasks. If task A requires task B, and task A is active, then task B is forced to be active as well. However, at this point A can run in parallel with B. If A needs to be loaded before or after B, then “before” or “after” should be used to determine the precedence of tasks. …

View Comment

cmoussa1 commented on issue flux-framework/flux-accounting#749.

I was able to reproduce this pretty easily in a Docker container where an association has max_nodes and max_cores limits of 1 each and submits two 1-node jobs. The second one gets held due to max-resources-user-limit, but even after upping the association’s limits and updating the plugin with flux account-priority-update, the second job remains in DEPEND state….

View Comment

tzanio commented on issue GLVis/pyglvis#55.

Thanks so much for fixing this, @justinlaughlin !…

View Comment

cyrush commented on issue Alpine-DAV/ascent#1614.

Note, this is with:…

View Comment

v-dobrev commented on issue mfem/mfem#4800.

This needs fixes after the merge from master….

View Comment

samuelkgutierrez commented on issue hpc/quo-vadis#424.

Perhaps we can provide an environment variable that somehow lets us determine the resources. This could be set on a per-site basis….

View Comment

trws commented on issue flux-framework/flux-sched#1383.

Yeah, I think what’s happening is that the FCFS policy is treating the unsatisfiable job as the first job that couldn’t match. When that happens it stops trying to schedule more work, because more work can’t fit, but because that job is actually being rejected completely that assumption is wrong. The set_schedulability (true) is what we need to have happen….

View Comment

grondo commented on issue flux-framework/flux-sched#1383.

Ah, ok. That is starting to make more sense. In the tests @wihobbs was doing it was clear the remainder were not getting resubmitted though……

View Comment

tzanio commented on issue mfem/mfem#5002.

Merged in next for testing……

View Comment

grondo commented on issue flux-framework/pr-validator#10.

Thanks! This repo doesn’t have mergify, so I’ll just press the button. …

View Comment

grondo commented on issue flux-framework/flux-pam#11.

Oh oops. I forgot this now modifies .github so it will need a manual merge. Removing mwp….

View Comment

wihobbs commented on issue flux-framework/flux-core#7063.

Thanks for doing this @grondo!…

View Comment

adrienbernede commented on issue LLNL/uberenv#149.

> It is fine if we support both options but I personally don’t want the spack package information in multiple places. It makes the most sense in my opinion to be in the uberenv config file …

View Comment

markcmiller86 commented on issue visit-dav/visit#20586.

Great diagnosis, @brugger1. I wonder where that cell type is coming from. Its either something that gets generated in VTK filter we use or there is code in VisIt that creates it directly. So, I searched our sources……

View Comment

hppritcha commented on issue open-mpi/ompi#12077.

closed via #13401 …

View Comment

tpatki commented on issue flux-framework/PerfFlowAspect#198.

@asantagata I think this PR now includes the fix for #156, correct? Could you update your description? I’m running the CI on it now and will test after that….

View Comment

cmoussa1 commented on issue LLNL/cmvl#14.

That’s a really good question @morrone - I think I tend to agree with you. And the definition on the events in the ECS Documentation does not make it all that much clearer to me:…

View Comment

adayton1 commented on issue LLNL/RAJA#1900.

Can you provide some context?…

View Comment

artv3 commented on issue LLNL/RAJA#1912.

Is there anything to do for the OpenMP backend? …

View Comment

jeremylt commented on issue CEED/libCEED#1461.

Yea, I can work on this some now, thanks for the update!…

View Comment

hppritcha commented on issue pmodels/mpich#7571.

@dalcinl thanks for the heads up!…

View Comment

vsoch commented on issue flux-framework/flux-python#18.

@trws @grondo @garlick looking for your advice! In testing building for Mac, I found that flux core and flux security need something called pipe2. …

View Comment

trws commented on issue flux-framework/flux-python#17.

It is, we actually use one on flux-core now if you want to snag some configs from over there….

View Comment

JustinPrivitera commented on issue visit-dav/visit#20582.

https://teams.microsoft.com/l/message/19:f2ed7be3682d40d1b8e038744e500a09@thread.skype/1756487055813?tenantId=a722dec9-ae4e-4ae3-9d75-fd66e2680a63&groupId=70162982-9587-4bcc-ad53-20178c76fe11&parentMessageId=1756487055813&teamName=VisIt&channelName=General&createdTime=1756487055813…

View Comment

cyrush commented on issue visit-dav/visit#20582.

Main issue was confusion about the the scalar range of the tensor plot….

View Comment

cjvogl commented on issue mfem/mfem#5001.

Noting a good idea from @kmittal2 in a Slack conversation: …

View Comment

grondo commented on issue flux-framework/flux-python#17.

And I guess CI will check if the build still works :laughing: …

View Comment

tpatki commented on issue flux-framework/flux-core#6873.

> Also, I wonder if we can find another way to pass in the instance URI, since embedding it in the dependency URI might cause parsing problem later on (like ambiguity about which scheme an appended ?option=value belongs to)? …

View Comment

imguoguo commented on issue RadxaOS-SDK/rsdk#87.

adrienbernede commented on issue LLNL/radiuss-spack-configs#142.

@rhornung67 I guess you need the branch to live a little longer….

View Comment

CamStan commented on issue LLNL/UnifyFS#821.

> Have you had a chance to figure out why the CI builds are not running? …

View Comment

adayton1 commented on issue LLNL/CHAI#328.

CHAI is used successfully on Windows, though in a CPU-only configuration. It uses CMake as its build system, which is supported on Windows, so the build process should be very similar. You might have to select a specific generator (e.g. cmake -G “Visual Studio 17 2022” -A x64) to generate a visual studio solution file, for example. Or supposedly, in visual studio there is built in support for CMake projects (see https://learn.microsoft.com/en-us/cpp/build/cmake-projects-in-visual-studio?view=msvc-170). Other generators are listed here if you don’t use visual studio: https://cmake.org/cmake/help/latest/manual/cmake-generators.7.html. …

View Comment

jedbrown commented on issue pyOpenSci/software-peer-review#331.

> We’re not a journal and people aren’t submitting papers but code….

View Comment

hppritcha commented on issue open-mpi/ompi#13338.

hmmm not sure what’s going on with NVIDIA openshmem test….

View Comment

cmoussa1 commented on issue flux-framework/flux-core#7047.

Thanks @chu11! Going to set MWP here…

View Comment

garlick commented on issue flux-framework/flux-core#7046.

There was a little “override branch protections” selection that I used without going to settings. Which I needed in the powerman PR because a couple of our CI runners were using obsolete github runners and would never run. …

View Comment

cmoussa1 commented on issue flux-framework/flux-accounting#740.

Thanks @wihobbs! Setting MWP here…

View Comment

adayton1 commented on issue LLNL/Umpire#997.

I haven’t seen this before….

View Comment

tgamblin commented on issue spack/spack#51266.

Should we try to get rid of the local imports after this PR, since they’re basically a sign of where circular imports used to be? I feel like we should use this to think about what the proper layering should be….

View Comment

hppritcha commented on issue mpi-forum/mpi-issues#1004.

Fine with me. In this case I’d like to find an approach which limits API growth. For the ‘c’ interfaces could we use a more generic approach for treating the handle - like with MPI_T_PVAR_HANDLE_ALLOC? Also if there were some way to just say no to f90, then for f08 we could use polymorphism. I haven’t thought much about the copy/delete callbacks though….

View Comment

jandrej commented on issue mfem/mfem#4994.

I skimmed through the changes and felt a little confused. Are you aware of the dFEM interface? See here for an example. dFEM covers a broad spectrum of functionality of automatic differentiation capabilities and I’m not sure why there is effort in recreating this functionality in different parts of MFEM. …

View Comment

wihobbs commented on issue flux-framework/flux-accounting#714.

Thanks @cmoussa1!…

View Comment

tpatki commented on issue Olympus-HPC/Mneme#43.

Closing to create a branch to trigger Gitlab CI….

View Comment

cmelone commented on issue LLNL/hubcast#137.

unlinking this from #121 since we still need to add bot functionality for the gitlab client…

View Comment

alecbcs commented on issue spack/spack-tutorial#491.

Looks good to me :)…

View Comment

alecbcs commented on issue spack/spack-packages#1386.

> Can you add more defensive checks, and at least print the exception? In particular GitHub API requests may fail. …

View Comment

jameshcorbett commented on issue flux-framework/flux-sched#1398.

For some reason when I tried again yesterday the checks passed in the TOSS 4 builder, so the package is out there. TOSS 5 still failed though….

View Comment

wihobbs commented on issue flux-framework/flux-core#7042.

With that, setting MWP….

View Comment

bgunnar5 commented on issue LLNL/merlin#549.

Bypassing the review process here as this is a combination of PRs that have already been reviewed….

View Comment

trws commented on issue flux-framework/flux-core#1991.

@grondo, is this still something you want to consider? happened to pop up in a search today…

View Comment

cbritopacheco commented on issue cbritopacheco/rodin#121.

@copilot I have fixed the syntax error and the test. Please finish it. Also most of these are just basic functionality tests which should be categorized as unit tests and moved to tests/unit/ under their respective path and file. So please separate the unit tests from the manufactured tests (which actually are solutions to test against and not class functionality). Also add a few more more manufactured tests….

View Comment

tzanio commented on issue mfem/web#335.

deployed as of 1084806

View Comment

tzanio commented on issue mfem/mfem#4907.

Re-merged in next for testing……

View Comment

markcmiller86 commented on issue visit-dav/visit#20110.

Just a thought on documentation work that could be relevant to this……

View Comment

v-dobrev commented on issue mfem/mfem#4931.

Merged in next for testing……

View Comment

tzanio commented on issue mfem/mfem#4906.

Re-merged in next for testing……

View Comment

garlick commented on issue flux-framework/flux-core#7034.

:+1: for removal…

View Comment

markcmiller86 commented on issue LLNL/Silo#453.

In 33e4935ff83aec904541d3d56281bfa7cde13721, I added tests that emulate the issue reported by Lila. …

View Comment

alecbcs commented on issue spack/spack-packages#1304.

@haampie if you can follow up in another PR with those pkg name modifications I’m happy to review :)…

View Comment

balos1 commented on issue spack/spack#51281.

CC @steven-roberts…

View Comment

jedbrown commented on issue rust-lang/rfcs#3847.

Similar proposal: https://github.com/rust-lang/compiler-team/issues/907 …

View Comment

vsoch commented on issue pydicom/deid#286.

I think this would be a fantastic development for the project. We can introduce changes (that are breaking) as long as it is clear / versioned with an appropriate bump. I can give feedback and review at each step - let me know on issues / PRs when the time comes….

View Comment

jeremylt commented on issue openjournals/joss-reviews#8388.

@editorialbot generate pdf…

View Comment

grondo commented on issue flux-framework/flux-sched#1399.

flux-cancel(1) is a reference to the manual page in section 1, a common practice in documentation and error messages to refer the user to the correct documentation. (i.e. man 1 flux-cancel). Perhaps in this case it would be clearer if the message was?…

View Comment

wihobbs commented on issue flux-framework/flux-core#7033.

@chu11 or @grondo can you check that I did the completions right? I’ve never messed with them before, and are unfamiliar with how they work….

View Comment

grondo commented on issue flux-framework/flux-core#7033.

Want to check if it is in the bash completions as well?…

View Comment

markcmiller86 commented on issue betterscientificsoftware/bssw.io#2251.

Ok, sorry for bad link in previous comment. Go here, https://github.com/markcmiller86/markdown-collab/blob/main/ExperiencesIntegratingMOABAndVisIt.md….

View Comment

balos1 commented on issue LLNL/sundials#752.

Thanks for sharing your workaround @mottelet. …

View Comment

cyrush commented on issue Alpine-DAV/ascent#1609.

braid case might be a subtle color difference (not that that helps too much with the underlying mystery) …

View Comment

tgamblin commented on issue hpsfoundation/tac#35.

> If the “Align with the mission of the HPSF” requirement is enough to prompt others to scrutinize the dependency licenses, then I’m happy to close this pull request without merging. …

View Comment

jameshcorbett commented on issue flux-framework/flux-sched#1398.

The same test fails in the TOSS4 build farm, although the failure was in test case #3 rather than #4. I didn’t see a segfault message, but it’s possible I just missed it….

View Comment

jameshcorbett commented on issue flux-framework/flux-coral2#403.

@mergifyio requeue…

View Comment

garlick commented on issue flux-framework/flux-coral2#397.

Thanks! MPW now….

View Comment

wihobbs commented on issue flux-framework/flux-coral2#402.

It’s helpful to remember, if the node can be returned to service immediately, to raise a fatal exception on the job but exit 0 in the prolog (this is useful, for instance, if a user requests more storage than we cap them at):…

View Comment

chu11 commented on issue chu11/freeipmi-mirror#76.

ipmitool’s output can be different as it intereprets data differently. some ideas…

View Comment

gardner48 commented on issue LLNL/sundials#728.

> @gardner48 Looks like the extended precision test for cvsRoberts_FSA_dns_constraints_-sensi_stg1_t.c is failing because a line number is in the output file (due to an error message, see sundials-codes/answers#60) , and the line number changed. We should probably just disable that test with extended precision since it fails. …

View Comment

adayton1 commented on issue LLNL/camp#184.

> D’oh! Yes, good catch. Thank you. …

View Comment

artv3 commented on issue LLNL/RAJA#1866.

@LLNL/raja-core , what do you guys think of updating the CHANGELOG within each PR? I think it may help us keep track of new features as they come in – instead of when we are making the release candidate. …

View Comment

jeremylt commented on issue CEED/libCEED#1891.

oh, our vector access protected us accidentally here…

View Comment

becker33 commented on issue spack/spack#51140.

It’s not done as a post-concretization step, the specs from the dev specs are imposed in the solver itself. Then there’s also a post-concretization step that ensures the dev_path variant is present, but it doesn’t worry about the rest of the spec….

View Comment

hppritcha commented on issue open-mpi/ompi#13280.

Thanks for checking this stuff out in its early state @dalcinl. some of the above functions have been implemented but are sitting in various states in PRs. some of these should be defined - like MPI_Wtick and the aint related functions so i’ll see what’s going on. As for the fromint/toint that seems like an excellent project for a AI LLM. I’ll see what can be done there. …

View Comment

grondo commented on issue flux-framework/flux-coral2#383.

No objection here. …

View Comment

jameshcorbett commented on issue flux-framework/flux-accounting#735.

go off king …

View Comment

cmoussa1 commented on issue flux-framework/flux-accounting#733.

I was able to reproduce this in my docker container following your set of instructions above. After the first job, subsequently submitted jobs get rejected with a Queue not valid for user error message. For flux-accounting, this seems to be a particular issue when default queues are configured, e.g….

View Comment

dylan-copeland commented on issue LLNL/libROM#316.

@dreamer2368 An example using this PR is in file src/rom_handler.cpp of https://github.com/LLNL/scaleupROM/pull/60 …

View Comment

cyrush commented on issue spack/spack-packages#1218.

@adamjstewart It looks like it it is trying to build with a newer umpire than ascent 0.8.0 supports. …

View Comment

cmoussa1 commented on issue flux-framework/flux-coral2#394.

Yes I can. Here goes nothing!…

View Comment

cyrush commented on issue LLNL/conduit#1459.

@abhishek1297 glad you were able to work it out, we can add that method to the C-API. Thanks for the feedback!…

View Comment

emily-howell commented on issue Alpine-DAV/ascent#431.

@cyrush Also, you mentioned wanting to compile with 64bit IDs and then use caliper to observe any performance changes. Is there a specific analysis you were hoping to see? I was just doing some runs of different areas of the test suite with caliper reports to see any notable changes….

View Comment

becker33 commented on issue spack/spack-packages#1254.

@hfp this might be of interest to you….

View Comment

dylan-copeland commented on issue mfem/mfem#3807.

> @dylan-copeland did you make the changes you planned here (after mfem/data#12 was merged)? …

View Comment

cbritopacheco commented on issue cbritopacheco/rodin#119.

Merging even though not finished….

View Comment

tzanio commented on issue mfem/mfem#4980.

Merged in next for testing……

View Comment

vsoch commented on issue google/dranet#151.

Thank you @keithmattix much appreciated. Enjoy the holiday!…

View Comment

v-dobrev commented on issue mfem/mfem#4801.

@tepperly, the PR will be merged by the editor (@pazner in this case, as seen in the table added to the first post) when there are at least 2 approvals from people in the Reviewers team and after some additional testing (run nightly) in the next branch. The procedure is documented in CONTRIBUTING.md: https://github.com/mfem/mfem/blob/master/CONTRIBUTING.md#pull-requests – we try to follow it closely but it’s not set in stone. …

View Comment

garlick commented on issue flux-framework/flux-core#6958.

I added testing and removed the WIP. I am not hard over on merging this as is, but wanted the option to be available….

View Comment

chu11 commented on issue flux-framework/flux-core#6999.

> I wonder though if we could just create bad treeobjs directly instead of laboriously modifying good ones? Could even have some prepared JSON in test data files. Just a thought. This is fine for now. …

View Comment

markcmiller86 commented on issue betterscientificsoftware/bssw.io#2251.

> Agreed! Are you back from your break, @markcmiller86 ? …

View Comment

tgamblin commented on issue spack/spack#51246.

This is very nice for #51137, where we start showing conditional deps in spack info. …

View Comment

trws commented on issue flux-framework/flux-sched#1339.

This one is mostly good too but currently has no testing….

View Comment

grondo commented on issue flux-framework/flux-sched#1394.

Yes, sorry. I dropped the ball on this one. Rebased and will hit the button….

View Comment

grondo commented on issue flux-framework/flux-python#16.

Oh, I see you answered in the email thread. Thanks!…

View Comment

grondo commented on issue flux-framework/flux-core#6990.

This does seem more user-friendly!…

View Comment

cmoussa1 commented on issue flux-framework/flux-accounting#731.

Thanks @jameshcorbett! Setting MWP here…

View Comment

cmelone commented on issue cmelone/hubcast-test#3.

@lc-hubcast restart failed jobs…

View Comment

becker33 commented on issue spack/spack#51190.

Looks like the tests need to be updated for the changed method name, but otherwise LGTM…

View Comment

jeremylt commented on issue openjournals/joss-reviews#8388.

Ratel just will error if misconfigured. That’s to hard baked into the PETSc error and options handling….

View Comment

jedbrown commented on issue openjournals/joss-reviews#8388.

Yeah, the options are extensible, akin to a programming language, and -help is used to show everything that can be specified in the current expansion. You can’t get to the entire expansion without running. It would be possible (at substantial cross-cutting effort and maintainability impact) to make a system that shows the useful options in a simulation, but even that would be unable to deal with solution-dependent logic (e.g., solve an auxiliary problem, enter an optimization loop, and/or write output only if the solution satisfies a numeric criteria). The decision to make -help comprehensive and extensible was made (by the PETSc team) long ago and responsive to community needs. We could bikeshed over a different name, but this is widely used and accepted in the PETSc community and we consider it a feature that Ratel be readily usable by people familiar with configuring PETSc solvers via run-time options (which you can liken to a domain-specific programming language)….

View Comment

hppritcha commented on issue open-mpi/ompi#13280.

jenkins ci runs make distcheck…

View Comment

cbritopacheco commented on issue cbritopacheco/rodin#118.

@copilot I have fixed your tests since they contained some mistakes and inaccuracies and renamed setInterface to setFront. Please write more tests a few unit tests and more manufactured tests. The manufactured tests should test with more than just point sources. You can specify that the initial front will be the boundary of the mesh. From another side, an interior interface is also useful to test (for example, a rectangular interface of edges inside a rectangular triangular mesh). Please test analytical solution vs the numerical….

View Comment

adayton1 commented on issue LLNL/Umpire#986.

@rhornung67, @kab163, @davidbeckingsale, any other comments? Since I pushed a change, it dismissed Rich’s and Kristi’s approvals….

View Comment

emily-howell commented on issue Alpine-DAV/ascent#431.

https://github.com/Alpine-DAV/ascent/blob/258e06ed902d251c1f8eb4d987043d049b77cade/scripts/build_ascent/build_ascent.sh#L697…

View Comment

becker33 commented on issue spack/spack-packages#1123.

@hfp I changed the spec slightly to make it more legible for Spack 1.0, but I had success with: …

View Comment

milroy commented on issue flux-framework/rfc#466.

These changes look good to me with respect to the interim need, and I’m fine with this PR as is. I agree with @trws that fluxion can be adapted to support nslots without too much difficulty. …

View Comment

chu11 commented on issue flux-framework/flux-sched#1394.

@grondo i assume has to be merged manually, wanna hit the button?…

View Comment

chu11 commented on issue flux-framework/flux-accounting#727.

@cmoussa1 i think has to merged manually, wanna hit the button?…

View Comment

cyrush commented on issue LLNL/conduit#1459.

We can add more c methods if needed. …

View Comment

adayton1 commented on issue LLNL/camp#152.

@MrBurmark any other comments?…

View Comment

adayton1 commented on issue LLNL/RAJA#1888.

I just noticed this doesn’t prevent trying to use the internal cub or rocprim submodules. So at the least the messages like “Using RAJA cub submodule” need to be converted to a fatal error and the message should be updated….

View Comment

cyrush commented on issue visit-dav/visit#18884.

Resolved in #20494 …

View Comment

cjvogl commented on issue mfem/mfem#4905.

@homeomorfismo , I’ve made a first pass through the code. Overall, I think this is in really good shape. Let’s focus on the corresponding write-up first, and only return to the code here if that write-up is completed before the end of the week….

View Comment

tgamblin commented on issue hpsfoundation/tac#35.

> Today, we don’t formally vote on this. …

View Comment

trws commented on issue flux-framework/rfc#466.

That’s a fair point. As I said I don’t see any problem with it, it’s easy enough to supply. @milroy do you have any thoughts here?…

View Comment

wihobbs commented on issue flux-framework/flux-core#6993.

Thanks @jameshcorbett! Setting MWP. …

View Comment

jameshcorbett commented on issue flux-framework/flux-accounting#726.

Yeah, it wouldn’t save you any indentation. It might be a bit easier to read though?…

View Comment

chu11 commented on issue crate-ci/typos#1345.

```…

View Comment

balos1 commented on issue LLNL/sundials#758.

I think this can be merged as-is, but it might be helpful to add a super quick demo in the developer docs in a “tools” section. I think just an example plot + the command that was used….

View Comment

cmelone commented on issue LLNL/hubcast#167.

ok @alecbcs that worked, though for some reason I needed to pull out the permissions into ci.yml from security.yml……

View Comment

alecbcs commented on issue LLNL/hubcast#167.

Can we merge the CodeQL CI YAML file into the existing security CI YAML so that we run both out of a single file and they’re triggered by the same conditions?…

View Comment

imguoguo commented on issue radxa-pkg/linux-qcom#4.

mej commented on issue mej/nhc#162.

@adriansev - I don’t see anywhere that mentions which config file you have those settings in, but that can make a difference. You might try adding them to the command line just as a test. You can also enable tracing. Here’s an example of doing both at once:…

View Comment

trws commented on issue flux-framework/flux-core#6986.

I mentioned it mainly because it showed up in two actions sets in a row on two different PRs for me today. Given the timeouts, it may just be that things are running extra slow, but something must have tickled it….

View Comment

cbritopacheco commented on issue cbritopacheco/rodin#117.

I need an example of utilization….

View Comment

cmelone commented on issue LLNL/hubcast#144.

@alecbcs my latest changes should address your comments. There’s no logging inside the library modules. …

View Comment

tgamblin commented on issue spack/spack#51210.

Looks good to me… I think we could add more stuff to this page (environments, developer workflows, CI, OCI container builds, etc.) but this is a good clarification. …

View Comment

jedbrown commented on issue pyOpenSci/software-peer-review#331.

Suppose a human types // sparse matrix transpose, presses tab, and gets a page of code that still has namespaces from an existing library with copyright/attribution stripped. What does it mean that “accountability remains with humans”? What if the algorithmic system obfuscates just enough that it isn’t obvious to the human that it’s plagiarizing an existing library (violating that project’s license)? Just because many people use a product doesn’t mean it isn’t manufacturing plausible deniability. If the claim is merely “I don’t think copyright holders will successfully sue me for infringing”, that is a statement about power rather than justice or consent….

View Comment

garlick commented on issue flux-framework/flux-core#6589.

I think A is the sane thing to do, unlink the bad dirref. Isn’t it the same problem as removing a valref?…

View Comment

chu11 commented on issue flux-framework/flux-core#6953.

re-pushed, --lost-and-found is now --repair, tweaked some documentation per comment above …

View Comment

grondo commented on issue flux-framework/flux-core#6983.

Thanks mentioning @kkier. The key thing to note is that the only change in behavior while /etc/flux/system/{prolog,epilog,housekeeping} exist is that any scripts dropped into libexecdir/flux/{name}.d (meant to be used by other packages) will be run before the system scripts. …

View Comment

trws commented on issue flux-framework/flux-core#6929.

I imagine you already found it, but here’s the link for git-absorb. I heard about it a long time ago but for whatever reason never actually tried it until today, wishing I had done it a long time ago….

View Comment

imguoguo commented on issue RadxaOS-SDK/rsdk#81.

>

balos1 commented on issue LLNL/sundials#759.

> …

View Comment

adayton1 commented on issue LLNL/blt#725.

I don’t have permission to merge, and I will be unavailable Monday and Tuesday. So feel free to merge whenever you are ready, @white238….

View Comment

cjvogl commented on issue E3SM-Project/E3SM#7615.

> @cjvogl how urgent is this PR? After the last sprint with diags capabilities, I was thinking to pause new diags, and implement a more flexible yaml specification paradigm. Eg, I was thinking of a syntax along the line of …

View Comment

becker33 commented on issue spack/spack-packages#1128.

@spackbot rerun pipeline…

View Comment

becker33 commented on issue spack/spack#51069.

@XXVIMilia do you think this could be the same problem as #51180?…

View Comment

jedbrown commented on issue rust-lang/rust#138689.

I believe the compute_* and sm_* semantics are consistently represented in this PR, and that single-invocation multi-target behavior is a major feature that would not entirely supplant ability to build kernels and device code using --target=nvptx64-nvidia-cuda. I think a similar amdgcn_target_feature would make sense….

View Comment

v-dobrev commented on issue mfem/mfem#4948.

> First, I need to parallelize the operation of assembling N*N sparse matrices into a block matrix. Currently, I’m using HypreParMatrix and HypreParMatrixFromBlocks. I’d like to know if there are any problems with my approach….

View Comment

becker33 commented on issue hpsfoundation/tac#34.

I think this is all subsumed under the requirement to join the LF – I don’t think we want to double-approve that…

View Comment

tgamblin commented on issue hpsfoundation/tac#45.

@becker33 @jlapolla-cray @kmorel @ax3l @dalg24: after reviewing the (transcript of the 7/24 TAC meeting I tried to write what we discussed. …

View Comment

wihobbs commented on issue flux-framework/flux-core#6972.

For reference, the same commands in a bookworm container work fine:…

View Comment

cmoussa1 commented on issue flux-framework/flux-accounting#656.

Well, after a few months of searching, I think I found the culprit….

View Comment

hppritcha commented on issue spack/spack-packages#1128.

we don’t support singularity in Open MPI so i’m fine with this change….

View Comment

hppritcha commented on issue open-mpi/ompi#12085.

@naughtont3 any updates on adding this functionlity?…

View Comment

vladotomov commented on issue mfem/mfem#4941.

Is the behavior of hypre_ParVectorToVectorAll invalid when the local size is zero, or is the MFEM usage incorrect? …

View Comment

jeremylt commented on issue mfem/mfem#4609.

sure, reverted…

View Comment

cjvogl commented on issue mfem/mfem#4907.

> @cjvogl , @dohyun-cse , any chance looking at this? …

View Comment

tzanio commented on issue mfem/mfem#4974.

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….

View Comment