vsoch commented on issue flux-framework/flux-python#18.
@trws @grondo @garlick looking for your advice! In testing building for Mac, I found that flux core and flux security need something called pipe2. …
trws commented on issue flux-framework/flux-python#17.
It is, we actually use one on flux-core now if you want to snag some configs from over there….
JustinPrivitera commented on issue visit-dav/visit#20582.
https://teams.microsoft.com/l/message/19:f2ed7be3682d40d1b8e038744e500a09@thread.skype/1756487055813?tenantId=a722dec9-ae4e-4ae3-9d75-fd66e2680a63&groupId=70162982-9587-4bcc-ad53-20178c76fe11&parentMessageId=1756487055813&teamName=VisIt&channelName=General&createdTime=1756487055813…
cyrush commented on issue visit-dav/visit#20582.
Main issue was confusion about the the scalar range of the tensor plot….
cjvogl commented on issue mfem/mfem#5001.
Noting a good idea from @kmittal2 in a Slack conversation: …
grondo commented on issue flux-framework/flux-python#17.
And I guess CI will check if the build still works :laughing: …
tpatki commented on issue flux-framework/flux-core#6873.
> Also, I wonder if we can find another way to pass in the instance URI, since embedding it in the dependency URI might cause parsing problem later on (like ambiguity about which scheme an appended ?option=value belongs to)? …
imguoguo commented on issue RadxaOS-SDK/rsdk#87.
adrienbernede commented on issue LLNL/radiuss-spack-configs#142.
@rhornung67 I guess you need the branch to live a little longer….
CamStan commented on issue LLNL/UnifyFS#821.
> Have you had a chance to figure out why the CI builds are not running? …
adayton1 commented on issue LLNL/CHAI#328.
CHAI is used successfully on Windows, though in a CPU-only configuration. It uses CMake as its build system, which is supported on Windows, so the build process should be very similar. You might have to select a specific generator (e.g. cmake -G “Visual Studio 17 2022” -A x64) to generate a visual studio solution file, for example. Or supposedly, in visual studio there is built in support for CMake projects (see https://learn.microsoft.com/en-us/cpp/build/cmake-projects-in-visual-studio?view=msvc-170). Other generators are listed here if you don’t use visual studio: https://cmake.org/cmake/help/latest/manual/cmake-generators.7.html. …
jedbrown commented on issue pyOpenSci/software-peer-review#331.
> We’re not a journal and people aren’t submitting papers but code….
hppritcha commented on issue open-mpi/ompi#13338.
hmmm not sure what’s going on with NVIDIA openshmem test….
cmoussa1 commented on issue flux-framework/flux-core#7047.
Thanks @chu11! Going to set MWP here…
garlick commented on issue flux-framework/flux-core#7046.
There was a little “override branch protections” selection that I used without going to settings. Which I needed in the powerman PR because a couple of our CI runners were using obsolete github runners and would never run. …
cmoussa1 commented on issue flux-framework/flux-accounting#740.
Thanks @wihobbs! Setting MWP here…
adayton1 commented on issue LLNL/Umpire#997.
I haven’t seen this before….
tgamblin commented on issue spack/spack#51266.
Should we try to get rid of the local imports after this PR, since they’re basically a sign of where circular imports used to be? I feel like we should use this to think about what the proper layering should be….
hppritcha commented on issue mpi-forum/mpi-issues#1004.
Fine with me. In this case I’d like to find an approach which limits API growth. For the ‘c’ interfaces could we use a more generic approach for treating the handle - like with MPI_T_PVAR_HANDLE_ALLOC? Also if there were some way to just say no to f90, then for f08 we could use polymorphism. I haven’t thought much about the copy/delete callbacks though….
jandrej commented on issue mfem/mfem#4994.
I skimmed through the changes and felt a little confused. Are you aware of the dFEM interface? See here for an example. dFEM covers a broad spectrum of functionality of automatic differentiation capabilities and I’m not sure why there is effort in recreating this functionality in different parts of MFEM. …
wihobbs commented on issue flux-framework/flux-accounting#714.
Thanks @cmoussa1!…
tpatki commented on issue Olympus-HPC/Mneme#43.
Closing to create a branch to trigger Gitlab CI….
cmelone commented on issue LLNL/hubcast#137.
unlinking this from #121 since we still need to add bot functionality for the gitlab client…
alecbcs commented on issue spack/spack-tutorial#491.
Looks good to me :)…
alecbcs commented on issue spack/spack-packages#1386.
> Can you add more defensive checks, and at least print the exception? In particular GitHub API requests may fail. …
jameshcorbett commented on issue flux-framework/flux-sched#1398.
For some reason when I tried again yesterday the checks passed in the TOSS 4 builder, so the package is out there. TOSS 5 still failed though….
wihobbs commented on issue flux-framework/flux-core#7042.
With that, setting MWP….
bgunnar5 commented on issue LLNL/merlin#549.
Bypassing the review process here as this is a combination of PRs that have already been reviewed….
trws commented on issue flux-framework/flux-core#1991.
@grondo, is this still something you want to consider? happened to pop up in a search today…
cbritopacheco commented on issue cbritopacheco/rodin#121.
@copilot I have fixed the syntax error and the test. Please finish it. Also most of these are just basic functionality tests which should be categorized as unit tests and moved to tests/unit/ under their respective path and file. So please separate the unit tests from the manufactured tests (which actually are solutions to test against and not class functionality). Also add a few more more manufactured tests….
tzanio commented on issue mfem/web#335.
deployed as of 1084806…
tzanio commented on issue mfem/mfem#4907.
Re-merged in next for testing……
markcmiller86 commented on issue visit-dav/visit#20110.
Just a thought on documentation work that could be relevant to this……
v-dobrev commented on issue mfem/mfem#4931.
Merged in next for testing……
tzanio commented on issue mfem/mfem#4906.
Re-merged in next for testing……
garlick commented on issue flux-framework/flux-core#7034.
:+1: for removal…
markcmiller86 commented on issue LLNL/Silo#453.
In 33e4935ff83aec904541d3d56281bfa7cde13721, I added tests that emulate the issue reported by Lila. …
alecbcs commented on issue spack/spack-packages#1304.
@haampie if you can follow up in another PR with those pkg name modifications I’m happy to review :)…
balos1 commented on issue spack/spack#51281.
CC @steven-roberts…
jedbrown commented on issue rust-lang/rfcs#3847.
Similar proposal: https://github.com/rust-lang/compiler-team/issues/907 …
vsoch commented on issue pydicom/deid#286.
I think this would be a fantastic development for the project. We can introduce changes (that are breaking) as long as it is clear / versioned with an appropriate bump. I can give feedback and review at each step - let me know on issues / PRs when the time comes….
jeremylt commented on issue openjournals/joss-reviews#8388.
@editorialbot generate pdf…
grondo commented on issue flux-framework/flux-sched#1399.
flux-cancel(1) is a reference to the manual page in section 1, a common practice in documentation and error messages to refer the user to the correct documentation. (i.e. man 1 flux-cancel). Perhaps in this case it would be clearer if the message was?…
wihobbs commented on issue flux-framework/flux-core#7033.
@chu11 or @grondo can you check that I did the completions right? I’ve never messed with them before, and are unfamiliar with how they work….
grondo commented on issue flux-framework/flux-core#7033.
Want to check if it is in the bash completions as well?…
markcmiller86 commented on issue betterscientificsoftware/bssw.io#2251.
Ok, sorry for bad link in previous comment. Go here, https://github.com/markcmiller86/markdown-collab/blob/main/ExperiencesIntegratingMOABAndVisIt.md….
balos1 commented on issue LLNL/sundials#752.
Thanks for sharing your workaround @mottelet. …
cyrush commented on issue Alpine-DAV/ascent#1609.
braid case might be a subtle color difference (not that that helps too much with the underlying mystery) …
tgamblin commented on issue hpsfoundation/tac#35.
> If the “Align with the mission of the HPSF” requirement is enough to prompt others to scrutinize the dependency licenses, then I’m happy to close this pull request without merging. …
jameshcorbett commented on issue flux-framework/flux-sched#1398.
The same test fails in the TOSS4 build farm, although the failure was in test case #3 rather than #4. I didn’t see a segfault message, but it’s possible I just missed it….
jameshcorbett commented on issue flux-framework/flux-coral2#403.
@mergifyio requeue…
garlick commented on issue flux-framework/flux-coral2#397.
Thanks! MPW now….
wihobbs commented on issue flux-framework/flux-coral2#402.
It’s helpful to remember, if the node can be returned to service immediately, to raise a fatal exception on the job but exit 0 in the prolog (this is useful, for instance, if a user requests more storage than we cap them at):…
chu11 commented on issue chu11/freeipmi-mirror#76.
ipmitool’s output can be different as it intereprets data differently. some ideas…
gardner48 commented on issue LLNL/sundials#728.
> @gardner48 Looks like the extended precision test for cvsRoberts_FSA_dns_constraints_-sensi_stg1_t.c is failing because a line number is in the output file (due to an error message, see sundials-codes/answers#60) , and the line number changed. We should probably just disable that test with extended precision since it fails.
…
adayton1 commented on issue LLNL/camp#184.
> D’oh! Yes, good catch. Thank you. …
artv3 commented on issue LLNL/RAJA#1866.
@LLNL/raja-core , what do you guys think of updating the CHANGELOG within each PR? I think it may help us keep track of new features as they come in – instead of when we are making the release candidate. …
jeremylt commented on issue CEED/libCEED#1891.
oh, our vector access protected us accidentally here…
becker33 commented on issue spack/spack#51140.
It’s not done as a post-concretization step, the specs from the dev specs are imposed in the solver itself. Then there’s also a post-concretization step that ensures the dev_path variant is present, but it doesn’t worry about the rest of the spec….
hppritcha commented on issue open-mpi/ompi#13280.
Thanks for checking this stuff out in its early state @dalcinl. some of the above functions have been implemented but are sitting in various states in PRs. some of these should be defined - like MPI_Wtick and the aint related functions so i’ll see what’s going on. As for the fromint/toint that seems like an excellent project for a AI LLM. I’ll see what can be done there.
…
grondo commented on issue flux-framework/flux-coral2#383.
No objection here. …
jameshcorbett commented on issue flux-framework/flux-accounting#735.
go off king …
cmoussa1 commented on issue flux-framework/flux-accounting#733.
I was able to reproduce this in my docker container following your set of instructions above. After the first job, subsequently submitted jobs get rejected with a Queue not valid for user error message. For flux-accounting, this seems to be a particular issue when default queues are configured, e.g….
dylan-copeland commented on issue LLNL/libROM#316.
@dreamer2368 An example using this PR is in file src/rom_handler.cpp of https://github.com/LLNL/scaleupROM/pull/60
…
cyrush commented on issue spack/spack-packages#1218.
@adamjstewart It looks like it it is trying to build with a newer umpire than ascent 0.8.0 supports. …
cmoussa1 commented on issue flux-framework/flux-coral2#394.
Yes I can. Here goes nothing!…
cyrush commented on issue LLNL/conduit#1459.
@abhishek1297 glad you were able to work it out, we can add that method to the C-API. Thanks for the feedback!…
emily-howell commented on issue Alpine-DAV/ascent#431.
@cyrush Also, you mentioned wanting to compile with 64bit IDs and then use caliper to observe any performance changes. Is there a specific analysis you were hoping to see? I was just doing some runs of different areas of the test suite with caliper reports to see any notable changes….
becker33 commented on issue spack/spack-packages#1254.
@hfp this might be of interest to you….
dylan-copeland commented on issue mfem/mfem#3807.
> @dylan-copeland did you make the changes you planned here (after mfem/data#12 was merged)? …
cbritopacheco commented on issue cbritopacheco/rodin#119.
Merging even though not finished….
tzanio commented on issue mfem/mfem#4980.
Merged in next for testing……
vsoch commented on issue google/dranet#151.
Thank you @keithmattix much appreciated. Enjoy the holiday!…
v-dobrev commented on issue mfem/mfem#4801.
@tepperly, the PR will be merged by the editor (@pazner in this case, as seen in the table added to the first post) when there are at least 2 approvals from people in the Reviewers team and after some additional testing (run nightly) in the next branch. The procedure is documented in CONTRIBUTING.md: https://github.com/mfem/mfem/blob/master/CONTRIBUTING.md#pull-requests – we try to follow it closely but it’s not set in stone.
…
garlick commented on issue flux-framework/flux-core#6958.
I added testing and removed the WIP. I am not hard over on merging this as is, but wanted the option to be available….
chu11 commented on issue flux-framework/flux-core#6999.
> I wonder though if we could just create bad treeobjs directly instead of laboriously modifying good ones? Could even have some prepared JSON in test data files. Just a thought. This is fine for now. …
markcmiller86 commented on issue betterscientificsoftware/bssw.io#2251.
> Agreed! Are you back from your break, @markcmiller86 ? …
tgamblin commented on issue spack/spack#51246.
This is very nice for #51137, where we start showing conditional deps in spack info.
…
trws commented on issue flux-framework/flux-sched#1339.
This one is mostly good too but currently has no testing….
grondo commented on issue flux-framework/flux-sched#1394.
Yes, sorry. I dropped the ball on this one. Rebased and will hit the button….
grondo commented on issue flux-framework/flux-python#16.
Oh, I see you answered in the email thread. Thanks!…
grondo commented on issue flux-framework/flux-core#6990.
This does seem more user-friendly!…
cmoussa1 commented on issue flux-framework/flux-accounting#731.
Thanks @jameshcorbett! Setting MWP here…
cmelone commented on issue cmelone/hubcast-test#3.
@lc-hubcast restart failed jobs…
becker33 commented on issue spack/spack#51190.
Looks like the tests need to be updated for the changed method name, but otherwise LGTM…
jeremylt commented on issue openjournals/joss-reviews#8388.
Ratel just will error if misconfigured. That’s to hard baked into the PETSc error and options handling….
jedbrown commented on issue openjournals/joss-reviews#8388.
Yeah, the options are extensible, akin to a programming language, and -help is used to show everything that can be specified in the current expansion. You can’t get to the entire expansion without running. It would be possible (at substantial cross-cutting effort and maintainability impact) to make a system that shows the useful options in a simulation, but even that would be unable to deal with solution-dependent logic (e.g., solve an auxiliary problem, enter an optimization loop, and/or write output only if the solution satisfies a numeric criteria). The decision to make -help comprehensive and extensible was made (by the PETSc team) long ago and responsive to community needs. We could bikeshed over a different name, but this is widely used and accepted in the PETSc community and we consider it a feature that Ratel be readily usable by people familiar with configuring PETSc solvers via run-time options (which you can liken to a domain-specific programming language)….
hppritcha commented on issue open-mpi/ompi#13280.
jenkins ci runs make distcheck…
cbritopacheco commented on issue cbritopacheco/rodin#118.
@copilot I have fixed your tests since they contained some mistakes and inaccuracies and renamed setInterface to setFront. Please write more tests a few unit tests and more manufactured tests. The manufactured tests should test with more than just point sources. You can specify that the initial front will be the boundary of the mesh. From another side, an interior interface is also useful to test (for example, a rectangular interface of edges inside a rectangular triangular mesh). Please test analytical solution vs the numerical….
adayton1 commented on issue LLNL/Umpire#986.
@rhornung67, @kab163, @davidbeckingsale, any other comments? Since I pushed a change, it dismissed Rich’s and Kristi’s approvals….
emily-howell commented on issue Alpine-DAV/ascent#431.
https://github.com/Alpine-DAV/ascent/blob/258e06ed902d251c1f8eb4d987043d049b77cade/scripts/build_ascent/build_ascent.sh#L697…
becker33 commented on issue spack/spack-packages#1123.
@hfp I changed the spec slightly to make it more legible for Spack 1.0, but I had success with: …
milroy commented on issue flux-framework/rfc#466.
These changes look good to me with respect to the interim need, and I’m fine with this PR as is. I agree with @trws that fluxion can be adapted to support nslots without too much difficulty.
…
chu11 commented on issue flux-framework/flux-sched#1394.
@grondo i assume has to be merged manually, wanna hit the button?…
chu11 commented on issue flux-framework/flux-accounting#727.
@cmoussa1 i think has to merged manually, wanna hit the button?…
cyrush commented on issue LLNL/conduit#1459.
We can add more c methods if needed. …
adayton1 commented on issue LLNL/camp#152.
@MrBurmark any other comments?…
adayton1 commented on issue LLNL/RAJA#1888.
I just noticed this doesn’t prevent trying to use the internal cub or rocprim submodules. So at the least the messages like “Using RAJA cub submodule” need to be converted to a fatal error and the message should be updated….
cyrush commented on issue visit-dav/visit#18884.
Resolved in #20494 …
cjvogl commented on issue mfem/mfem#4905.
@homeomorfismo , I’ve made a first pass through the code. Overall, I think this is in really good shape. Let’s focus on the corresponding write-up first, and only return to the code here if that write-up is completed before the end of the week….
tgamblin commented on issue hpsfoundation/tac#35.
> Today, we don’t formally vote on this. …
trws commented on issue flux-framework/rfc#466.
That’s a fair point. As I said I don’t see any problem with it, it’s easy enough to supply. @milroy do you have any thoughts here?…
wihobbs commented on issue flux-framework/flux-core#6993.
Thanks @jameshcorbett! Setting MWP. …
jameshcorbett commented on issue flux-framework/flux-accounting#726.
Yeah, it wouldn’t save you any indentation. It might be a bit easier to read though?…
chu11 commented on issue crate-ci/typos#1345.
```…
balos1 commented on issue LLNL/sundials#758.
I think this can be merged as-is, but it might be helpful to add a super quick demo in the developer docs in a “tools” section. I think just an example plot + the command that was used….
cmelone commented on issue LLNL/hubcast#167.
ok @alecbcs that worked, though for some reason I needed to pull out the permissions into ci.yml from security.yml……
alecbcs commented on issue LLNL/hubcast#167.
Can we merge the CodeQL CI YAML file into the existing security CI YAML so that we run both out of a single file and they’re triggered by the same conditions?…
imguoguo commented on issue radxa-pkg/linux-qcom#4.
mej commented on issue mej/nhc#162.
@adriansev - I don’t see anywhere that mentions which config file you have those settings in, but that can make a difference. You might try adding them to the command line just as a test. You can also enable tracing. Here’s an example of doing both at once:…
trws commented on issue flux-framework/flux-core#6986.
I mentioned it mainly because it showed up in two actions sets in a row on two different PRs for me today. Given the timeouts, it may just be that things are running extra slow, but something must have tickled it….
cbritopacheco commented on issue cbritopacheco/rodin#117.
I need an example of utilization….
cmelone commented on issue LLNL/hubcast#144.
@alecbcs my latest changes should address your comments. There’s no logging inside the library modules. …
tgamblin commented on issue spack/spack#51210.
Looks good to me… I think we could add more stuff to this page (environments, developer workflows, CI, OCI container builds, etc.) but this is a good clarification. …
jedbrown commented on issue pyOpenSci/software-peer-review#331.
Suppose a human types // sparse matrix transpose, presses tab, and gets a page of code that still has namespaces from an existing library with copyright/attribution stripped. What does it mean that “accountability remains with humans”? What if the algorithmic system obfuscates just enough that it isn’t obvious to the human that it’s plagiarizing an existing library (violating that project’s license)? Just because many people use a product doesn’t mean it isn’t manufacturing plausible deniability. If the claim is merely “I don’t think copyright holders will successfully sue me for infringing”, that is a statement about power rather than justice or consent….
garlick commented on issue flux-framework/flux-core#6589.
I think A is the sane thing to do, unlink the bad dirref. Isn’t it the same problem as removing a valref?…
chu11 commented on issue flux-framework/flux-core#6953.
re-pushed, --lost-and-found is now --repair, tweaked some documentation per comment above
…
grondo commented on issue flux-framework/flux-core#6983.
Thanks mentioning @kkier. The key thing to note is that the only change in behavior while /etc/flux/system/{prolog,epilog,housekeeping} exist is that any scripts dropped into libexecdir/flux/{name}.d (meant to be used by other packages) will be run before the system scripts.
…
trws commented on issue flux-framework/flux-core#6929.
I imagine you already found it, but here’s the link for git-absorb. I heard about it a long time ago but for whatever reason never actually tried it until today, wishing I had done it a long time ago….
imguoguo commented on issue RadxaOS-SDK/rsdk#81.
>
balos1 commented on issue LLNL/sundials#759.
> …
adayton1 commented on issue LLNL/blt#725.
I don’t have permission to merge, and I will be unavailable Monday and Tuesday. So feel free to merge whenever you are ready, @white238….
cjvogl commented on issue E3SM-Project/E3SM#7615.
> @cjvogl how urgent is this PR? After the last sprint with diags capabilities, I was thinking to pause new diags, and implement a more flexible yaml specification paradigm. Eg, I was thinking of a syntax along the line of …
becker33 commented on issue spack/spack-packages#1128.
@spackbot rerun pipeline…
becker33 commented on issue spack/spack#51069.
@XXVIMilia do you think this could be the same problem as #51180?…
jedbrown commented on issue rust-lang/rust#138689.
I believe the compute_* and sm_* semantics are consistently represented in this PR, and that single-invocation multi-target behavior is a major feature that would not entirely supplant ability to build kernels and device code using --target=nvptx64-nvidia-cuda. I think a similar amdgcn_target_feature would make sense….
v-dobrev commented on issue mfem/mfem#4948.
> First, I need to parallelize the operation of assembling N*N sparse matrices into a block matrix. Currently, I’m using HypreParMatrix and HypreParMatrixFromBlocks. I’d like to know if there are any problems with my approach….
becker33 commented on issue hpsfoundation/tac#34.
I think this is all subsumed under the requirement to join the LF – I don’t think we want to double-approve that…
tgamblin commented on issue hpsfoundation/tac#45.
@becker33 @jlapolla-cray @kmorel @ax3l @dalg24: after reviewing the (transcript of the 7/24 TAC meeting I tried to write what we discussed. …
wihobbs commented on issue flux-framework/flux-core#6972.
For reference, the same commands in a bookworm container work fine:…
cmoussa1 commented on issue flux-framework/flux-accounting#656.
Well, after a few months of searching, I think I found the culprit….
hppritcha commented on issue spack/spack-packages#1128.
we don’t support singularity in Open MPI so i’m fine with this change….
hppritcha commented on issue open-mpi/ompi#12085.
@naughtont3 any updates on adding this functionlity?…
vladotomov commented on issue mfem/mfem#4941.
Is the behavior of hypre_ParVectorToVectorAll invalid when the local size is zero, or is the MFEM usage incorrect?
…
jeremylt commented on issue mfem/mfem#4609.
sure, reverted…
cjvogl commented on issue mfem/mfem#4907.
> @cjvogl , @dohyun-cse , any chance looking at this? …
tzanio commented on issue mfem/mfem#4974.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
grondo commented on issue flux-framework/rfc#465.
One idea for now – now that we have CLI plugins – is to implement this as a CLI plugin that users requiring the more advanced specification can install and use. I think @wihobbs was talking about working on something similar that acts as a filter, but embedded in the cmdline via a plugin with a unique option namespace is an enticing way to offer the functionality. …
trws commented on issue flux-framework/flux-sched#986.
Actually, I think it comes down to this: We have the index into the list of RSMI devices that we want to pull, it looks like we have to iterate over them to find that (can probably also use a filter to get there, or use cousin walking or something smarter that I can’t think of right now). Once we have it, we can use the suffix of the name (which is utterly insane but it seems there isn’t a field for it for some crazy reason) or we can use the AMDUUID=a30d0d26ba377c92 field from the osdev attributes and put that directly into the ROCM_VISIBLE_DEVICES. That value is a lot less pretty, but it’s stable so no matter how many times that variable gets applied into child processes and restricted environments it stays correct. Where ROCM_VISIBLE_DEVICES=3 becomes an error if it’s applied twice….
grondo commented on issue flux-framework/flux-sched#1391.
Hm, this was tuolumne. I was also wondering if it is something in my environment. Sorry I haven’t had a chance to run this down yet. …
trws commented on issue desul/desul#144.
Also stacked on #146 …
cyrush commented on issue Alpine-DAV/ascent#1273.
related to : https://github.com/Alpine-DAV/ascent/issues/356…
gardner48 commented on issue xiaoyeli/superlu_mt#25.
Thanks Sherry, looks like the CI is happy again….
tgamblin commented on issue spack/spack#50933.
The script (slightly modified) succeeded on my MacBook just now on 95a332eb93, when building from scratch. When I try it again with the build cache, it fails very quickly. Should be able to debug this fairly quickly….
v-dobrev commented on issue mfem/mfem#4937.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
tzanio commented on issue mfem/mfem#4987.
Merged in next for testing……
garlick commented on issue flux-framework/flux-sched#1390.
Thanks! I’ll go ahead and set MWP…
grondo commented on issue flux-framework/flux-sched#986.
> Really what would likely be most useful in the short term would be to ensure that those logical IDs are translated back to physical IDs in exec or the shell…
JustinPrivitera commented on issue visit-dav/visit#20189.
sounds like a me problem…
imguoguo commented on issue radxa-pkg/linux-qcom#4.
jeremylt commented on issue mfem/mfem#4932.
I made some updates in the linked branch (https://github.com/mfem/mfem/pull/4609) that might help….
jandrej commented on issue mfem/mfem#4984.
Have a look at https://github.com/mfem/mfem/blob/master/miniapps/dfem/dfem-minimal-surface.cpp#L175….
trws commented on issue flux-framework/flux-sched#1015.
I actually did some digging on this, so some more context. We only show an ETA for those jobs that enter the reserved state. Since we normally run easy backfill, that means only the highest priority job that can’t run immediately gets an estimated time. If we run with conservative, then we should get estimates up to reservation depth (which is usually shorter than full backfill depth). …
grondo commented on issue flux-framework/flux-core#6970.
(in case someone works on this) …
imguoguo commented on issue RadxaOS-SDK/rsdk#80.
All but two models passed the test on GitHub Action. The two models failed due to Incident with Actions but passed the manual test….
adayton1 commented on issue LLNL/camp#180.
I’m not sure what’s going on with the docker jobs, but I don’t think it’s related to my changes….
adayton1 commented on issue LLNL/RAJA#1875.
Ruby and corona being down are the reasons for the failed CI jobs….
artv3 commented on issue LLNL/RAJA#1875.
> > I’m actually wondering if we should just use caliper if the user wants annotations rather than trying to fall back on NVTX directly. …
cyrush commented on issue Alpine-DAV/ascent#1603.
modest replay output example w/o detailed annotations: …
becker33 commented on issue spack/spack#51140.
@psakievich I think it would be possible to refactor this as a generic Environment mutator that calls a generic Spec mutator, with a callback for the particular change to execute on the spec. I decided that as long as this is the only feature that works this way it’s not worth doing, but let’s talk about extending it to commit variants once this is in….
alecbcs commented on issue spack/spack#51144.
> @alecbcs I tried yours, but it has too many issues: …
jedbrown commented on issue rust-lang/stdarch#1805.
Yeah, I can rebase. I’m having trouble finding docs for a development workflow for stdarch. The rustc josh docs describe making PRs to rust-lang/rust. I would like to build stdarch and use it with either +nightly or +stage1 to test external crates that actually use the GPU (which CI does not yet do)….
jedbrown commented on issue mfem/mfem#4609.
Pushed. It builds cleanly for me with both 0.12 and main…
chu11 commented on issue flux-framework/flux-core#6963.
> a private KVS namespace would have been created. Do we simply destroy it? Are there any races if the job immediatley restarts?…
jedbrown commented on issue flux-framework/flux-core#3556.
Would you consider Rust for the submission tool? That would give good library support for CLI handling and JSON construction, and you get a statically-linked executable that’s every bit as fast as C….
trws commented on issue flux-framework/flux-core#4534.
Yeah, we do. Asking hwloc would be ok, and actually if we have a topology or a way to refer to the gpu device there that would make the ID translation issue trivial to fix too because it’s the same object we’d want to query. The ultimate solution would be to pull the unique ID for each GPU from it, and then use that in whichever env var is for the GPU (to handle changing GPU orders and multiple runtimes on a machine) but for systems that actually exist outside my office, all we really need is:…
cmoussa1 commented on issue flux-framework/flux-accounting#720.
Thanks! Setting MWP here…
cjvogl commented on issue E3SM-Project/E3SM#7481.
> Needs a rebase and test fails should be looked at. …
adrienbernede commented on issue spack/spack-packages#869.
@v-dobrev for the records….
hppritcha commented on issue open-mpi/ompi#13279.
did we add the tests for this to ompi-tests? i’m triaging compile failures for the tests in my mtt runs: …
wihobbs commented on issue flux-framework/flux-sched#1285.
Since the approvals were dismissed due to a rebase I’ll approve and add MWP….
jameshcorbett commented on issue DataWorkflowServices/dws#254.
I think related to this change I am now seeing the following error when I try to run nnf-deploy in my kind env:
…
wihobbs commented on issue flux-framework/flux-core#6952.
I’m very uneducated on this so apologies for the stupid question but @trws or @grondo, can you explain why its important that:…
tpatki commented on issue LLNL/msr-safe#185.
Correction of a typo in bullet 4 below, the cp command should be:…
jameshcorbett commented on issue flux-framework/flux-coral2#385.
Thanks @cmoussa1, setting MWP!…
alecbcs commented on issue spack/spack-packages#1028.
Unfortunately the CI failures are related. I’m still figuring out a fix. …
jeremylt commented on issue freeCodeCamp/freeCodeCamp#61453.
I recommend reading the contributing guide. Issues are not assigned and the first valid PR is accepted….
grondo commented on issue flux-framework/pr-validator#9.
Tested and seems to be working, thanks!…
grondo commented on issue flux-framework/flux-core#6959.
Ok, that makes sense. It only came up because modprobe wants a list of all modules, but has to treat connector-local differently since it is auto-loaded and should not be unloaded, etc. Easy enough to work around though….
grondo commented on issue flux-framework/rfc#464.
Yes, please merge….
JustinPrivitera commented on issue visit-dav/visit#20520.
Thank you! Let’s leave this ticket open then until we get the dmg file….
tzanio commented on issue mfem/mfem#4970.
ping: @jandrej, @sohailreddy, @alexanderianblair …
wihobbs commented on issue flux-framework/rfc#414.
This is long out of date, and a lot of the proposed components are unnecessary now due to improvements in the python-based job-manager JournalConsumer class and the ability to extend the command line via plugins. Maybe we’ll still need an RFC for notifications, but it will look very different from this one. Closing….
chu11 commented on issue flux-framework/flux-core#6953.
> Seems like repair should be the default …
trws commented on issue flux-framework/flux-core#6954.
Yup, sounds right. Feel free to hit it, or I can if you prefer….
trws commented on issue flux-framework/flux-accounting#714.
Yes, definitely. It’s useful to have the requested time because it has a significant impact on queue policy outcomes, especially with backfill policies, and can help us determine what queue policies and settings to use in the future….
cmoussa1 commented on issue flux-framework/flux-accounting#714.
OK, wrote up a small test and it looks like flux-accounting is fetching the updated duration, so this is something that flux-accounting could store in a separate column in its job-archive if that was to be desired?…
benzwick commented on issue Slicer/Slicer#6388.
Is there any documentation that explains how to compile Slicer with Qt6 so we can test this on Linux (and later on Mac and Windows)? And which branch should be used to test the latest progress on this issue?…
jeremylt commented on issue CEED/libCEED#842.
Given that XSMM targets this hardware and already gives us better performance on AVX hardware, I propose we close this. Any objections?…
alecbcs commented on issue spack/spack-tutorial#477.
Merging without waiting for a review since this exact file is already in spack/spack….
vladotomov commented on issue mfem/mfem#4289.
I might be missing something, but I’m not seeing the value of this example. Remhos already handles advection, offers more sophisticated limiting options, computes local bounds correctly based on the stencil, and supports general meshes. I realize this showcases the new bounds calculation, but there are already dedicated examples for that….
garlick commented on issue flux-framework/flux-sched#1380.
With FLUX_RC_USE_MODPROBE=t set for tests, flux-core 0.77 is required, but looking at one of the bookworm test failures, it appears we’re picking up something less than: …
jameshcorbett commented on issue flux-framework/flux-coral2#383.
I’d like to read through the core and sched modprobe PRs first so I can understand what’s going on. I’m doing that now. So far looks totally fine though….
garlick commented on issue flux-framework/flux-coral2#383.
NP if we want to hold off. I guess I am enthusiastic about moving fowrard. :-)…
adayton1 commented on issue LLNL/CHAI#298.
Could you add a new CMake configuration variable? Something like CHAI_ENABLE_EXPERIMENTAL? Then in CMakeLists.txt only add the new files if CHAI_ENABLE_EXPERIMENTAL is on. …
v-dobrev commented on issue mfem/mfem#4923.
@lindsayad, if it is not too much trouble, can you try this branch to see if it solves the issues you encountered in #4959?…
wihobbs commented on issue flux-framework/flux-sched#1285.
> How did you test this? I added the change in this commit to t1020 in current master and the test still passes. …
milroy commented on issue flux-framework/flux-sched#1285.
> Are we still OK with leaving in the uncovered code in resource_match.cpp:select_subsystems? …
bgunnar5 commented on issue LLNL/merlin#524.
TODO: add documentation…
tgamblin commented on issue spack/spack#51061.
@haampie We discussed a number of solutions for this, and I don’t see an easy one. The proposal is not to ignore the provenance – it’s to keep it but build one version as another. As you say, when you tell Spack to treat sources as a particular version, you are doing the same thing – assigning a version. In fact, you could already do what is in this PR if you had the git repo for every version. We’re simply extending it to work for releases/tarballs instead of just git versions….
bwpriest commented on issue LLNL/ygm#368.
Ok, good to know. Should we cancel this PR?…
tgamblin commented on issue spack/spack-packages#924.
fixed comments…
tgamblin commented on issue spack/spack-packages#739.
Finally
tzanio commented on issue mfem/mfem#4955.
Merged in next for testing……
cjvogl commented on issue E3SM-Project/E3SM#7481.
@tcclevenger , can you please add the CI: Approved flag to run the tests?…
JustinPrivitera commented on issue Alpine-DAV/ascent#1587.
…
JustinPrivitera commented on issue visit-dav/visit#19488.
I think this is a good idea and a good feature to add but it would be nice to also fix the underlying issue causing things to be so slow….
hppritcha commented on issue open-mpi/ompi#13351.
@edgargabriel could you check what’s going on with rocm ci?…
v-dobrev commented on issue mfem/mfem#4944.
Unfortunately, I don’t think there’s a way to automate the synchronization of the validity flags, at least not with the current interface….
mplegendre commented on issue hpc/Spindle#4.
Closing old PRs…
trws commented on issue flux-framework/flux-sched#1385.
@mhyatt000, what version of spack are you using? The dependency is listed, and has the correct version. Is it not pulled in as one of the dependencies of your sched build? Here’s the relevant part of the package….
milroy commented on issue flux-framework/flux-sched#1382.
Thanks for the review @trws! Adding MWP….
chu11 commented on issue flux-framework/flux-core#6589.
Wanted to start a design discussion on what we would like flux-fsck to look like. First, summarizing several PRs I submitted….
jameshcorbett commented on issue flux-framework/flux-coral2#379.
I think I understand now. As can be seen in the eventlog, Flux was restarted while the job was in the queue, so the plugin was reloaded. The exception callback in the jobtap plugin is only triggered if the plugin has subscribed to events for the job, but the call to flux_jobtap_job_subscribe() is only done in the callback for the SUBMIT state. (See here.) So the exception callback was never invoked and the prolog was never removed….
vladotomov commented on issue CEED/Remhos#53.
@pearce8 it’s merged, thank you, sorry for the delay….
cmelone commented on issue spack/spack-tutorial#467.
@scheibelp …
becker33 commented on issue spack/spack-packages#885.
I think we should we backport this to v1.0.1. It may come up in release CI for future 1.0.x releases…
garlick commented on issue flux-framework/flux-core#6260.
Oh, I thought that one was already in! Sorry, will look at that now….
tgamblin commented on issue curl/curl#18104.
Thanks for this!…
tpatki commented on issue LLNL/variorum#587.
Thanks for testing this on Tuo, @kulnaman!…
jeremylt commented on issue CEED/libCEED#1881.
Ok, the blocking issue here seems to be around permissions to create files/folders in the runner…
jedbrown commented on issue rust-lang/rustup#3397.
It would be very useful if we could rustup which llvm-link or perhaps rustup which --component llvm-tools llvm-link. If you agree this would be useful, do you have a preference on the two syntaxes, or pointers to where you think it should be implemented?…
tomstitt commented on issue mfem/mfem#4028.
> Thanks for checking @tomstitt! Can you give it another try with the latest commit? …
chu11 commented on issue flux-framework/rfc#459.
i will simply merge this manually until we can figure out what happened (or perhaps mergify updated some check and we need to update our mergify config)…
wihobbs commented on issue flux-framework/Tutorials#55.
Smart idea, my only worry is that we have sent and posted links that reference the existing directory structure. Is there a way to invisibly symlink everything so that the current links continue to work? (probably not :/)…
cyrush commented on issue LLNL/conduit#1453.
@Arlie-Capps since there were changes to the amr bent grid example as part of the PR – this has diverged. …
cyrush commented on issue visit-dav/visit#20509.
This is currently running tests using test data from an http mirror, w/o baselines (which of course will fail). …
alecbcs commented on issue spack/spack-packages#571.
@adamjstewart this is a bit our of my wheelhouse. Can you speak to this situation a bit more? …
wihobbs commented on issue flux-framework/flux-core#5531.
I wanted to update this issue with the outstanding to-dos as I see them….
gardner48 commented on issue LLNL/sundials#753.
Hi @mottelet, between versions 6.6 and 7.4 there have not been any changes to the projection capability in CVODE. The error handling across SUNDIALS was updated in v7 however, this should not have changed any of the return codes from CVODE. There were some fixes related to the stop time in versions v6.6.1 and v6.7.0 that could be related to what you are seeing. Before these fixes, it was possible that CVODE would reach a stop time but return CV_SUCCESS instead of CV_TSTOP_RETURN when the output time and the stop time are the same. …
adayton1 commented on issue LLNL/RAJA#1754.
I’m encountering this issue when I configure RAJA with ENABLE_CUDA=ON and ENABLE_OPENMP=ON and a downstream library (LEOS) with ENABLE_CUDA=ON and ENABLE_OPENMP=OFF (since LEOS only supports one backend at a time)….
astrophpeter commented on issue openjournals/joss-reviews#8147.
Thanks @warrickball we have merged your changes. …
jedbrown commented on issue openjournals/joss-reviews#7716.
Hi, @jfe-dkrz.
trws commented on issue flux-framework/flux-core#6925.
Thanks for the tmate work, going to try that now that I have the source cleaned up. Also going to see if I can get the annotate failures script (or part of it) to go so we get the debug info more reliably….
grondo commented on issue flux-framework/flux-core#6925.
> It appears in my workflow output but doesn’t look like it executes. (gray checkbox, 0s elapsed, workflow continues on) …
samuelkgutierrez commented on issue hpc/quo-vadis#354.
> Question: I issued a git rebase --whitespace=fix HEAD before pushing into my repo and the whitespace test still failed. …
JustinPrivitera commented on issue visit-dav/visit#20504.
nope, nothing. I’ll pick this up again on monday….
tzanio commented on issue mfem/mfem#4957.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
trws commented on issue flux-framework/flux-sched#1384.
They are not meant to be, but some of them operate on timeouts and can have failures like that especially if the resource is overloaded. The first of those tests is on a ten second timeout, so I wouldn’t expect a spurious failure there unless either launching the subinstance is very delayed (say a very, very slow filesystem) or running too many tests in parallel. …
cjekel commented on issue cjekel/piecewise_linear_fit_py#131.
Thank you for this!…
v-dobrev commented on issue xsdk-project/xsdk-issues#277.
@balay, By the way, now that the Spack packages are in a separate repo, the xSDK pipelines may need to be updated to pull the latest spack/spack-packages repository, e.g. by calling spack repo update along with some additional info like spack repo list and some command(s) to show what commit of spack/spack-packages is being used….
tgamblin commented on issue spack/spack-packages#739.
Ok bailing on this as a back port – tried something less disruptive in #792, which should go into 2025.07.1 instead of this. …
cyrush commented on issue spack/spack-packages#744.
this looks great thank you @vicentebolea !…
grondo commented on issue flux-framework/pr-validator#7.
I just noticed that crate-ci/typos publishes pre-built binaries in their releases. …
grondo commented on issue flux-framework/flux-core#6908.
> I don’t know if it is relevant but I did find a single remaining case of using a hardcoded path to lua:…
wihobbs commented on issue flux-framework/flux-core#6906.
oops y’all saw nothing
trws commented on issue flux-framework/flux-core#6926.
Oh and it can definitely wait, there’s a heisenbug in fileref of all things on GHA right now that’s going to take a bit to work out. Thanks for looking it over!…
garlick commented on issue flux-framework/flux-core#6925.
Apologies, I made a comment on this stuff in the other PR that is based on top of it. Just that I’m traveling today and wanted to have a closer look at this before it goes in. Great work @trws….
cyrush commented on issue conda-forge/conduit-feedstock#52.
@ h-vetinari thank you for trying to solve this mystery. …
artv3 commented on issue LLNL/raja-suite-tutorial#67.
I think is good to now, @tdrwenski are you able to hit merge? or should I merge?…
jeremylt commented on issue Eudicods/outworlds-wastes#134.
In #135…
cyrush commented on issue AMReX-Codes/amrex#4572.
@ax3l our current ascent containers (0.9.4) are using CMake 3.28. The internal layout changed a bit, but I can address that. …
hppritcha commented on issue open-mpi/ompi#13343.
this looks good to me…
wihobbs commented on issue flux-framework/flux-sched#1375.
Hi @BagchiS6, sorry we missed this issue, but I looked back and it seems like we made some progress on Slack a few days after you opened this….
grondo commented on issue flux-framework/flux-sched#1383.
Or the scheduling loop isn’t being triggered to consider the next pending job….
milroy commented on issue flux-framework/flux-sched#963.
We discussed this issue in the Fluxion group meeting today. I mentioned one more disadvantage of modeling a user (as opposed to an admin DAT) advanced reservation as a reservation rather than an allocation: re-reserving the reservation during each scheduling loop can cause the start time to change, necessitating feedback to the user submitting the request….
jedbrown commented on issue CEED/libCEED#1875.
This seems like only a naming convention thing, and like it would be possible to preserve deprecated stubs for the old names. That would ease migration at what looks to be minimal cost….
gardner48 commented on issue spack/spack-packages#496.
> I would also like to hear from at least one maintainer per package. …
vsoch commented on issue kubernetes-sigs/node-feature-discovery#2183.
Ping @adrianchiris @zvonkok @ArangoGutierrez @marquiz we’ve gone through several rounds of review and have LGTM from the compatibility working group. Can any of you review this?…
samuelkgutierrez commented on issue hpc/quo-vadis#349.
Done in #351. Thank you again for the reminder, @GuillaumeMercier….
cmoussa1 commented on issue flux-framework/flux-accounting#703.
thanks @jameshcorbett! Setting MWP here…
cyrush commented on issue Alpine-DAV/ascent#1585.
More build tweaks for mi300a:…
v-dobrev commented on issue spack/spack-packages#496.
@balay, can you please take a look at the petsc addition?
…
jandrej commented on issue mfem/mfem#4951.
Probably because the algoim integration in mfem is outdated and algoim doesn’t use versioning. ping @bslazarov …
v-dobrev commented on issue mfem/mfem#4827.
@mlstowell, I merge this PR in next since we have two approvals, however, you can still review it before merging into master if you want – it is a very small change….
chu11 commented on issue flux-framework/flux-core#6928.
thanks, tweaked the commit message a bit based on your suggestion and removed the setting of $jq in sharness….
gardner48 commented on issue LLNL/sundials#721.
@wuzhiqiao-ninecube thank you for the contribution. The development branched was recently rebased and, rather than trying to resolve the conflicts here, it might be easier to migrate your changes to new branch and open a new PR. As such, I’m going to close this PR….
adrienbernede commented on issue LLNL/CARE#336.
@adayton1 This is ready ;)…
adayton1 commented on issue LLNL/CARE#336.
@adrienbernede is this ready or is it still a work in progress?…
tgamblin commented on issue spack/spack-packages#649.
@alecbcs can you submit another pr for that?…
tgamblin commented on issue spack/spack#51018.
Can you revert the change to move the links to the bottom? I think if you are looking through the README in a text editor you likely want to see the URLs next to the links… or at least I would. The old way is much easier to read….
garlick commented on issue flux-framework/flux-core#6798.
There is a fix for that test failure over in the pr for syslog support….
v-dobrev commented on issue xsdk-project/xsdk-issues#277.
I created a PR that fixes the issue with mfem@develop: https://github.com/spack/spack-packages/pull/496, however, it is still a WIP….
cyrush commented on issue visit-dav/visit#20487.
Ran into some merge issues, closing this branch in favor of #20494…
JustinPrivitera commented on issue visit-dav/visit#20493.
Can you provide a reproducer so we can take a look?…
becker33 commented on issue spack/spack-tutorial#455.
I’ve reverted this PR on main and moved the current state of main to the spack-1.0 branch to facilitate running the PEARC tutorial on Spack v0.23 on Monday…
becker33 commented on issue spack/spack-packages#638.
Closing as superseded by #645 because #645 is the one I backported to the release branch…
vsoch commented on issue oras-project/oras-py#216.
Is this something you’ve discussed with the primary oras maintainers in slack, or is this feature already implemented in oras go?…
dylan-copeland commented on issue mfem/mfem#4326.
Thanks @IdoAkkerman for your updates. I verified that the results for the nurbs_surface are unchanged in the eyeball norm, with differences on the order of round-off, due to the different choice of points used by GetInterpolant. My understanding is that GetInterpolant generalizes FindInterpolant, with Demko points usually being preferable. The changes in this PR seem good to me, to deprecate FindInterpolant in favor of GetInterpolant….
grondo commented on issue flux-framework/flux-core#6908.
@ocaisa, can you try again now that #6915 is merged. There’s some new debug in those tests that may help determine why those tests are failing for you….
jeremylt commented on issue CEED/libCEED#1869.
Why the drop in codecov? I don’t see an obvious reason…
jedbrown commented on issue CEED/libCEED#1865.
@jrwrigh Do you do this (or want to) for the diffusive flux projection? The collocated quadrature produces a lumped mass matrix so it could be considered more consistent to evaluate the flux term in collocated quadrature prior to the lumped mass projection….
trws commented on issue spack/spack#41801.
Yes, I think you’re right about that….
cmelone commented on issue spack/spack#46447.
I’ll try to work on this soon–need to find some time to work on gantry…
vsoch commented on issue pydicom/deid#280.
I would interact through python and put an IPython.embed() here and walk through the logic to understand what is going on (that is what I would try)….
astrophpeter commented on issue openjournals/joss-reviews#8147.
Thanks @fruzsinaagocs…
garlick commented on issue flux-framework/rfc#458.
Eh, I vaguely recollect us discussing this a while back and concluding that it’s probably not worth it….
chu11 commented on issue flux-framework/flux-core#6798.
hit this build failure, it’s a very new test from #6911 so just documenting in case this is a racy pattern (could hypotheticlaly just be a timeout) …
adrienbernede commented on issue LLNL/Umpire#970.
@davidbeckingsale ready for merge. (Test should pass)…
adrienbernede commented on issue LLNL/CHAI#317.
@adayton1 Ready for merge. Test should pass….
v-dobrev commented on issue mfem/mfem#4917.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
chakshinglee commented on issue mfem/mfem#4909.
@tzanio other than “Sanitizer”, I think the failing checks are probably due to the upstream branch, which is still under development….
vsoch commented on issue google/dranet#151.
@michaelasp I have an equivalent example started - but I have a catch22. The environment I’m working in is user space kubernetes. We can’t see any devices without a privileged pod. When we add that, we see everything. This means the selector is irrelevant. I need an environment with production Kubernetes that I can run without rootless. I had Google Cloud credits but they expired, and I’d need to pay out of pocket. @aojea can you help? It shouldn’t be too many to test this out. Once I have that, I can add the full analogous example to the docs….
hppritcha commented on issue open-mpi/ompi#13299.
@jsquyres please review when you have time. we need this in main before branching 6.0.0…
jedbrown commented on issue rsmpi/rsmpi#152.
BorrowedBuf as in read_buf is an alternative interface, though we would need to make our own generic version (preferably in a separate crate)….
vsoch commented on issue pydicom/deid#280.
I can give a suggestion for a strategy to take - if you have very specific, scoped fields you want to keep, you can use the KEEP directive. If it’s more a global thing a strategy akin to the reverse remove_private_tags might make sense….
vsoch commented on issue google/dranet#151.
> I’d like to see an example of this at work, i.e spin up a pod with a resource request and see that the RDMA device gets properly mounted to the pod. Since a lot of that logic depends on NIC devices there may need to be some work done there for proper allocation/release of the device from the host to the pod. …
grondo commented on issue flux-framework/flux-core#6909.
To summarize offline debugging, it was discovered via running rpm --verify that /etc/flux/rc1 and /etc/flux/rc3 had been modified by configuration management and thus the system was running with v0.74.0 with the rc scripts from v0.71.0. This caused the sdmon modules to not be loaded, so the instance was stuck waiting for sdmon to check in….
gardner48 commented on issue LLNL/sundials#702.
@emprice Thanks for reporting this problem. I’ve modified one of our examples using inequality constraints and was able to reproduce similar behavior where the step size is increased rather than cut when a constraint violation is found. This occurs when the predictor and corrector both produce states that do not satisfy the inequality constraint. In this case the computation used to estimate the step size needed to satisfy the constraint is invalid. There are a couple ways to address this. I’ll discuss this we the rest of a team and update this issue when I’ve added a fix….
artv3 commented on issue LLNL/raja-suite-tutorial#40.
I think we can close this PR, we have decided to leave this lesson out of the intro tutorial. …
cmelone commented on issue LLNL/hubcast#145.
the handlers and clients have names like GitLabSrcClientFactory and GitLabSrcHandler. I haven’t changed the destination equivalents yet, or GitHub classes if there’s a more attractive option available…
gardner48 commented on issue AMReX-Microelectronics/FerroX#72.
Requires updates to the AMReX SUNDIALS interface in AMReX-codes/amrex#4562…
cyrush commented on issue visit-dav/visit#20472.
I think I know the issue with the vtkm unstructured grid, its not the coordinates. …
markcmiller86 commented on issue visit-dav/visit#20461.
@Sam-Briney I just wanted to reach out and ask if you might know if you have any automated scripting or some other such activity that is routinely pulling down LFS content in the visit-dav/visit repo? We’ve run into some odd issues regarding our lfs bandwidth quota and I am just trying to investigate….
tgamblin commented on issue spack/spackbot#109.
Spackbot can only request reviews from people in the spack organization. @arezaii and @bonachea are in the Spack organization – specifically they are part of the maintainers team that Spackbot invites org members to….
tgamblin commented on issue spack/spack-tutorial#456.
thanks!…
adrienbernede commented on issue spack/spack#49771.
@becker33 This is the error I am running into….
astrophpeter commented on issue openjournals/joss-reviews#8147.
Thanks @fruzsinaagocs I have added the missing DOIs and replaced the Tudat reference. https://github.com/LLNL/SSAPy/pull/93 . Please let me know if you would like me make any further changes. …
tzanio commented on issue mfem/mfem#4928.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
v-dobrev commented on issue mfem/mfem#4811.
Re-merged in next for testing……
cmoussa1 commented on issue flux-framework/flux-accounting#686.
Thanks for reviewing this @grondo! I force-pushed up a change to check the return code of flux_jobtap_event_post_pack () as well as added a comment explaining that an error there is not fatal. I’ll go ahead and set MWP here…
adrienbernede commented on issue LLNL/radiuss-shared-ci#24.
Pascal was retired on october 2024….
cyrush commented on issue Alpine-DAV/ascent#1559.
I think we can resolve by modifying the bounds data flow filter tracking logic to provide the bounds per topology instead of one overall set of bounds. The results can be in a conduit node instead of a vtkm::Bounds` object….
gardner48 commented on issue AMReX-Codes/amrex#4562.
FYI @ajnonaka, various updates I made when testing with FerroX. I’ll open a PR with some corresponding updates on the FerroX side as well….
becker33 commented on issue spack/spack-tutorial#455.
@tgamblin @kshea21…
v-dobrev commented on issue spack/spack-packages#143.
I’d like to get the PR that adds MFEM v4.8, #496, merged before this PR. That’s why I’ve been postponing the review of this PR for some time now….
hppritcha commented on issue open-mpi/ompi#13299.
related to https://github.com/open-mpi/prrte/pull/61 . We need updates to ompi_main branch on prrte fork to get help messages working for prrte help….
wihobbs commented on issue flux-framework/flux-core#6907.
As for the actual change, looks good to me but we should probably get an approval from @garlick….
benzwick commented on issue Slicer/SlicerBuildEnvironment#25.
It looks good to me too. Thank you so much for helping with this….
alecbcs commented on issue spack/spack-packages#507.
I use labeler in other projects, but it doesn’t support tags that come from the patch of the PR. For example, we should have update-package but we couldn’t have new-version because it only looks at the file modified….
tgamblin commented on issue spack/spack#50972.
> Is saving the compiler wrapper output (Spack debug logs) in the same directory as spack-build-out.txt easy to implement?…
hppritcha commented on issue open-mpi/prrte#52.
closing this for now. we can reopen if need be….
hppritcha commented on issue mpi-forum/pympistandard#30.
@jsquyres @wesbland please review…
homeomorfismo commented on issue mfem/mfem#4926.
@tzanio yes!…
jedbrown commented on issue RDycore/RDycore#295.
Does one need gradients or integrals, or only point samples of the solution field from the mesh without interpolation?…
becker33 commented on issue LLNL/uberenv#142.
I think @cyrush ‘s suggestion is probably better – you could still technically create a situation that required cleaning the bootstrap, but by far the most likely reason is two different versions of Spack trying to use the same bootstrap store….
becker33 commented on issue spack/spack-packages#53.
@scottstraughan is there any mechanism other than a file in the intel-oneapi-compilers prefix for oneapi to know where to look for plugins? Anything equivalent to the PYTHONPATH variable for python searching for python modules?…
v-dobrev commented on issue spack/spack#49871.
Migrated to https://github.com/spack/spack-packages/pull/496….
uvilla commented on issue pecos/tps#306.
Sounds good. …
garlick commented on issue garlick/brewcop#5.
Yeah we don’t have those modes anymore, so closing….
vsoch commented on issue rootless-containers/usernetes#373.
We got this working. I wish I could report why - it started working on a restart to the cluster. My suspicion is that the admin didn’t have all the kernel modules loaded that we need, but I don’t know….
imguoguo commented on issue osbuild/bootc-image-builder#963.
> Fwiw, I submited an RFC patch to the qemu-devel mailinglist that return “0” unconditionally for the set_robust_list() syscall. When I do this locally the podman locking works so I’m 90% confident that it solves the problem. I have no sense in how likely it is that the patch gets accepted though (my guess is not very likely), its arguably wrong but also in practice glibc does not care - it is a risk for non-glibc threading implementations though which would be a good reason to reject it (otoh most languages like rust/java use glibc it seems, go does not use set_robust_list and musl https://git.musl-libc.org/cgit/musl/tree/src/thread/pthread_mutex_trylock.c#n30 also does not check the return code ] …
vsoch commented on issue google/dranet#150.
Lost my allocation
uvilla commented on issue pecos/tps#306.
Another options could have been using MPI gatherv to handle all the …
hppritcha commented on issue open-mpi/ompi#13321.
@cpshereda could someone from Cornelis provide a list of sanity checks to run to verify an OPA network is correctly set up?…
tomstitt commented on issue mfem/mfem#4918.
@camierjs already did this in https://github.com/mfem/mfem/pull/4899 =]…
tzanio commented on issue mfem/mfem#4898.
Merged in next for testing……
v-dobrev commented on issue mfem/mfem#4899.
Merged in next for testing……
artv3 commented on issue mfem/mfem#4913.
Can we update the branch with main? I would like to try it, but I need the latest and greatest. …
grondo commented on issue flux-framework/flux-core#6898.
@wihobbs: if you approve I’ll go ahead and set MWP here….
BradWhitlock commented on issue LLNL/axom#1440.
This code does not compile anymore due to a static_assert so I’m closing it….
jeremylt commented on issue CEED/libCEED#1850.
If a user is bypassing our access model, there’s nothing we can do about that. It will always be a bug….
cyrush commented on issue Alpine-DAV/ascent#1552.
win2025 it is….
astrophpeter commented on issue openjournals/joss-reviews#8147.
Thanks both. @athulpg007 we just added some more examples. @andrea-sesta we’re working on updating the JOSS paper text again. Could you please let me know of any more outstanding items we need to take care of for the review? …
jameshcorbett commented on issue flux-framework/flux-sched#1372.
Another user reported this on Tuo:…
garlick commented on issue flux-framework/flux-coral2#376.
Fixed that - thanks! I’ll set MWP…
adayton1 commented on issue LLNL/Umpire#956.
Sorry for all the nitpicks. A lot of these changes have user-facing error messages, which is why I’m being a little pedantic….
adrienbernede commented on issue LLNL/RAJA#1859.
- [x] Merge change in RSC: https://github.com/LLNL/radiuss-spack-configs/pull/133 …
cyrush commented on issue visit-dav/visit#20449.
We should see if this happens with vtk 9.5 since the rendering paths will be different….
tpatki commented on issue kokkos/kokkos-tools#295.
Hi @ethan-puyaubreau …
chu11 commented on issue flux-framework/flux-core#6798.
removed WIP, now that #6772 has been merged…
grondo commented on issue flux-framework/flux-accounting#682.
I wonder if this error is the problem: …
cmoussa1 commented on issue flux-framework/flux-accounting#682.
No, not a problem. I opened this PR mostly as an experiment to see if removing the duplicate coverage.rc that I had in flux-accounting’s checks_run.sh (I think due to my my negligence in #644) would actually trigger the Python bindings from actually getting picked up by Codecov, but I’m still not seeing coverage there.
camierjs commented on issue mfem/mfem#4899.
> This looks good to me. It builds a few heavy libraries (including libcxx), but they are cached and preserved between individual runs right? …
wihobbs commented on issue flux-framework/flux-core#6898.
As I looked deeper in to it, I realized it’s not a problem as I thought it would be. I was expecting we’d have several places where the phrase “job environments for Jobspecs created in Python have an empty environment by default” would show up, but that proved not to be true….
trws commented on issue flux-framework/flux-core#6704.
That sounds right, we could probably get away with a replace op for this one. Maybe allow updates to job.update.<json-patch-path-root> so you could do (I forget the exact path, but something like) job.update./attributes/dependencies to allow updates to it. Depending on how granular we want the control to be that might not be quite right but it would make it easy to allow updates to specific roots of the jobspec, or even restrict it to specific array members if we ever needed to….
balos1 commented on issue LLNL/sundials#736.
FS permissions should be fixed too…
JustinPrivitera commented on issue visit-dav/visit#20154.
Can we reschedule this ticket for a later release now that we have addressed mili?…
v-dobrev commented on issue mfem/mfem#4757.
Re-merged in next for testing……
tzanio commented on issue mfem/mfem#4909.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
trws commented on issue flux-framework/flux-core#6704.
The first thing that went through my mind on this is we could use json patch formatted content. Jansson doesn’t support it natively, but there are examples around the internet for supporting it with anything that has a json_pointer_set or similar. There are a number of tools that can work with or produce it, like a diff output for json in general, so it would likely end up useful other places too. …
balos1 commented on issue LLNL/sundials#732.
I found a workaround with the generator, so this is not needed anymore….
BradWhitlock commented on issue LLNL/axom#970.
I added ArrayView::fill() in an earlier PR so I’ll finish this one….
tpatki commented on issue spack/spack-packages#148.
@slabasan …
vsoch commented on issue singularityhub/singularity-hpc#670.
If you have interest! I didn’t comment because it’s marked as a Draft. Let me know when it’s ready for review….
jedbrown commented on issue rsmpi/rsmpi#209.
Closing in favor of #214 …
jeremylt commented on issue openjournals/joss-reviews#8467.
I would be interested in reviewing, as long as me being out for travel for a couple of weeks in Jul and Aug isn’t a problem for the review timeline….
grondo commented on issue flux-framework/flux-core#6774.
Also forgot to mention that this now has support for a module priority value. Module alternatives are sorted first by priority then by load order, so the last module configured gets preference if priorities are the same. The default priority is 100, and sched-simple has a configured priority of 50.
…
jameshcorbett commented on issue flux-framework/flux-coral2#373.
Looks like a transient error, it’s passing now! Setting MWP….
jedbrown commented on issue Tehforsch/diman#91.
I just wanted to share this update from the const generics group lead:…
adayton1 commented on issue LLNL/spheral#258.
> @adayton1 is this something you’re still working on / planning to work on in the near future? …
cyrush commented on issue LLNL/conduit#1447.
:-) …
markcmiller86 commented on issue LLNL/Silo#448.
FYI, if you have a chance, see #450….
jeremylt commented on issue CEED/libCEED#1847.
Note to me - bump Ratel CI on Monday…
cyrush commented on issue Alpine-DAV/ascent#1571.
This work builds off @nicolemarsaglia’s uniform grid sampling work to add sampling at a list of points, or via a line (start, end, and number of samples). …
vsoch commented on issue zenodo/zenodo#1606.
You know, it’s been enough time this would be a fairly straight forward task for an LLM. As long as you provide it the structure and data you need to populate it….
becker33 commented on issue spack/spack#50936.
@haampie added…
jedbrown commented on issue rust-lang/rust#138689.
@wesleywiser :wave: What are the next steps for this PR?…
garlick commented on issue flux-framework/flux-core#6887.
I was mistaken. pthread_cancel() is only called on each broker module during broker shutdown, from modhash_destroy()…
cmoussa1 commented on issue flux-framework/flux-accounting#677.
Thanks for the review and the helpful feedback @jameshcorbett! I ended up changing this command’s name to just show-usage - I agree with you that it might be a better name for it than list-usage. I also force-pushed up some changes based on your suggestions above. Will set MWP here shortly…
grondo commented on issue chaos/pdsh#170.
Well one thing you could do now is to put a wrapper script ssh into someplace like ~/bin/ssh with the following:…
cmelone commented on issue spack/spack-packages#183.
@G-Ragghianti please rebase your PR on the latest version of spack-packages in order to get CI to pass…
wihobbs commented on issue flux-framework/flux-core#6348.
@kulnaman also suggested this today, specifically for seeing the fluxion versions, which are currently only available through flux dmesg (which is restricted to the instance owner)….
alecbcs commented on issue spack/spack#50931.
Todd and I considered this in #50868 and ultimately decided against it since setting a value would have no effect for users without rerunning spack repo update and thus would be confusing to debug.
…
garlick commented on issue flux-framework/flux-coral2#370.
> We should double check that we aren’t configuring the plugin under the old name anywhere so I’ll mark this WIP pending that. …
adrienbernede commented on issue LLNL/radiuss-spack-configs#133.
Another nice side effect of anticipating the release is that RADIUSS Spack Configs will automatically pick that release in its CI. It wouldn
adayton1 commented on issue LLNL/Umpire#795.
> > What’s the current status of this merge request? I’m testing out asan and finding it works for simple tests. I’m working on enabling it in my application, but until this goes in, I’ll have to disable memory pools. …
adrienbernede commented on issue LLNL/RAJA#1859.
@rhornung67 I
astrophpeter commented on issue openjournals/joss-reviews#8147.
Hi @fruzsinaagocs,…
adayton1 commented on issue LLNL/radiuss-spack-configs#133.
> > > > Where do the 2025.04.0 and 2025.06.0 version numbers come from? …
astrophpeter commented on issue LLNL/SSAPy#88.
This PR Aims to address the JOSS review comment https://github.com/LLNL/SSAPy/issues/80…
jedbrown commented on issue rust-lang/rust#138689.
I rebased. The warnings for implied features were fixed by https://github.com/rust-lang/rust/pull/140920. I updated a stale comment left behind in that refactor, and my handling of features transitively implied by base features moved to rustc_codegen_ssa. …
homeomorfismo commented on issue mfem/mfem#4769.
> I noticed that now the following two sample runs are actually identical: …
v-dobrev commented on issue mfem/mfem#4903.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
grondo commented on issue flux-framework/flux-core#6882.
Thanks! I’ll set MWP…
v-dobrev commented on issue xsdk-project/xsdk-issues#277.
Hi @balay,…
adrienbernede commented on issue spack/spack#50916.
For the records, here is a pre-v1 compiler compiler config that I am trying to port over to v1:…
tgamblin commented on issue spack/spack#50920.
This one’s more complete – with updated docs…
garlick commented on issue flux-framework/flux-core#6885.
I’ll set MWP - thanks!…
chu11 commented on issue flux-framework/flux-core#6880.
just pushed a commit on top that implements --tail=N in flux job attach. Everything appears to work as expected.
…
cjekel commented on issue cjekel/similarity_measures#39.
Thank you!…
JustinPrivitera commented on issue LLNL/conduit#1424.
With my two comments above I believe I have addressed all of your feedback @cyrush. I think this is ready to be merged. Please let me know if there is anything else we should discuss….
trws commented on issue LLNL/camp#179.
They could if someone wants to set up an image with one of the CPU-backed SYCL implementations like AdaptiveCPP or the clang upstream offload version (which I think now has “run in separate process” support to give you memory errors on CPUs if you mess up transfers). We don’t have that set up though. …
markcmiller86 commented on issue LLNL/Silo#432.
Already handled in f10090abcc63f5e93d52130db0b8bb0773c765d9…
tgamblin commented on issue spack/spack-packages#44.
@kwryankrattiger …
hppritcha commented on issue open-mpi/ompi#13279.
@edgargabriel i pushed the remainder of the fortran related files to the PR - hopefully….
vsoch commented on issue kubernetes-sigs/node-feature-discovery#2170.
The nfd worker generates a lot of logs (and other unexpected output) so I wasn’t sure how to cleanly do that. Whereas with writing the file explicitly, I can control exactly the contents….
trws commented on issue flux-framework/flux-sched#986.
Not substantively, we operate on the IDs as logical IDs (effectively assuming, in absence of actual structure, that lower IDs are close to other lower IDs). We still have a direct hwloc reader, which I believe is still tested, though we’re not currently using it. We would still need a way to connect the two together. Really what would likely be most useful in the short term would be to ensure that those logical IDs are translated back to physical IDs in exec or the shell. Having the actual locality in fluxion would definitely be good, but with what @ryanday36 showed in the issue description just doing that logical->physical translation even with hwloc-calc right before doing the env var assignment would fix it. Admittedly not fix it the long-term “right” way, but we’ll need that logical to physical translation anyway because we don’t want to be tied to whatever crazy variable numbering cuda or hip use from 1pm to 2pm on alternate Thursdays….
grondo commented on issue flux-framework/flux-sched#986.
This issue came up again in the flux dev meeting yesterday, so just commenting here to revive the issue….
mplegendre commented on issue flux-framework/flux-core#6883.
We’d previously discussed starting a spindle session at allocation time that lasts the whole allocation. That would also solve this problem. But the drawback is it’s hard for users to pass configuration arguments to spindle, since spindle’s session starts before the user gets control. Though I’ll go this route if we can’t do alternatives….
cmoussa1 commented on issue flux-framework/flux-accounting#667.
Rebased this PR to catch up after #672. Setting MWP here…
vsoch commented on issue expfactory-experiments/attention-network-test#2.
What sticks out to me is defining “blocks” that are then looped through for trials. So possible reduce the sections there, and within each entity added to blocks, you can also delete….
balos1 commented on issue LLNL/sundials#721.
Thank you for opening this pull request. Due its size, it will take us awhile to be able to consider and review it. …
alecbcs commented on issue LLNL/hubcast#19.
Oh good point! I think we can close this one out :)…
cmelone commented on issue LLNL/hubcast#19.
@alecbcs is this still relevant given the addition of the config handler?…
cmelone commented on issue spack/spack-packages#107.
If you’d like a review, try posting in the #pull-requests channel on Slack. The CI errors will need to be fixed though…
alecbcs commented on issue spack/spack#50874.
Yep. Working on a few other things today / tomorrow. I can do this Friday….
markcmiller86 commented on issue openjournals/joss-reviews#8106.
I recommend this paper for publication….
adayton1 commented on issue kokkos/kokkos#8195.
Thank you! I’ll give Kokkos_IMPL_AMDGPU_FLAGS a try!…
grondo commented on issue flux-framework/rfc#454.
Setting MWP….
artv3 commented on issue LLNL/RAJA#1853.
Consider moving the plugins into src/plugins – keep as cpp files. …
emily-howell commented on issue Alpine-DAV/ascent#1502.
## TLDR: …
markcmiller86 commented on issue visit-dav/visit#20442.
> Here’s a question: the query output object for Spatial Extents queries is a single entry with key = ‘extents’, and value an array/vector of the values. With the changes to the output string, should the output object (XmlResult) be modified to use the XMin/XMax, etc keys instead of just ‘extents’? If so, this would possibly be more of a problem, even if it is the better way to report. …
imguoguo commented on issue osbuild/bootc-image-builder#963.
> Thank you! This looks nice! Ideally we would have a proper test for this but given that its not an official fedora arch yet it fine. …
jandrej commented on issue mfem/mfem#4898.
> @jandrej, could I suggest a couple small changes that I noticed in the DFEM code? …
tzanio commented on issue mfem/mfem#4898.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
vsoch commented on issue kubernetes/website#51164.
@graz-dev do you need any more clarification from us? …
samuelkgutierrez commented on issue hpc/quo-vadis#342.
Is something up with Github?…
adayton1 commented on issue LLNL/Umpire#967.
I think you are going to need to update the MemoryResourceType enum in MemoryResourceTypes.hpp. Otherwise, “SHARED” could map to the wrong implementation….
JustinPrivitera commented on issue LLNL/Silo#448.
This would be a nice feature!…
balos1 commented on issue spack/spack-packages#219.
@everythingfunctional Can you try adding depends_on("blas", when="+lapack") to the sundials package.py to see if that fixes this. …
trws commented on issue flux-framework/flux-core#6492.
I don’t recall seeing this when it was being done, but it was mentioned in one of our recent meetings so I came looking. There are at least some updates here, in that uv_ref/unref now exist at least, and the child handling could be handled one of a couple of ways depending on the requirements (either uv_process_t if we can, or uv_signal_t if not). The others I think are still at least different, and the close item is vaguely interesting, I would think we’d be able to tolerate that even though it is a bit annoying. It’s probably safer for io_uring style setups as well as windows, but I’m not 100% sure about that….
gardner48 commented on issue LLNL/sundials#713.
Fixing this typo in another PR….
adrienbernede commented on issue LLNL/radiuss-spack-configs#129.
@tdrwenski Could you open a PR in Quandary that checks whether your CI works well with the present PR in RSC?…
camierjs commented on issue mfem/mfem#4326.
There were some changes to bring from doftrans-three-arg, done in 2bef31b and 4a46614.
…
grondo commented on issue flux-framework/flux-core#6873.
> I wonder if we could add an exec_bypass flag and let this plugin use both flags and post alloc (adding a fake or empty R), free, start, and finish (with job result) and have the proxy job track the state of the actual job? …
garlick commented on issue flux-framework/flux-core#6873.
This is pretty neat. However it seems like its usefulness will be limited as long as the result of the proxy job is always reported as failure. I see why a fatal exception was used to get the job from DEPEND to CLEANUP state in the prototype, since there’s no other way to do that currently, but I wonder if we can think up a better way that allows the proxy job result to reflect the result of the actual job. That way workflow tools, not to mention Flux native dependency schemes like afterok ,would not need to treat delegated jobs specially when they need to fetch the job result.
…
vsoch commented on issue vsoch/oci-python#24.
Thanks! …
markcmiller86 commented on issue visit-dav/visit#4914.
Here is a potential confusion. When listing the dimensions of an multi-dimensional mesh (e.g. 2DCoRectMesh as above), the dimensions are specified as ZYX, not XYZ. So, the mesh is 9 nodes in Y and 33 nodes in X….
JustinPrivitera commented on issue visit-dav/visit#20440.
> > One question - does it make sense to rename bv_qt6.sh to bv_qt.sh, and to change the name in associated build scripts and in modules.xml?
…
jedbrown commented on issue rsmpi/rsmpi#215.
This would be resolved by #214 . There has also been an issue with the runtime feature (cf. #203 ). Do you have an opinion about this question? https://github.com/rsmpi/rsmpi/pull/214#discussion_r2136959267…
jedbrown commented on issue openjournals/joss-reviews#7881.
@editorialbot recommend-accept…
tzanio commented on issue mfem/mfem#4841.
@dylan-copeland , can you please resolve conflicts?…
trws commented on issue flux-framework/flux-core#6315.
> > add the resource.rediscover to the sub-instance config by default…
garlick commented on issue flux-framework/flux-coral2#369.
Cool, thanks. I’ll set MWP….
vsoch commented on issue flux-framework/Tutorials#54.
It also looks like there is a “Slides coming soon!” message that can now be updated….
artv3 commented on issue LLNL/RAJA#1859.
> > > This PR changes cmake to support a minimum cxx standard of 17. …
JustinPrivitera commented on issue Alpine-DAV/ascent#1556.
Let’s have renders for optical_depth fields as well. We should attempt to have tests that capture every single thing included in the output and the inputs we provide in tests should cover as many of the edge cases as possible….
emily-howell commented on issue Alpine-DAV/ascent#1526.
All of these action items were addressed in #1524 …
cyrush commented on issue visit-dav/visit#5770.
> > For AMR, we shouldn’t use VTK. For blanking out cells, we should use nesting….
hppritcha commented on issue spack/spack-packages#209.
@RonRahaman please open a PR for this, thanks….
v-dobrev commented on issue mfem/mfem#4880.
The normal on a boundary edge is not uniquely defined – typically, the edge has two adjacent faces that have, generally, different normals. How do you want to treat these cases?…
grondo commented on issue flux-framework/flux-accounting#659.
It does seem like a good idea to store the priority factor weights in the database, especially if there’s going to be an easy method to view the current weights….
bgunnar5 commented on issue LLNL/merlin#512.
@lucpeterson after spending hours trying to research and implement this, turns out Redis only accepts plaintext in the redis.conf file. Therefore, even if we encrypt the password with Fernet, Redis will just use the encrypted string as the password. I don’t think there’s any way around this so those last three CodeQL issues are unable to be resolved….
cyrush commented on issue Alpine-DAV/ascent#1486.
resolved in #1527 …
chu11 commented on issue flux-framework/flux-core#6871.
thanks! and I just noticed I typoed “updated” in the PR title and the commit message. Fixed that too. Will set MWP…
jameshcorbett commented on issue flux-framework/flux-core#6870.
Force-pushed to rebase with master and expand the test a little bit, setting MWP….
wihobbs commented on issue flux-framework/flux-core#6315.
@eleon has a few thoughts here shared today with @trws and me. Tagging him so he can share more….
jameshcorbett commented on issue flux-framework/flux-coral2#367.
Force-pushed to fix release date, setting MWP….
jedbrown commented on issue RDycore/RDycore#313.
These would be useful for dependencies:…
eleon commented on issue LLNL/mpibind#45.
For mpibind to work as intended, you need to tell Flux you want the full node (-x). I also suggest using as few parameters as possible in your command line since you can, inadvertently, add conflicts between Flux affinity and mpibind. …
tgamblin commented on issue spack/spack#50867.
closing as the RHEL8 UBI issue seems to have sorted itself out….
chu11 commented on issue flux-framework/flux-accounting#656.
I wasn’t able to find where in the code you configure journal_mode and synchronous modes. In content-sqlite it is set to “WAL” and “NORMAL”, for a smidge better performance….
tgamblin commented on issue spack/spack-packages#127.
I think the answers would be: …
tgamblin commented on issue spack/spack#50595.
I think we should do this but we are attempting to get #47615 in for 1.0, which also adds the hash of the spack instance to the misc_cache. …
jedbrown commented on issue rsmpi/rsmpi#203.
@mscroggs Following up on this, we get build failures on MacOS without the runtime feature. It works everywhere else. Do you know of a way to fix this?
…
tzanio commented on issue mfem/mfem#4804.
Re-merged in next for testing……
tpatki commented on issue flux-framework/flux-core#6873.
Hi @trws @garlick @grondo: …
alecbcs commented on issue spack/spack#48820.
Closing since this PR was sucessfully migrated to spack/spack-packages….
v-dobrev commented on issue spack/spack#49790.
bwpriest commented on issue grid-parity-exchange/Egret#318.
> @bwpriest I do not understand the failures … maybe I messed something up in 160a4a4? …
artv3 commented on issue LLNL/RAJAPerf#515.
> > yes, 2 is equivalent to the x index in cuda/hip …
cyrush commented on issue Alpine-DAV/ascent#1550.
…
v-dobrev commented on issue mfem/mfem#4851.
I’m not sure why this was merged without approvals and with requested changes pending. Is the idea to review these changes as part of #4800?…
trws commented on issue flux-framework/flux-core#6858.
I really like this, had one tiny docstring tweak and a question but it looks really good @grondo….
grondo commented on issue flux-framework/flux-core#6868.
Thanks! Setting MWP….
cmoussa1 commented on issue flux-framework/flux-accounting#631.
Looks like #632 ended up fixing this issue on tuolumne at least, so I’ll go ahead and close this now….
markcmiller86 commented on issue visit-dav/visit#20396.
@JustinPrivitera the best workaround I have found so far is to just create an alias expression and then use that alias in any further expressions requiring the original variable. On my mac with current develop, I don’t get the garbage data condition then. So, in other words, define foo as an alias for ElementBlock and then define bar as foo*1 and that works fine….
cmelone commented on issue spack/spack-tutorial#443.
The changes LGTM (after rebase), my other comments are not blockers…
hppritcha commented on issue open-mpi/ompi#13288.
With big count disp_unit argument is of type MPI_Aint for the “_c” routines. So that’s the reason why we’re using ptrdiff_t now….
brendankeith commented on issue mfem/mfem#4873.
@mdmeeker I think this breaks something in navier_kovasznay.
…
tomstitt commented on issue mfem/mfem#4821.
> @tomstitt, is this ready for review? If it is, can you please add the ready-for-review label?
…
garlick commented on issue flux-framework/flux-core#4201.
…
jameshcorbett commented on issue flux-framework/flux-accounting#652.
Oh my bad!…
BradWhitlock commented on issue LLNL/conduit#1439.
This is working with Conduit (and the host code). I plan to do some more testing to see whether other test suites are affected….
markcmiller86 commented on issue visit-dav/visit#20396.
If I look at an integer variable from a Silo file such as ivar from specmix_quad.silo, I DO NOT experience the same behavior. So, it may be somehow specific to the Exodus reader….
alecbcs commented on issue spack/spack#50565.
@alalazo after this PR/commit I can no longer concretize emacs +native. I’ve checked my packages configuration and the gcc external correctly shows as having languages=jit so I’m a bit at a loss for why the package is suddenly failing to use the external.
…
vsoch commented on issue oras-project/oras-py#204.
Why are you calling this in one off functions instead of at the class init?…
tzanio commented on issue mfem/mfem#4804.
Merged in next for testing……
grondo commented on issue flux-framework/flux-core#6843.
Closing as duplicate of #5035….
BradWhitlock commented on issue LLNL/conduit#1434.
I implemented adjset point sorting based on spatial bins. This works for the Blueprint tests but for some reason, it totally fails on the test problem I’ve been debugging. …
jedbrown commented on issue CEED/libCEED#1830.
I feel it. FWIW, it was once Chop and changed to Filter in https://gitlab.com/petsc/petsc/-/merge_requests/6699….
trws commented on issue spack/spack#50702.
Yup, go for it….
v-dobrev commented on issue mfem/mfem#4821.
@tomstitt, is this ready for review? If it is, can you please add the ready-for-review label?…
chu11 commented on issue flux-framework/flux-core#6840.
thanks, I’ll set MWP and adjust the github settings for the CI adjustment….
BradWhitlock commented on issue LLNL/axom#1580.
The idea was to add workarounds for double into the new wrappers for axom::atomicMin and axom::atomicMax (https://github.com/LLNL/axom/blob/3666e7888c7542c50ab4177044089da539b1c933/src/axom/core/execution/atomics.hpp#L51) …
v-dobrev commented on issue GLVis/glvis#336.
> @justinlaughlin, what happens if we load a steam with “screenshot” command in the web version? …
jandrej commented on issue mfem/mfem#4804.
Reminding all reviewers to approve or suggest changes asap….
jameshcorbett commented on issue flux-framework/flux-core#6842.
> After typing that up, I realized one issue with a special exit code is that exiting early from the prolog due to a potentially nonfatal error is probably not a good idea. This could skip other parts of the prolog that are necessary for preparing a node for use by the user. The node may be drained, but the user could still log in, or choose to undrain the node….
grondo commented on issue flux-framework/flux-accounting#648.
> LGTM and sure, a PR in flux-core sounds good! …