tgamblin commented on issue spack/spack-packages#3200.
Closing this as we do not plan to implement it. We may make stage names configurable as in https://github.com/spack/spack-packages/pull/3200#issuecomment-3821996900, which would at least give affected people an easy out….
imguoguo commented on issue sipeed/picoclaw#2236.
gardner48 commented on issue llnl/sundials#900.
The last commit updates the level 2, 4, and 5 logging outputs to match the output on the Jenkins test machine. The Jenkins PR tests use logging level 3 and the release tests use logging level 2 (the default level), so outputs for levels 2, 4, and 5 were not updated in previous PRs and a difference in the level 2 output was causing one test to fail. …
cbritopacheco commented on issue cbritopacheco/rodin#217.
@copilot+claude-opus-4.6 Please proceed auditing, fixing, adding, implementing, correcting the batches you listed, updating the checklist….
JustinPrivitera commented on issue visit-dav/visit#20891.
I see, but this is only needed for containers? Or will we need this on LC?…
cyrush commented on issue visit-dav/visit#20903.
window is blank (as expected) for both standard and ospray mode, anari is the only mode we have an issue…
markcmiller86 commented on issue visit-dav/visit#20897.
@cyrush I think this is ready now….
gardner48 commented on issue sundials-codes/answers#72.
Re-targeting this PR to main for llnl/sundials#897…
v-dobrev commented on issue mfem/mfem#5246.
Re-merged in next for testing……
jameshcorbett open issue flux-framework/flux-sched#1443.
Updating Fluxion to v0.50.0 causes interner to abort
On Hetchy, I updated the flux-sched RPM and then ran the following:…View Comment
grondo commented on issue flux-framework/flux-sched#1444.
@mergifyio refresh…
trws commented on issue flux-framework/flux-sched#1443.
This means somewhere we have a top-level entrypoint that isn’t catching exceptions to avoid termination. That needs to be fixed….
grondo commented on issue flux-framework/flux-core#7501.
Thanks @trws and @wihobbs for your comments. After further inspection, there’s some outstanding ambiguities in how CLI plugin options and dest work that this implementation makes worse:
…
wihobbs commented on issue flux-framework/flux-core#7501.
Added to the scope of #6980…
trws commented on issue flux-framework/flux-core#7501.
Sounds good to me, @wihobbs would you create something?…
garlick commented on issue flux-framework/flux-core#7513.
Fixed a typo in the commit message and setting MWP, thanks….
jameshcorbett commented on issue flux-framework/flux-coral2#466.
Oh ok that’s very helpful actually. What’s happening is that Flux is trying to watch the storages resource in K8s for updates about rabbit status. It asks k8s to only see recent changes, where “recent” is defined by passing in an identifier string grabbed from one of the storages resources. However, kubernetes is rejecting the string as being too old–I guess there is a storage resource on elcap somewhere that hasn’t been updated in a long time. As a fallback, with Kubernetes rejecting the watch request, Flux asks to get the current status of every single rabbit on the system. That takes a long time to process. Then Flux tries to watch changes to the storages resources again with a new identifier string (and hopefully a more recent one that kubernetes will accept). But no–for whatever reason, the identifier string is rejected once more, and the cycle begins again. In effect, Flux asks to get the current status of every single rabbit on the system every five seconds. This generates a ton of traffic and log messages….
cmoussa1 commented on issue flux-framework/flux-coral2#467.
What about raising a job exception on those rabbit jobs with this descriptive error message? I am not sure if that is any better from the user or admin’s perspective if the job has an exception raised on it, but would that prevent them from having to a) kill the jobs manually, or b) restart a Flux instance entirely? And instead you could just reload the plugin after all of the rabbit jobs have finished cleaning up?
cmoussa1 commented on issue flux-framework/flux-accounting#840.
Thanks for giving this a look @grondo! I just force-pushed up a couple fixes based on your suggestions above. I also added a new set of tests to check that with two queues a job held in queue A due to a max SCHED limit is not released when a job in B transitions to RUN state. I went ahead and appended that set of tests to the sharness test file….
jeremylt commented on issue CEED/libCEED#1830.
I would recommend this order, personally…
vladotomov commented on issue CEED/Laghos#209.
@amroakmal this looks good, thank you….
cyrush closed issue Alpine-DAV/ascent#1686.
Threshold filter on point meshes crashes due to CleanGrid merging coincident points
Description:…View Comment
emily-howell commented on issue Alpine-DAV/ascent#1663.
@cyrush I went through and addressed all of your feedback. on all three branches. I tried to keep things still relatively with the original changes to keep things less noisy. I did update the documentation in #1682 to reflect the changes that I made so that might be a good place to start reviewing from….
jeremylt commented on issue openjournals/joss-reviews#10237.
Unfortunately, I am not available until August…
artv3 closed issue llnl/RAJAPerf#578.
FEM Kernel Update
- [x] Add an atomic variant for the mass PA kernel …View Comment
adrienbernede commented on issue llnl/RAJAPerf#529.
Replaced by #638 …
trws commented on issue llnl/RAJA#2009.
As a stylistic note, we do this in OpenMP with single if the other threads should wait, or with masked or the deprecated master if they shouldn’t, while once is used by C++, C, and posix to mean “run exactly one time, no matter how many threads encounter this, and block all encountering threads until that one run is done”.
…
artv3 commented on issue llnl/RAJA#1917.
@llnl/raja-core this may need another review. …
adrienbernede commented on issue llnl/RAJA#1999.
@rhornung67 this should really be merged: it will update the toolchains and reduce spack concretization times….
milroy commented on issue flux-framework/flux-sched#1432.
@jameshcorbett the final issue to address is the question of the scope of the change of token to sequence_number (i.e., everywhere in the code, just the readers, or postpone the renaming). Once we settle that I’ll approve the PR….
vsoch commented on issue flux-framework/flux-docs#313.
https://github.com/jbms/sphinx-immaterial/issues/485…
chu11 commented on issue flux-framework/flux-core#7493.
thanks, will set MWP…
benzwick closed issue benzwick/guix-mvox#2.
Error when building mvox using guix
Build failed after executing guix install mvox…View Comment
alecbcs commented on issue spack/spack-packages#4060.
I originally stayed away from using urls because a package cannot have both url and urls properties and there are some r-* packages that set a url, however since we gate populating the urls on the cran class attribute I think a package setting both a cran identifier and a custom url is reasonably expected to fail….
tgamblin commented on issue spack/spack#52167.
If this is going to be essentially the same as spack compiler find, should we document that clearly? Is spack compiler find a convenient alias for this, or is this an alias for spack compiler find? I think probably spack compiler find should be documented to say it’s an alias for this….
jedbrown commented on issue openjournals/joss-reviews#9333.
@editorialbot generate pdf…
hppritcha commented on issue open-mpi/ompi#13801.
Thanks for the heads up. I don’t think any of our test systems have such a new version of pbspro. In fact, only system I have access to that runs pbs (aurora) runs a very old version of that software. looks like …
tzanio commented on issue mfem/mfem#5291.
ping: @stefanozampini …
JustinPrivitera closed issue llnl/conduit#1132.
is this multi-buffer material set example correct?
``` …View Comment
BradWhitlock commented on issue llnl/axom#1836.
Closing this PR as it was only for reviews….
milroy commented on issue flux-framework/flux-core#7439.
Thanks for the feedback! Setting MWP….
vsoch commented on issue vsoch/pipelib#13.
@matthiask thank you for this PR! I have a few deadlines into April but I’ll have time to look after that….
camierjs open issue mfem/mfem#5247.
Test failure for `ex1p_ceed_np=4`
Thank you for developing and maintaining this project….View Comment
benzwick closed issue benzwick/StreamVorti#45.
Parallel DCPSE produces partition-dependent results for 2D block partitions (np=4)
## Problem…View Comment
garlick commented on issue flux-framework/flux-core#7494.
Reproduced:…
vsoch open issue converged-computing/mcp-server#10.
Features to add for more production robustness
When we have this deployed in a production setting, I want:…View Comment
markcmiller86 commented on issue visit-dav/visit#20892.
Ok, I built noise.C on current develop against Silo 4.12 and Silo 4.10.3 and then ran both versions of noise creating PDB files….
cyrush commented on issue visit-dav/visit#20892.
I think maybe its an issue with looping over the dims…
imguoguo commented on issue sipeed/picoclaw_docs#18.
LGTM…
v-dobrev commented on issue mfem/mfem#4917.
Merged in next for testing……
alecbcs commented on issue spack/spack#52144.
> I think putting new commands we just happen to want in CI under spack ci is not really the path forward. This is going to operate on mirrors, considering the state of a repo. Neither of those things has anything to do with “ci” which is really just “build farm scheduling”. …
cjvogl commented on issue mfem/mfem#5270.
I just ran the code and everything is looking good! All that is left is to address the last syntax concerns noted above….
artv3 commented on issue mfem/mfem#5124.
Any comparisons with MFEM’s AMGX backend? https://github.com/mfem/mfem/blob/master/examples/amgx/ex1p.cpp Super cool! …
mplegendre commented on issue llnl/Spindle#148.
I went over the /bin/.. case in detail, and it looks like we handle it okay. There’s definitely some oddities with spindle putting “..” into an internal variable named ‘file’. But we ultimately always supported spindle operations on directories (even if that wasn’t common), and “..” just gets treated like other directories and handled correctly. …
markcmiller86 commented on issue llnl/Silo#527.
@biagas this is how I’d like to proceed with Silo. That said, if you feel better about your original patches for bv_silo.sh because you have tested those changes in multiple places, then I am ok with keeping your bv_silo.sh logic as is….
garlick commented on issue flux-framework/rfc#505.
Eh this was prematurely posted - sorry. Closing for now….
jameshcorbett commented on issue flux-framework/flux-sched#1432.
Aside from 229e25d, there are no code changes from @milroy ‘s last review. However, I did add some new tests in the last commit. The tests fail because the agfilter output is incorrect for cores: it considers fewer cores to be allocated than are in fact allocated. This discrepancy appears to have something to do with the match format and the way it skips vertices, because if the test is re-run with rv1 match format instead of rv1_shorthand, or if the job is modified to only request nodes non-exclusively, the agfilter checks pass. …
jameshcorbett open issue flux-framework/flux-core#7494.
idset: `idset_set (idset, -586)` caused `SIGABRT`
As part of https://github.com/flux-framework/flux-sched/pull/1438 I tried passing some negative integers to idset_set and found that passing -586 (which I picked randomly) caused my process to be killed with SIGABRT. I noticed the following assertion message in my test output:…View Comment
grondo commented on issue flux-framework/flux-core#7495.
I’d just add a note in the documentation. Something like…
wihobbs commented on issue flux-framework/flux-core#7495.
I guess an edge case might be “what if the hostfile for the taskmap specifies fewer hosts than the -N request?” which is currently allowed….
jameshcorbett commented on issue flux-framework/flux-coral2#463.
Similar to your PR this also needs a manual merge @cmoussa1 …
cmoussa1 commented on issue flux-framework/flux-accounting#836.
Thanks @jameshcorbett! Setting MWP here…
JustinPrivitera closed issue visit-dav/visit#20846.
numpy issue on LC toss4
Even though default compiler on lc systems is gcc 10, numpy will look for ccache, which in a default env ends up using gcc 8.x. …View Comment
becker33 closed issue spack/spack#51971.
Mirroring packages that throw an error breaks mirroring
### Steps to reproduce…View Comment
hppritcha commented on issue open-mpi/ompi#13790.
okay this is curious. The “problem” seems to be in the ompi error checking functions in cases where the send/recv count value is 0. This is not really a fortran interface problem….
tzanio commented on issue mfem/mfem#5265.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
cyrush open issue llnl/conduit#1557.
python DataType constructor should accept same args as set
```…View Comment
cyrush commented on issue llnl/blt#758.
Sounds like: https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD_REQUIRED.html#prop_tgt:CXX_STANDARD_REQUIRED…
artv3 closed issue llnl/RAJAPerf#666.
MASS3DPA_ATOMIC checksum failure
Describe the bug…View Comment
trws commented on issue flux-framework/flux-sched#1438.
You could write a catch2 test that literally calls the function. That’s probably what I would do actually, there’s no reason to make it an integration test….
chu11 commented on issue flux-framework/flux-core#7136.
was chatting with @watson6282 about general “how to know about a certain failure” was brought up. I recalled this issue….
cbritopacheco commented on issue cbritopacheco/rodin#204.
@copilot+claude-opus-4.6 Please now implement the generic src/Rodin/Solid/Linear/LinearElasticityIntegral.h for any FES. Take a look into the P1 specialization for LinearElasticityIntegral and H1 QuadratureRule implementations for the general idea….
jedbrown commented on issue CEED/libCEED#1808.
In the makefile, we figure that discerning users should set OPT themselves. Our default is roughly like CMake’s RelWithDebInfo, though I think that uses -O2 by default. I would not be opposed to switching to making the default -O2 (it’s basically a tradeoff of debug sensibility, but you likely still want more aggressive (e.g., associative math) for production runs. (The significance of such flags depends on how the user’s qfunctions are written; the library parts of libceed are not so sensitive.)…
cyrush open issue Alpine-DAV/ascent#1681.
rendering at resolution greater than 1024 is broken because of bad tiled rendering
I have found a regression running Ascent with a single task, but at resolution greater than 1024…View Comment
jeremylt commented on issue openjournals/joss-reviews#9153.
Realistically, I’m probably jammed up until August, unfortunately…
balos1 commented on issue llnl/sundials#809.
> I think that might be ok (as long at the results are not radially different). The runner images are not updated frequently, so this would be a way of moving to newer versions as the “latest” runner is updated. …
becker33 closed issue llnl/llnl.github.io#734.
Repository owners not included in Search context
When running a search in our catalog, I would expect to be able to search for a specific GitHub organization to find all of their entries, especially since the cards are presented with the “owner/name” format for the titles. However, as an example, searching for “chaos” only returns chaos/chaos.github.com….View Comment
JustinPrivitera commented on issue llnl/conduit#1362.
extrapolating from this limited data:…
grondo open issue flux-framework/flux-sched#1437.
invalid idset is output in R
Over in flux-framework/flux-core#7486 a change in configuration resulted in Fluxion generating R with invalid idset in the core field:…View Comment
benzwick open issue benzwick/StreamVorti#39.
Fix the sparsity pattern plots
The zoomed out ones look wrong….View Comment
jedbrown commented on issue RDycore/RDycore#381.
Spelunking the history: …
jeremylt commented on issue CEED/libCEED#1808.
Ok, I think I’m following now….
trws commented on issue spack/spack-packages#3962.
I’m generally supportive of the change, but is there a mechanism we can use to make this easier on users? If the ruff and ty builds work the same as the py- versions for all practical purposes, can we keep the py- names as aliases for example?…
tgamblin commented on issue spack/spack#52061.
> it’s simpler to have fewer exceptions to the rule. …
alecbcs open issue llnl/hubcast#242.
Permissions sync between forges
Repository owners will need to define their maintainers and permissions structure on both the source and destination forges. It may be cumbersome to maintain both of these permissions list simultaneously….View Comment
BradWhitlock closed issue llnl/axom#1822.
Build problem with -DAXOM_NO_INT64_T definition
When AXOM_NO_INT64_T is defined, some mpi_traits in axom/core/Types.hpp are not defined. This later causes a compilation problem in quest where some MPI reductions rely on int64 support….View Comment
alecbcs commented on issue spack/spack-packages#3906.
It looks like version.satisfies() doesn’t operate like I’d hoped. I’ve asked @LinaMuryanto to revert the previous two commits for now and I’ll work on making an issues / fix upstream to make this better for future PRs….
btalamini open issue mfem/mfem#5281.
Silent enzyme errors
# Summary…View Comment
btalamini open issue EnzymeAD/Enzyme#2765.
Promote Enzyme pass remarks to warnings when they indicate result may be incorrect
I have a case in which a derivative is silently computed incorrectly. If I compile my code with the flag -Rpass=enzyme, the following remark is generated:…View Comment
tgamblin commented on issue spack/spack-packages#3945.
Looks like py-kornia-rs and friends are building now and CI is fixed….
cbritopacheco commented on issue cbritopacheco/rodin#201.
@copilot+claude-opus-4.6 I have made some fundamental changes to polytope iteration in the library. Namely, I have changed that MPI Mesh polytope iterators return with the MPI Mesh reference, as opposed to before that they returned the shard’s reference. This has a lot of implications in the library. The first one is that XDMF somehow encounters this exception. Please fix it and find other places in the library which should be modified. …
alecbcs commented on issue spack/spack-packages#3931.
Should this package also depend on openjpeg itself?…
tgamblin commented on issue spack/spack#51931.
@johnwparent take a look at the simplifications here, particularly around locking vs. atomic move….
vsoch commented on issue kubeflow/trainer#3325.
@andreyvelich this is ready for review and eventual merge - apologies for my confusing posts! I was testing locally with the wrong container image (I had updated it back to kubeflow for the PR here, and needed to use my custom build). …
gauthier12 closed issue jetpax/pycoclaw#3.
Source code
Hi, …View Comment
grondo open issue flux-framework/flux-sched#939.
resources are not scheduled fairly among competing queues of job requests
Problem: when multiple queues are defined, fluxion schedules all jobs in the first queue before looking at the next queue. The queues are thus implicitly prioritized according to the order defined, with no available mechanisms to prevent starvation or ensure progress for all queues. …View Comment
grondo open issue flux-framework/flux-core#4306.
use cases for partition + qos or queues
Here are the basic things that we do with the combination of partitions and qos in Slurm, and just queues in LSF: …View Comment
garlick commented on issue flux-framework/flux-core#4306.
That is almost exactly what was kicking around in my brain. I was internally calling them “vqueues” but external sounds good too….
vsoch commented on issue flux-framework/flux-core#7217.
Go home, codecov, you’re drunk….
vsoch commented on issue flux-framework/Tutorials#57.
This came out great! Since our HPSF tutorial was shorter than anticipated, I recorded the entire thing (AWS, cpu with EFA and GPU) today with a short (2.5 minute) introduction to Flux. It is edited and ready to go, and will be released with the Kubeflow blog announcement….