jedbrown commented on issue openjournals/joss-reviews#7716.
Hi @abaer-kit, I see that some of the issues on your repository that were opened via this review are still open. Could you determine if they are complete and close if so? And let us know if there is anything you understand remains to be addressed?…
btalamini commented on issue llnl/smith#1585.
@white238 and @tupek2 , I modified this. Would you review again? …
BradWhitlock open issue llnl/axom#1628.
Improve tranformation support for Klee's Geometry operators
Klee shapes have operators that apply transformations (scale, translate, rotate, …) to their geometry….View Comment
markcmiller86 commented on issue llnl/Silo#543.
FYI…in #548, I did fix the issue on main your experience alerted me to and I mentioned above….
grondo commented on issue flux-framework/flux-core#7550.
This could be solved by the mapper introduced in #7566, since it is able to set or adjust arbitrary systemd properties per job, and has access to the locally assigned resources. As a first cut, the default HwlocMapper could scale MemoryMax by the ratio of cores allocated to the job vs available cores, e.g. if MemoryMax=98% in the config, and a job is assigned half the cores, the mapper could return MemoryMax=49%. …
garlick commented on issue flux-framework/flux-core#7568.
Ok, on reflection, your instincts are I think correct. I’ll move the “normalization”, the standard device list, etc (basically what systemd does) over to flux-security and leave the helper with a simpler job: fetch properties, set options….
cbritopacheco commented on issue cbritopacheco/rodin#244.
@copilot …
jeremylt commented on issue CEED/libCEED#1951.
This is looking pretty good. Did you want to take a try at adding this to the CUDA ref backend?…
cyrush open issue visit-dav/visit#20935.
feedback for new mfem LOR support
From Veselin:…View Comment
markcmiller86 commented on issue visit-dav/visit#20934.
Just curious if this general section on File Locations might address some of the concern and whether this specific secrtion on debug logs address specific questions about that….
alecbcs commented on issue spack/spack-packages#4373.
Hi all, this PR should now be ready for a final review and merge. The secrets have been created in the repository and AWS has been configured for OIDC authentication with GitHub….
v-dobrev commented on issue mfem/mfem#5312.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
dylan-copeland commented on issue mfem/mfem#5313.
As @v-dobrev mentioned, mesh-explorer has features to help refine (uniformly) and convert the mesh. If you would like more control over refinement, Mesh::KnotInsert gives you complete control over the number of elements and their spacing, for each KnotVector. If you would like to use lower than 4th-order, it would be best to refine the mesh fully with order 4 and then convert to lower order (e.g. mesh-explorer option ‘c’)….
adrienbernede commented on issue llnl/radiuss-spack-configs#165.
@tdrwenski to “fix” that failing job, first trigger the Dane alloc job, then the Dane spack job and then the reindex job – possibly several times – until it passes…
alecbcs commented on issue llnl/hubcast-test#4.
@lc-hubcast approve…
cyrush open issue llnl/conduit#1585.
conduit util to coalesce related vf fields into a matset and matset values
JustinPrivitera commented on issue llnl/conduit#1585.
This will be helpful for Ascent integration work Nicole is working on….
vsoch commented on issue kubeflow/trainer#3312.
Thanks for the ping @andreyvelich ! …
garlick commented on issue flux-framework/flux-sched#1461.
“Very useful or at least harmless” falls short of the justification needed to bypass our normal test/soak cycles IMO. It should be “Fixes a critical problem observed in production”. …
wihobbs commented on issue flux-framework/flux-core#7537.
Any amount of sharness testing under ASAN is better than none at all; thanks for pushing on this @chu11!…
chu11 commented on issue flux-framework/flux-core#7537.
> Perhaps one consideration is that under ASAN, we just run some subset of sharness tests. At some point, we perhaps accept that some tests are just weird and kooky enough that it’s unrealistic we can get everything working under ASAN without heroic efforts or obscene workarounds….
cmoussa1 open issue flux-framework/flux-accounting#858.
job usage: redesign job usage decay to make it more configurable post-DB deployment
I had an offline conversation with @ryanday36 about the possibility of redesigning how job usage is decayed in flux-accounting to make it more configurable post-deployment….View Comment
vsoch commented on issue singularityhub/singularity.lang#12.
That’s alright! Have you tested and confirmed this works as you would like?…
trws commented on issue flux-framework/flux-sched#1454.
Are the tests added in t: add tests for storage_node in request_feasible still relevant?…
garlick commented on issue flux-framework/flux-coral2#478.
> One additional concern is the added load these daemons will place on the k8s infrastructure when they’re always running….
trws commented on issue flux-framework/flux-coral2#478.
So after tuning it’s 15 seconds of CPU time per day on the segregated system cores? Did anyone look at whether there was measurable impact on a workload, even without doing further containment that’s not much at all….
vsoch open issue converged-computing/slurm-operator#9.
Improvements to do
- [ ] remove JobSet. It isn
benzwick open issue SlicerCBM/SlicerCBM#78.
Package SlicerCBM for GNU Guix (ship guix.scm + guix-systole channel entry)
The following was written by Claude Code……View Comment
benzwick open issue SlicerCBM/Guix-SlicerCBM#6.
Optional: slicer-cbm-app curated launcher via make-slicer-application
guix-systole provides a make-slicer-application factory that wraps a curated module set behind a single branded launcher. Launching the wrapper overrides SLICER_ADDITIONAL_MODULE_PATHS to only the chosen modules, so the resulting Slicer instance shows only CBM-relevant modules rather than everything in the profile….View Comment
sam-maloney commented on issue flux-framework/flux-sched#1457.
> Oh, I should have asked, I think we gave you enough access to be able to set merge-when-passing for yourself on this PR now that you have an approving review. If something doesn’t work with that, poke me and I’ll set it and see what’s going on with the permissions.
…
trws commented on issue flux-framework/flux-core#7520.
Sounds like a good plan to me, especially since different vendors and cases may need to allow for differences….
becker33 commented on issue spack/spack#51946.
@wouterdegeus you need to make changes to address the feedback from Harmen and myself above….
tgamblin commented on issue spack/spack#52291.
Blocked is better. Still not sure whether it
hppritcha commented on issue open-mpi/ompi#12200.
anyone still working on this PR @jiaxiyan …
cyrush open issue Alpine-DAV/ascent#1710.
field filtering matset considerations
Support something along the lines of:…View Comment
emily-howell commented on issue Alpine-DAV/ascent#1701.
Thanks for adding the checkboxes @cyrush. That helped me realize that I had missed a line item in the issue….
milroy commented on issue flux-framework/flux-sched#1414.
Claude and I generated a prototype in Python for structural compression to address item 4 above. I’m pasting it here for discussion: https://gist.github.com/milroy/069f042e14f2fa21b6aab0f977b1453e…
benzwick commented on issue benzwick/StreamVorti#46.
## UMFPack vs MUMPS at np=1: why MATLAB’s factorize() matters…
tgamblin commented on issue spack/spack#52319.
@green-br does this look ok?…
tzanio open issue mfem/mfem#5310.
LOR does not support MatrixCoefficient
When using LOR batched assembly, forms with MatrixCoefficient are not properly supported. The issue stems from the ProjectLORCoefficient function located in fem/lor/lor_batched.hpp….View Comment
markcmiller86 commented on issue llnl/Silo#543.
@junghans I believe this is corrected on the HEAD of the 4.12RC branch. …
grondo commented on issue flux-framework/rfc#515.
Fixed those things and will set MWP….
jameshcorbett commented on issue flux-framework/flux-sched#1454.
I rebased on top of #1453 because otherwise the tests in https://github.com/flux-framework/flux-sched/pull/1454/commits/1a3244f70c95fd3d018ebca1c305145ee0685dbf failed when reloading a module with new resource types. However, the tests I added in that commit pass even without the changes introduced by https://github.com/flux-framework/flux-sched/pull/1454/commits/b22642f8c17cc5b100cd115565430476bf685af5. …
garlick commented on issue flux-framework/flux-core#7546.
Sounds reasonable! Yeah we should move forward with this….
vsoch open issue converged-computing/mcp-server#13.
Support for catalog
Conceptually, we have the idea of a catalog, and we are using it to expose resource providers (both compute and related resources, and software) for real and simulated. We also support adding one off functions and events. I’d like to expose the ability to add a catalog, where the catalog is akin to the resource provider interface. We don’t care about how it works or what it does - it just needs to generate the instructions for how to make the different calls. The current resource providers will fall into it nicely, and I have ideas for other (more workflow related) catalogs I would like to add….View Comment
markcmiller86 commented on issue visit-dav/visit#20924.
I know it
trws commented on issue flux-framework/flux-sched#1452.
Yes, the initial load absolutely has to contain them. For some of the options like the id-list format we’d have to use a different initial load format. The solution for children is to allow them to request the full initial input from their parent in addition to the scheduling key, the id-list is again an example where there really isn’t another way to make that work….
grondo commented on issue flux-framework/flux-core#7546.
BTW, the IMP itself isn’t aware of how the imp-exec-helper obtains the input to the IMP. For now we could fetch DeviceAllow and DevicePolicy from systemd (perhaps rewrite to some input more suitable for use with the IMP so we don’t have to re-implement systemd DeviceAllow parsing), in the future if this data needs to come from outside systemd, an alternate method could replace or even be added to the helper.
…
cbritopacheco commented on issue cbritopacheco/rodin#232.
@copilot I meant you should refactor the CCMLC2014 folder code to remove the crude names and also add extensive doxygen documentation. This is the paper on which it’s based on: …
jeremylt commented on issue CEED/libCEED#1951.
Awesome. You can use search=t129 to run the new test specifically …
cyrush commented on issue visit-dav/visit#20920.
@biagas thanks for look into this. …
v-dobrev commented on issue mfem/mfem#5306.
Merged in next for testing……
tzanio commented on issue mfem/mfem#5309.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
gardner48 commented on issue llnl/sundials#918.
> We could also move the CONTRIBUTING.md if we renamed doc/ to docs/ (see https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors). I don’t think we want to move it into .github as it is more broadly applicable.
…
JustinPrivitera commented on issue llnl/conduit#1581.
Annotate more than just forall…
artv3 commented on issue llnl/RAJA#2006.
> I played with making a range type that could have any of begin, end, and stride be runtime or compile time constants. Is that something that you are interested in @artv3. Right now you construct the range in the lambda so the compiler knows that begin is a constant 0, but if you constructed the range outside of the lambda and captured it then the compiler would not know that begin is a constant. If you had a range type that could have any of the parameters be constant or runtime could fix that. …
garlick open issue flux-framework/flux-sched#1451.
allow el cap rabbit pool resources to be used without quantization
Problem: currently el capitan rabbit allocations are quantized to arbitrary ssd chunks, where each job exclusively allocates one ore mores ssds to get to the required capacity. It would be better if there were one storage pool per rabbit that can be allocated in arbitrary quantities….View Comment
chu11 commented on issue flux-framework/flux-core#7547.
hmmm all the builders failed, I seemed to have introduced a memleak. …
garlick open issue flux-framework/flux-coral2#476.
revert handling of alloc_rabbit property
Problem: the alloc_rabbit property hack to allow rabbits to be used with rv1_nosched was perhaps a bad idea and should be reverted…View Comment
trws commented on issue flux-framework/flux-coral2#473.
I think it’s mainly just something we haven’t done, it should be straightforward as long as we keep it simple and make it an error to reduce the pool size below any active allocation size and things like that….
jameshcorbett commented on issue flux-framework/flux-coral2#473.
> IIRC, one way we discussed to handle this was to add a way to update the pool size with an RPC right @jameshcorbett?…
cmoussa1 commented on issue flux-framework/flux-accounting#857.
Thanks @jameshcorbett! I addressed the nit you caught. Will set MWP here…
cyrush commented on issue Alpine-DAV/ascent#1701.
This resolves a subset of the issues in #1587 , i added checkboxes to that ticket we can mark off when this is merged. …
hppritcha commented on issue open-mpi/ompi#8845.
anyone still working on this?…
adrienbernede commented on issue llnl/RAJAPerf#652.
@rhornung67 I fixed the issue from updating RAJA. This is ready….
wihobbs commented on issue flux-framework/flux-pmix#127.
@garlick FYI this is also the case for flux-security….
sam-maloney commented on issue flux-framework/rfc#452.
No worries at all! I am also aware that I am throwing up quite a lot of text recently, so I certainly don’t expect everyone to be going through everything right away
sam-maloney commented on issue flux-framework/flux-pmix#126.
@garlick I don’t think I have access to set MWP in this repo, so perhaps you could quickly poke this through so it doesn’t get forgotten, thanks! :slightly_smiling_face: …
wihobbs commented on issue flux-framework/flux-docs#318.
Even just having it on core would get us most of the way there. Let me try this out this afternoon and see if it works….
wihobbs closed issue flux-framework/flux-core#7542.
`TypeError` when running flux-jobs(1) with `--sort` and `-A`
Oops. @gonsie reported on Tuolumne that flux jobs with both --sort and -A was throwing an error:…View Comment
benzwick open issue benzwick/StreamVorti#46.
Benchmark parallel Poisson solver/preconditioner combinations
## Context…View Comment
mplegendre closed issue llnl/Spindle#153.
Message Bundle does not retry message buffer cache flush
Priority: Low…View Comment
emily-howell commented on issue Alpine-DAV/ascent#1676.
I don’t think the CI failures are related to this MR or the changes I just pushed as I am also seeing them on my #1688 MR…
markcmiller86 commented on issue llnl/Silo#537.
Yes. But, don’t also enable BUILD_TESTING. I am seeing a CMake issue when that is enabled. And, of course, you can’t have the python interface in a static build either….
becker33 commented on issue spack/spack-packages#4076.
Re-ran cI jobs that failed for CI-system issues, they all pass. …
grondo commented on issue flux-framework/flux-security#219.
Thanks! Setting MWP….
garlick commented on issue flux-framework/flux-core#7500.
After discussion with @trws and some reflection on #7496 , it seems like the existing python schedulers should be reusable with externally provided ResourcePool implementations. I’ll change the “rack” test scheduler proposed here to be a test RackPool class instead, and then make it possible to override the pool class from the Scheduler base class (via module option and via R.scheduling.writer URI key)….
grondo commented on issue flux-framework/flux-core#7528.
> But, given your explanation, my sample script should work, right?…
markcmiller86 commented on issue visit-dav/largedata#5.
Thanks for the report and the fix :muscle:…
imguoguo closed issue sipeed/picoclaw#2427.
[BUG] WebUI cannot show both of content and tool_call at the same time now.
By default, the WebUI will show the tool_call only. After refreshing the page, it will show the content only….View Comment
vsoch commented on issue singularityhub/guts#10.
We would need a SingularityContainer class akin to the DockerContainer class that exposes the same function signatures, and I think that would do it. Knowing Singularity images, the issue we might run into is with respect to speed to do the same operations, but it is worth a test! If you are interested in taking a shot, the main entrypoint creates a ManifestGenerator that is going to call extract on that class. That happens here:…
v-dobrev commented on issue mfem/mfem#5251.
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch….
JustinPrivitera commented on issue llnl/conduit#1358.
Updated strawman from my talk: …
garlick commented on issue flux-framework/rfc#452.
Great point about the single core jobs. I am flip flopping on the template idea today and going around in circles I’m afraid….
sam-maloney commented on issue flux-framework/rfc#452.
I’m going to start working through the jobspec examples from RFC 14 to see what comes up (giving just the resources key, and essentially arbitrary assignment of ids):…
trws commented on issue flux-framework/flux-sched#1424.
I’m digging into this now, and I’m pretty sure I have a handle on what’s going on. Fluxion sets the expected start time as an annotation, and sends that along to core. Core interprets time of now or earlier as “now.” Both of these are fine independently, but sched tries to avoid sending too many annotations because of some old issues with memory ballooning due to too many annotations….
garlick commented on issue flux-framework/flux-docs#317.
Great improvement!…
chu11 commented on issue flux-framework/flux-core#7528.
> Yes, that’s pretty much what I want. But, doesn’t flux batch require flux start to be called prior to make the resources available? How is it seeing the resources?…
cmoussa1 commented on issue flux-framework/flux-accounting#846.
Thanks @jameshcorbett!…
hppritcha commented on issue open-mpi/ompi#13713.
@devreal could you re-review this PR?…
jandrej commented on issue mfem/mfem#5296.
What part of the dolfinx assemble process are you timing? Can you please post the source including the regions and timings you get?…
jameshcorbett commented on issue flux-framework/flux-docs#315.
LGTM as well, so I hit the button….
wihobbs commented on issue flux-framework/flux-docs#310.
Thanks @garlick! I also added a link to the tracking issue for multi-cluster accounting, instead of just “needs design.” I’ll set MWP….
wihobbs commented on issue flux-framework/flux-core#7252.
Interestingly, flux-sched’s CI appears to be catching a legitimate error not caught by core:
…
cbritopacheco commented on issue cbritopacheco/rodin#226.
@copilot Revert back to commit 9871634…
jeremylt commented on issue CEED/libCEED#1950.
For sure. If we see a performance difference, then I think the way to go for ChipStar would be to make chipstar backends /gpu/hip/chipstar/shared and /gpu/hip/chipstar/gen that delegate back to the current shared/gen code and that code would check the resource string for the root /gpu/hip/chipstar to determine if it needs to do the padding elements…
hppritcha commented on issue spack/spack-packages#4163.
please address others’ comments and I’ll review….
hppritcha open issue mpi-forum/mpi-issues#1107.
MPI_Type_commit - should it be const?
# Problem…View Comment
balos1 commented on issue llnl/sundials#898.
> This is for version 7.6.0!…
btalamini open issue llnl/smith#1581.
Axom codevelop build problem on mac
Since the switch to c++20, building Smith on my Mac fails due to a non-compliant c++20 problem in Axom, in particular with sol….View Comment