tzanio commented on issue mfem/mfem#5434.
> I don’t have permission to make label changes. …
hppritcha commented on issue spack/spack-packages#4291.
well i keep approving then someone does some other changes then i have to review again. …
tgamblin commented on issue spack/spack#52815.
@map0te I’m not sure whether this or #52806 is the right place to do this, but I think (and I suspect @becker33 and @alalazo agree) that we should just get rid of the duplicative criteria between roots and non-roots, and have a consistent set that’s ordered the same way for l0, 1, 2, etc. I think this is the right thing to do … keeping the irregularity above is hard to understand and I suspect we don’t need it….
dylan-copeland commented on issue mfem/mfem#5426.
@najlkin Is there an example that uses this new feature? Should a sample run be added to some example or miniapp, since a unit test is not added?…
grondo commented on issue flux-framework/rfc#544.
Ok, now based on top of #545. A leading + is added to automatic queue properties. This indicates a property has been auto-assigned by Flux and need not be copied into R objects generated for allocations….
milroy commented on issue flux-framework/flux-sched#1387.
The PR looks ready to merge to me, but I’d like either @trws or @jameshcorbett to weigh in before setting MWP….
imguoguo commented on issue sipeed/NanoKVM#844.
typo: reduce …
hppritcha commented on issue open-mpi/ompi#14229.
@N00byKing could you rebase on top of main? #14216 is merged into main now….
camierjs commented on issue mfem/mfem#5317.
Conflicts resolved….
JustinPrivitera commented on issue llnl/conduit#1661.
TODO add new function to API with a note and then write tests for it that trigger the errors….
BradWhitlock commented on issue llnl/axom#1928.
I have questions / comments for Monday….
adayton1 commented on issue llnl/Umpire#1101.
> @adayton1 - do you think this would resolve the cmake target issues? …
adrienbernede commented on issue llnl/RAJA#1647.
This was replaced by #2030…
eleon commented on issue hpc/quo-vadis#556.
It would be nice to document -DROCmSMI_HOME in the Build Options sections of the main README. …
garlick commented on issue flux-framework/flux-rest-server#7.
> do we want the REST schema coupled to (and silently versioned by) a flux-core binding signature, or do we want a curated, documented field set that we control and can keep stable across flux-core releases? …
garlick commented on issue flux-framework/flux-pmix#134.
@sam-maloney does your team want to take this? If you’re lacking critical mass there due to the holidays I’m happy to do it to keep things moving….
grondo commented on issue flux-framework/flux-core#6567.
Maybe the right move is to fix #4310 first regardless of any decision here. This prepares the job manager for proper multi-queue support whether using multiple allocators or not….
garlick commented on issue flux-framework/flux-core#6567.
> What is the single allocator per queue invariant solving exactly? Are there issues with the multiple priority queues per scheduler implementation that can’t be solved? Is there really no reason to have both?…
cmoussa1 commented on issue flux-framework/flux-accounting#917.
Thanks @jameshcorbett! I think I’ve addressed your catch above and have force-pushed up the changes…
jeremylt commented on issue 4C-multiphysics/4C#2012.
Sounds good, just wanted to check in since I merged your branch into mine for testing purposes …
JustinPrivitera commented on issue visit-dav/visit#20291.
> @JustinPrivitera how does this look?…
cyrush commented on issue visit-dav/visit#20246.
We need to test this in VisIt 3.5.0…
balos1 closed issue llnl/sundials#976.
max local size
What is the upper limit on the local problem size? I’m just trying to understand whether it’s limited by the maximum value of an unsigned int or something similar….View Comment
adrienbernede commented on issue llnl/radiuss-spack-configs#195.
@smithsg84 this is precisely the type of use case with will help with. I’m going to merge now and update the RAJA PR so that it’s ready for merge as well….
bgunnar5 commented on issue llnl/mada#17.
…
adayton1 commented on issue llnl/axom#1933.
I’ve used the following flags to disable the stack size warnings: -Xptxas –suppress-stack-size-warning -Xnvlink –suppress-stack-size-warning…
markcmiller86 commented on issue llnl/Silo#567.
Resolved on 4.12RC in #568 and on main in #569…
samuelkgutierrez commented on issue hpc/quo-vadis#556.
@eleon please give this update a try on your system….
tpatki open issue flux-framework/flux-rest-server#8.
rest-server: option to recreate shell login environment in job-submit API
Follow-up from PR #7: current cwd/environment defaults are minimal…View Comment
cyrush commented on issue Alpine-DAV/ascent#1748.
the windows errors look like images diffs above threshold, I can build on windows and take a look…
jedbrown commented on issue openjournals/joss-reviews#9333.
Looks good. At this point, please proceed to:…
jandrej commented on issue mfem/mfem#5421.
I can see how this makes sense in a downstream application. For mfem as is, I don’t understand the refactor. What part of the code keeps you from doing this internally?…
chu11 commented on issue flux-framework/flux-core#7730.
> The kernel doesn’t queue those signals so I assume we don’t need to. …
sam-maloney commented on issue flux-framework/flux-core#7747.
Perhaps I’ll leave this open for now, but once https://github.com/flux-framework/flux-pmix/issues/134 is resolved, that seems like it would be the “canonical” fix, then this can presumably be closed as other plugins should use the same logic….
chu11 open issue chu11/freeipmi-mirror#82.
lan20: do get channel cipher suites check
Some vendors apparently dropped support for cipher suite 3. It might be nice to check if the chosen cipher suite is supported before establishing a connection….View Comment
garlick commented on issue ParaStation/psmpi#8.
> If Flux actually enables both interfaces at runtime if both are installed, this should IMHO be changed in Flux to selecting one of the two available interfaces per job…
sam-maloney commented on issue ParaStation/psmpi#8.
> If Flux actually enables both interfaces at runtime if both are installed, this should IMHO be changed in Flux to selecting one of the two available interfaces per job - like Slurm does with the --mpi option on srun…
v-dobrev commented on issue mfem/mfem#5405.
Merged in next for testing……
mplegendre commented on issue llnl/Spindle#196.
@rountree - Are you working on fixing the CI failures?…
artv3 open issue llnl/RAJA#2066.
RAJA policy audit:
> As a quick audit: …View Comment
wihobbs commented on issue flux-framework/flux-sched#1015.
I updated the title here, which I think might’ve been stale. Fluxion currently provides t_estimates for all jobs that enter the RESERVED state, up to the reservation or queue depth (whichever limit is hit first). In the case of the easy policy, this is just one job. In the case of conservative/hybrid policies, this ability is expanded….
sam-maloney open issue easybuilders/easybuild-easyblocks#4188.
Bundle does not run postinstallcmds
As far as I can tell, the bundle EasyBlock does not run any postinstallcmds, but just silently ignores them. The only way I can currently see to run such commands “post install” is to abuse the sanity_check_commands……View Comment
vsoch commented on issue rse-ops/flux-compose#4.
If we put an arbitrary large number there we don’t need to rebuild - they will just appear as down. What do you think?…
vsoch commented on issue kubernetes/enhancements#2033.
Usernetes, of course!…
markcmiller86 commented on issue betterscientificsoftware/bssw.io#2563.
> What if we don’t link SSF at all where it appears in the body and just let the MIF link carry all of the responsibility? …
cyrush commented on issue Alpine-DAV/ascent#1732.
@nicolemarsaglia does this resolve#1725?…
alecbcs commented on issue spack/spack-packages#5621.
@spackbot run pipeline…
tgamblin commented on issue spack/spack#52780.
Curious, what’s the performance improvement you’re seeing?…
balos1 commented on issue spack/spack#52762.
> I would take a step back: filter: is very generic for a niche feature. Can’t you do spack env create --filter filter.yaml? Does it even compose for your spack config get idea? I’m sure there are ambiguities regarding what filter refers to if you have includes/stacking.
…
becker33 commented on issue spack/spack#52769.
@haampie I’ve rebased this and confirmed that it overwrites the package hash appropriately. …
jedbrown commented on issue openjournals/joss#1563.
I agree with @sneakers-the-rat. Automation bias is strong in this context and LLMs embody biases that the editor may not even be aware of. “Accuracy” in historical decisions does not imply validity. If we were to deploy this and then audit the resulting system, we would almost certainly find a lack of construct validity and that “bad” recommendations from the LLM unacceptably influenced decisions. I think it also violates trust of authors and the broader community, and cheapens the meaning of a JOSS publication. …
v-dobrev commented on issue mfem/mfem#5426.
@najlkin, is this ready for review? If so, please add the label ready-for-review….
alecbcs commented on issue llnl/hubcast-test#6.
@lc-hubcast help…
JustinPrivitera commented on issue llnl/conduit#1652.
@mohityadav8 why don’t you choose between #1641 or #1632…
trws commented on issue llnl/camp#218.
Agreed. Forcing the change to a ULL seems reasonable, but I would note that even if it didn’t have the qualifier on it increasing the version to a number requiring that size would have produced warnings for anyone assigning the literal to a smaller value. Honestly I’d prefer we keep the format and force the size change rather than change the format, it’s less likely to cause downstream breakage that’s undetectable by the compiler….
BradWhitlock closed issue llnl/axom#1530.
Add function to compute curvature of a NURBSCurve/BezierCurve at a given parametric location
Functions to compute local curvature within a NURBS curve was removed from the C2CReader in #1526 …View Comment
tgamblin closed issue linuxfoundation/insights#2030.
Repository groups for E4S
LFX insights is only analyzing the https://github.com/E4S-Project/e4s repository for E4S, but the project has many more. It would be good to include them….View Comment
garlick commented on issue flux-framework/rfc#541.
Thanks!…
trws commented on issue flux-framework/flux-sys-rs#4.
Ok, sounds good. If we end up wanting 2024 for the higher-level crate I think all we’d need to do is be sure we can reasonably use that toolchain in the buildbot so we could deploy modules using it in LC. Something for later. …
grondo commented on issue flux-framework/flux-security#234.
Thanks! I’ve set MWP….
wihobbs commented on issue flux-framework/flux-sched#1528.
Working off of pure vibes, I want to see if this passes CI. Hence the change to draft….
jameshcorbett commented on issue flux-framework/flux-sched#1534.
> Note: it is difficult to change the phrasing of statements like opt_p.value_or (null_planner) because none of boost::optional’s operators cleanly express “empty or populated with nullptr” or the inverse in a single statement (opt_x == boost::optional (nullptr) returns false when empty and true when null), and try_at only returns references but boost::optional cannot be initialized with an rvalue reference (see Optional references).
…
trws commented on issue flux-framework/flux-sched#1535.
I honestly don’t really care, just didn’t realize it was a separate issue tickling that one. It might be worth doing that when we update to the next TOSS release so everything works in our normal production environment but I don’t see it being worth all that much right now. Thanks for this @wihobbs….
grondo commented on issue flux-framework/flux-core#6440.
Having something that could run on new code would really nice now that we’re making heavy use of LLMs which seem to forget half the time some of the formatting instructions they’re given….
trws commented on issue flux-framework/flux-core#6440.
Adding custom handling to <, == and != to the thing I linked above with never as the policy might take care of those trailing breaks that were bugging us. The last time I was seriously thinking about this, my plan was to add clang-format to pre-commit, and have it run either only on files with diffs or only on the diff itself so we could at least count on it for new code. …
garlick commented on issue flux-framework/flux-core#6440.
Closer. …
cmoussa1 commented on issue flux-framework/flux-accounting#916.
Thanks for catching that issue in the commit message @jameshcorbett - I’ll go ahead and remove that from the message altogether. The .backup DBs are automatically cleaned up in the testsuite, but you are right, the backup isn’t deleted if the update completes successfully. I guess the thinking here was that it would be an admin’s responsibility to manually clean this up for this reason:
…
jeremylt commented on issue CEED/libCEED#1830.
If you’d like to take a crack at it, feel free! It should be largely the same code copied over, but you have to make some small changes to account for the difference between CUDA and HIP syntax…
jeremylt commented on issue 4C-multiphysics/4C#2133.
I added folks who I’ve seen approve changes to these files in the git history…
cyrush closed issue visit-dav/visit#20153.
Create macOS 12+ Style Icon for VisIt?
I’ve noticed that of all the icons in my macOS Dock, VisIt is uniquely non-conformant to the icon style that has been consistent post-macOS 12. …View Comment
JustinPrivitera commented on issue visit-dav/visit#20950.
I want to make sure we error instead of crashing….
becker33 commented on issue spack/spack-packages#5711.
It might be worth showing a warning, but I think this is generally good (for two primary reasons). …
imguoguo commented on issue sipeed/NanoKVM#442.
Since we
hppritcha commented on issue open-mpi/ompi-www#569.
@jsquyres noted these missing presentations prior to HPSF meeting…
adrienbernede commented on issue llnl/radiuss-spack-configs#195.
@tdrwenski @davidbeckingsale …
adrienbernede commented on issue llnl/RAJAPerf#688.
@smithsg84 I’d appreciate a review of the changes in RAJAPerf spack package: https://github.com/spack/spack-packages/pull/5716…
artv3 commented on issue llnl/RAJA#2036.
@lc-hubcast approve…
hppritcha commented on issue hpsfoundation/tac#93.
> @hppritcha thanks for he responses above. The link https://github.com/orgs/open-mpi/teams/ompi-devel-merge is not publicly visible, unfortunately….
samuelkgutierrez closed issue hpc/quo-vadis#542.
API Simplification?
Hello,…View Comment
tpatki open issue flux-framework/flux-multi-cluster-utilities#30.
Add a performance-based policy with XOR support (reopen #30 with updates)
Add support for job performance lookup-based policy to enable evaluation of demo workflow. …View Comment
chu11 commented on issue flux-framework/flux-core#7730.
> maybe on_sigchld() with a status argument would be better callback name here? …
tpatki open issue flux-framework/PerfFlowAspect#202.
`WeavePassPlugin` INTERFACE target is missing `-fpass-plugin=`, so downstream consumers never actually run the pass
Running into this as we build gromacs for the paper for @spencer-gre and @alizalisan. …View Comment
imguoguo closed issue sipeed/NanoKVM-Pro#95.
Mark Images icon with colour when image is mounted (like it is for Power icon)
Currently to check if image is mounted you have to click on Images icon and in submenu the Mount Image text will be coloured if it is….View Comment
hppritcha commented on issue open-mpi/ompi#13133.
@kingshuk00 are you planning to work on this further? Note a related PR #14083 will be merged soon….
v-dobrev commented on issue mfem/PyMFEM#315.
Hi @sshiraiwa, thanks for reviewing this. There are CI failures, however, they are not related to this PR – are you okay if I merge this, regardless of the failures? …
BradWhitlock commented on issue llnl/conduit#1645.
Hey @cyrush , I see that you approved this PR already so I’m merging it….
jandrej commented on issue EnzymeAD/Enzyme#2964.
> @jandrej this failure is presumably from upstream mfem? …
tpatki commented on issue llnl/variorum#591.
Update from 7/21. …
bgunnar5 commented on issue llnl/mada-tools#10.
> Did the gitlab ci pipeline pass for this? I can’t find it in the pipeline list for some reason. …
eleon commented on issue hpc/quo-vadis#9.
@samuelkgutierrez , could you please try the test test-mpi-phases? …
wihobbs commented on issue flux-framework/rfc#529.
@grondo Okay with adding MWP to this?…
tpatki commented on issue flux-framework/flux-rest-server#6.
…
jameshcorbett commented on issue flux-framework/flux-accounting#912.
roger roger big boss…
cbritopacheco commented on issue cbritopacheco/rodin#311.
@copilot Fix the CI….
emily-howell commented on issue Alpine-DAV/ascent#1751.
Thank Justin for finding it and making a ticket!…
camierjs closed issue mfem/mfem#5363.
[CUDA] nvcc / cicc memory exhaustion (OOM) compiling element assembly kernels with -arch=sm_120 (CUDA 12.8)
# cicc memory ballooning / OOM compiling element-assembly kernels for sm_120 (Blackwell) with CUDA 12.8…View Comment
vsoch commented on issue flux-framework/flux-framework.github.io#205.
Thanks for the 3rd comment, Mergify bot. I almost forgot you were there after the first two. You and coffee bot must be good buds. …
JustinPrivitera commented on issue visit-dav/visit#20980.
Thanks for these changes! Everything is merged and should be released in VisIt 3.5.1….
tpatki commented on issue llnl/variorum#591.
Spent a few hours debugging the segfault with amd_smi APIs. Summary from claude below.
…
BradWhitlock open issue llnl/axom#1530.
Add function to compute curvature of a NURBSCurve/BezierCurve at a given parametric location
Functions to compute local curvature within a NURBS curve was removed from the C2CReader in #1526 …View Comment